From: Akhil Goyal <gakhil@marvell.com>
To: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "ciara.power@intel.com" <ciara.power@intel.com>
Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm
Date: Wed, 13 Mar 2024 18:22:20 +0000 [thread overview]
Message-ID: <CO6PR18MB448470CC8460F3D041C97D73D82A2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240313145448.26264-1-arkadiuszx.kusztal@intel.com>
> Because net crc api is not thread-safe, setting crc algorithm
> by the application will prevent race condition in the calc function.
> Race condition still may occur when any of the threads will call this
> function again. Function is called with the highest possible SIMD
> extension, which is AVX512, but if this is not found, CRC API will
> pick the other highest possible extension, or scalar if no SIMD
> available.
>
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
>
> Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> app/test-crypto-perf/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
> index 40c0b4b54f..58496797d7 100644
> --- a/app/test-crypto-perf/main.c
> +++ b/app/test-crypto-perf/main.c
> @@ -11,6 +11,7 @@
> #include <rte_eal.h>
> #include <rte_errno.h>
> #include <rte_cryptodev.h>
> +#include <rte_net_crc.h>
> #ifdef RTE_CRYPTO_SCHEDULER
> #include <rte_cryptodev_scheduler.h>
> #endif
> @@ -599,6 +600,8 @@ main(int argc, char **argv)
> goto err;
> }
>
> + rte_net_crc_set_alg(RTE_NET_CRC_AVX512);
> +
> ret = cperf_verify_devices_capabilities(&opts, enabled_cdevs,
> nb_cryptodevs);
> if (ret) {
> --
Not sure what is the use of this API here.
Which calc function is it fixing.
Also will it ever pick neon handler?
next prev parent reply other threads:[~2024-03-13 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 14:54 Arkadiusz Kusztal
2024-03-13 18:22 ` Akhil Goyal [this message]
2024-03-13 22:15 ` [EXTERNAL] " Kusztal, ArkadiuszX
2024-03-14 12:49 ` Akhil Goyal
2024-03-15 9:56 ` Kusztal, ArkadiuszX
2024-03-15 10:44 ` [PATCH v2] " Arkadiusz Kusztal
2024-03-15 10:49 ` Power, Ciara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448470CC8460F3D041C97D73D82A2@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).