From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41C0E43CA1; Wed, 13 Mar 2024 19:22:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8278406BC; Wed, 13 Mar 2024 19:22:26 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 67B9E4025E for ; Wed, 13 Mar 2024 19:22:25 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42DCnl6h016105; Wed, 13 Mar 2024 11:22:24 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wucg2sedy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 11:22:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMZi/7ch74ryzjAL8VBzj0L+eS0A78I8FQrzABOOGNEko8Kb4yzOLo/1FKAlVUOF3A0nJiVeE/aBhotwLBTnlk0WOuC0B2YpQNale7nMgw+llciet7XdvH2YMBsTQqyaLFq/GNVjnoedQWUQXl6+2+E+xxOUqJ7ly8oZPjwn+lLgK9HUH92/OKNApcGMgZEMpyyfSqRejumDFiePovj1Y0kUR5hkAntS6+Q35Yu9//PLikyY8CNfYJ5KmmwCTuJdLNtiAlvvCwLGW3nj9H674VMC4uqceUg9q6AfbX9QiSA/PaMXkN2mhybDAbXSaQCXDowgCUrsNEaEQ4F20MxK1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h391cmpJ3ElH4kz+RathsW4PH8gjcN60Ik9V4Oz8N+Y=; b=M/4xxtCArNQB9toqqfWZjz2ieiTMkYmzHK9ezfk5A3OcYz/4PQen6xmB1ugBv+RQYnOTcpZSZCEk10NT4fD9hmm5EM95LkMAyJLqIRtY92hMR57yU29Ix1JWVEjGv0P075KroA1W5OpVNvmsXBcEl4QxzLSW83nCTa3HI5DnTzHCauK8iZmHjDYnBufaFNJjURDh3wy879FUKm0sHPM02otWz5SeDgq6QhWvzvk9st+rz+Bmx55CWcsIekk6udsYP6PgI45f+JeGxBN8P0dUlX6DDw6UuD1FfH2eYQLLrkAo/pzSWs1Y3u2UygLis5CSlKPI1yBbvkAy+SY8k2M+dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h391cmpJ3ElH4kz+RathsW4PH8gjcN60Ik9V4Oz8N+Y=; b=j5OMwb2j1im7R/ZNljoprpIBih8Na6CILY3sMcJ84Q9foNVZ7Hlia6IjXSHWLkfVAXIBErJ5U9d28N3u8tx4V7AmFiY26G+kYX3sRWI0558Owdn+L0Wx2p3Fh1N3wtsp1ejRxyV8FS8uVDK/Q8/fX1hlX2eXXHa4CjUKD3UKE/Y= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4108.namprd18.prod.outlook.com (2603:10b6:a03:2e9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Wed, 13 Mar 2024 18:22:20 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 18:22:20 +0000 From: Akhil Goyal To: Arkadiusz Kusztal , "dev@dpdk.org" CC: "ciara.power@intel.com" Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm Thread-Topic: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm Thread-Index: AQHadVZrTfylhwZQhkK04ruPgjNas7E1+zZg Date: Wed, 13 Mar 2024 18:22:20 +0000 Message-ID: References: <20240313145448.26264-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20240313145448.26264-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB4108:EE_ x-ms-office365-filtering-correlation-id: d725e667-3397-435a-73e7-08dc438a8556 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SpscJA7BBXgJJrn+I8drXrbPuklrVqENQq6/Ct/HY4NESHC6Nz/ebeiQip3p9f5ybrFjEbBiY5X4957PchlLq2G7flgUxHSwWPEh4HarfcM/esGwa0WdpmyPfM/oQ+t3AcahIXWVFmnJTFqk96PhQc54JrxTHjJQHijxouTSB0z9S1sS/hf1KVb8sMJgrxO8ZeZybeUA1WEjEg6Ntj1Sz2Me570/VPxvhsRofz5CzDxhgk6BO2zn/vGquNzDg0331TEq39hNUjzVLyezKml59BX5j9IybHVaQqkOmgJXIxiDJoyumpyR129rLexHE7fKaAKgDzDKMRpqofMoMEx/mSO8fZ+64R+NkMUnl7hS8kJgtTdWzKVKIx/qCggwVCfaaPH6GyBB8Uz+c2/suD1qSqNCWnhxsduBsll6MAHdU1CjSrid7L/FHXtOA8ctcFgH5Pi4rQJQBeThe19ZsGQ6+FO220+Kk5OMrJhOr4ZdxqDdWx8T4lcK9zhf7aEn3zOax28g/ccEUI4tORLm+MXcUsxbAnEkvfv5BhO+pvvLq78EnFllUGQM54zYTK0qk9z/Su1/O+dvNDxP+UN2aXS4a63HQUPjoArjTOALU8fWRDmK/qrFRlpBKUbkbR6vnwwKewOw/BpT4r/CobbKyhM9Xb7E4uqnasn3SaYn9ZCJuPTUZyQyyVd8c2phDLi9Fxe50144zkOtxA3wZEtsviBSfCsTLHSOH17ESzoThyF8t+U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MqI/nGQ825mku2aL7Rhgb0EY06Kq7DMH8/LzzI0NvpKbLpgQ0thpUV9sca1O?= =?us-ascii?Q?JVOxKyCmvW4s3EJwMXO6W4hqcND+EgqOwf0VL/SEeRkEqdAIGNZyXZ5aKptN?= =?us-ascii?Q?HvrnmKdyzpFVRJFvc96g/6ksOlA3FI5EhAkItFXXb8KRPEDu9IvnGrnjaLgC?= =?us-ascii?Q?7BeQH8ltQyYW4pwlmgj/DY/Y824i0En08HPU/IQ7JsyxCirQeEazxVr1J4Zu?= =?us-ascii?Q?bmcP96M7EkCM1w23422j5/KfCjB7i+5uBux52cObkmNFXLphptXNWwEzILmG?= =?us-ascii?Q?Yzbq6O0jlS75lItbLmitaM1YFhpG/6bkmjeReVsPvAiPWl8Hm8IPgq4fZWGy?= =?us-ascii?Q?NdYgQ/KPffYgSc1rIGdJXq2zPnGnDcz0dBAnDRQwp5y+XCVJsXyvToHC5B6f?= =?us-ascii?Q?x7M0pTd7ZT1jp0NSUzPm9Jd+8QvUC3AAS+xa+4CnWkf4b8+YVjrW/KskJ4GE?= =?us-ascii?Q?ecqtL8j9stvAz9p4ehDYpqAaRkcungsV/6wOUFWCxBncVyeWD6D/31kzGhb3?= =?us-ascii?Q?pK6bBM2hZUhE15+5HDP4TO1TPa8qM3oGn/O4hA37Ilg4L48AUlmXHTm/rACW?= =?us-ascii?Q?lMuD0fKHPKitHQw3O38ut7SYe9r0UVOs8fMPU9Oagy7W0zAOYrfDWZ7PCKG0?= =?us-ascii?Q?q4xF1UkRxtP7VTqD4rA5OZ8XpE8ZGnkDXK6ICtd7lAhmQKcUgNYHNDENDmfP?= =?us-ascii?Q?aI5BunQCH2y0AAfskoWW1Lu2+7aqnOsdDB8JT7pFHCujENVE6vwbrYifE3nv?= =?us-ascii?Q?uOjEe12FNWcsmwMt8GfFivhPpmSgQkIlh4sGOlqjj10vUiHMoBG0xjJeZQw1?= =?us-ascii?Q?QVmCiC4k5h+g8NfJeyfiEZhvvX/4M8JP+iF73O23UTXTQw/HIzrVvnZYQa4F?= =?us-ascii?Q?mlrRm59/Xl8BD9H7oozFwv6cjoOCpXAg2QKxw5UXXvXqe1zJ43rNktA3ezzA?= =?us-ascii?Q?ekvlv7QEJHr1zeNjBNGSOZVGOsoNet8L1oWNwwlgQKsCNcCK8X07io/6VcGz?= =?us-ascii?Q?r22PzCicIm0g9p+tQukyqRpN67mtcEI5fdXY2cXRt7Te9I3hATlMDXzmC5W9?= =?us-ascii?Q?Of3KmKdJpiSVzLoQvVwnMrsl8TARWMOHdUoqRppR8Wte/+MVmrTUce9fMz5H?= =?us-ascii?Q?9UwQLZkcEpKysQXZMmeqZShsJ9df0Mqk9sAQIyWI3MNf1Q7lMO4G7Sh5JgXR?= =?us-ascii?Q?JiEBA1hsiraTPDmZn+CM0Z7xyJmmC2bUAnd6eLtDN/D/7vCkTTR9uYE1PuX+?= =?us-ascii?Q?rFF/bfy4ZMdDK/zGZvpFfee68k412NG5tD76BToS0cRH3MgTE4MC63jR65Ig?= =?us-ascii?Q?OTY2zPqhVZ6aAxJylTIFUcyCeKcZRTEEFP5KelPvoay1wtcddOUbOhHal2Qu?= =?us-ascii?Q?6C8X5e9bmyT7ETYrHUClpcsesPxBFBjDq5GbHrLm6r8x76c02MQbyreLVOlB?= =?us-ascii?Q?OhJi9UakmvNad4UB9wfYW1X7IKoU9ndT/qpg4U35kgR6vwvQBDcOdavKPZAz?= =?us-ascii?Q?tETlGIE3wWwj49d9NH2zrMNHD1MYjxUr75MLak5gxE4hEx7HW77IGIAZ0b7m?= =?us-ascii?Q?qw8DYeJ1T17TMER8C9uq8BEaMXN3Tl7AgzM+W4pa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d725e667-3397-435a-73e7-08dc438a8556 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 18:22:20.1228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QAUb7DCOJ2m6Knbof8uAEnUf4WGcqtVuk0/p0y/1Uur7570MVSjbXuMJL6W/xNNcDPYaJKANeesq5KbebbLMZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4108 X-Proofpoint-ORIG-GUID: AxoL3RMpItX5olqHL9dslswZDN78BOFs X-Proofpoint-GUID: AxoL3RMpItX5olqHL9dslswZDN78BOFs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Because net crc api is not thread-safe, setting crc algorithm > by the application will prevent race condition in the calc function. > Race condition still may occur when any of the threads will call this > function again. Function is called with the highest possible SIMD > extension, which is AVX512, but if this is not found, CRC API will > pick the other highest possible extension, or scalar if no SIMD > available. >=20 > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test applica= tion") >=20 > Signed-off-by: Arkadiusz Kusztal > --- > app/test-crypto-perf/main.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c > index 40c0b4b54f..58496797d7 100644 > --- a/app/test-crypto-perf/main.c > +++ b/app/test-crypto-perf/main.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #ifdef RTE_CRYPTO_SCHEDULER > #include > #endif > @@ -599,6 +600,8 @@ main(int argc, char **argv) > goto err; > } >=20 > + rte_net_crc_set_alg(RTE_NET_CRC_AVX512); > + > ret =3D cperf_verify_devices_capabilities(&opts, enabled_cdevs, > nb_cryptodevs); > if (ret) { > -- Not sure what is the use of this API here. Which calc function is it fixing. Also will it ever pick neon handler?