From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 587BFA0548; Sat, 16 Oct 2021 13:46:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC91A410DC; Sat, 16 Oct 2021 13:46:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id AD5CA4067C for ; Sat, 16 Oct 2021 13:46:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19GAsdl3023659; Sat, 16 Oct 2021 04:46:19 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by mx0a-0016f401.pphosted.com with ESMTP id 3bqv3qg99y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Oct 2021 04:46:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqhqHmOcR3u/RnZ5M3JG6uQS87+EDZ4H5YPS7ZXJowWUlYxFHwSONoVcb76n8yBp+ZP3ZVxf7cQKrQoOzi1maXhumK4bIeM995jmeHlHG3O39y22LAOWHpDT0i1c1UkR6abNFEqD8bOikOdja7M0xG5qjmegae2Vrnn4P4rh83/ihKtjY1gg/X51kct4+7Afs+3ckOfy0bmLI/zHQKS7CaIbM7RGIZKzVgRlv4s1wl/7BClhpNE33nPWXr3mI5ovalG42bem6A0iCqIUc7uCeR37rvYotaDq1ExAlGQFWwMv8+CVvNT9oMkHYZ0ae6PzDoarMt9NQk3/xvB6xq901Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IMfYiOt8v0ueikgY3YX8VQC/H+ujoCuqYZY//Vo1BhA=; b=L4P0Kdoq2dOS+42s7iH+FIeU27cgvRe7cjmPDNP6r1L+tbWxOVfW7eVqTzEWLm3mAo+Fydn5mFyxKi7gxd9unu1GLhLYvGBZaHGbL0i43OgG4jlikdd4SYQ6CTzB7s7hLgTak8VfScp6ek1A7/vLWfxfC0x/a3I1MuzTP63EblunnjlSwjm/4fRG4aisGoHy+BapjyWdhWrZ1or+00Xad5bjEsEgg4UGKuCcxpKGbpvXLaadBRvJAw+eeR0qcO4JoMf3uBJ0QWLGXTPp/m9f0SkVcDuzrJ44oJsjJu0un7ruKHNq9zubJY4Y0VaBLT5mVB2wr0kzelpRcZRyMsY1eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IMfYiOt8v0ueikgY3YX8VQC/H+ujoCuqYZY//Vo1BhA=; b=OequRhirT65kUfbCAUd+sPgfoVBrEAliAfcNxxhsHpnDMWUE+dauAF9ruWCQdHECS4vHhbDkkMf0bsFyfyXSMsNdGi6HQdW87X1aIv09ngK3A7yKFOo1iR+7olmcP97M7u3p7DbpKKQc71mw+ooLgb/056T4Iy41dvA6QuxLn8c= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4556.namprd18.prod.outlook.com (2603:10b6:303:ff::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Sat, 16 Oct 2021 11:46:16 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.018; Sat, 16 Oct 2021 11:46:15 +0000 From: Akhil Goyal To: Fan Zhang , "dev@dpdk.org" CC: Arek Kusztal , Kai Ji Thread-Topic: [EXT] [dpdk-dev v3 08/10] crypto/qat: add gen specific data and function Thread-Index: AQHXwRd0XBuDefEjbU2tsX+23YLJS6vVg/eg Date: Sat, 16 Oct 2021 11:46:15 +0000 Message-ID: References: <20211001165954.717846-1-roy.fan.zhang@intel.com> <20211014161137.1405168-1-roy.fan.zhang@intel.com> <20211014161137.1405168-9-roy.fan.zhang@intel.com> In-Reply-To: <20211014161137.1405168-9-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13866687-e1a2-4916-05a9-08d9909a8fad x-ms-traffictypediagnostic: CO1PR18MB4556: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K86fOfPAjrJuv2IqYEOGV21gNv6zMb7vln3pN0k2o2v8U8wX0utefOgPTEFUru1v1+Wup8mcMHw2MTbbXCRox6WF7KrSzGTx9YzyqwLJcVZejq0Bmyypm1bJLmyMhHr6p39GGwOwCOIc5j6SktmPqkyVD8Uaf5KTXDWP7hbb6YztLDcYHhmQRogWQ7eBzfz/d1F2iRftzR5+rNDJHp90s1pVjhv/gr/YXDEmoBlgxs8+KW7/SU8nhyIdRLzwWCcS7lUSMVRuyMcji4wuStLJ6i1b704zw1h3dNyvImXJr/RL/Cip/q6lfImz4ogIE5tCWVa7obS88ayHWA7HoHC6Z7WvzFW7Lo1xAUavGhmQyHkdoo1iTp7BmZPRpdT6RHA7ngAVSnuCRCiJ3l2WzikRD05ZKsOrusbx5iwpHre2xG4K/Gxd5opgF6wQeO/SZh27Wf2fpgkDi76KfWmVByaVmReva3reQDPokpWerIcdyoBlZELJeqz525okmqSgDdQuPhaPSq3vzP3Fg4CrYMRBymxQDTjscY77Es78nMoUyXg3fDeY2mQbXetOLHwfbwwXyeRZW15rLn+BlQM8tIwKSfrHeg4ueuZ/UaYia4Oz0KettUwlZsRkzoD6klXbEcc7VyJuvcfQ08NejA0wjRCB9fLY1x442mpPDgLVLT6RH5qZA88eyi5r2k8fNBC1pyLI3GKaBWQn5tt1XB/poKRQcg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(5660300002)(122000001)(508600001)(52536014)(55016002)(66476007)(66446008)(6506007)(76116006)(66556008)(38100700002)(7696005)(55236004)(66946007)(186003)(8936002)(26005)(86362001)(110136005)(2906002)(38070700005)(4326008)(71200400001)(54906003)(33656002)(9686003)(64756008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+OcWWTz/re3OPHp6nvntzpe4YFw8lPZjo9pyHrewK1WMRAlavFeTu946Pvhu?= =?us-ascii?Q?d3aGf2xH68p00WoGffgrUkW1VUOxaidU+8BAUQvFL13FZa2MQPXHIlLC6sLC?= =?us-ascii?Q?UqbZIdLWeCe4j/l8lX8R8sArhL3O9CCZWty3etq+w6M2MLvDdfcr+TdrVD7o?= =?us-ascii?Q?bXLcqPb9Z0BQmWCfZ4gx8wNnf+EXMMnk/PAzB2LTwQktcnRL9agrCdFjJWnX?= =?us-ascii?Q?adthfkIsAzGKf9DZe05NgHDGSVwvMVT4nBDeElesf79hk5wx8keBh2x7Y8Tn?= =?us-ascii?Q?1CukYU2XlEmEAQt23JWjSk0o/K6dFlaKrdwX+y914HCaAsqwq55V/Qi88lNA?= =?us-ascii?Q?iWiiqRXB5N0FllZuFCqfapJWqRNJhC8G1JUipi4axMZAgP5n8bFn9wsqwRvG?= =?us-ascii?Q?Kk8RzpKbJrxH1iX5StQ/1cIZCtU6fUSZxn86OB4tvzecS4BN2eAhmaWjGFq+?= =?us-ascii?Q?Pl0JMM4ZAuXl8Gbnu20PDAfPubGwq7hpq8iXudNsrKi2R6Xc63xmKh3xgfyb?= =?us-ascii?Q?cCx24dIqZAupW753/j8D6U80s+k7U8xv+hAjXeC7MTjoNxtQruicb0hZdtPa?= =?us-ascii?Q?7HFbZqqNnoY22aCc1oBOlGgPH4Dpp4HS1p2tddKZPjMO/wj7fDaZcjOcSk6/?= =?us-ascii?Q?cfBQhdF+WD3J9Igt7XJDBON5iWGOSGCS7LtvoodJN/j3RGhOE0temllxNQ+S?= =?us-ascii?Q?4bAxJ+ffN5dlLArKz+veKu5LjovBeAFLjDarKa5zX+DdKQ5bV02BfLQsmMkI?= =?us-ascii?Q?w72wFfFIe+e+BRLh2/BFLpWCxJWyCPGclqe7KckKyUXGz65CwByRUmZileNE?= =?us-ascii?Q?gTLr3mzcK/dmTBpucBnJHaT7qhU3BaBG2b48kUCcaMhrlgxrMX6wgySbv1Rq?= =?us-ascii?Q?2r70E0H1pCes+F2ftHSxuf5stfY2y7o6gqcTQ9EEptG8iEccuWzNwM8PkMi4?= =?us-ascii?Q?+eSAoNBmk/Rikk6GhIdzAi2wUPlTDuDukFy6Epolfo88GrHa2TBn0WE3lnMC?= =?us-ascii?Q?vg4dEPud23dIWuws32CzoeY2zUw0BXU4Y3vSMkkE5LkKy/NCxKMJuR2IorWl?= =?us-ascii?Q?sV74XGIVoV90/mvWz5PjRS+Du/tKW29F8BaOSnVH0kR+oL6ON1Y05DWx1GDR?= =?us-ascii?Q?pI3oFCZYvCNNQkFvIUeFHEOHaaRKsyB6Q4+sbH5AyAYE6kzmEj1x7wQ8IqgC?= =?us-ascii?Q?ZdkPi+arluA/71aNg4ryhVD+n8CREGEuedc+D/VrUOV53chsQ8dO99Yl24Mg?= =?us-ascii?Q?Fo0ddU/9KB82w+HkpK1jOC1ol6lF+IN+kmBSdpfG+kK3XkPs0nJU6Zhuz62V?= =?us-ascii?Q?7NWK6dUwHHY2PI32zoxsmfAm?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13866687-e1a2-4916-05a9-08d9909a8fad X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2021 11:46:15.7807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z3uKEdx9VhDpmqWv/28Kr+3G5rx/e7oKucVe3836K9KZewrmz75YLqTasMsdMsgJng9BWN2A7KqOR35aTwceSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4556 X-Proofpoint-ORIG-GUID: P-HX88KyPuEIFJFOeAwsvWA_dOqf22pr X-Proofpoint-GUID: P-HX88KyPuEIFJFOeAwsvWA_dOqf22pr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-16_03,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v3 08/10] crypto/qat: add gen specific data and function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > +/* Macro to add a capability */ > +#define QAT_SYM_PLAIN_AUTH_CAP(n, b, d) Can you add a comment for each of the defines, specifying what these variables (n,b,d,k,a,I etc)depict. > \ > + { \ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > \ > + {.sym =3D { \ > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > \ > + {.auth =3D { \ > + .algo =3D RTE_CRYPTO_AUTH_##n, > \ > + b, d \ > + }, } \ > + }, } \ > + } > + > +#define QAT_SYM_AUTH_CAP(n, b, k, d, a, i) \ > + { \ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > \ > + {.sym =3D { \ > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > \ > + {.auth =3D { \ > + .algo =3D RTE_CRYPTO_AUTH_##n, > \ > + b, k, d, a, i \ > + }, } \ > + }, } \ > + } > + > +#define QAT_SYM_AEAD_CAP(n, b, k, d, a, i) \ > + { \ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > \ > + {.sym =3D { \ > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AEAD, > \ > + {.aead =3D { \ > + .algo =3D RTE_CRYPTO_AEAD_##n, > \ > + b, k, d, a, i \ > + }, } \ > + }, } \ > + } > + > +#define QAT_SYM_CIPHER_CAP(n, b, k, i) > \ > + { \ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > \ > + {.sym =3D { \ > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_CIPHER, > \ > + {.cipher =3D { \ > + .algo =3D RTE_CRYPTO_CIPHER_##n, > \ > + b, k, i \ > + }, } \ > + }, } \ > + } > + > extern uint8_t qat_sym_driver_id; >=20 > +extern struct qat_crypto_gen_dev_ops qat_sym_gen_dev_ops[]; > + > int > qat_sym_dev_create(struct qat_pci_device *qat_pci_dev, > struct qat_dev_cmd_param *qat_dev_cmd_param); > -- > 2.25.1