From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FC42A00BE; Wed, 20 Apr 2022 15:51:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFC7140C35; Wed, 20 Apr 2022 15:51:25 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6FDA7406A2 for ; Wed, 20 Apr 2022 15:51:24 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23KAYT6Z009244; Wed, 20 Apr 2022 06:51:18 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fhtapdewv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Apr 2022 06:51:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGqZKri6hQtT6dnKcuMtMsL6NMbb/xeOvqrB3dfQKs0hGRnzF4hIY38sLxE1mON1DKICpfArNOqK345/2fl6C96SV7zy4KIpsiW7ikzaTlWo6A8G3rDPklUcvoZj9Smm8JyQSxgIjS1azjjdu1HbwntZrNt84YYs05N9hmWHk/DqrKe/iE5qOcZIJy4up9aWGq8gOaDrfbXrRNsFmjxTj7S+licRswnAWse4k9Bz7Dv+VrgSPNnRuws27wBZ9/d8VKXDC8zDXaGWTNX4j2z1VylNQATP2GFpoMIuZEnJ5sspHeEjMFY6v4NkeNlpJBHQZP+30U7o9nhZQhpIXc7aLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pFjTplq0l4NCA1bRKvic5Lc8LEVBvStJU+Iv5SDvW2E=; b=S1Bc7oQ19V7JaiKVlV7PSiScM7+dByCcklHe9a9unaLjM1QPQG+UEA09ktbxWR16qPxmeX3/X8L+yc73a0cscdL4UClWv5OTgte+flHVkTAHDPqfxG7b2ekkBdoiywju3odfJ3Jqi8YMZB31b/Ts/TMGZlXAW2JiRpezndNC6usiAyMv9kyPkZNXWgpNo0EcsSsToYRSQutAk1Mk5QM9m0kEzzHgj2uWA6WtgOiDVpdMUXJUWH3pI20FnNZ8nVFn3DbIJy0bcKBjWXy1D2oVRdCQd63jibSgRS0mbYJeN7TOw0N9B/SZggohbaa1hetokyRlMxP2dMCEQX0fWAK1fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pFjTplq0l4NCA1bRKvic5Lc8LEVBvStJU+Iv5SDvW2E=; b=Rx4lIZDkKPhzcDMZdw2oH2iRp9Wjb8X9uJqyn1PbY1OkYyENmgdrY2VvtkyL+T1r4s/HiqQ+Vy2QRhWVWc7zjwRGOxWWTGg9Xm+rL92hv7xbpAaU1c8oByt0ReFUtaxSxb8YjnQSSbD6x4etWB0ETSOyWPTdi6Oi1GmuwyXWOjY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4900.namprd18.prod.outlook.com (2603:10b6:a03:40b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 13:51:15 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%6]) with mapi id 15.20.5164.025; Wed, 20 Apr 2022 13:51:15 +0000 From: Akhil Goyal To: Ray Kinsella CC: Thomas Monjalon , "dev@dpdk.org" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "konstantin.ananyev@intel.com" , "ciara.power@intel.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Topic: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Index: AQHYU8uwM2cgSOHVbk6YmCEbondN/qz2/x5ggAAPHACAABsvcIAANs6AgAFXP7A= Date: Wed, 20 Apr 2022 13:51:15 +0000 Message-ID: References: <20220217172341.607360-1-gakhil@marvell.com> <11961195.O9o76ZdvQC@thomas> <4703969.GXAFRqVoOG@thomas> <87zgkhnkro.fsf@mdr78.vserver.site> In-Reply-To: <87zgkhnkro.fsf@mdr78.vserver.site> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4c9afc8-5f74-4aed-f836-08da22d4d69d x-ms-traffictypediagnostic: SJ0PR18MB4900:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nprudDYpROZskxseB9aGbTXqiQq7DmFpnm2A+Uw0hBfwjh9vQycQ9S8pH4z1w8Yr3wT39r6cPQiquwPJknKKuXsUUvQoSQGSaZqfvkjN8Mr/xJ1C1YYar7nElii/tuddaMhcu8ai//VXkWpwHXlPDAS0I1RbEXTTwJXcVTIfWxaiJFM/jFp2HEE+LtZS3nWH8HbHVFfAlyaaeDJsvhxDgBIE4ZrbMiHHZWh9uVIsY2xKq+pskLDk9Yw+VMQC3EzBdTr2YcjjfysySHJaod9x69kj6Ou9PT/v6njvZtM0TbEBuWOGQGlRsr3UnGe+1kR9fgHxCpD9e2JE4GagehoP5+kHuPfsExEr3percLRBJfC1Rhy7UxjYj+KFs+b7siQYjz+4XERMHUWXlPXoTvjoZ3o12Cll0W+eZyyxM4lXGYbpiw+zx6ZPafDLV5slUJo0JBqWdmUHv5O43ADbj/dewARAcrNhE1GxqToDQ3MfqOy4KtoRNL7gdJ2PuTMwBxgOw/mwT6XWRLgJeUKS6CLpHr3YumKlFl+tVJyA4OiGKZOdAf9OK7m4diKGvwex6MmRtWS7O/ypeCuy2O3tBiQTV9XifLEWaDpiPia7v6qOgIH+UmRqWRYNpAqc14Hf6Zim1PSC+USyY3Ii4p1tV8vOpRzqUYbxlm6KgIyK78m+MA4LsgSUJnriC8u9c5pxrDXeVMAY7Aneo5AbTLYQFnzKQM5WytUCgeio3EJJzW6BdwU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(38070700005)(316002)(33656002)(54906003)(55236004)(86362001)(76116006)(8936002)(38100700002)(26005)(66476007)(122000001)(66446008)(5660300002)(64756008)(66946007)(66556008)(52536014)(4326008)(8676002)(2906002)(6506007)(6916009)(7696005)(71200400001)(186003)(9686003)(55016003)(107886003)(60764002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?544O8017ybWoI48EpWX/y7SdOP6fbIDOYLsXvlcmPP6tk6OAaafXxlytljUy?= =?us-ascii?Q?tMe+ln+Bb1HiyI42IJGBTlAujrljOzoR+Q0DMKCYGQlN1fT0dp5l84l5KI90?= =?us-ascii?Q?zFxGbKzCWWloTViwbLv3RC4/7EYz2JBQi32qs6kXurMyDkuREKcZTlQzXJ3o?= =?us-ascii?Q?zD6or8RlP14dm3dxRyhywLlpg8VQABWHZlRDwzStkvtJTUEwpKUti7tk1Li8?= =?us-ascii?Q?VIU42Iawel4rpHrN/P53MrxuQ2R0h6vAYRCS9hW+VH1BYMTL7oyC36wnzUoq?= =?us-ascii?Q?8tFuPzH2cjy+xwTeI6YkiVRyOMite5+AFWfKOBl/uyYMG8PkZjW4OlGqjIXC?= =?us-ascii?Q?CajkW39iKz4ftLfwiIWeiq12/s9JRZKkuewxP9f5LnYBemosEBCW3yLJ195/?= =?us-ascii?Q?qRhf8/ar2iZb4xRlQ2UFrVB5tpfsCFXvFMKLMlfr5PUL4Smc3lgzKxp3U5uI?= =?us-ascii?Q?cWTJpj21bDTWzHBAHWrEUjQHrsVAk8J+JIkalQbXSRS3N05cJskNZR0Bm6vH?= =?us-ascii?Q?0PFBmzLs+f9wT5F2bMeO95xOStb4szK0O9QbOgcsjK0qq9ftGAd8g9sGsHgY?= =?us-ascii?Q?2MSXfT4ct9voDRxMDN4BHt2TZP0uPiWub/XUOinR9naTV0/B2Ev+TQxcjbSP?= =?us-ascii?Q?4uwsjJzn84HrF51XS1eJEwEDTF03O7oJid2xMUmUNyomS60b7lz9+gcp7y76?= =?us-ascii?Q?I5PKcoKsG9UKC/hHXSzs7PAYkPeSH6yyBFlw3ofSqvclrxzeZP70/bLSNH9C?= =?us-ascii?Q?b7IjP5rWyeZytpLMMF5UpRVUEoPCNqHfU5jgnWAV31geR4AfUHz6BAKLtA9m?= =?us-ascii?Q?qR8o1hAumw+2WgX9lFXr0FxWAN8E7VxSuNIwMptdbIfI2880DxDh11iuw8mM?= =?us-ascii?Q?pv6ygtwkKIHD4fE11NZQ8UMsvhNCUfIZqRHXqQCXz/OKsyIlIJKp5hqAsEI+?= =?us-ascii?Q?aOMKcZ2A1hA7m6DfwxSJP7duzslWr9XrgRMdI9I5ObrHY0jYUSfUDcIMdZAw?= =?us-ascii?Q?VKj8VXvKGlNxrEW/0G4KQkTgmlE+Utp1hX7To9aUcN1F3+++RbLlS3bTRDSA?= =?us-ascii?Q?NRP9OLGgjasPjgBefUDmODVp8j6kOTixDxsL+wFZwUVbgWFAhBVkwzXXox0N?= =?us-ascii?Q?jAVtwG5U1FEc81lMgKHTjmRnKBNrRs8loCU/D46qh16RkEjYlu1+QBdgBDuM?= =?us-ascii?Q?7V3orgQ3TbK1nVhCwOjaLFsnP+Wj7ap273xr2C/n/bej0BS7sVOvifrR8H+1?= =?us-ascii?Q?DefPhL2NQwGke6KzUb0KTz3nB4lSpdwP84F6oBHRh4ITUN8ZjPFAEUkzlq7T?= =?us-ascii?Q?DSmBAtmYuhCeZ5C4TqPD7J9MGy03OB5YjVgJwFqstLu0gZgvtFuHxFW84Ltc?= =?us-ascii?Q?oB8L5iIEYtM9haZF6Nuwp4qI8eWHrcqmAYJ4S8DIQfC+uViQyRYh/MU0t5bM?= =?us-ascii?Q?vXcwkbYTRkMpYiaYClKpPGnl5tsrK1Fj95vn0iYQMOYC4KlfLdDg1gdk6wi1?= =?us-ascii?Q?x51vXOlXbMJxm8a4olKkZMpfqq22ao7Qp35ujC5T0hgP/zMcjMPerRfJw30s?= =?us-ascii?Q?FAcizoccEOmPF0MDm3s6P+FxYtZpPXB8iKmK6RDBXTJZdkB9c3j3ds3dW3X0?= =?us-ascii?Q?C84xznpbrF4ZTtWKTClo5zCGteICyuHulC1wmlFCOofQOtQP+GKcIAkoganP?= =?us-ascii?Q?eOvkpFF8SFQ9JBvIRTaUI9IzFNM89sr7qJb4pKO1Dj9+ThC2oiy5JZ2HU4En?= =?us-ascii?Q?QJzQ66HneQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4c9afc8-5f74-4aed-f836-08da22d4d69d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 13:51:15.4653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: buntB4pezAtvaXo3et//0W/0S2NgUfQy+NuFMPq+i0BNUir9Boxo/Cl3d1eXCQlr5gJZQHrCoLhLRVsjq/Rr2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4900 X-Proofpoint-GUID: C4whOhHZ5d8pROOPz9Ti6mO7CdjQkZCI X-Proofpoint-ORIG-GUID: C4whOhHZ5d8pROOPz9Ti6mO7CdjQkZCI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-20_04,2022-04-20_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ray, > >> > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > >> > > > + /** Hard byte expiry of SA */ > >> > > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > >> > > > + /** Hard packet expiry of SA */ > >> > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > >> > > > >> > > Same comment for the 3 events. > >> > > > >> > > > /** Max value of this enum */ > >> > > > RTE_ETH_EVENT_IPSEC_MAX > >> > > > }; > >> > > > >> > > What is the impact of this "MAX" value on ABI compatibility? > >> > > >> > I see no issues reported while running ABI check. > >> > There is no array being used inside library based on MAX. > >> > >> No need of array inside the library, the events are exposed to the app= . > >> I'm surprised libabigail is OK with changing an enum value. > >> > > @Ray Can you please check if it is an issue to add more values in this = enum? >=20 > Well look there is two seperate things going on here. >=20 > Why isn't libabigail complaining about the _MAX value changing. I'll > need to look at libabigail to see what the issue is, so lets put this > one aside for a moment. >=20 > This second issue is it safe for the _MAX value to change? > We have a lot of back and forth argument on these, and previously > concluded that we should probably look to remove _MAX values in the > 22.11 release. Agreed. >=20 > The core issue is that we need look at how a user is likely to use > rte_eth_event_ipsec_subtype. Take a look at the example below:- >=20 > /root/src/dpdk/examples/ipsec-secgw/ipsec-secgw.c:2592:0 >=20 > For instance, can we guarantee that an application built against DPDK > 21.11, but running against 22.xx will never recieve one of the new > values in event_desc->subtype (or by any other means)? ok we can defer the 7/10, 8/10, 9/10 patch to next release then.