From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82FDBA054D; Thu, 26 May 2022 13:34:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2818740151; Thu, 26 May 2022 13:34:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C8BE340150 for ; Thu, 26 May 2022 13:34:25 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q2Aeot003160; Thu, 26 May 2022 04:34:24 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g9jap5e23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:34:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kT/SKp7tduHWf48Zlu+SJNqf3t7ggQ4il7b0bTquZWJvu+p1x6XoQ31beqkmnC+jD7q+wvPLHH5SXwpahmHfXT8pmnrwAJj/5hBgpDPte2GwvNpjXedKK/5dLTKPhnLG69jYZYcJcUKGVmC/p1/S+MlqRJ8jk0DQsoY4jqa48CXkO2tRxbPS+O9kLMKI77kL/oKXFKKEn8gpBVzm+w7f8i7A+oWrnn9gTBvxSlHK6VZ62A/E53cbgDBYOXjXXOOQ8+2pBlOHTNj5qzEOLsG+ZMDKa67+0aErC6dnx5BP42rRp/H2NQwu0SFRhDneL1H9YFcMvQFRfj1q03gRhJ8Gfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/sNfxQyyfkw2C9lHt4b9aUj3OYOsIbieUaKa38y1guc=; b=FyTbPg4wVR3pUOGcrt/O2cV2VDQDz2LIXsgCFMOjktXc0shI3UQfAUjThv9Xrz6bOLaLE6+8LzrZ1m1fE34TDQjORVyRK59hhfX/rBFG8p7ofDXZxw7dhVhkGl9GocEnwtzsT4EzxOyZJZ8AsF67TVLeOpXQkDJBlM9oGDS0t18biNYGa3IPF8rnbs/5Boc3ZanCztBsaupzp0BssuEKEbCcD8J0+Gv5Gx3rQ703tDVwN5m2WKrS99haFbSwAgxiKIIMrNRGymiVtOdtMzXjX57rvVRyiG80pDyBpw3yKo9Oi+j7O4B9lkj8dXKTdYyPNVekmCElSdmH7WocXyn0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sNfxQyyfkw2C9lHt4b9aUj3OYOsIbieUaKa38y1guc=; b=pNzpud/1CZdcmrGKbiRg6Wg3UOQPCho4VRUsDNC1IgYCDvcyLCdlXSG0wGvMLci+31upX1Z95bIHwFlbp/5fR6axGnXAEsHYtAFMQdQ8itdqPy9dY5WEmJO5ZSl4R0Ih3cmMN8FV+UB2edtg3iHGkBgTt/7REYlRVuhD/KXhQEg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM6PR18MB2683.namprd18.prod.outlook.com (2603:10b6:5:189::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:34:22 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:34:21 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option Thread-Topic: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option Thread-Index: AQHYcFmTjn/KlFR3t060jlIOPILDXa0xB1OA Date: Thu, 26 May 2022 11:34:21 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-9-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-9-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a13712b1-4fab-4742-a111-08da3f0badb5 x-ms-traffictypediagnostic: DM6PR18MB2683:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uzjiI6g9WfJTREoImftBL9kM4JXANknXgrvT4yGAlGC380yB1NaK4aBE9QG/3RzNQ/ct7FRiQs8dgEDJpaERyazl5RGQ7UkeArqrY6HHOr1quZkj6U+eqs47cHv2ykdMvJ3i0kHF0Vx4PZZCDKR2R+XztBy2IAP8sBicTRHdn0iCN/sRlako03fCL4lMputZ1zON43znMlfAIQ9Q9mYjwV7ujjRtRAHVTMHcxzzP3g06CLY44s3iIaaX+cUi8eW7g2kDDnj+vNAIFfIt6TDprmyBADSrVTbu81Bdg0mpsfvauPR3UU5835nsZxbpY8qtL1YwPDm5wvJzKtbMdcbr686ziYig1Xyofa+QtrYtMMOK3HiqezYiyAI/p7EChdfv/HBKJ6nfATgiWqC3za4WQmEc1fltA3PRdk6w+j+IZ+8D8m6D5viDSSAwT1cYv2GHM1S0/WwUiYX/KyfzEwoMdwbTKjYF0SFKGg3MFgMqAeHJhPj2nedqsHV9/qAyI92K7kMtCrBj8+BbbfxD9InbpnL2v/81oOI/VZDIXKpDoLik2TPzSg6RXsgXopAJ+U7ktz7eHQNVKODX3t96OeJsSElzZM4dBL5nWiUiMFuzODRfaJ5pewRm7AtBsa05Rt+6Pp0tEA19NA9i9Ni+efUPhaS40GdMHHrlCK0VrVrKOIjxM0+T+/K20BFNf0KRB1jD1J22a5NdzDrYOPOM5FKrTA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(122000001)(110136005)(5660300002)(38070700005)(33656002)(71200400001)(83380400001)(186003)(38100700002)(2906002)(86362001)(7696005)(52536014)(6506007)(8936002)(316002)(15650500001)(508600001)(26005)(9686003)(76116006)(66946007)(55236004)(8676002)(4326008)(66556008)(66446008)(66476007)(64756008)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xw58/zmgXq/R5JNHM/d6JNC4bviy7+mCfHCTFL2QsMkfKEspQe6YGvlPfON8?= =?us-ascii?Q?0ymsYEdwozLos6gN6uOnAA7cdovLOXbowNhhf3Qlg+Q/OflYNDI8FW52jpYD?= =?us-ascii?Q?ZxdohNdHDD4vyMHWBDv6cAWQtP7TMhB1+YSaGb/4Tm7nYjXJVBGp4PSaPy9n?= =?us-ascii?Q?eNlIETZtBJsy5XxUDoSrW9TpHS5eMrrqgMI8NBSQMbPv56t4EHUHPAFPFQO0?= =?us-ascii?Q?Hqk5yME1TyiGE/c1CVKKlrl6XnWjJvKC5siL2GPIC/yYgAbGiP6iA/rtdzWz?= =?us-ascii?Q?lSs7uwA/g0mMQwNNmaV4qbS5wayTCaveJG1vu+LSaihCRRIZaCkc0Y4JxWfm?= =?us-ascii?Q?1Dee+Ob8qnn3V/jfxWglSqPhgwz1SJ0hbaRx/IN0HU+GLELWY8QtmXuuIrVl?= =?us-ascii?Q?Xf0DZ2IMOJv7QyzXNz256Lv++xtCMrLaopfin33zEY/fIhplXFX/A1cbKvMm?= =?us-ascii?Q?r7khZHp3RO3NiSdc/uUEUwO/1O3+8QGbBorOQXEktZ0J4qhdJPAbsRVZ/m8w?= =?us-ascii?Q?wyOg+3jRD/jcfUTZg22tSlV8tLwt09b9/WafFrG3dKb10GQZiPxOnXk41OpP?= =?us-ascii?Q?5YmMDR/DB6Z7LfBhvbNy/QjTkBSyKpC13QBPgiovJDjBn22tWGlDeL9Mgg+k?= =?us-ascii?Q?XnDCm2FCu5XEK9kTWvAkeQTk9M0Geo6DsrknZhO5wDkwd1CDaN2X28obCBBZ?= =?us-ascii?Q?RCehTUU2yMW00jdBcdnQEsshD99CFJl3LzP5MDKFDj7e5IkiGDqkMvZXdf8R?= =?us-ascii?Q?pHyvyyx8PmupIkOqWXan7iUnmHJDlefnvW67UrVrOcQuRQ7Cbj/UTcId6EHu?= =?us-ascii?Q?v4DS59giiO999FLeH/N0CB2nnDT6vo7lRpDIFFrg183fEoYHeC6WPodjzk6k?= =?us-ascii?Q?cngr/fsEHZ04vJph6ffMCTufC6jg+4I2So9zBU8bpqp2ibi641tq9KeQFp1k?= =?us-ascii?Q?igRekWBSk5ij35pVd+uDL0/fODrs3mvE+FSE8Hsgn3WQgC/rzJ9FO2Sdc97h?= =?us-ascii?Q?varIKJKUW7XKGls2mSxjmLwCcHjLn0YYkGyT0Tsw93OiyCXOONavzU7KqNPg?= =?us-ascii?Q?b0bQxhusX4IZCCLZjrmIPuuO/2Q1heDOkCFTFpRUwnayS+DrhBUhk6Y2A0L5?= =?us-ascii?Q?H9r79j7T6mW4ba5VdrsUsac0ZPm8K6AvuRL7zdBIBCXvEuxo9npPQSTW+yiR?= =?us-ascii?Q?7ceH+9DG5ZyVpxbGNWRUjHug6K4Zmn6p+TiGfECI7ic8e0xFLujYjUiALnrH?= =?us-ascii?Q?d5ePAmQGQczCXciJZ7k+i7eQb+CdyrwXGlatD5mFvZ+xgN3Z15UeUFuZHSqU?= =?us-ascii?Q?8fKgtdMrAERTPRG4pDzDULHa0X8JG9+EGnoTUJzRqLMsXpuCAqngdKT3KXdM?= =?us-ascii?Q?5zSYY6K5ieMN5i01uUXPw5voWbi8ZgOfg3pjq4JOWDgmcfOlClmOuHQQoDk6?= =?us-ascii?Q?rQ7qhpxga9UTmvmZM+9Nx8mWpzhLji8XnsgkNwcM8IcLne41sSTQ4AQG4gWS?= =?us-ascii?Q?lMmu8dwR6uyi3fccorjRIYiIH3IZ0ZxQig9APmDeVfleq4vhdNp1OEJZzQ4k?= =?us-ascii?Q?1bwqOewUB8hRbaqM/MgFaTSMa7gnN0IAlf906P31czdMRPK/1AqN1Yjm02G4?= =?us-ascii?Q?Vh3XhxQcOGQsy1YM6ycREsYVVLytp9pMQSd56mj45VNhyRRFHkBadm4I1/bo?= =?us-ascii?Q?3SybKCVtDmFCRvLSNpVTVx5nYIY7Km3PS5rAhV+SRYaf4Y/Jr4+oEdL04B6Q?= =?us-ascii?Q?OLbR5r+c2A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a13712b1-4fab-4742-a111-08da3f0badb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:34:21.7585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vc/E6rK35AKjay/JtC0o7EFNfUtuF4CznX8haLH44VZHYut82FUBZuhn2gvn8lmwQSVn1eQOx3GX+opEzxyjgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2683 X-Proofpoint-GUID: f7Qw5nPElUIlGUilaXd6y5oVIiBZet9O X-Proofpoint-ORIG-GUID: f7Qw5nPElUIlGUilaXd6y5oVIiBZet9O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_06,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Added key exchange public key verify option. > For some elliptic curves public point in DH exchange > needs to be checked, if it lays on the curve. > Modular exponentiation needs certain checks as well, though > mathematically much easier. > This commit adds verify option to asym_op operations. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 9 ++++++--- > lib/cryptodev/rte_cryptodev.c | 3 ++- > 2 files changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 0dab7c0593..3eafaecbbe 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -141,8 +141,10 @@ enum rte_crypto_asym_ke_type { > /**< Private Key generation operation */ > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > /**< Public Key generation operation */ > - RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > + RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE, > /**< Shared Secret compute operation */ > + RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY, > + /**< Public Key Verification */ If this is not for DH and only for ECDH, then specify this in comments also= . But IMO, it will be OK to use RTE_CRYPTO_ASYM_KE_PUB_KEY_VERIFY. If it is not valid to use it for DH, we can mention in comments. > }; >=20 > /** > @@ -434,8 +436,9 @@ struct rte_crypto_ecdh_op_param { > * Output - generated public key, when xform type is > * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE. > * > - * Input - peer's public key, when xform type is > - * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > + * Input - peer's public key, when xform type is one of: > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE, > + * RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY. > */ > struct rte_crypto_ec_point shared_secret; > /**< > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.= c > index af58f49d07..57ee6b3f07 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -185,7 +185,8 @@ const char *rte_crypto_asym_op_strings[] =3D { > const char *rte_crypto_asym_ke_strings[] =3D { > [RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE] =3D > "priv_key_generate", > [RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE] =3D > "pub_key_generate", > - [RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] =3D > "sharedsecret_compute" > + [RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] =3D > "sharedsecret_compute", > + [RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY] =3D > "pub_ec_key_verify" > }; >=20 > /** > -- > 2.13.6