From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72CDAA034C; Thu, 26 May 2022 15:52:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19D7840151; Thu, 26 May 2022 15:52:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 77E0B40150 for ; Thu, 26 May 2022 15:52:50 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24QDMQK7027629; Thu, 26 May 2022 06:52:49 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty90a7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 06:52:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+WC/UdS3vLVqgI42W1N0YQKWZ4KGB62QW9PH0xAwPPCz5fLrYcAKdBRVfaw9D1fUDlzFu7q8QE4qTXiyQ+APgAeKN/MWSzeFAkn9ThfgVu3ZRB2J9dK2F2nav5+J9UHRf5R4tgeCEMk1nOTivDDyN7Wv2ehDDfqdggXg7ANdrBoAfSEAwRDWRi/JTvE6awDaWbwbQ98yfNdx+NqWo7nMeGxyoa7p5pOLUxzrt1OieNRuQ8FFuInaZIdAz0sGiOw8Kca6gp/ynROLJaS055W1RqxVLsEPQtOsTzybv1L/8G6/18X6y9ZCAgcaYuQGM+GVQ2FBntNAQRLMxMmgl8WdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDnzWaToBsb/vjBrXlEw9w0EqL83rvj+C0FdKG6MH5E=; b=gtFSLtOHqWAEnLe97lDAmo9ackCzrtRVAfto8F/wa/IzfVGL5MzMgARDe5fsJdSGfOFvlKFnHdv7SQiI3IMnz5mA90QYLj24p7GFIh3s95NZUU16ZfpNB7CkNKXAKHDT1T+BTwlOI/LX5CSx2DFOmMXO2+MAQ3IHsCdWU/pjPYxPvrhcJJpSbu7rqQC8uzRBWlR6d1cgNdG6N0uA3HTwHefDLDfUZMeHhNf6BQmGZYCFuDeAL1aDbAEZe+XEwUU+X533UHsQ3bBd6rf5HTHO2uoQKVu3K/sb6/E02HRmEgYwidLmeBPFsHiMGEJ2+m8z7+35s7kXk6gHQL2g0PuyGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDnzWaToBsb/vjBrXlEw9w0EqL83rvj+C0FdKG6MH5E=; b=KL7scPfjFRCEK2TNI/iXT+SPqKTt2AbUzwr7k5wqQTOw8GeUPI/CkRXDhUN4OU7MGuqniKvev6ov07Scuau3Uoz1PedNy866MM191aJJYGEUkkyTvFQ5zAW28hpw5sxr5m+p4w3Z6RmdObmorIvsWBqiqGitTq6/49dtdUC6HqU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BY5PR18MB3236.namprd18.prod.outlook.com (2603:10b6:a03:1a6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 13:52:46 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 13:52:46 +0000 From: Akhil Goyal To: Gagandeep Singh , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Topic: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Index: AQHYbAEVPTFjFIBZi02ZoEOjCcZ9xq0xN4vg Date: Thu, 26 May 2022 13:52:46 +0000 Message-ID: References: <20220517033858.40394-2-g.singh@nxp.com> <20220520042104.3784908-1-g.singh@nxp.com> <20220520042104.3784908-2-g.singh@nxp.com> In-Reply-To: <20220520042104.3784908-2-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 22d14662-4e4d-4f0c-707b-08da3f1f03c3 x-ms-traffictypediagnostic: BY5PR18MB3236:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +WpM/+lVwp4Ge87VG9DgNt2OORh2240KHztg/f8fwQ8hWOF7tNzWnw8SXoavTmePQXjOEQaJbrZ01I2ficRWV2Q5SlHyC+PiIjlNym9HAVAM0hsjPDVJDBmSguzhkA789qoDNyo8SvFpYjC5jWPce1feH8wSxfbRW0OLl2I+CP1FzM4GhTbkVbMTPfs9gONRe13CNIvi0Yvx/6ADPYMtas0Q80GMqkUd/JWjPVw3K8d/BHzyi0lPhjDQTlYgcfVcJlrShA5vambptJ6YAgi1mv6Ol/gmMROOrVmjSIbixIk7W0bFFaFKsb8m2hBrXepdmnjuqsT4L0wwhDpSzXEAU409gfZJJOcP5uSD5RHt/jcbMsXNogXfys+nswthBr8vNzSlHOb0NIKTpvP+oKVyeQbho72bRioHp4niQZKK/LAZSgh/We4pMwJqUPOkJsJUjpmQPtPcwgyPtmJOP4YCBIWx2k4K7AxN3N3eNFAgvgMYTN0zS0ge4kqWd+6EAUpt6oI+5tnyy9tEuLufX2PQqCRkX+6s0M2NCkbApBpLU4d8iODZtkH4eyB9/gOM7a9Itt7Z5L8hXsOhWVTdPQP8Mw5vWCWhyCaqbUtdb+BtzE+uGcQmVH0A6ENv4wo+v0xb3/k9YT6eq+76dYiLQv/KDzoS+L4W/Cjl9BxppkUSEAQ2lJmHW4kK2paFPGVflxflWgRKX388lOhHoKdjetUAuA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(55016003)(55236004)(7696005)(6506007)(83380400001)(8936002)(5660300002)(52536014)(186003)(33656002)(26005)(508600001)(71200400001)(122000001)(66946007)(38070700005)(110136005)(86362001)(38100700002)(316002)(66446008)(76116006)(66556008)(64756008)(8676002)(66476007)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PdTa1DE+MUvlL5Rp3ET4UFSMU7LfKjqBRruJz+uC6VZ/an2lUaw9oH37/N5R?= =?us-ascii?Q?eGmkMUBQH1sELQSl0pXn/diTG8wPfIqjYfe6zaiIR+CQsbsD4dfFBHUqoBay?= =?us-ascii?Q?LWv3Xr8x3XHZaRfLa72JV/7nX9qJNihaYqDa9xrMTQdozgzEosuAa/eESEya?= =?us-ascii?Q?Ic3pIWwoMBHoDE9eopmFLl/gk3Iee3Sql+MHIucNgixazMMoZjQPElvw870K?= =?us-ascii?Q?i84uLtbswYmPXAseConTuDpTVeNhErEx1KTKgdzIQXqeyULJzFWXbCQN4KIG?= =?us-ascii?Q?1GZ8zVsG8shE7IVfQWuMDFDY4FpWyMQIWXW/8cyXiHdzLyTFJsm7m78QNgdJ?= =?us-ascii?Q?UBLN9sVq3MBA2F+fmoNlAXk8+TkvEY8/6UJYTJH6ItbWhrczOgGit5AXylMr?= =?us-ascii?Q?fgXYE7ZXU4ClXK6YA9vi8SuRwbaTQrcgb9oEYjKpYcY0yz0ug8Tw1Z4TDN0/?= =?us-ascii?Q?RX2LAYnLGY8Uc7TG/ncgHm6lY/iZ2g5NQjUvUwZZrszhTuebshYTBRCAR0cC?= =?us-ascii?Q?3qBE9o8Ecz89L97PiexcgRQNxxr7elk/CPkFakcGpLP5uPkjR6C+nk2dX+7m?= =?us-ascii?Q?6n5j7HNOaxZqyvypMDUjJTSA4qPJ1TVjG3EOtVjlfo4l+qABqEPSAqZo6Ny6?= =?us-ascii?Q?Esh+96numoEIJvl7M3u4TLyMnxQkqsZGadsm3xwX6H2MyUOQiBtN1IropDcL?= =?us-ascii?Q?5ohvKepSPUqPCkIqcSolAeOb7HaZH50Oia+g/O3pqSkMKTBgNTn9ZncBxRp/?= =?us-ascii?Q?NlaFw1XOdHHZjok3ofR2n08OjR5K4EWuTzX2ZcHzaV/XIRIfDX3RaHU6ntTd?= =?us-ascii?Q?losAKOy0cri52ahvALVMpwGeEgjNYDdGSxFNyNbhJ+vgSdo2PXt6qr98ivDQ?= =?us-ascii?Q?0OkdEut4trYD2a4OeVcsvr4APIwrjTBsQy8Rv71tCPtvz8xtqEnQIaMaeqHg?= =?us-ascii?Q?sDqoZ7vP+PQGAJTPQ++Q4qI1xy6NTm8aUQjtrPDwGl33PPIZfAZSV4UMFH2G?= =?us-ascii?Q?ZaLMr4GalaJFGoz+fevxf9iQFi4FjmobDyZbIi5kUMBLvMd471shFzkPejRQ?= =?us-ascii?Q?rd1lavzz6gGixQ1uBKRtQ2gMFaliyG4gYBdWme0PmPb1Z2wuzF1o52lML8hA?= =?us-ascii?Q?4EoLqUwjU5JVBGXtnPqhX2/f65rz8iIn3e7aGtiOJtA14wOc9GH8qCJChDP6?= =?us-ascii?Q?TMhm8lNR/XmW1S+DCQso70cKGMcAa0v0+Nx+HSTH2k1X4ngvmaeMPyTkXF9q?= =?us-ascii?Q?O9LbDb6WpDkBhvsO8qeTohWOa5d8dh+//vdmGft6d9BKI8yws8RDFNpO5Y5g?= =?us-ascii?Q?xxv7r0YUK9AFsTIndaN/e2IJI9xle9MCZENJ6yb3/9zOvAo7u3JETbeWC8IV?= =?us-ascii?Q?egNbyQxBiTluHE3q35TeDXllJ2Oaw2OCgkRbNCzHVoJtU4my1uFXbFLlPyYI?= =?us-ascii?Q?2aOXdEOV4KwioCme0hIuAH2jIOrQ0SNemb6NsZiEjyo0FffPmXbEKIeAciz8?= =?us-ascii?Q?kt5GAjkzII7Ar1MoL2IcfHLFB3kIOEnrlKahpj5pF50cOfpD36bUs8iyAHFF?= =?us-ascii?Q?TzXL/8Wqnjn/qwpxcU8IUVHkYIBONcy9v04Qj8UW1AqwTJ9mQMDwwYwndJ9A?= =?us-ascii?Q?fPT56y0spHNgb9t7eaXBsL0sor9o5Xs+V8hadie3q4uEjErAc03nkp1c8GGa?= =?us-ascii?Q?OV/laQoDQJt6Co7uJty6MnQoLilMAakMoOLCAHg7aF1DJjLdOQ7hNL47sBN7?= =?us-ascii?Q?OwcxCQoxpw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22d14662-4e4d-4f0c-707b-08da3f1f03c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 13:52:46.5553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a3Ff8wr/bO7gPgr0okGCY8XBAH4dlbOIYDxXTt8CMssmlLeMThJH+oFXUIPjUnBvaYgsjDkkYM4Y+MLj2GNdOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3236 X-Proofpoint-GUID: mEeSMVNkbYDw8skNJzczllpbgd6ch124 X-Proofpoint-ORIG-GUID: mEeSMVNkbYDw8skNJzczllpbgd6ch124 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_08,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Add a command line option "--enable-sdap" to enable > Service Data Adaptation Protocol. >=20 > example command: > ./dpdk-test-crypto-perf -c 0xc --log-level=3D8 -- > --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr > --cipher-op encrypt --auth-algo zuc-eia3 --auth-op generate > --auth-key-sz 16 --ptest throughput --total-ops 100000 --burst-sz 64 > --buffer-sz 64,390,1512 --pool-sz 4096 --silent --pdcp-sn-sz 12 > --pdcp-domain control --enable-sdap >=20 > Signed-off-by: Gagandeep Singh > --- > app/test-crypto-perf/cperf_ops.c | 1 + > app/test-crypto-perf/cperf_options.h | 2 ++ > app/test-crypto-perf/cperf_options_parsing.c | 12 ++++++++++++ > doc/guides/tools/cryptoperf.rst | 4 ++++ > 4 files changed, 19 insertions(+) >=20 > diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cper= f_ops.c > index cbefce8d6c..4295656a0b 100644 > --- a/app/test-crypto-perf/cperf_ops.c > +++ b/app/test-crypto-perf/cperf_ops.c > @@ -861,6 +861,7 @@ cperf_create_session(struct rte_mempool *sess_mp, > .hfn =3D options->pdcp_ses_hfn_en ? > PDCP_DEFAULT_HFN : 0, > .hfn_threshold =3D 0x70C0A, > + .sdap_enabled =3D options->pdcp_sdap, > .hfn_ovrd =3D !(options->pdcp_ses_hfn_en), > } }, > .crypto_xform =3D &cipher_xform > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto- > perf/cperf_options.h > index 09caefde22..613d6d31e2 100644 > --- a/app/test-crypto-perf/cperf_options.h > +++ b/app/test-crypto-perf/cperf_options.h > @@ -14,6 +14,7 @@ > #define CPERF_PTEST_TYPE ("ptest") > #define CPERF_MODEX_LEN ("modex-len") > #define CPERF_SILENT ("silent") > +#define CPERF_ENABLE_SDAP ("enable-sdap") >=20 > #define CPERF_POOL_SIZE ("pool-sz") > #define CPERF_TOTAL_OPS ("total-ops") > @@ -129,6 +130,7 @@ struct cperf_options { > #ifdef RTE_LIB_SECURITY > uint16_t pdcp_sn_sz; > uint16_t pdcp_ses_hfn_en; > + uint16_t pdcp_sdap; > enum rte_security_pdcp_domain pdcp_domain; > uint16_t docsis_hdr_sz; > #endif > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-cryp= to- > perf/cperf_options_parsing.c > index 09c98121c8..28680347f1 100644 > --- a/app/test-crypto-perf/cperf_options_parsing.c > +++ b/app/test-crypto-perf/cperf_options_parsing.c > @@ -64,6 +64,7 @@ usage(char *progname) > " --pdcp-sn-sz N: set PDCP SN size N <5/7/12/15/18>\n" > " --pdcp-domain DOMAIN: set PDCP domain \n" > " --pdcp-ses-hfn-en: enable session based fixed HFN\n" > + " --enable-sdap: enable sdap\n" > " --docsis-hdr-sz: set DOCSIS header size\n" > #endif > " -h: prints this help\n", > @@ -548,6 +549,15 @@ parse_silent(struct cperf_options *opts, > return 0; > } >=20 > +static int > +parse_enable_sdap(struct cperf_options *opts, > + const char *arg __rte_unused) > +{ > + opts->pdcp_sdap =3D 1; > + > + return 0; > +} You should also set a default value of this flag.