From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AB19A04FD; Wed, 22 Jun 2022 13:50:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 288874069C; Wed, 22 Jun 2022 13:50:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 21CE340689 for ; Wed, 22 Jun 2022 13:50:12 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25MARjLC019109; Wed, 22 Jun 2022 04:50:12 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gutv0a3rp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jun 2022 04:50:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGME4ONSkf36CqX77DJOWiv3kbApL9VoCIOAT0qopcYPzkCA8Ui5BYv0iJX6x4Col0rIpXjmzukEEt88axCTi0AKcb/rG+18vVMYPa9oyKdbs2Ex2LW+0wBL62uWKT0Yd+NaJHYP3/YL33bUJFnnrLjRSJAhubyluEVBjq4aVXDZEK5Q93xG2UA1RXTTAdZn0oiGq/lk26yrywYFxZp5Mx2qvGyII8MH/BYDRk4jtplWXc/IkIU24poZCsh4++zADCbBX7JYGXus8PmgvGx7XyXq67JYUaLDsiAQBVB5bEUz0PWZG6BNp4fBa2Qh6HxVfCicjoAH2cM+eSfhCSQtsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oQgGVdJ/rFt5gYi3pnxkJu8NEmmzVgq56HfHTvEuyJk=; b=VdUwVR+KtstKgHOn5qOVJ5MycCjioI7CGWx5ABA36jdm9E4hAa7zhmlno9qd1SWR+ha0C9hrgw3nHO1TBPorj4Dqxyg+iisq0U2TpsiGwT5+2hTBoGeenP2iAW2Tj/IAkY6UXLsYkRAFlEn0hRczn2066rlgsvHuVHysHNSfYOXmyu+EpJG6VqEg7HHCOPyPjow5eIOakt7YufU2b/t8DUAo3M6DRI1piXbbPoVOthjBTSzkHcyt8CdRIpxRbh2Jkvrwggj71oUHrZG7MfTdNpEWSl2H32NUH+doTka7ZC/dbt88tMWLc63RQFr+hwDv9EBtMcNjGio1jdUMpsXizA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQgGVdJ/rFt5gYi3pnxkJu8NEmmzVgq56HfHTvEuyJk=; b=e7MNYAsclsyqKc/kliQPytTFf3ZiXU/CXQhA962DVvf5Eeg1L4W7WDiGbhOEUzRxATjbqT/gA/rqMuM2roNUZFyQ4hoNi8ozmy/L/0kVfWFshZqW6UlR4nMQ9rZM9vKhYRbGrE7WclB2DsAfsuIRNTRIJ1fZGGW6+8nsjRBcwyw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1317.namprd18.prod.outlook.com (2603:10b6:903:14c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Wed, 22 Jun 2022 11:50:10 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5%9]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 11:50:09 +0000 From: Akhil Goyal To: Akhil Goyal , Nicolas Chautru , "dev@dpdk.org" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "thomas@monjalon.net" , "ray.kinsella@intel.com" , "bruce.richardson@intel.com" , "hemant.agrawal@nxp.com" , "hernan.vargas@intel.com" , "david.marchand@redhat.com" Subject: RE: [EXT] [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Topic: [EXT] [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Index: AQHYdT+UT9hwzmlIf0aqE0GNKxdRbK1QmASggArZFJA= Date: Wed, 22 Jun 2022 11:50:09 +0000 Message-ID: References: <1653350912-53876-1-git-send-email-nicolas.chautru@intel.com> <1654036307-182860-1-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe625521-979b-4553-029c-08da54455c00 x-ms-traffictypediagnostic: CY4PR18MB1317:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x6u+86Rms01t7/Bh+wudJXpiuspEUv/PCLZYyhKisn8NDBZPz6piV6zzX6zeL6Eit0BB5487EZYlq8odIrZ/piC0sgidyXGTdPq5M/eWQkgWBd4JGPUKgU5S7wPmtViMQdsQrm5sw29uKfJ0yD8sw7jkvUhDFWkEqt+uOne1PMoee+P1viOoJHkyO47L+mAFF8WHVW0yrbyPsd5qt2aviZEJpURkwA+PptubMhZ8cJgDdJl/qS/qxYHmN5EVvoNkoi5duesqQnaR6iaiZhlKiHRSw0wIm33YCxJwnIzJ4yaQ2RuDYmHs1cTtNumZQegcr1fSZOEE0WTtAgKhRtb4YuwzL8fZccUnz4B7HTL+4knkAU2ssbaP5OWxLVDqyJZM+gviU7++SqouDzA6t1tTcWIT7rsm4+nOc+SMrI4/mjZu8w+pInJuTr2/PwrUiBPw10QCpy/fYQK4ugWm5WBwugHe5BnZyyBB2gZJQEW9XUZ6OyMEuktIcH1uagx1JDIzrL6NdY5dYwlix3G9e/4nvuH4+UF7MliNkbPIyr/fU5ICrClr5OKOqh7Sd85taS4vCOjxgYFRS/bT8uqmmYITtxrVUdp7Z8GGDA5H7uREGlfRZgTha6j44EzQ1/IXFTembrjBYYw2O6550ISkMyW/O/glRhNUC/QV1/nWlxEkpHd0M+GhhkzHdoryP/xZqNET1bVTY9vUY9B2/c4AgwJBiYpxyOfonDTAabSon5TThpaqwYyhjCjVnzO9gjFJuIm2tKAgGBUcyUsr5OdAQJl6bA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(122000001)(66476007)(478600001)(64756008)(54906003)(4326008)(2906002)(110136005)(8676002)(186003)(83380400001)(66446008)(66556008)(38070700005)(71200400001)(66946007)(76116006)(38100700002)(7696005)(9686003)(55236004)(41300700001)(86362001)(6506007)(52536014)(5660300002)(55016003)(7416002)(8936002)(33656002)(316002)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ntDykHer33CM+RkodQe+Qc73Z69ktCogRb2pu+Fko+IEUBLc4LJKxv5IWmXy?= =?us-ascii?Q?zpwFAh1RZEapOL1/aZXgylE/4fD5IRI/fxmIbUqs64Zs2KFho/fim5kn0Svd?= =?us-ascii?Q?JjUuZSHuyfjmuTT1pKYpBGejfTbi9L2/0aXJCJ6r5GMVjSlz2+wYYnX6/T2/?= =?us-ascii?Q?u63pIfj1IBctDlptOIkDjAA3T4CbjkhrxuTYatiQX6hV+KB8hY6kAwzhsooy?= =?us-ascii?Q?BOEKms26YW6HU/BddfoybhiGw/2S6aRin+kXasfWUrS8uFd8F8krZuc9XMXS?= =?us-ascii?Q?Jn4W8FciVWL83UbgjbtC8Bgyw3MntQruk77Lq+GkkWK7Sg7sfPoI3T+phdqG?= =?us-ascii?Q?A5NZyYlGKGLC+Iq8c2apb76/IWNaNgHjPUO9V0P+h2Kw2n9I16F/qCBr/23s?= =?us-ascii?Q?NdcV+qd4d1jDZMgWgGeK8ZYyCp5ZPr/apYGoC2+ZpN5b3TlNnpNJqk8WzZlx?= =?us-ascii?Q?k5SLdTwDp9CLF+8jo1rBKpm/WP5IenMCdSJvaRaoVJhSaEg+yxcOUiuvnoJa?= =?us-ascii?Q?4qQXWenXY36BYfIsz8pSy/jb6766LBwxobBs+t3uGbUJQwqHJk3/CiIcoHJW?= =?us-ascii?Q?vDX9W3eUPvdUKGdbIP5W4FD/MSk3E/j7CjjkReLbHU78iVioVJyeJDUKhFHX?= =?us-ascii?Q?oDm+c3l5UKrnF3A4iRJT4VSVOF/WOw4ETeM15F1xS6Qu+zI8l2joPaWUdcWi?= =?us-ascii?Q?Xv6dCJ+KJIO+hlkj2Og8+d97zjtSKx6emOlVBfH+TDWvFjI2nLRw3RCZvVsw?= =?us-ascii?Q?+ZWZkOen5r5eYKwOdraxsRZp2LVQhAOvaXKBto74h/qDxTl9Es84y3BXgWNS?= =?us-ascii?Q?J9YKazwa9ZJvepbod83kKnpMy3xiRMUMqYQKif8A5iHm6rTvrtRaKuddmep3?= =?us-ascii?Q?FydDkGQMz/mvTiiLOnJiaxeDjchvlLd6DgTqXuy+1hhuIuWIirTl1tBn7i3i?= =?us-ascii?Q?HKwReSHGar4FNISLRURsbTEEc1CEili29I6Ua823mMCTdet4CIYNK3LsN4lK?= =?us-ascii?Q?kY1yJT+qvH+ev2l37DNj+4kgPjnDH3JzShj78lCpFxR/RpyuIug09Uf5jL/4?= =?us-ascii?Q?ZWuDw4nk0MK2JhSdDu/l3dCHRNXBUJZgdiolZgFQSvRc4/mIFkrxWtUgP5jb?= =?us-ascii?Q?M33jNlvuHI6jmBipCD2lAHKNNzt0q+514wCFRdInOLBSJM4ZATIWS2NWWBzh?= =?us-ascii?Q?iAIqsYBnynpYPpa1eCGBSZlT5uTYKtl1Tg7HSgtkaZo3Pq0PYOqSxH6kERDQ?= =?us-ascii?Q?G+kpPqDL6cTIXl/QmAJvzjCWGmC+fYbSrs+vWmRDUX1dXL+C1zOmClOiUERa?= =?us-ascii?Q?WelYcryyLOYwWHfBO2+dEMx3Ctxk8W32LiC3q07oAOWag3/t0AZECzGpa5ga?= =?us-ascii?Q?FJLyRnEoVcSlgMOqURo8ixBDSqf4G6bU6WEyvepoe5rW3NxY0eI9duarOMFo?= =?us-ascii?Q?RAB4UUFuxYzY/HK8qG9pg5qH1jFpYg0GDK+isjqX7jiYzWjtXiHJjZAG5nra?= =?us-ascii?Q?N/1P9h+Q34mFveqcOqmPydYaPfBwRVT2+AX2+88AQzUEwBzTKennelf3qA+A?= =?us-ascii?Q?YNYHZiUiSlWfskXPcusuaF83kqCNqzhbx9dOYBGXjJNi42q8Inakak5ojHKj?= =?us-ascii?Q?ZWpNjcm6uwaY7ZMxkBxZ8aSAQv52hKiHwSNoxZ7btTkJKjnljwwvKpHPB4Nj?= =?us-ascii?Q?osT54anTcdB0xYi7ktfK+uhWOdjxqJVULpU14+xHTCz4RwGGJYG91reLFXtP?= =?us-ascii?Q?ps/7rN/OfQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe625521-979b-4553-029c-08da54455c00 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 11:50:09.8702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pDbgPvHGl1e5rwmldrPi9N1bxllxKsLR0got2/bRF+Ld8PD82WvxcEO1/hX9y4KuwR/qyH1FJ+cZmK7SF+4k1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1317 X-Proofpoint-GUID: TD0ibHMGx2PwljoEZ4YT34aAXSjbgNjz X-Proofpoint-ORIG-GUID: TD0ibHMGx2PwljoEZ4YT34aAXSjbgNjz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-22_04,2022-06-22_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, Please submit a patch for renaming rte_acc100_pmd.h to acc100_pmd.h as it is an internal file. >=20 > > v7: updates suggested by Akhil and Maxime. Removed RTE prefix for inter= nal > > #define, removed > > build-time single FEC engine configuration mode, documentation fix, cod= ing > > guideline fix, renamed new file without rte prefix. > > > > v6: use formally an unified driver for AC100 and AC101. Exposing single= unified > > function for the PF device configuration used by bbdev-test. > > > > v5: minor fix to doc and intermediate commit caught in CI > > > > v4: incremental updates based on reviews Changed order of patchset to > include > > two ACC100 specific commits first: updating formally the companion conf= igure > > function from PF and the protection adjustment. > > Then next 3 commits for the actual changes specific to ACC101: the dev= ice > > specific function for FCW 5GUL generation used as a local function, com= bined > > documentations into a single .rst common to both devices, updated > comments, > > removed unused #defines. > > > > v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test secti= on > > calling the configure companion function for ACC100/101, taking the Pmo= n > > commit out which is not directly required. > > > > v2: Based on good feedback from Thomas and David, now implementing the > > ACC101 PMD as a close derivative from existing ACC100 PMD with hooks to > > have different behaviour based on variant. > > This prevents code duplication and only rely on different functions and > > behaviour when hardware requires or support differences. > > Note that these are pending changes for ACC100 which would be specific = to > that > > device and not ACC101 but these can be managed based on the new > > implementation, ie. is_acc100() etc... (such incremental changes for AC= C100 > > trending 22.11 but confirming this is future proof). > > The serie also includes commits which were meant for ACC101 but are als= o > > valuable for ACC100. > > > > v1: This serie introduces the PMD for the new bbdev device ACC101 (aka > Mount > > Cirrus). > > This is a derivative from previous Mount Bryce ACC100 which includes si= licon > > improvement, bug fixes, capacity improvement for 5GNR and feature > > improvement. > > > > > > Nicolas Chautru (6): > > baseband/acc100: update companion PF configure function > > baseband/acc100: add protection for some negative scenario > > baseband/acc100: remove RTE prefix for internal macro > > baseband/acc100: introduce PMD for ACC101 > > baseband/acc100: modify validation code for ACC101 > > baseband/acc100: configuration of ACC101 from PF > > > > MAINTAINERS | 1 + > > app/test-bbdev/test_bbdev_perf.c | 6 +- > > doc/guides/bbdevs/acc100.rst | 37 +- > > doc/guides/bbdevs/features/acc101.ini | 13 + > > doc/guides/rel_notes/release_22_07.rst | 3 + > > drivers/baseband/acc100/acc100_pf_enum.h | 18 + > > drivers/baseband/acc100/acc101_pmd.h | 50 +++ > > drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- > > drivers/baseband/acc100/rte_acc100_pmd.c | 687 > > ++++++++++++++++++++++++++++--- > > drivers/baseband/acc100/rte_acc100_pmd.h | 37 +- > > drivers/baseband/acc100/version.map | 3 +- > > 11 files changed, 768 insertions(+), 91 deletions(-) > > create mode 100644 doc/guides/bbdevs/features/acc101.ini > > create mode 100644 drivers/baseband/acc100/acc101_pmd.h >=20 > Series applied to dpdk-next-crypto >=20 > Thanks.