From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AAC0A0548; Wed, 15 Jun 2022 16:08:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4497D40F1A; Wed, 15 Jun 2022 16:08:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2757540F19 for ; Wed, 15 Jun 2022 16:08:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25FCGRi5029253; Wed, 15 Jun 2022 07:08:09 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gq83ytas7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Jun 2022 07:08:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzGA/ig8xHwb96+8pBuhCk7ADTWl9v/ArTjWmLlkr4zhQh+NQIi9A+qVgwuLViLmQjy5vamJb0bmNTQuMfLC+ZLPVVW5RqsFQDElGMD9IZLP8qWFrxO2ZGXfjh0jeEKSNSYZrsQ5O3RXF8TK8k7tfg0kXProzBTQL9XywNQl3lntWmVMKm0fuvNeAjmZhQzFpSkUmWsydW+AuKcF2d66W9xLfkWeDuici3Zbx/xfAjPJ71YKgIUG0xQ9RpcxtZ4kLST4ISSlR4KQXBktvgNevkejEd7O1G9t0rAWACjnU1DEy5RKxbdt1yNT8/Z9PLAwVOPoXkfVB1jGthLYLT3Mqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OlN38f5gcn/z0060L1V4fwZJuUqJTLSJAXkbO6LbbRA=; b=PjhbxvMh6+3a7V2GFqWpSzmPFlucYaoAsVj+Z8v1PecTNy6LLnE//viyTBERbci5121HG+aZndx9AQsJBsvf1cjAO7xlKTnMhhkWIZmIX0AIS6RHpNYLHYsHskTTF9W5J+pJjhUxUzXsudNkD6KkP2zN32gWcBdDzAWmz+PBaeWvuWD8AtfFK4jROkBt0apwf0PbFdjnrfNua8jleT+kVQIbhiTa0FS0ICwB1SbyrKnGdfL1F46ydRoVdzOj1uthi/XY4apv9OebvzFlF1piTpIMoXdQzbcVdy3ysIL3BUm0hVO8158QWxAaXGzZ/agNFUX7aIh+Co+O9dZClRxHqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OlN38f5gcn/z0060L1V4fwZJuUqJTLSJAXkbO6LbbRA=; b=uSNUNonoty7ZYjywVFi+Iu5z4RtspaywhPVmLA+Bu4HQrD0ieppzkLTQ7S+l2JiXPZKbSPK1hG1mZuzarLG8/760DK2X5kiZccoqWE/jSyQ+4WIQjix18Z5g0WQVC+UUwfY33kE8KTHiQ34pNY2nVtnMDkp5s97JCV+T16Gyrnc= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW2PR18MB2331.namprd18.prod.outlook.com (2603:10b6:907:f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 15 Jun 2022 14:08:07 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5%9]) with mapi id 15.20.5353.015; Wed, 15 Jun 2022 14:08:07 +0000 From: Akhil Goyal To: Nicolas Chautru , "dev@dpdk.org" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "thomas@monjalon.net" , "ray.kinsella@intel.com" , "bruce.richardson@intel.com" , "hemant.agrawal@nxp.com" , "hernan.vargas@intel.com" , "david.marchand@redhat.com" Subject: RE: [EXT] [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Topic: [EXT] [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Index: AQHYdT+UT9hwzmlIf0aqE0GNKxdRbK1QmASg Date: Wed, 15 Jun 2022 14:08:06 +0000 Message-ID: References: <1653350912-53876-1-git-send-email-nicolas.chautru@intel.com> <1654036307-182860-1-git-send-email-nicolas.chautru@intel.com> In-Reply-To: <1654036307-182860-1-git-send-email-nicolas.chautru@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 04ccd55f-9325-4c99-cfce-08da4ed8789a x-ms-traffictypediagnostic: MW2PR18MB2331:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7PfKx1K42KSOvNbm0AutAn6FI8U2UfDZlsAv01D5xwoTM+lpXtjyfQboaUu73lb3a0nyy0GqkQ/muTYglSd/aZbW7IADVXoKSLAzAMDZ7XCGutRGD59KSCIPuaObOyyXxv3ijvFi0I8ufzFo2IKfQAtBeMKorMfv/bo+h8+gGf3LeJeVlZ7DFjZbdyIEI5lujmm1MltAE009Gn4XSWnVCdPFYWkIFaAyZVYyrU66EYhVjB48eU2J+H5abfaghy7s/cvXIDOyyD+7QbmZKVeZD11UXgLg5Zw1KAC9Ahc2DgjoyWPiY+/jH2NO1801t3pPD4DoJQgIKXzEbZO8B3WRteocil6XrnioC70BRzkP01+e03NONrTvWRuRt7FhpjuVIAKG7atlpqGfk6EZhx99I64yJbHgM+wM12d7hg3LV0LMrF8H9uhnCeh+dGf2s89jdcNSExTczXHLQf1PkN/QvKzU56nMHaTX+s58ck+sfYKF1iGHDwS/i5qfOVKshBtxXKABGCWRQTdkpUNLlqITzEZlprHd7lRsYmhCsv0IZZ614DR6h9jHNgPrfvbIXfhvU/pv0l0rfVM9T1fO1jxfv3T6Jb+6uQ9g2BQ3PzN0W/4BKjFrnNLoxS/U6REGl2i5fXJ2QV6tYab0TJwPxV3H8f7ZqidhRGvc8LJDd4+fjduzSCimXjbVku8Sf3DX8tx/aimBDOdojgjtrlrizNR6ng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(5660300002)(7416002)(8936002)(52536014)(4326008)(55016003)(2906002)(83380400001)(122000001)(38070700005)(33656002)(66556008)(86362001)(38100700002)(71200400001)(66446008)(508600001)(64756008)(66476007)(66946007)(76116006)(110136005)(54906003)(316002)(8676002)(186003)(6506007)(7696005)(9686003)(55236004)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lz7ZtVTJ1u0LHVoJzhUcM40VflRRZDe6GnsiAB0sAbJBYLNCkAsEvjQJq7ga?= =?us-ascii?Q?nNRvsdM5apXVyDEBNbz4HnYIrPfez1DAB313IQV4jLbRPylOz0CeKwzOcFmB?= =?us-ascii?Q?P/hh3SzPm7DmUf3As0xSlkiwGExA9ilCMMJx/P6Fr7RtMUtIPNTwgX3kbGH8?= =?us-ascii?Q?YvnLN1/bqy3LkyN7kAnS6JbT0xNeryJWz16b074AyGbvZ2VeNhR88nXKwtFl?= =?us-ascii?Q?mjRphpe1xEdhkZR1rvN4YBGegC5ookUDIBCRdtvUW4TaC0/5xLZ9ryvmX+k2?= =?us-ascii?Q?ghOIPBkeM0L5s2Qtml1lE6719FfILTZ/OPBDSuSymKjwcg8ym/fbmZ+yb/qf?= =?us-ascii?Q?22Y9V0JcF33CgTPEvILVD5gaY7hA33zf3fVY+Nil8vtDC9CDGXqVWdk5hReD?= =?us-ascii?Q?uBEZVk9rcb3AiZAEBjzh3WeMHsuL5tp1VDfuzeKCa7UodD4YryiyV2fS0EcE?= =?us-ascii?Q?/eHmR7gZDqBEo7nxZ1nXMEnuq+h5yxJIzl+b1JEY0cbbpaKCxMDBjzSFLqcw?= =?us-ascii?Q?+J9raX8/HDcoPfKtZLZ0cOtexZ96MRA6MwGR0A5imWhMAFBgzNcDDS7EDlSw?= =?us-ascii?Q?kM+ZpFtFQ9m7+6q73crYMPBwbZvkYjtngb6pDIkckQWUmHpuRjPdNyoSM9nh?= =?us-ascii?Q?O/FmupNUoqV8+KQSSuImIYHT0RqS8dY+GoLhLbM4h3sk+AL27OGwh7WPjSxP?= =?us-ascii?Q?0BhyXcX3BUTxmrG4VeO05gwNq3SgdObUABgvaqu+VDoc+5VSZckT7nL3olLR?= =?us-ascii?Q?19t49Ljs8GLTrAd+rVR4KocyN8udVyz4fEUj9Jf1S9ThHHXsuCAWlSMqj+og?= =?us-ascii?Q?BPeWt7ZQhoSj6QXHTRVKMcN4c2gwdjpY23FREyfEAXY6SrCvtIFFtTKEQTxR?= =?us-ascii?Q?rNWsJ0eLjwi7Fwn/GiIDDPVfO0lNQBMpNylQov0jpb1YtzjjCrT8GRNuyhhn?= =?us-ascii?Q?x91vANczK4lhcaa3o3bdHabCLaRACo6NwjmTRQjVWDm01zvejB+hparuQD5o?= =?us-ascii?Q?iChlV5PNXLavUOlaAarkt459mG/+lWVJ9Mz4I0cqNm7IZ/EJxgVWEdxm2XZU?= =?us-ascii?Q?aaEkFXF2c8aDjHO3T2NRE47Tv0m68BmiV2GwJSZKKr4u6Y9jUVdJ6CS7gjce?= =?us-ascii?Q?ytupU0YqHRmtp7nKwuB0InkQPGPrFeyT45xxJGVMxCvsysA9Epno8QJ25mtA?= =?us-ascii?Q?x0YEsto7tnipAHwCwpfCm0zqzzbVAh+3gRVgqG6LiY/M4ZpTiXIjbN8RlDVZ?= =?us-ascii?Q?M/SAm0gKfYh6Nn6Wx7Gnr2/bqSD3M4sNXVUZtOuexNo8eq3/aaExq66m1itA?= =?us-ascii?Q?Oy8CbR/4ftkaNqkgUSl1C4siSqIlTvNovWvcJkLiUYhoIsnzppSZ6j79H5np?= =?us-ascii?Q?WZeY9u5IIQt96qQ/ApVt1+Ls0xH9Isq8csHzQQk/xYoi6jisVb7cEnd8FhLf?= =?us-ascii?Q?5AGz1L4wyyn/TOQi/R/NniO+Tau6oQYbQnKg+WdbPrDT0b7dcza9jNQ+o8G2?= =?us-ascii?Q?kEEM6f6qUeUt1IM9yuPM3GFFWWqm1UxhfOWq9H/Mxl5KujksUN8blXBDg+pu?= =?us-ascii?Q?VEg1QO5Dm/0Vx6E7+5Q7rlKq49Vz6anAJHEYQGYavH+UmeOwMDEXOW/Ui5AL?= =?us-ascii?Q?SrHmiWJEp4CwLAX/G38xUjwVNrsdshhG55t9Y8VTxmLLLW5LebrqctyVDS5I?= =?us-ascii?Q?ip3FUvm0ylixKyZbp2pLprHZ5BojadLTLZNUHV2SGqI7MK36Q3d5O+Yc5fTf?= =?us-ascii?Q?eLli4c6KMA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04ccd55f-9325-4c99-cfce-08da4ed8789a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 14:08:06.9505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /IerjwzyDvSFAErjfkd3YatmH/rArF9hX1FHEylCWKdvB8LkXoVa+RfJcdfZ1Ut5nkdFdULwqTX7hSNU/uQ+bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2331 X-Proofpoint-ORIG-GUID: acANDJKeJCVcWp7OiTM_9kmq5KNfMXKS X-Proofpoint-GUID: acANDJKeJCVcWp7OiTM_9kmq5KNfMXKS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-15_13,2022-06-15_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > v7: updates suggested by Akhil and Maxime. Removed RTE prefix for interna= l > #define, removed > build-time single FEC engine configuration mode, documentation fix, codin= g > guideline fix, renamed new file without rte prefix. >=20 > v6: use formally an unified driver for AC100 and AC101. Exposing single u= nified > function for the PF device configuration used by bbdev-test. >=20 > v5: minor fix to doc and intermediate commit caught in CI >=20 > v4: incremental updates based on reviews Changed order of patchset to inc= lude > two ACC100 specific commits first: updating formally the companion config= ure > function from PF and the protection adjustment. > Then next 3 commits for the actual changes specific to ACC101: the devic= e > specific function for FCW 5GUL generation used as a local function, combi= ned > documentations into a single .rst common to both devices, updated comment= s, > removed unused #defines. >=20 > v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section > calling the configure companion function for ACC100/101, taking the Pmon > commit out which is not directly required. >=20 > v2: Based on good feedback from Thomas and David, now implementing the > ACC101 PMD as a close derivative from existing ACC100 PMD with hooks to > have different behaviour based on variant. > This prevents code duplication and only rely on different functions and > behaviour when hardware requires or support differences. > Note that these are pending changes for ACC100 which would be specific to= that > device and not ACC101 but these can be managed based on the new > implementation, ie. is_acc100() etc... (such incremental changes for ACC1= 00 > trending 22.11 but confirming this is future proof). > The serie also includes commits which were meant for ACC101 but are also > valuable for ACC100. >=20 > v1: This serie introduces the PMD for the new bbdev device ACC101 (aka Mo= unt > Cirrus). > This is a derivative from previous Mount Bryce ACC100 which includes sili= con > improvement, bug fixes, capacity improvement for 5GNR and feature > improvement. >=20 >=20 > Nicolas Chautru (6): > baseband/acc100: update companion PF configure function > baseband/acc100: add protection for some negative scenario > baseband/acc100: remove RTE prefix for internal macro > baseband/acc100: introduce PMD for ACC101 > baseband/acc100: modify validation code for ACC101 > baseband/acc100: configuration of ACC101 from PF >=20 > MAINTAINERS | 1 + > app/test-bbdev/test_bbdev_perf.c | 6 +- > doc/guides/bbdevs/acc100.rst | 37 +- > doc/guides/bbdevs/features/acc101.ini | 13 + > doc/guides/rel_notes/release_22_07.rst | 3 + > drivers/baseband/acc100/acc100_pf_enum.h | 18 + > drivers/baseband/acc100/acc101_pmd.h | 50 +++ > drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- > drivers/baseband/acc100/rte_acc100_pmd.c | 687 > ++++++++++++++++++++++++++++--- > drivers/baseband/acc100/rte_acc100_pmd.h | 37 +- > drivers/baseband/acc100/version.map | 3 +- > 11 files changed, 768 insertions(+), 91 deletions(-) > create mode 100644 doc/guides/bbdevs/features/acc101.ini > create mode 100644 drivers/baseband/acc100/acc101_pmd.h Series applied to dpdk-next-crypto Thanks.