From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A59CA0350; Tue, 8 Feb 2022 21:21:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4489441144; Tue, 8 Feb 2022 21:21:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5324541101 for ; Tue, 8 Feb 2022 21:21:51 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218G54SZ011857; Tue, 8 Feb 2022 12:21:47 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e3mhsk7fr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Feb 2022 12:21:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8cJfotzoOmh6ZGhoJxUMc0nQg+hdD4WidzvPyt0n6rXFIAKnfC9lAkdofRCzx3AM8lKnOvXB8C+yTjqmzBsGYeC73wxx9zduXAiy9t4WGFE50iaioPNQPDMX+Q14xKLKQRHJGw7V0o0EwsojHokV6354PYSJHH3WgBMSd59qNK/46LhMLoWxu+pdrxSx6n8xZh6C2zBX1si5A70eTqCjtc4IqK3JCKfRJ+hJ2gvi/zU1NCfD75r/mkn+7mkwgGpezWdQMeWUUn3XA48OS88FV64A3N6PEq/+dCNfhfIvjeDcmEE3bQXnmYyXQpeLuB0LI0eQc7a5CAVGPffWHVExg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cD/rORo3VepXYw8OueGfckoV22uH3TxCQT9SHYyVRHM=; b=Na542FRhFxcydF9o1NQXcCZLSPr4JrpBrb2e3WPlyT8QTEgunBUe4gafJzI0rD4nWt8gkVHjeGE/tLgvw3B9BTbhWsmVYAlnpgz+XB1gX6dBTI7Kx3+nh2b3QXBySamR896J5cT3rAuTvbXNvkbY3Tu2NliUnzMauDbd1lN8iWaLKYFej5soAbis/x58zrJEssgcNOSiHM69IEeHwN1VRtFQ5PL1tfuEZJKFyRaonrBMGo2OmHdaGoDO18ieBrkw3jllB15Nxvua4vzvaFjEz/RuAw1sYS3ln5SaA9WCoi/3fQNcFIvEnTX2l5JD5cNNxUypPHYKQXzm7C5S/yyhvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cD/rORo3VepXYw8OueGfckoV22uH3TxCQT9SHYyVRHM=; b=Ws0+qWDh/DtMoA2JtOSvX9IaEBP759aorDSL+PmRNca9IJ9OZCYFFib5x7LdoLTXr2nrS6RbaSDjIA1pr+8d+afHwsfHrcQuHiReI6iTNnSJJwuUiL1J2p48pC56zLWmCOP1A+VrPlsG06tk7ODW6NcSZ0eCyp1Ruw9iUNCg5P8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR1801MB1845.namprd18.prod.outlook.com (2603:10b6:910:79::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 20:21:29 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc%5]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 20:21:29 +0000 From: Akhil Goyal To: "Power, Ciara" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , Anoob Joseph , "mdr@ashroe.eu" , "Doherty, Declan" , "thomas@monjalon.net" Subject: RE: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create Thread-Topic: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create Thread-Index: AQHYGRfmqk9bEutzFEqs+/3ro2AQBqyHy58QgABmX4CAAe5y8A== Date: Tue, 8 Feb 2022 20:21:29 +0000 Message-ID: References: <20220203160449.1638311-1-ciara.power@intel.com> <20220203160449.1638311-5-ciara.power@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b29c73a-1e1c-432a-91ae-08d9eb4096e6 x-ms-traffictypediagnostic: CY4PR1801MB1845:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EvPmNRpt7lw3CWAwQCQzvhBly66s51aYoeuWqrbje1hAMRIKqeuJBnGV40ytLunx0yZEj1G0W/OSknVfsrtDFBNdGfPOQdPHpcGkG6wUAmdK7hIGDs06ApQPt2kppNdwLq1SFi/TaLmAKyzolTJrAESWaLWoOHYCebvfdh+rilAZAkvJdxuA5K28CFr/RY2WepXeOyfn/EZ4anY6Nf44Zpo0KWGCrlRRiCIkXTR4HBU1IhjlrUbfZkiSoJPTiSPUkmvFutpbhNiwywSMTf+ivdveXLGp2yJdoVjVF10b4u+lhOu4SZX5pKanAtIoXv3jTsXyqxL/tBf28wTOaX8HFsDPxkd0QME98CeQ1g6CVgAU4Jgqi7NEgKxzMiEk9ppEWVkBaf5+TtOWzpeMZxaFAG9WzYwy3I1m1WUlbtrDLWpjE9xh5FJSKK2YNElnrGtGRXtd858V0/LLBW0sewNd2Cc5m/cLFCzp8IzufAvi0hZR7McVsa7BexWgREltUO1978gaPJjR4pYi/ycFofKVSDi1cchWAH7V3sGucngTJ2YdKg55iSuBPmzavXYSdW9QgouABqkU7A9FQ7pgatH98NLvHyZ8E+7obs6WtSl5OZKYZLnV4pPWJ8MI965JGfGSpv2efIoVWw5YxzX9dh06qhOWM6Mzpa5RD5kdFzm5fiYMpqUx7w7hwVLkXopuC80u+YPp6bkDS5FwKDtJSQZYSw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(71200400001)(33656002)(2906002)(83380400001)(86362001)(8936002)(76116006)(8676002)(52536014)(55016003)(186003)(38070700005)(55236004)(5660300002)(66946007)(66556008)(38100700002)(110136005)(54906003)(9686003)(4326008)(316002)(122000001)(64756008)(66446008)(6506007)(508600001)(7696005)(26005)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q3FwVdJVu9OFMeYkoLUIlxxRI/1jTXiIyma3DgNb5n0Y5AJWbNJrlfF6VTL+?= =?us-ascii?Q?nEnMglYzQp8EQb8JZ8ckbTJ80BvEWQQrBGTpNRz8nSAbGMhA5fQbi1elzLWx?= =?us-ascii?Q?dSj708x+/LAg3fZ0CKnOEKITbP0KmBvtpLoCIIUMgBpKSzaEaYQOJ1UtBZQS?= =?us-ascii?Q?4eVFEohFHn58SmXU87Hz60lvGzMtaVQj2PeuOUaZnZX2xO7dAiUgARYEFPaG?= =?us-ascii?Q?lmRX/KqmjxiOkBMtRwQaYrug6JHUiXX+f9sDME/rp/lMCBUCUF7vVFuye2mo?= =?us-ascii?Q?GISs24MpidXiqVk8Z9o1wMAdp3GD4PNo0tpH12BaLMPoG4y1cxXF1HJioU2I?= =?us-ascii?Q?g8nMNb9pBFrT909RoeZHn2XzW3hNpbqmjRIAvslNUzXIkdnQ9MZzctYBp0wm?= =?us-ascii?Q?uJwm57bPttUaIOtUgfPUcUPFQkiplsvQpjTg+2hZ53tarZCpBpAeeuJ4khOd?= =?us-ascii?Q?WPR3E/Gx37Bd9yzx3WF2oJW5r4cRQ1wkKmqQVXqC9860SmumwGvB3f/L3HwF?= =?us-ascii?Q?JCFdLE+jpSShzFq/Z657D9n89AwLa/p0rFcmLmSN+LOceIcRkh5Yp/5kanFt?= =?us-ascii?Q?qK5nG+uhHY+bSgHnwsutshIg/AvDkkSHPVGQfe7kre8Po3gp3FJnxen1ioiR?= =?us-ascii?Q?ifFUb3wwIv1qIOtefoPD3GWbSA7jtjYKJKZFqtrwhSBoLLL2oagaGO9ykDb1?= =?us-ascii?Q?bILQZZdlXf5MNDNC6XUXkfkm1JKieCjywmS3DkY1NIvL1ifRD2BJVa9Y+G8/?= =?us-ascii?Q?JCWQMUrEZ1e+eXmslplIRpAbQCsv+Xo72UyVxm0JUkNetCgu3JGdgTa6QQzO?= =?us-ascii?Q?T9kaC3tsF6EelKcGZrIMGrM4UNnr592abf0CTGxMUZgsVQ1kgwGxSoQ/kbFw?= =?us-ascii?Q?vd7z1PUtCaYjHcjvEaZRa36gp47MWEXByWOGVoEWKaAnCYnnoC/fECn7G4rx?= =?us-ascii?Q?XeAnCQWq8pXzSo2PYsnkUJqbEkxhSKiOEheJnc0Y/BaykXkiuujS7FPcj7YU?= =?us-ascii?Q?+mTF3aYpsxuj0gZlNARf7xQGKf42IRKok3Feu/pKBx0xUzcAdtxh0//D2prS?= =?us-ascii?Q?LDJmrVFREFRY8XvPyciMQesT7MUQyIwhW+7gL07NSnsH56rtObej7/PEp6Kt?= =?us-ascii?Q?dA4f+IhI7pndfo71QS3mLRFpTZuOUkZRU1TzJw96UeywRZs7FPh9EIZAKiE9?= =?us-ascii?Q?tXuSeJkEsmLvbrUlAzshUcex/0LnlyXPlbqq0hh1/2veQoam03xZhhiyJWtU?= =?us-ascii?Q?d/E5GGJNowdu6S2Lker2I+vCAsonf4+1+ukW4zeF6kHWuaOcCpcCW7iEntBt?= =?us-ascii?Q?UAuBiWkORw48rgnSO3q0KUqeODnVZ3qu7eCyHAIvB8tFhGGFUgCFxYt6LDCi?= =?us-ascii?Q?tcjEYaK04EYQAwi3GVB2ZqRf37/Bdy9dcpMQp5S5bmeOOP6Gxq56QFtjjJLi?= =?us-ascii?Q?Jv+5pNf48L03OJJQ+34o7B1GgpQ5WFRabTIGjyThEmqcNVqNiNuvdxKzm5AT?= =?us-ascii?Q?jKTODsBZ4mRYkGZjjzCduGSdOS/nLVLjXSbmSVaLzHwqtVvA4+jXcWM2w8mp?= =?us-ascii?Q?rQv9DbAGAq+CkgPKQkAeMZVVO2mUwxjhlesfbe/d4O5exJMa16RzWSmT2g+S?= =?us-ascii?Q?xYP7T8q2htl5K1KWT2j+kJ4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b29c73a-1e1c-432a-91ae-08d9eb4096e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 20:21:29.0513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: scOhZAIGAVg1z6ZuI8E14tcn4umZ7AGmwYkrXgJ/WDuC4Oatz95CFIz+usY2WLJrbID2dNNq9i2JOuZ3ogz4eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1845 X-Proofpoint-ORIG-GUID: B8DzHQCycO0o3MMsabpJ5pnCwkdj_ihr X-Proofpoint-GUID: B8DzHQCycO0o3MMsabpJ5pnCwkdj_ihr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > >> diff --git a/lib/cryptodev/rte_cryptodev.c > >> b/lib/cryptodev/rte_cryptodev.c index 0d816ed4a9..005f0e7952 100644 > >> --- a/lib/cryptodev/rte_cryptodev.c > >> +++ b/lib/cryptodev/rte_cryptodev.c > >> @@ -1912,9 +1912,9 @@ rte_cryptodev_sym_session_create(struct > >> rte_mempool *mp) > >> return sess; > >> } > >> > >> -void * > >> -rte_cryptodev_asym_session_create(struct rte_mempool *mp, uint8_t > >> dev_id, > >> - struct rte_crypto_asym_xform *xforms) > >> +int > >> +rte_cryptodev_asym_session_create(void **session, struct rte_mempool > >> *mp, > >> + uint8_t dev_id, struct rte_crypto_asym_xform *xforms) > > > >Do you really need a double pointer for the session handle? > > >=20 > [CP] Yes I believe so, the return value used to be session, but now that = we have > an int return value, the session needs to be passed in as a parameter som= ehow. > We need the double pointer because we need the call to rte_mempool_get() = to > set the original session pointer that can be accessed outside of this fun= ction, > rather than just the local copy if it were a singular session pointer pas= sed in as a > parameter. >=20 Ok