* [dpdk-dev v1] app/test: fix of bitwise and operator in return
@ 2022-11-11 11:59 Kai Ji
2022-11-11 13:16 ` Zhang, Fan
2022-11-11 16:27 ` [dpdk-dev v2] " Kai Ji
0 siblings, 2 replies; 6+ messages in thread
From: Kai Ji @ 2022-11-11 11:59 UTC (permalink / raw)
To: dev; +Cc: stable, gakhil, Kai Ji
This patch remove incorrect bitwise and operator used in the
return function of sw snow3g testcase
Signed-off-by: Kai Ji <kai.ji@intel.com>
---
app/test/test_cryptodev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index e1122fcd7c..d6ae762df9 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6870,8 +6870,10 @@ test_snow3g_decryption_with_digest_test_case_1(void)
*/
snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data);
- return test_snow3g_decryption(&snow3g_test_case_7) &
- test_snow3g_authentication_verify(&snow3g_hash_data);
+ if (test_snow3g_decryption(&snow3g_test_case_7))
+ return TEST_FAILED;
+
+ return test_snow3g_authentication_verify(&snow3g_hash_data);
}
static int
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev v1] app/test: fix of bitwise and operator in return
2022-11-11 11:59 [dpdk-dev v1] app/test: fix of bitwise and operator in return Kai Ji
@ 2022-11-11 13:16 ` Zhang, Fan
2022-11-11 13:18 ` [EXT] " Akhil Goyal
2022-11-11 16:27 ` [dpdk-dev v2] " Kai Ji
1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Fan @ 2022-11-11 13:16 UTC (permalink / raw)
To: Kai Ji, dev; +Cc: stable, gakhil
On 11/11/2022 11:59 AM, Kai Ji wrote:
> This patch remove incorrect bitwise and operator used in the
> return function of sw snow3g testcase
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
> app/test/test_cryptodev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index e1122fcd7c..d6ae762df9 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -6870,8 +6870,10 @@ test_snow3g_decryption_with_digest_test_case_1(void)
> */
> snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data);
>
> - return test_snow3g_decryption(&snow3g_test_case_7) &
> - test_snow3g_authentication_verify(&snow3g_hash_data);
> + if (test_snow3g_decryption(&snow3g_test_case_7))
> + return TEST_FAILED;
> +
> + return test_snow3g_authentication_verify(&snow3g_hash_data);
> }
>
> static int
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] Re: [dpdk-dev v1] app/test: fix of bitwise and operator in return
2022-11-11 13:16 ` Zhang, Fan
@ 2022-11-11 13:18 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2022-11-11 13:18 UTC (permalink / raw)
To: Zhang, Fan, Kai Ji, dev; +Cc: stable
> Subject: [EXT] Re: [dpdk-dev v1] app/test: fix of bitwise and operator in return
>
> External Email
>
> ----------------------------------------------------------------------
> On 11/11/2022 11:59 AM, Kai Ji wrote:
> > This patch remove incorrect bitwise and operator used in the
> > return function of sw snow3g testcase
> >
Add fixes tag
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> > app/test/test_cryptodev.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> > index e1122fcd7c..d6ae762df9 100644
> > --- a/app/test/test_cryptodev.c
> > +++ b/app/test/test_cryptodev.c
> > @@ -6870,8 +6870,10 @@
> test_snow3g_decryption_with_digest_test_case_1(void)
> > */
> > snow3g_hash_test_vector_setup(&snow3g_test_case_7,
> &snow3g_hash_data);
> >
> > - return test_snow3g_decryption(&snow3g_test_case_7) &
> > -
> test_snow3g_authentication_verify(&snow3g_hash_data);
> > + if (test_snow3g_decryption(&snow3g_test_case_7))
> > + return TEST_FAILED;
> > +
> > + return test_snow3g_authentication_verify(&snow3g_hash_data);
> > }
> >
> > static int
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev v2] app/test: fix of bitwise and operator in return
2022-11-11 11:59 [dpdk-dev v1] app/test: fix of bitwise and operator in return Kai Ji
2022-11-11 13:16 ` Zhang, Fan
@ 2022-11-11 16:27 ` Kai Ji
2022-11-14 10:22 ` Power, Ciara
1 sibling, 1 reply; 6+ messages in thread
From: Kai Ji @ 2022-11-11 16:27 UTC (permalink / raw)
To: dev; +Cc: stable, gakhil, Kai Ji, lukaszx.krakowiak
This patch remove incorrect bitwise and operator used in the
return function of sw snow3g testcase
Fixes: 24342ade2c9d ("test/crypto: check SNOW3G when digest is encrypted")
Cc: lukaszx.krakowiak@intel.com
Signed-off-by: Kai Ji <kai.ji@intel.com>
---
app/test/test_cryptodev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index e1122fcd7c..d6ae762df9 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6870,8 +6870,10 @@ test_snow3g_decryption_with_digest_test_case_1(void)
*/
snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data);
- return test_snow3g_decryption(&snow3g_test_case_7) &
- test_snow3g_authentication_verify(&snow3g_hash_data);
+ if (test_snow3g_decryption(&snow3g_test_case_7))
+ return TEST_FAILED;
+
+ return test_snow3g_authentication_verify(&snow3g_hash_data);
}
static int
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [dpdk-dev v2] app/test: fix of bitwise and operator in return
2022-11-11 16:27 ` [dpdk-dev v2] " Kai Ji
@ 2022-11-14 10:22 ` Power, Ciara
2022-11-15 9:30 ` Akhil Goyal
0 siblings, 1 reply; 6+ messages in thread
From: Power, Ciara @ 2022-11-14 10:22 UTC (permalink / raw)
To: Ji, Kai, dev; +Cc: stable, gakhil, Ji, Kai, Krakowiak, LukaszX
Hi Kai,
> -----Original Message-----
> From: Kai Ji <kai.ji@intel.com>
> Sent: Friday 11 November 2022 16:27
> To: dev@dpdk.org
> Cc: stable@dpdk.org; gakhil@marvell.com; Ji, Kai <kai.ji@intel.com>;
> Krakowiak, LukaszX <lukaszx.krakowiak@intel.com>
> Subject: [dpdk-dev v2] app/test: fix of bitwise and operator in return
>
> This patch remove incorrect bitwise and operator used in the return function of
> sw snow3g testcase
>
> Fixes: 24342ade2c9d ("test/crypto: check SNOW3G when digest is encrypted")
> Cc: lukaszx.krakowiak@intel.com
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
Acked-by: Ciara Power <ciara.power@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [dpdk-dev v2] app/test: fix of bitwise and operator in return
2022-11-14 10:22 ` Power, Ciara
@ 2022-11-15 9:30 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2022-11-15 9:30 UTC (permalink / raw)
To: Power, Ciara, Ji, Kai, dev; +Cc: stable, Ji, Kai, Krakowiak, LukaszX
> > This patch remove incorrect bitwise and operator used in the return function
> of
> > sw snow3g testcase
> >
> > Fixes: 24342ade2c9d ("test/crypto: check SNOW3G when digest is encrypted")
> > Cc: lukaszx.krakowiak@intel.com
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-15 9:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 11:59 [dpdk-dev v1] app/test: fix of bitwise and operator in return Kai Ji
2022-11-11 13:16 ` Zhang, Fan
2022-11-11 13:18 ` [EXT] " Akhil Goyal
2022-11-11 16:27 ` [dpdk-dev v2] " Kai Ji
2022-11-14 10:22 ` Power, Ciara
2022-11-15 9:30 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).