From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16812A0093; Sun, 1 May 2022 20:36:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA48840E28; Sun, 1 May 2022 20:36:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6A87C40DDB for ; Sun, 1 May 2022 20:36:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 241FeUo0005466; Sun, 1 May 2022 11:36:20 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fs4mkk41g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 01 May 2022 11:36:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gq5TCvGyhZrhyYK6BV7j3h/gdlvFDQ2XM5G5JqGgcP0dd+GBM05L2VW89gc4qf8o5/kVuIYnbf02i6wzRrjOmL+d9Z00ugPMGNrQMrjOdbrsgAb4DmxLVmXnN8tsfZ6upsOCgRpVgpyCzkmp37mRE2dPr8aqls68CpEMBScjNWMqpZQTrFbihM93LGstISE/gbThj8/h7IMxS4EUMpMhbwMBZRUtxqsPgxpferyUua34p8gX4/FIyQSSutjFLyYSi0Rkk69895R5OjhxL5R7Fbfh1F0mFRg/gMUdYoFPzKWA7ERNO92M9cBmW8WuBOVwLZzoHC2/tnfFONOY9p+mUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wNxKspoGMrJIYbLP41GKWIFl8YSxAc7u7Jr60cBjyHQ=; b=RCsxQQJz0f2V/vyNiKdZ2R7vN3EmODHHwEKdle+UE22fo9D4cIVG+ahYUY7LPAsM1jP+QkrdVcEoSPp90ObZRaOW3OX4CHiTKs8i+fDApC3UPO55S5suvfG76OX5ulCwc3t844Iar403wBJV7qkA4Ws95gdxHcovrsNcOImXcXUsn0RdS5Cd/SWLTHOLVCY1tvXosuKNedapVDzyeMw8Rz6uOO+boqH9P2K6t0jTMNguObFthM63Lx1EYo6ivBsIrzCPVtZ2kJoo0zK8zrDQwnqqwGRPPc5DpWY/PZKEtJ9eGwqdSYrK/p6k996mlvrYBLaMp4F8EeQwfVVTyLfNJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wNxKspoGMrJIYbLP41GKWIFl8YSxAc7u7Jr60cBjyHQ=; b=XVevRunGruPkF3beDpKloAW4BlA7lhEg7AN1VChPwr+FFAyh3UOeqA/oqhiTsOU2U95d7yOJGL23c1E7eZPid0p/MdLV3Ik5/7sn/mfsBsZYYa7Y2AbTXQoBv3AzA6ILWW9T/jKfba58PaVW+v4s/JHab+j31BkKbzgV66d866o= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4891.namprd18.prod.outlook.com (2603:10b6:510:11a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sun, 1 May 2022 18:36:17 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%7]) with mapi id 15.20.5206.024; Sun, 1 May 2022 18:36:16 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Anoob Joseph , Jerin Jacob Kollanukkaran , "Jayatheerthan, Jay" , "Vangati, Narender" , Volodymyr Fialko Subject: RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter Thread-Topic: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter Thread-Index: AQHYVY1qVlP+0V1i40KXJY1D6KIuAa0FekqAgAFhiTCAAyvCAIAAYDzA Date: Sun, 1 May 2022 18:36:16 +0000 Message-ID: References: <20220418193325.368313-1-gakhil@marvell.com> <20220421143720.1583062-1-gakhil@marvell.com> <20220421143720.1583062-7-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7e7d206-b656-433c-b932-08da2ba17a5a x-ms-traffictypediagnostic: PH0PR18MB4891:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 74OTqx1WuajR41jAHrL2+EhfJ8ZYj1XHm0Me+AmruW/GXOu8ReMxwKlFKOS6Je3af4vnFNHt/d0YfztUo3t/4ENlAszLQCh33rqEuWKfqEba/G9/zW8Bo5hDW2rc5B7w5QJU5epp+KASHOKvo5HGY+2SzyqRt9n5VeofbsjXVsccnpwxzhdP8DiZz05JzVMC8JVsACpXT/QYNtchmRVb1rjMxzdFaSopSNSsFb0/Z2Oh2AwsY9VrFFz+N0LII2kus1OgqCMQbg6DYiKbdOEVK/w1/EdwoPmnfShW2REy/EjmXThU+kVclUUz5/STY0qL823tIhlejUv0muarr8eJ86w/sk+wAcxhmHiR5yzzivFwTWeXp8m2egIn1qs1NYufhqvKh8FR2Fnx7wKNFRZQevJDd4hEfLqPrgHBB7b6kOYy8cABi7WtLufpvHhItqqgFbolyRIPMGWBiVQe685pB9Phg6XcRElBq+QYboq+8DF6DuBWY/VDlS9KQCVmOSfpVZFvcPNcqGjKdH3HJ5cnKM04KdUOGyGNh8gkgSfZUJRDoH8vWBkc7xBJUc7DupUNTQ8hybc04/FgtMXOlE1qc3wgRxt9Ex7Y57oRfq48wN6pguZvlHXtBCCAxkn66Cre+XkLL8uLHAduAlagHyDMczigEJpSJJp/UK++tCl3X5vZXYx8sua2yHkGZ6kmAfgccgyuF4i9VNKRQ883KmEFaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(86362001)(38070700005)(38100700002)(5660300002)(4326008)(2906002)(71200400001)(9686003)(7696005)(6506007)(122000001)(26005)(66446008)(64756008)(66476007)(66556008)(55016003)(76116006)(52536014)(8936002)(33656002)(186003)(66946007)(54906003)(55236004)(110136005)(316002)(508600001)(83380400001)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4ttnYkz64f09WTScUcTZVa9BC5lynE24EHIPdFQwG5Xxy6zLUejGlY7Hk1uX?= =?us-ascii?Q?b4z+5AVC+FBlLwWs6BRxDZKrWvZlfZHH/ZphHu3zBA17b+jxJi9XufFKhzK2?= =?us-ascii?Q?d8D4mMdYlj+8jdH0bs2J+UK2j00BtbhvsOBeedRdveaGPQvxUbqiNKBTOoRV?= =?us-ascii?Q?p7se9Rbft49nvoC73ud14ECe0zEgXHiGirgyos2AC+3KdhO/FV6Bw5d5uCmj?= =?us-ascii?Q?t/bMTFkvG+1uAoDvedV1gnv/zP8c+gcDlq6mm97ZEyUvMFYY9CXkEIGxyOCi?= =?us-ascii?Q?YlonBKd1ImuuykkFpvlDgPm2Z+83BL5IU5AtuBECie1e1jHiNUD1TbV6d27V?= =?us-ascii?Q?6JZV6lDmIo4h5lazE7XJZrSqcnYXduFk40tE92vMsViG9d1cAFka4f8SaUN9?= =?us-ascii?Q?5nT26/KVRW+kYJ2cVV0G0JkIGx3vg+7emBGuS480FK2v1qBEm9FRNPpKEcSM?= =?us-ascii?Q?0FVDGySiY7Go6YELMOmPAIY5EeHfNmLeRfOJ3iDoKzWqS4RK/b2A11mdOb+R?= =?us-ascii?Q?e2xqYSXxVMp3G8bMTCsDBdYEUnAGCDLnjbRpasqAQXTnM5qHdVkFJv4txPg4?= =?us-ascii?Q?8gMHi2rGiOXOGDNc0Tt08FQJF37AHyTrzsy93T0hYyZkGmhpvJzmYLvrjuVA?= =?us-ascii?Q?BdTs+22YUT9Z/mOboSeoHgHL5XazfYiiakPOK7VgEl1D4nltE3SRtyF7WVhv?= =?us-ascii?Q?Ajpa5LujnezYtd//0gfqrBP/ro4jD39ngL6c31TsIkl6AGbrQIeg7qLft6+b?= =?us-ascii?Q?uS1pXjbbgiJMfIacHOcBgvlD8a10cmWMjKZD53bXvcI5JF2yC0ZDRCgguLNe?= =?us-ascii?Q?+g4D3dKSK2sVof05b+853jrATB1Jwd4cq7kFXwQJqWbTT20DVSlaLkr5Pizo?= =?us-ascii?Q?/Gr8JDPNSt7kmoo8xx04PMF7fRh1yYsfHAIep3PFq7GNeF+M6jlSky+CQOP8?= =?us-ascii?Q?/SLzQKIxhUuTtunr/WfydUk15iHUopWqP1wpYwBNJMlB4wIFpGN6X0CeSUDs?= =?us-ascii?Q?H0IG1g2UzAfkx+KC3njWM/NWEB+U2BsZmnMV5SZEE02J7571rJPk0KvkLiTj?= =?us-ascii?Q?5BdCL7LAouypHB5w5WdWNtyXZYwCn4DohRQJLH9dNZF39Itv71oIc5dvMIqD?= =?us-ascii?Q?WGtESNr09uCwbX7A+XSzJgaFcLUMmK8Qy2HT9ByPoYoqq8zI1zbiY+BAH8Jm?= =?us-ascii?Q?Sa+yJ8NkBX7nkgDGnGlk436qSgDZqTsT9PE/5u73PF8LhWOb8ys0bJ3OYFYB?= =?us-ascii?Q?J0HeBSwBmKeHN8np8Hj8MwBLeg8+AsiWdiKq75ErXiD1ZFe9xoHlOtsQWWE6?= =?us-ascii?Q?Gy/C7pKeJr1sCPvlY9U9dML++xz3rCa+iiLM5G2LKWPweM5qqVExPA9VNoK6?= =?us-ascii?Q?YbXtXU5lS+RjYpGOEm9ChknaGRQe4rKwhrs6Uv1ME3o69+KDNnh9HiIg4TWo?= =?us-ascii?Q?5QOGAYrYLGdmkqoqvc5IFZoqW9UOVRloERRIDIwi618T1Kf9sawfl9BVH3xF?= =?us-ascii?Q?ONyddkqniZCg+Z2KYh18B3fM4pn0+BhmXznH2FUiXCJnslJXjs0gEvelY01K?= =?us-ascii?Q?deTonFWnIuEF3EPxc1WXiDW18UqlLyx813vFt75vMHrQJ7e41ZIkKDNESb7S?= =?us-ascii?Q?WoM3k6eVl0JPSBfVGFZPRfhw//WSWGrD1s5XEt5g9JXHm0MeYN6f3/MF3xhT?= =?us-ascii?Q?zgJd8qf8458Cen7r0Cm4erWYOdIn0CXKKhJvW+iG+tbCuA71oQgXqbOmC+1q?= =?us-ascii?Q?a+NxYiak/w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e7d206-b656-433c-b932-08da2ba17a5a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 18:36:16.8529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g5AsErCoXObgzSMroejXZgbejSiwjPmq35QPUg78qapTuTChpDu+rYSORCoV9u9pbs9Gyo01Jh/W3lPY4XKkBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4891 X-Proofpoint-GUID: pnt_rrb4EXag4ZwCUMi8v7sO6yp58YE4 X-Proofpoint-ORIG-GUID: pnt_rrb4EXag4ZwCUMi8v7sO6yp58YE4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-01_07,2022-04-28_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhinandan, > > > > > This is failing with asym changes. Please look into this. > > > > Thanks for pointing this out. It is failing as null crypto does not sup= port asym > > And asym_session_create would need an op from driver which is NULL for = null > > crypto > > > > Please check if below change is working for you. > I could not apply this patch cleanly. I see that you are skipping the asy= m test for > NULL PMD. > Can I use openssl or any open source PMD to test this feature? If yes, pl= ease > provide the command line. The patch is not skipping specifically null pmd. It is not creating asym session and asym op mempools for devices which do n= ot Support asym sessions. OpenSSL can be used as it support asym ops(vdev can be passed as command li= ne arg), But the test will not execute, as it would not support event crypto adapter= . This patch can be tested with PMD which support ASYM crypto adapter and no = other PMD support that as of now. > > > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index eecfc22057..2ecc7e2cea 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -934,13 +934,16 @@ test_asym_session_with_op_new_mode(void) > > static int > > configure_cryptodev(void) > > { > > + const struct rte_cryptodev_capabilities *capability; > > struct rte_cryptodev_qp_conf qp_conf; > > struct rte_cryptodev_config conf; > > struct rte_cryptodev_info info; > > unsigned int session_size; > > + unsigned int i =3D 0; > > uint8_t nb_devs; > > int ret; > > > > + > > params.mbuf_pool =3D rte_pktmbuf_pool_create( > > "CRYPTO_ADAPTER_MBUFPOOL", > > NUM_MBUFS, MBUF_CACHE_SIZE, 0, MBUF_SIZE, @@ -9= 63,19 > > +966,6 @@ configure_cryptodev(void) > > RTE_LOG(ERR, USER1, "Can't create CRYPTO_OP_POOL\n"); > > return TEST_FAILED; > > } > > - params.asym_op_mpool =3D rte_crypto_op_pool_create( > > - "EVENT_CRYPTO_ASYM_OP_POOL", > > - RTE_CRYPTO_OP_TYPE_ASYMMETRIC, > > - NUM_MBUFS, MBUF_CACHE_SIZE, > > - (DEFAULT_NUM_XFORMS * > > - sizeof(struct rte_crypto_asym_xform)) + > > - sizeof(union rte_event_crypto_metadata), > > - rte_socket_id()); > > - if (params.asym_op_mpool =3D=3D NULL) { > > - RTE_LOG(ERR, USER1, "Can't create CRYPTO_ASYM_OP_POOL\n= "); > > - return TEST_FAILED; > > - } > > - > > > > /* Create a NULL crypto device */ > > nb_devs =3D rte_cryptodev_device_count_by_driver( > > @@ -1020,16 +1010,34 @@ configure_cryptodev(void) > > TEST_ASSERT_NOT_NULL(params.session_priv_mpool, > > "session mempool allocation failed\n"); > > > > - params.asym_sess_mpool =3D rte_cryptodev_asym_session_pool_crea= te( > > - "CRYPTO_AD_ASYM_SESS_MP", > > - MAX_NB_SESSIONS, 0, > > - sizeof(union rte_event_crypto_metadata), > > - SOCKET_ID_ANY); > > - TEST_ASSERT_NOT_NULL(params.asym_sess_mpool, > > - "asym session mempool allocation failed\n"); > > - > > - > > rte_cryptodev_info_get(TEST_CDEV_ID, &info); > > + > > + while ((capability =3D &info.capabilities[i++])->op !=3D > > + RTE_CRYPTO_OP_TYPE_UNDEFINED) { > > + if (capability->op =3D=3D RTE_CRYPTO_OP_TYPE_ASYMMETRIC= ) { > > + params.asym_op_mpool =3D rte_crypto_op_pool_cre= ate( > > + "EVENT_CRYPTO_ASYM_OP_POOL", > > + RTE_CRYPTO_OP_TYPE_ASYMMETRIC, > > + NUM_MBUFS, MBUF_CACHE_SIZE, > > + (DEFAULT_NUM_XFORMS * > > + sizeof(struct rte_crypto_asym_xform)) + > > + sizeof(union rte_event_crypto_metadata)= , > > + rte_socket_id()); > > + TEST_ASSERT_NOT_NULL(params.asym_op_mpool, > > + "Can't create > > + CRYPTO_ASYM_OP_POOL\n"); > > + > > + params.asym_sess_mpool =3D > > + rte_cryptodev_asym_session_pool_create( > > + "CRYPTO_AD_ASYM_SESS_MP", > > + MAX_NB_SESSIONS, 0, > > + sizeof(union rte_event_crypto_m= etadata), > > + SOCKET_ID_ANY); > > + TEST_ASSERT_NOT_NULL(params.asym_sess_mpool, > > + "asym session mempool allocation failed= \n"); > > + break; > > + } > > + } > > + > > conf.nb_queue_pairs =3D info.max_nb_queue_pairs; > > conf.socket_id =3D SOCKET_ID_ANY; > > conf.ff_disable =3D RTE_CRYPTODEV_FF_SECURITY; > > > >