From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E8B9A0C47; Tue, 6 Jul 2021 11:38:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 056A64120E; Tue, 6 Jul 2021 11:38:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id EF36840688 for ; Tue, 6 Jul 2021 11:38:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1669WhZ5027982; Tue, 6 Jul 2021 02:38:01 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2168.outbound.protection.outlook.com [104.47.73.168]) by mx0b-0016f401.pphosted.com with ESMTP id 39kt2mcg8p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Jul 2021 02:38:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7AlrN66TnUIA8DmDvrUygRpf589vprhUhQIGuOE6HscVkPRGYvdrU/rEmr7JU5OfLJRD+eOMSP4rhBDExvdTMokin3jYi71A/5ZVM9bD9sLoaxC2ilnxW8N/amUIbEmzlW2SaLUNa8uydJ5yAoGN443qkYi/7nlvMKGkKNHz70QdW9oX5ry1S4U8OXRsSBpGCdZSZIKLtNBWtJhxUiqaElqe+LRo/tBgHB8nDGmV4UIA6ORGkptlRG7XtKpRYkiGOu7Dg2pZHdHnJk9p7/BV4BmCfYU14sdiVpZeqBshTzmRq3I27OuqrePNUQ8vXNkJTuUhlfrEvEFxTelFt2YZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kf+2helnw+dlam46O6HdsO7dvoBX0MZ1ezj7VSWwDKA=; b=F4WSIy7fE/dFQQt1lbquPpfQVyWsdmss6MeNSIyLSutKJ7iVDNduSiEHtHK6aDtiwYEqmmIAneE/3RpIWRizPxZ79FUg2syi0ZIr5SDx0vXpvUIfPmhUkifVqskLyJ7nhxXjkkXUzXPIohUbjgUgr/gu6oLynJe/85/5Wtqys6MkYvaCNYP+sxY+GKDYX8gK9bkhvxEmFN4CWiu5YP1v7F7Ftc1v7r5F0z5oSToivopQfJzxZ+jePeeo4tx51BTN2GLn5CrHmlVkTG809wLFDU3mU+0GdQaoOjq8kMxp0V87bIlh+orCZPm16ft6w/Mi0dJqBTrtF0EV8XIl7Vg0xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kf+2helnw+dlam46O6HdsO7dvoBX0MZ1ezj7VSWwDKA=; b=Jvj1F47kZo9gwMZu8QsCZNsrQ2HtN0a3CN0tdGn1sgU7vz+6GsvdBmE+lecRJ34CA8PgQWf4mgnFI0MvEg/x0FGlMYYHViJZjiWNqZMKgeK6kqPM5Lyo4m4Em6vMYYv27jEyzWLP9gqV1+61/tUg8hM8UG6ppiBTD7+dW+C/8vw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4698.namprd18.prod.outlook.com (2603:10b6:303:e5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Tue, 6 Jul 2021 09:37:57 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4287.033; Tue, 6 Jul 2021 09:37:56 +0000 From: Akhil Goyal To: Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , Suanming Mou Thread-Topic: [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests Thread-Index: AQHXbnzWAdzsjacxxEmOrGnqAk9VbKs1kZ5AgAAfPoCAAAZcMA== Date: Tue, 6 Jul 2021 09:37:56 +0000 Message-ID: References: <20210509160507.224644-1-matan@nvidia.com> <20210701132609.53727-1-shirik@nvidia.com> <20210701132609.53727-16-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.68.121.110] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23782853-5572-4702-2711-08d94061bc98 x-ms-traffictypediagnostic: CO1PR18MB4698: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PAATk+iz2iteNzc9rxaSTW8UrRmfh+6h8qfx9UtcKQy/h9pn+/fp3hXXvw/Cs1F3Om/CTtbZ098llyYbwouE/ZsBfhz0XN4KMDwO8JlEZ608Cw5tSV7AAa67EOlhslUlyzec+CqSZPwFIQefTzlWANiCgpAQV1WOSlEXz9B0xnsfljoY/iIWzrj7NSEVVBbYlah5PC6naZ6zHrjXiS4u8viDOtACCvh/iiJ+wDADD7SiYCVfni+cIiLJHyFcu7gY4wTBu6aAmkb/oGDTf/TcSXBUIZtUzw6H5wMAr++VeAOVpHR43z14E+pyG4igCR89/nNHXJwIxir96/Jf62fxX9F8/BIEhFzQRGcggqoWjg6uCDuc7Ut3UNLu3c1TS7cBkkyxl2ZwMETXSCo3OUTRWXIK1VQ13sC+aqSKxsc46nGVkbQlEBi696H/LpwW++bQtgdiiNOOh0BBZS9GAZ5m86ajhUIZI37fHd+YpRFH3THuNpBwKiELNBB6pKLwCAOpFnTq+bTEwGLYYCbH+W1OH0VCg4OVpuiE4Pf4SxzoI7y6Zg3nojXVVozEjL1LyLpSJofqPGMiL2wz95w6NpExthrQWHuBnve8zU6vnff/uBfc37eT0uZ1f+/fVMG7xwA2RwigFpdpddVtHSCWcO1Dkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(186003)(66946007)(71200400001)(66556008)(76116006)(6506007)(55016002)(478600001)(66476007)(2906002)(4326008)(64756008)(33656002)(9686003)(26005)(8936002)(66446008)(52536014)(110136005)(316002)(83380400001)(86362001)(122000001)(7696005)(38100700002)(8676002)(54906003)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I2GbcB7sXvPhqu0bVvGEWRs4iPF9casilxKCXpMkyz7BFBOB8oyfPcUZhwTg?= =?us-ascii?Q?mvErvpM1KVCp+vlUWNDCF8oF+97jx90kEb1T2nPXrW1NIrJZG7TeZj1EfvKV?= =?us-ascii?Q?ECNK2AuZ4RT2PM7uiE//vedwoWRUVGqEHyzjKtKs9ZyNGcDhru0ZnLg0QqzH?= =?us-ascii?Q?+EDuItpHR11Vt2oID1Au06/BKZ1FIuXjXGgBi3rI84SaVxxM/QYRqoV7CT5u?= =?us-ascii?Q?3HMcQu7vIswNVYDK9K/uep0i2p7wwAihQjoOIm3PVg8YL/OEdaERGdPKrgr3?= =?us-ascii?Q?/EJDYd2jsrkb33U6xoKS4tt/kRtY+PPFZYojMFNVI7rMSbalK6hYkGPNW70y?= =?us-ascii?Q?McHywriTZ09Z3/XuIRCWyyxQx+2XsBq85pa1H3k3U9q38MLnaoYbHVIFdwy3?= =?us-ascii?Q?xuQ8lBoUkEIz0rHJeQRbiDvVMMDtCp4N9e867HUtbrp32GGNannEaU7fhIcQ?= =?us-ascii?Q?wH9HgWzxqekko9569WVVUVJRy7CnrTYIB9er5zOOOOMy8CoIce7sJTXaJ2VU?= =?us-ascii?Q?h7HftPOgNDCsO3bhRMHMdbMvIU+pJEhcclNqauzMw20/xDcSKhWzJIDaNe5z?= =?us-ascii?Q?rzmarg9D2cbO7j+FavKyi9CzC4ub7yEfh9MW1AdWgaV/H17+MMoqjG8hegbi?= =?us-ascii?Q?ZH5ntIoGq8qGbPicZAFhHvSkZam+dq7qOcYG5emNq5BMKnGDV7KtTqu78KZN?= =?us-ascii?Q?draAwW2cmqPrmq0LwLxBL/SGrNOWv7WFHUrtu6AzSRKgUEzzx/RDWYF6e4e0?= =?us-ascii?Q?MqhHNyNc5MMgIJi0tAmmqD6cmvWTcBvDxBUj2mSTBrCpZNhwdGbTfgIxHP9e?= =?us-ascii?Q?hQ0ub61Mjg/GhMM847APsyQqZj0QbppvSrQpaycLhsu11Ppczdk7boun8Z7i?= =?us-ascii?Q?xLGnTteYdw1LqVw4blLnuFjB0ZaMRywrJjo2MHB0qoNgGbS84tZkyLTGfZUs?= =?us-ascii?Q?S4kkSgrwHK2DV3EUmoahbTupOXtdnp0JdGFBbSBv5C9c163fv5PZp0oeHAHb?= =?us-ascii?Q?y+EhitLVUQqT8HY2L5USGp9gRTN2sVTXfBbPvvKF9/3dEmuu9Mq/NhJsECtx?= =?us-ascii?Q?Fib3inKMPb80/BwdmZJJ/YbFv59NR+htEt/hTGe5gruAGgGt5nRROKvPB2Zx?= =?us-ascii?Q?FABe/W+DpvijTQuvf7d6knUV5Lxh5T5JK8Ayj4sWSBrCkt2E+2ULyB77HaId?= =?us-ascii?Q?BMSpVcWd94Vh3MXbzqBUPI/ln9PIFXSIg0q8YM4P/U4IgvIx+vIJzpODMo/Z?= =?us-ascii?Q?crTr8qVLuS/JCc9hnoeSYo0HEA3n181MKj/iaXXyMm7PRuxckebq5GRrtpB+?= =?us-ascii?Q?xtEIZf6LqRaOLe7xbk8a/q/c?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23782853-5572-4702-2711-08d94061bc98 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2021 09:37:56.8375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1yoVGz4na9QZ4/gzmfhrbq34za7vYjFruRhh62nDmB1Qob9MLxedsGi/ygUo0czgnERFbD/w8yK5Z8JVFsOU7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4698 X-Proofpoint-ORIG-GUID: X8L-16mlK1PYxk4gdpIyrPdqjAaGAASS X-Proofpoint-GUID: X8L-16mlK1PYxk4gdpIyrPdqjAaGAASS X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-06_04:2021-07-02, 2021-07-06 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > The crypto mlx5 driver supports multi segment encryption and > > > decryption operations. > > > > > > Added mlx5 multi segment encryption function and multi segment > > > decryption function that will both use the mlx5 vectors. > > > > > > The added tests will test both data integrity and correct stat values= . > > > > > > Signed-off-by: Shiri Kuzin > > > Acked-by: Matan Azrad > > > --- > > > app/test/test_cryptodev.c | 277 ++++++++++++++++++= ++ > > > app/test/test_cryptodev_mlx5_test_vectors.h | 3 - > > > 2 files changed, 277 insertions(+), 3 deletions(-) > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > index 8dbe324b81..4d27a9444c 100644 > > > --- a/app/test/test_cryptodev.c > > > +++ b/app/test/test_cryptodev.c > > > @@ -6681,6 +6681,219 @@ test_mlx5_decryption(const struct > > > mlx5_test_data *tdata) > > > return 0; > > > } > > > > > > +static int > > > +test_mlx5_encryption_sgl(const struct mlx5_test_data *tdata) > > > > The test cases cannot be specific to one particular device. > > Hence the name test_mlx5_xxxx cannot be accepted. > > > > Moreover is it not possible to add aes-xts in test_blockcipher_one_case= () > > and add only the test vectors of aes-xts? > > And probably, you do not need a new file for test vectors, XTS is varia= nt of > > AES, Hence the vectors can be part of "test_cryptodev_aes_test_vectors.= h". > > > > I don't think there is need for a separate function for XTS right now. > > The current function test_blockcipher_one_case() covers all capability > checks > > And feature flag checks so that the test is skipped for the devices whi= ch do > > not Support a specific case. >=20 >=20 > Hi Akhil, > Thank you for taking the time to review this. > I would like to change the test according to your comments as follows: > Use the existing AES-XTS testing function. > Since we require using data-unit and wrapped key I will add two new field= s to > the blockcipher_test_data struct: > XTS data unit- to be used by drivers that support data unit. > Wrapped key - to state whether the key is wrapped or not. > I will add vectors which will include the needed data unit and wrapped ke= y to > the "test_cryptodev_aes_test_vectors.h", which will be generic and could = be > used by other PMDs as well. > Will that solution align with your comments? I believe this also addresse= s the > comments you mentioned it the other email. > Please let me know what you think. >=20 Yes this looks good. You should have 2 separate patches 1. for adding mlx5 crypto PMD in test app. This should be minimal similar t= o cnxk PMDs. 2. adding aes-xts algo support in test app. I believe SGL is already supported in block cipher, you wont need that one = separately.