From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E971A0C49; Tue, 20 Jul 2021 11:43:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECCFA40689; Tue, 20 Jul 2021 11:43:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 6D19040140 for ; Tue, 20 Jul 2021 11:43:08 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16K9e8MI027098; Tue, 20 Jul 2021 02:43:07 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by mx0a-0016f401.pphosted.com with ESMTP id 39wa68bx4v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 02:43:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9urslU1XU6Ho7TMmSlABU/gCPO+9P8Imw7rBmPVt4Vd0ZSW7tgLbvieBzRF9Rf/ItoKGKedo1UJXkdzpJKtAWaNoBKZ0WSUFU3c5RcpNBbpyipsnjnTTRyTMqd5E5RHW5XICLMJ1++vFWXYRCt5UmSKWR+xRk8m7Jkaxj4qNxX9as9j9eNRwGfB6c55vYveDDjf0qV9Gv7q1XltlNhXYjA4GBpigu+fHjEp8T/+xABbczdzAw6rvPKx5dUm+cmxml+i/ndiGOnN0ej9mKYQQf+4RyzQf0dXFlxDmiOR7O50jyutoL4cbdnmji5GJJEEjBwqZJGWccxLD7Hv3hbrog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wUZZIgOCtf/7BEUfQ3FlS/oJvTAf5k7Pje3l1AgLweM=; b=nQw6dfqLaQCcl8ZLCaEQnAIUWU/vbcyv166jBFBeHA/BSUteA3kF5sJ8a762IdfaVCHlJh5MgqMu3xLMFkRqThDJF+hItPHatEABKkHX7pdiimSfVlBUj2qxrdWA3CbvIkhu4nm6Jh6j12nENhcy2ealGIjURh2wBlLesg4Ay/mC1nPemehKWA3b3VBRi64gK1XEoDmmRw6cmTa7+ro/U5+4iaQfSsFQ5jYlCXtcAf2AXjuAbf2RE0GtKY6teMZBcNV7AXXcN8Zddvg1IcUeXhmbCKea16dNOLyepGMJEw5IY1ecb3sIHmwrtxekx03CpsYSlSvojsKdnWoxe1jJ7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wUZZIgOCtf/7BEUfQ3FlS/oJvTAf5k7Pje3l1AgLweM=; b=oAohfIub6P568Ikwd70cU9cJDk0Sd7hBxWaxuKc4AjwLRgmN59ax7aMZOZnuO4Ew4i/qgb9KUe3+ChEBR0HX4EP+0S0KHKBdngrWz7lJ0tW3MpdUJw3tun8Wb1n2RzdphjJlqWAROt0IJhkp4YHRj9Q5tpdi2OI0NgVSflYkr/o= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4404.namprd18.prod.outlook.com (2603:10b6:5:35a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 09:43:04 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:43:04 +0000 From: Akhil Goyal To: Suanming Mou , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations Thread-Index: AQHXeZhbnCd1uXT6C0q3QumS/R7iw6tGAc7QgAWYdgCAAAiRYA== Date: Tue, 20 Jul 2021 09:43:04 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-4-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8d5b0a0-381c-4ba2-bd7b-08d94b62c58d x-ms-traffictypediagnostic: CO6PR18MB4404: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OGE1LDbKD8FeP5yP4suKlESj4a7/P4/k3JdcLicuT0ldGHKXVEW6iT/9CXxoBYWkGEKnCRqWYTHuYhJXLJGHiNZ1Bpwteb6X6I6oFyR8xuOWQ8BjKlkoBkQS1JhM0XrpChIMJDb3RIbTGpXKWKyRG5Av48oVUnH6+jDm0uONtbQ4++PXyBK3V7Ohkm/9Ypy9RxjTMj9SP1l1peCB59x4GOZdKGgYPh3zjtzve6tXWv6jyviCZIUfpO6v0Zmqoe5Yw5CZJOhX+PRazRnkap+HM9HBd6h5OuhbmVG6tBtpc4wTOIXsBtSbo6R4HorOzg2WL/8PplManUFLTYT6nB9PTfZJZhhxHUlsYh5HAsxFyXxZLslyJHdOY5pjAI1SvmvneLo0GY3WHWoloWLJt6KfqgvSJeLA5HF46Mxn7WlEfwgzV67kUsJ0dqJIq8GMOuKxFvT7Ficsb/DV58bQhP51MhvcjVR8sv37LpxwPlekEaCHARaK3Tz3Xjyaedt8mslYBYsmi9SsiLaeMxwnCK0Ow020x7RV+ZSnlqv/Asqzwy/PEa9JB37lAnKnyk4rBcZJhDh/cG6LzsOdU87S8IAb9NTN4Qv4lXYqToG+4A72QaH0J2AEVXFu/Fkt6WTM+211pzQFnHGqtKCBzs/RSNAYLFDcGCybTgucxAOwYhZWWRfT+TcLYyIIK06NxMqM75TGpXixgJ+bldOT8yAo0/2xeA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(52536014)(110136005)(83380400001)(316002)(38100700002)(54906003)(122000001)(33656002)(6506007)(8676002)(86362001)(7696005)(26005)(55236004)(64756008)(55016002)(186003)(66946007)(478600001)(71200400001)(66446008)(66476007)(2906002)(66556008)(4326008)(76116006)(9686003)(5660300002)(8936002)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nraOe/sODhHc/l8AuuZ/EdeOLhSUMUTsvEUmGFlcaXeJY5m69o2n5rZhdQJl?= =?us-ascii?Q?4FRapTkfGW4QfuLoSjn9BqlXkG5AIXcAiY8BHfjs6bWjKaTq1yblAZWGDDGN?= =?us-ascii?Q?aqwGetf/AVOADahFRrAymj4+ioaAutexYNjGCls9hfoYVVW2teEGBS/2i1jS?= =?us-ascii?Q?jXN2pjQe1xJHRn2rC//NuQKACv1CFpeHpigwCbBv9ofEgvZv33cg3woGlJ9o?= =?us-ascii?Q?eHCDYOumjtUjHwIULhkS5ieT2aJ9r7UTazo8CJmFhuhRYGtc04MjvBFkUs4g?= =?us-ascii?Q?fC+5gxrDSpR9OYa+8iizZQffuFdVPpFk81Zd02kjpPWGt9EEXknwBGonKjxD?= =?us-ascii?Q?X9Z+xdFndK9KKirUTNZnusvZU3Gs2wl3TGR/vFZMIeh+ZAzgoE8kV+EbbE5G?= =?us-ascii?Q?WVX7tY6gosk2mHBGcVMV220WK7Y8wvkyGgSWmOu8GiisSr5mrbBXPGXtrCSx?= =?us-ascii?Q?WNTmTVkXNlnlsjD2VheusFf/RsKfVewAPpPmRZFSeU7r4N/UQ5xpy9aptcO5?= =?us-ascii?Q?sFzsK9jiDEeHBsjeJxDK7EsNPGOgEbGPy0+2OAUL+1dC9j7IbdEdsU7z5rVZ?= =?us-ascii?Q?keXCGgN7yjdG9QWGPW/vuAUk7uJNwKSyQn9JIFkJZBFlzXa+9i6kmn5kGvOq?= =?us-ascii?Q?ivsHKAP9vKQak55e738nEb2sTE1s05aBfDOiXpQ9nTuv4HseQBQhrzH13KHC?= =?us-ascii?Q?hlECbHYBDH32NKd7q7bv+rABmRS//XLSDPJREv3Dy8orvjPHO6mAYvi0lSB+?= =?us-ascii?Q?9ds5NB6dkoRLOgm+2ZmBLmCocUb/1sNnHhiK6+Tlk6Y55Szk1Dv15aBjV8up?= =?us-ascii?Q?B7PG/aEBJi059yH2YCn2SatGhi5MAIrYrsuB68dPG77j/JvMJRsjIzO2ShQe?= =?us-ascii?Q?WNX0XlZ8wi06a2PmluJW0NBB6rBaE3tI6QqjeOB3vLNsjfMYcko/iXSAOnH+?= =?us-ascii?Q?lFzrUiCVWHhHsLVDV5/WAz1vSaK48pgKGzDbn84w+bRbVTF7U82zyia6FmdB?= =?us-ascii?Q?JCit73orOedjFjJAjapdkMmUcBge+TaTfEqz2ylGjaLXmm+gMJwHtCoB2mIE?= =?us-ascii?Q?LCgtJi2jisqqgQTB1f+z9iTqsN8fMcWy1KltfDdZR8yfq4+ulp7EL1hgbYh3?= =?us-ascii?Q?gsKFlLNDrbzEjilScMPPwZrz41qjl6nUNOfaxQLP0l4yHuFWLSjwJ4mbQYR2?= =?us-ascii?Q?2ZKGI+jtqN3gDG1SdaZCQVVVR8A7ppHHMM6HxcZUZzOzlaRXYnwBDXcpq6ak?= =?us-ascii?Q?UWRZw9sJXe66o2KB1HLxUDcqS4u1EuaQE3Mntw3YPgZc8xRUxHDsegVDm/RT?= =?us-ascii?Q?FdxvpowazeXDTpR/sAHB5Y8F?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8d5b0a0-381c-4ba2-bd7b-08d94b62c58d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:43:04.1291 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BmU+aATVuxBZJgnOUSDvFWw4xdTgFai3LpQHaq6AGjNP3damc6i7C7IAlaV44ICekY+KgbwtOI81QfGoGQ8l8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4404 X-Proofpoint-GUID: TVolGnreMt9L_ycJJwV06a_Lo1Bs1chf X-Proofpoint-ORIG-GUID: TVolGnreMt9L_ycJJwV06a_Lo1Bs1chf X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-20_04:2021-07-19, 2021-07-20 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > Sessions are used in symmetric transformations in order to prepare > > > objects and data for packet processing stage. > > > > > > A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, > > > bsf_size, bsf_p_type, block size index, encryption_order and > > > encryption standard. > > > > > > Implement the next session operations: > > > mlx5_crypto_sym_session_get_size- returns the size of the mlx= 5 > > > session struct. > > > mlx5_crypto_sym_session_configure- prepares the DEK hash-list > > > and saves all the session data. > > > mlx5_crypto_sym_session_clear - destroys the DEK hash-list. > > > > > > Signed-off-by: Shiri Kuzin > > > Acked-by: Matan Azrad > > > --- > > > doc/guides/cryptodevs/features/mlx5.ini | 5 + > > > doc/guides/cryptodevs/mlx5.rst | 10 ++ > > > > Documentation update is done in 3/16 which means the feature is > complete. > > But basic operations and queue pair initialization is done later. > > This is not good. Please move this patch after QP additions. > > Please take reference of other drivers for sequence of patches. >=20 > I'm not sure what was discussed before for suitable documentation places, > but as you suggested here and in other patches, can we be aligned to put = all > this documentation related pieces to the (13/16) final PMD patch? >=20 Introduction of the PMD in mlx5.rst can be part of initial patch. You can also add empty .ini file also in the initial patch. Now as and when the feature/algo is added, .ini file need to be updated. And while adding the test app changes in the last patch, you can update mlx5.rst. For reference see cnxk patches.