From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3040A0548; Wed, 25 May 2022 08:06:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6FA4400EF; Wed, 25 May 2022 08:06:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 62C55400D6 for ; Wed, 25 May 2022 08:06:09 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24OK8LTV020536; Tue, 24 May 2022 23:06:08 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty2d35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 23:06:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlIBDTBa9UJhPBdXu168orOA4MbvHo9akrHKF338SQFUcnuVMgNLZtEnBKNqinjHiFoJAeWwdnNkNW+iozySloJvUqt+IWnj1sszy1PRNUIQiHRI503ohPi7PHGxUrNN8Gij512JPtGonJ/0lQUElABKI+rQPC5DbV63sT5xVvIQ14I5YpPPJDl+6S1Fsg8A5IFUzMgmthyIbyOI/c/CkYG8iiOq1dFfR4KIzSEGVctfGd1GY0dPCkKgkCMEP2m0UQJThpQhrgnne6bN7uam5XgYhdzbzvr4VRyEm7ICRSUVF/LEkO/qJfcfRBttU9Rxrz1OzM156Btc6fjaM44PCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bESqEXr3M921hWD8tyvCWfUzZQQELVBFXdf+idet8yE=; b=e+vv7a/OwETsYcyLxw4qSvkNSyXQI0/mFqM+JCBO4RfZM52mVoT6faX/8/jtAOCp+xPYb7/ecPZQikJ8LFBePkL8d37/WfCDE6Q84YgH2pxTBWvjIe+CWOZ6n0hrup6GORmIFyBtMaqT2qsFJDmeDsz3v6h0FcUuhOjOXnm+z0o923CquDt6i1YFoOwe/Tzckj94M9bjDuVKTRvdh324E+I6RHl9jM5qoTgXV3tebYyibTtBXzc1AKfq2b7rb79WME+Kj7NsNtUNGqNSR0qKFecPzDH0dnRxGOYlYcvyQ3i2lksc0VFHPrYMS0EEN1AY5icITC+l3IjbbGcwTCjoXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bESqEXr3M921hWD8tyvCWfUzZQQELVBFXdf+idet8yE=; b=k5hInIJKVeHYHeSgPSGpvb+sDYRk3U5rgvIhJJzkF/hL9/FrlA96BuQVxTgFIDCnrswjQI7O2adAWy/zdlE05H78DIoxj9I3K9hUORtbnupaqjlQ5bQkXMWtGgK8+YXtsa99s23XABjAPL5ogfSb3bDhiYdlM/b2bhe/W5DUn2c= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN6PR18MB1284.namprd18.prod.outlook.com (2603:10b6:404:ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Wed, 25 May 2022 06:06:05 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 06:06:05 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" , Kiran Kumar Kokkilagadda , Anoob Joseph CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBelYDqy3ZgaBEOpezgSxEE94a0t5dhAgAA8VACAAP/xgA== Date: Wed, 25 May 2022 06:06:04 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-Mentions: kirankumark@marvell.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bc8302a-1f9d-4fe3-44ee-08da3e14a71a x-ms-traffictypediagnostic: BN6PR18MB1284:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WHpGxC3qPBcMFlooy8g//W97fsSgKQ3xeXMsmYZvti3hKh2QHsNCaSneQwaJLCxOyvRo43UCiNhLDOdBXDaS5jAGJnHUkIoOmvFE4IHLpsczkWMO1cFSQK0F0qnfIanOy2zgBYaZWCTo96FD7FrRppwVpo0HdjaHDrbrdyVYyoDvcywJCPxAu4GX+jQPt3uYGvH5LSq74u76TzOgqrvk2OqzrRxEqLxThKgbvyQ8lCbG1sWQZ6WkaFdW81evyRBN5ApE5a0ZL9bobxTWXVfayiLAR1fjPDOWYFCKeNjEg+rr2L0PMvZQnBjItymugsJOzkpGA0218raqzedhCYOJ7Zf10Atg8A5EZzCB9hSe8XlLvMac+OX6OmxN9/JOM4tTOdO6aBC/v2RmlTsjdWUIPhsFSQp1DXdmvtcpuDZ6AN8O0OZ3ZEuNdtaPh/FMb/qQT54PMGFKnAqnijKAOIIS2UGEv1djR5CF0EbsSSb3CjUleQMBlGscP86RGVGfFfEWAvPDWasQfq/RVoe+r6tcFhmSbSg+IgDdtsEjdYeQ8mEtD0ljVV4fOirRg/Q+yy6i7jLp+y+JRiglfap1UOHR8WOlcVtykcz16k6mGafUpDHArsP1UCyigHomD2/gUTCZ6f/VkMNeG7WO9W2p3a3HleiBi2PxsbIhChTYoDpApQgAzgj/HF/1N3Tor1BvJy+vPzu9e2OhHihq+/9k98KaGQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(83380400001)(7696005)(55016003)(508600001)(316002)(38070700005)(38100700002)(33656002)(8936002)(6636002)(110136005)(52536014)(2906002)(186003)(5660300002)(86362001)(8676002)(64756008)(26005)(76116006)(66476007)(66446008)(66556008)(4326008)(66946007)(9686003)(55236004)(71200400001)(6506007)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aPC7vs+sVp6DgwaolcoDEu3mEBL0/k16zoDBSfW8Zldicu5wEzvfabJz3cao?= =?us-ascii?Q?Xomb5IlUhLFRBPBJ1GsSHE4mSRIQzPuOtOYqG8NqOxP1R/vnW45rusEA+sJT?= =?us-ascii?Q?X4qo/DQQRpoOqfZADNPwNdzAdc7aL61TnX/GXrwpfyWsv0cJIlJX/xOKw87z?= =?us-ascii?Q?0qcN2QeCFv+T3RwLfBkX4oPutdgPvGUrjp44QD77ObK27Cz3aId5b83zS+sK?= =?us-ascii?Q?9RFLJQtGLwzDoeVIM2xeshtMG/x0I4Pc2hWvkmkWO2aBwW5Twf+A/WKUq99d?= =?us-ascii?Q?iVdXGtE5KLBdpdXBFzXrVnbHVYpNhh/N7TaMjRde9cObiYMbSr7+Z9657Wdk?= =?us-ascii?Q?quNCjnKEmHc/bsrgYYWNsPb+j2XSlZndo/7kDCDw+QpKVh/hHAH3z71r2Zf/?= =?us-ascii?Q?IHtxUHAubmgV7QCzLvC+mdtgkgXx+q8PMYFDmfyhG8N/eqhQW4ry3iNxm25t?= =?us-ascii?Q?MabhK+q0Xc8mRkSiK+Ozew5OhppIAdsGcxHG/SKCudYBGkRw26LYhbIBs8gQ?= =?us-ascii?Q?+IapIodozTB/2d0n5EwzzgKIujb1AdsVAEDyifbi3tnq/UGzSsomFfWH1AKH?= =?us-ascii?Q?OfbcvmbXhzEY1j3QFYLgk3FNEpWqV8e6zluhBNsc3lI+lRJRDwBrlM5MBGpt?= =?us-ascii?Q?wP8ZDBXvEkdMAxJQVqYvyT8CH8vOdaD6Pl8KeEm2hqmfUSevk957CyTuPf6a?= =?us-ascii?Q?o77r6BXV+zOsXDyJOQdUwVYLKxGsCHsQsletozvSgPgCME72GulC8bwzJZC/?= =?us-ascii?Q?3pddYEzfLLwPLDwvZo7tggvhLWMZiT5Qm5RiRYKaVaRIYHRkYw/mJQe4pu9N?= =?us-ascii?Q?X1BAQG5fbivNTRTPGs4TLW273W4D5DTDdwFIW5owbf4qBo7JGIW2fuFJTXyj?= =?us-ascii?Q?DaTF6WyYJUGhqzeQxPVGX3eWX7mlpEDBphlKDRX+D2afuGQozuxfk2FX9eQB?= =?us-ascii?Q?oywDOwQHgJEEigGPpjZ+V10et0c7PXsr+YiiQzF82Y8FrthdkPl45nsIIcHU?= =?us-ascii?Q?LAEScijLkuauOy3ah/swmu+u2cFbuD6KlsohDg3Q+3FHKVZJhEeesQhVV6W5?= =?us-ascii?Q?XuDrLHjJ4dlHIgit5ji+IqlIp22suAlKO5FaIZy3wC2VR6QDUbErXKVBS+An?= =?us-ascii?Q?FgCmOONRMgqE6HRsMm6CT0CyQZpfIf5DwJ1fQZdOHV2RweCOlaF7OcRuVbcQ?= =?us-ascii?Q?bNMfI/08D65ErWT/ekG20bywIwzp1zXsPZJl/ohYvI0smZzl82JYiBc3Vdyw?= =?us-ascii?Q?+vVw1jjVaq/Z9Cg4OmbbyNtMwXBIE05vGcpk/B5fu1725peNjUMVDZQjKHV8?= =?us-ascii?Q?7+wkA7ZteUQMQugf4E75d268rcK/mrWpDJsBjYUypbBesglwQMLZq8r+2bJ0?= =?us-ascii?Q?o/fnBhxDZhpzjiVeOUca0OVGBKGNXrhpEQa8dIRDWkh0sGvhjOQPejhpmjVN?= =?us-ascii?Q?7XlUM5sI99H4vzi/KF90DshLsvqj60HIPOjhLgB3rEhJVd05fpyOM3MtmXeI?= =?us-ascii?Q?3fpzu5p2tsdSy1N3hLt5lLy2mdGfth8L1godbLrYVOhgYrY/S56b4I+rk1Fh?= =?us-ascii?Q?cQx2CdbpWUojgOysmB7YhKbmmqx0sRQsTbJoWtcjS402kiZQKbQOX8UcfiIj?= =?us-ascii?Q?SB2F1LfPNKhHifuo5dL7sHnH8otFCP/8gk3VFrjzXFQ9EqL+TLqGRfZDAmwG?= =?us-ascii?Q?aCHee2sQRhG6JsZksl2atJdGnI4NBqNzjMEmHPZZdJcxhavi8TED9SoGkAf9?= =?us-ascii?Q?TH5IIGaT3g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc8302a-1f9d-4fe3-44ee-08da3e14a71a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:06:04.9974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o4hgo++2k1eMMctMp4A7Xoiifg7YxLKpJzeUlzoR1BF7M36mB2+ig09zv0w1CB1qftW6T54Iy4VfrNEZNDyQ3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1284 X-Proofpoint-GUID: Tvo6BVQbRRN8umxdEWCNNMd6bjg29PWP X-Proofpoint-ORIG-GUID: Tvo6BVQbRRN8umxdEWCNNMd6bjg29PWP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_02,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > - removed asymnetric crypto xform next field. > > > Rationale behind having chaining in symmetric crypto was a fact that > > > encryption and authentication are usually done on the same set of dat= a > > > independent of algorithm. > > > HW usually will be able to handle it in one PCI call. > > > In asymmetric there is no such relation between algorithms, therefore > > > next field would be useless. > > > > > > Signed-off-by: Arek Kusztal > > > > Please check documentation "doc/guides/prog_guide/cryptodev_lib.rst" > > Not all asymmetric crypto xforms are supported for chaining. Currently > > supported asymmetric crypto chaining is Diffie-Hellman private key gene= ration > > followed by public generation. > [Arek] And why do chaining when this can be done even with one bit flag. >=20 I believe it is OK to remove next. @Kiran Kumar Kokkilagadda/Anoob please c= onfirm. If we are removing it, then documentation should be in sync. > Also, currently API does not support chaining of > > symmetric and asymmetric crypto xforms. > [Arek] - This is one unlikely scenario to combine symmetric and asymmetri= c. One > I can think of was once proposed DH + DSA integration for random number. = But > not much else, although we can keep it around for a while. Yes it is highly unlikely to use this combination. > > > > > --- > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > b/lib/cryptodev/rte_crypto_asym.h index 1652a434a5..b355cbe5fa 100644 > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > * Structure describing asym xforms. > > > */ > > > struct rte_crypto_asym_xform { > > > - struct rte_crypto_asym_xform *next; > > > - /**< Pointer to next xform to set up xform chain.*/ > > > enum rte_crypto_asym_xform_type xform_type; > > > /**< Asymmetric crypto transform */ > > > > > > -- > > > 2.13.6