From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D86A00C2; Tue, 27 Sep 2022 21:25:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2F0E41133; Tue, 27 Sep 2022 21:25:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A25FA40694 for ; Tue, 27 Sep 2022 21:25:12 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RIUe96001129; Tue, 27 Sep 2022 12:25:06 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jv6gug5sq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 12:25:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GU/CD0potXVEY0s/zimuNUrUdEaLynqNwDCPFZf8uHGqeN2iIzAhbwOBJXCw1KLihdlddCUQs9ufMg+fF4Mco1mvjipJ4sywbinnATCtnvfv7y9o5rBoOICuA3oyG9Tg+CtVaC28tqVn7eJFlmRnWeANmNMms/Bq5H/15QmAWIOF4rP0KQ3/OfF/evrsdBzp114OXn839pR3nMK2LW1SoWAakHqD5uVZu9zetXB7WXW4qehjHg4Hlu6VfI/vKJQ6tmYCkiPQv8z0vbGUYsuO5kHK3ew3Gk0PKRGa6dt+VXq37rL3fKSzWsZATSsUuJt+EXBNQNwl4G+6YCtEkyL5Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XU0t1GiAp4E1Xdd+HLchECItlChIqrkQ3z5cFENeRfQ=; b=QuNbIn17KnL+r15EeBPTGfGhj0x0+3fAjDJMDlHRVUfKhHEmSRn9/YWdSQm8aVsoIKOPzcgrwUxtxWKxNcbH+pfABYmfpxahQDry70h8o+4zh7omv6WzO4P2MpARw2FsAgbj/g/KkuWyBBnt3BrTSyNVOaVqPwiF4Ydhbn2NixbsZySVotLg1E3lZr66qmMu08vMbp3jGTCxOv6trBZq3SxBENXeoNaw/J20XngIF4iWjROGiy8I8ckkEgmXZReURSsRKJw5ZKwdk832tXSsmQbhJm73ftnnccx/9dZmiMR0Ktato2qtSyIqSSdY7B1vT5LX2Xb+18ITURfhFc1Mlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XU0t1GiAp4E1Xdd+HLchECItlChIqrkQ3z5cFENeRfQ=; b=mYEz73NLl7SzgVh6gG2AgpQuZ0xrgcwKqolEpq81yMPu7zscTfjnodFdpl1Y8mhh+JDtlTzUyQSrijEk8nj0XzAAN8VfV0rVUpTir84sBrVcvz0Ixe+xk6gxC0JOHwlRlhGIHx8aFsH/xkJ1L76gAgHZf/A3YNdC+fSFgBd25cs= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN9PR18MB4316.namprd18.prod.outlook.com (2603:10b6:408:101::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Tue, 27 Sep 2022 19:25:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.015; Tue, 27 Sep 2022 19:25:03 +0000 From: Akhil Goyal To: "Ji, Kai" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Vamsi Krishna Attunuru , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "konstantin.v.ananyev@yandex.ru" , "jiawenwu@trustnetic.com" , "yisen.zhuang@huawei.com" , Igor Russkikh , Jerin Jacob Kollanukkaran , Ankur Dwivedi , "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "matan@nvidia.com" , "g.singh@nxp.com" , "Yang, Qiming" , "Wu, Wenjun1" , "jianwang@trustnetic.com" , "Wu, Jingjing" , "Xing, Beilei" , Nithin Kumar Dabilpuram , "Zhang, Roy Fan" , "Coyle, David" , "O'Sullivan, Kevin" Subject: RE: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Topic: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Index: AQHY0dxFgvo0mbmg50aOqXbcnjAU6q3zHdiAgACLqrA= Date: Tue, 27 Sep 2022 19:25:03 +0000 Message-ID: References: <20220924163542.4159562-1-gakhil@marvell.com> <20220926191424.1069668-1-gakhil@marvell.com> <20220926191424.1069668-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|BN9PR18MB4316:EE_ x-ms-office365-filtering-correlation-id: 939eee04-8f29-47a4-1292-08daa0bdfa40 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CU76knqrgdB6K1OL4tdxeyrbbGwg1VeHqIz54+qiKinP4VMx5pPNpBPZPVH9HJaNrysJE1NOobt6Yxc5TpfEJuShB+brS3WYnBfeU5oWe7nP2OjKZvK05zSFqtb3wWxAHg/HShmX+/mYtVzCruKYTw/KGxZ5+SGKVtLasdGfsg5UJ02kOVAb2svRCuPOibuiTJN3OkwJU3W8252KK7cDYSds6k9cbJKT+YfAs8IljmZ5gwvzQFmMxpxs90Zb4eslE/LMwcxM8jdC9udDbyCSP1wBJp/xjsC+749ro9qJTkYldJvDTryAhDuJ/DHGC+Zq92TvLLT99JxpDQQea5XA3cDoreglSELWhAXPCf714cBrPTJETCgIsb+0uIqZY1je789oC5J6UULkd9/kkcJzr63tGcR52JlUwPo4G0h1sGxPhovCznYMG+QYlq+dq51JgNXo9rJslvb5prvmqTh1sAgS0wdQAwwOhIamwyTfdCLQFhARDkDY2ziNSnJOFiJdvJteftsN7Qj5bOlPJ5DmB//fiqWAI/gMvLZ9ZIPqGXQyG1L4B6WZ1FPtZpX6g3t0ict/folxuvYMRLtreIcyOAAgZ9bNpjfuC0+Wz0wiGcPnozZRo2rk9NMiTv8hunByfdhnISPoOJh2XReqMDQftXXMbMFHOceLgDUxUThPGfivuv0LSDBO5FPcUGN57qEAkr9j9ECJvwnGOnvPQZCy1t1XzIXjrjGhJHIpnqli2T9WznBpI5JtK1Vci8RtYjtIXEMSn6gYUPk7sw8p5ICUW7WUFUJ9krXUpMtOhLyPYDM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199015)(7696005)(6506007)(55236004)(316002)(53546011)(52536014)(54906003)(110136005)(186003)(26005)(9686003)(8936002)(86362001)(2906002)(122000001)(55016003)(41300700001)(83380400001)(33656002)(38070700005)(40140700001)(8676002)(64756008)(66446008)(4326008)(66946007)(66476007)(76116006)(38100700002)(66556008)(71200400001)(478600001)(5660300002)(7416002)(23180200003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kwjZkcr87zxnS0N1tYAm1mRPM+C01gHBjo10BYl4/V0T1ZTKTP/tFHeWG8qr?= =?us-ascii?Q?0wVbVInWOwOiUtMM+74ajI0zYM0fTHpSJKb+PKqfEXBnIgkkr36AyTNVT4fu?= =?us-ascii?Q?dhNW7+HePBfVEpe8uKtmJe/0Lbg05Kao3Zg1QC35hmhtHnJfDR9T7SORaTHF?= =?us-ascii?Q?rjZSJ68AqC6z+v5An8KghcA3U/8qU6G4VIbj9ImrgFxebx7UnBXkE693VSII?= =?us-ascii?Q?nB+VISwMuJVn+P/ueYg2m3oqyxWI7ID1XXsq5vN0t2Hg0tow1qgbOwp6sP06?= =?us-ascii?Q?gjiUBqrvaldIIvGsXYgqnvszc4pW4zym0B4pc4KEEj2VE51jMdjQuWY2mbNP?= =?us-ascii?Q?ZOLKX3z766D8t/hUNCbTr32zybEhfJVJWS4ZflKH5fDjhmQc/fiWaJTlPpb1?= =?us-ascii?Q?i4axbPjfvltisvptlwpaLIXQseolliNNWdCk5JGpoKtKJ+bg9ksFi6qJLOgj?= =?us-ascii?Q?LLk+oV8RVVy4gPxsQROtZTNZc49f0dye28pQ4UzcX03MoFAA4b69bF/g9C2D?= =?us-ascii?Q?HTvPZ5HM+Ka8cuiDoIprXU+tOsGzMuWXv/9BnKIBcQ/sfaDh1UclBU6epHl9?= =?us-ascii?Q?yBGu2pvX87OYnM0G2plnrdz7Q29CYvCI12Up1YPy7lN/VdY1A2XDzAGt278c?= =?us-ascii?Q?Vbq2jOMXr7isOhsGqtMToHAhmEnrnoWxEEa09wT08cdSova80wwRshRfrPsJ?= =?us-ascii?Q?ciAXCTdLK7lSMb1olRWyDXImnovJB3I8CSJnZZvwt3DcVC6ytEhl798Kw/Nx?= =?us-ascii?Q?fE2HnXDB7vR+xIKD40+GRGmOdofG6Dv09W1WkmZH2xVdtNi3DbknD0nVBsyf?= =?us-ascii?Q?/VKpG9Oo81OyM6PO+Ep6ii867pxyr/1jneFOsVztPo6x9amV3op0TR+a+6r7?= =?us-ascii?Q?vRpLv2dUUlJ5Dro3onqYwTI9hX3OV1Ynbu5FxgKYBsJ1Bw83PM39IK4kQQsF?= =?us-ascii?Q?LsM3Cbtjx58d4L9JA/V89Jy1JzUgJnSigh7cc5Ssbdn0r7F+EusMKb+bYMhs?= =?us-ascii?Q?05NRdVaaD0BQYxIkdt6GYt8j6iBMYvIDCDYJTKj5rcrpC/sKwM4g2e22m5tQ?= =?us-ascii?Q?iwf0prFvcbHtnDhPW5balScXwR44V/YlnPP7jqKtk9AtNbAOHV1SLkxcWc/w?= =?us-ascii?Q?CFHSXMX9gXhMDN7lzMhhJywXkoZpex8y/8f+1HRZn5OfXbv6a9nxqkEpjqAm?= =?us-ascii?Q?6OSyKjryQ6CZFZp/c2XpZAH/Pf54QrR0iEts1BbMxO7S9TVs4N/eR2JF53wn?= =?us-ascii?Q?kPgmKIudaor809pLihkM2lk3vTolyfJOR2IyYhMa0qj5U1H3Uo8uSfacanqy?= =?us-ascii?Q?S3I1Hb9giGL4W7rTFBIwz2Be9OLbIOJmySeK6gJ6DyAnCs/8/ZMvKuY+WgmY?= =?us-ascii?Q?kRLBuCGm4vpgmnyPKunEdFRSdCVX9GXBHwCl8alsjG0dqTJQJSX860TBK0hW?= =?us-ascii?Q?Msv/b7P95PlUUa7R1UWDzKk0imD5T5kydUwSSmeVUWRhqq4lnHaYcuwMiBzs?= =?us-ascii?Q?FV38JcpDcqRMIQaMUuePz0TCde3jbEtQRlHDFvXr8cN9w5i9G3uJ8bNw3dT8?= =?us-ascii?Q?39enTM6epsgXcwJm1T8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939eee04-8f29-47a4-1292-08daa0bdfa40 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 19:25:03.3954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1aHEgEqK1Z2K/alUkynopHn78uZmu3MU1dCd6m9jtN97IOP2mprtPyEaXsPyuyAzz92l9pt/vLdjaJoLMl8r5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4316 X-Proofpoint-ORIG-GUID: USB7UVOa6Wo8Snqc8qG4dOnxoXGWD02P X-Proofpoint-GUID: USB7UVOa6Wo8Snqc8qG4dOnxoXGWD02P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Have the sym sessions changes been tested with the dpdk-test-crypto-perf = tool ? I have not tested for scheduler pmd. Can you root cause the issue and send = a fix?=20 Fan may have tested it. >=20 > root@silpixa00401033:build# ./app/dpdk-test-crypto-perf -l 3,4 --socket-m= em > 4096,0 -a 0000:33:01.0,qat_sym_cipher_crc_enable=3D1 --vdev crypto_aesni_= mb1 > --vdev > "crypto_scheduler,worker=3Dcrypto_aesni_mb1,worker=3D0000:33:01.0_qat_sym= ,m > ode=3Dpacket-size-distr,ordering=3Ddisable,mode_param=3Dthreshold:64" -n = 6 --force- > max-simd-bitwidth=3D512 -- --ptest throughput --silent --total-ops 300000= 0 -- > burst-sz 32 --buffer-sz 105,277,1301 --imix 15,10,75 --devtype crypto_sc= heduler > --optype cipher-only --cipher-algo aes-docsisbpi --cipher-iv-sz 16 --ciph= er-op > encrypt --cipher-key-sz 16 --docsis-hdr-sz 17 > EAL: Detected CPU lcores: 128 > EAL: Detected NUMA nodes: 2 > EAL: Detected static linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'PA' > EAL: VFIO support initialized > EAL: Using IOMMU type 1 (Type 1) > EAL: Probe PCI driver: qat (8086:37c9) device: 0000:33:01.0 (socket 0) > CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_sym >=20 > CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_sym,socket = id: > 0, max queue pairs: 0 > CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_asym >=20 > CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_asym,socket > id: 0, max queue pairs: 0 > CRYPTODEV: Creating cryptodev crypto_aesni_mb1 >=20 > CRYPTODEV: Initialisation parameters - name: crypto_aesni_mb1,socket id: = 0, > max queue pairs: 8 > ipsec_mb_create() line 152: IPSec Multi-buffer library version used: 1.2.= 0 >=20 > CRYPTODEV: Creating cryptodev crypto_scheduler >=20 > CRYPTODEV: Initialisation parameters - name: crypto_scheduler,socket id: = 0, > max queue pairs: 8 > cryptodev_scheduler_create() line 138: Scheduling mode =3D packet-size-= distr > PMD: Sched mode param (threshold =3D 64) > cryptodev_scheduler_create() line 193: Packet ordering =3D disable > scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler attach= ed > worker 0000:33:01.0_qat_sym > scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler attach= ed > worker crypto_aesni_mb1 > Allocated pool "sess_mp_0" on socket 0 > USER1: Test run constructor failed >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Monday, September 26, 2022 8:14 PM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; david.marchand@redhat.com; > > hemant.agrawal@nxp.com; vattunuru@marvell.com; > > ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; > > konstantin.v.ananyev@yandex.ru; jiawenwu@trustnetic.com; > > yisen.zhuang@huawei.com; irusskikh@marvell.com; jerinj@marvell.com; > > adwivedi@marvell.com; maxime.coquelin@redhat.com; chandu@amd.com; > > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; > > anoobj@marvell.com; De Lara Guarch, Pablo > > ; matan@nvidia.com; g.singh@nxp.com; > > Yang, Qiming ; Wu, Wenjun1 > > ; jianwang@trustnetic.com; Wu, Jingjing > > ; Xing, Beilei ; > > ndabilpuram@marvell.com; Zhang, Roy Fan ; > > Akhil Goyal ; Ji, Kai ; Coyle, Da= vid > > ; O'Sullivan, Kevin > > Subject: [PATCH v4 2/6] crypto/scheduler: use unified session > > > > From: Fan Zhang > > > > This patch updates the scheduler PMD to use unified session data struct= ure. > > Previously thanks to the private session array in cryptodev sym session= there > > are no necessary change needed for scheduler PMD other than the way ops > > are enqueued/dequeued. The patch inherits the same design in the origin= al > > session data structure to the scheduler PMD so the cryptodev sym sessio= n > > can be as a linear buffer for both session header and driver private da= ta. > > > > With the change there are inevitable extra cost on both memory > > (64 bytes per session per driver type) and cycle count (set the correct= session > > for each cop based on the worker before enqueue, and retrieve the origi= nal > > session after dequeue). > > > > Signed-off-by: Fan Zhang > > Signed-off-by: Akhil Goyal > > Acked-by: Kai Ji > > Tested-by: Gagandeep Singh > > Tested-by: David Coyle > > Tested-by: Kevin O'Sullivan > > ---