From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0FB0A0C43; Fri, 8 Oct 2021 20:26:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A35FD4014F; Fri, 8 Oct 2021 20:26:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2AF6740143 for ; Fri, 8 Oct 2021 20:26:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 198G99NR015216; Fri, 8 Oct 2021 11:26:27 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by mx0a-0016f401.pphosted.com with ESMTP id 3bjs8nrfnq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Oct 2021 11:26:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZRfgmO0WZxZ9kGu/3RfDxlsJdGILNVjl4A/dNPvwvzsh+KuDR88I+IF9UXwPi7ERwNoKqB2i7p6GmXX4q872IEiV5KugMzgS4/Xj/X0LIPDrQ3C3j2RTvVKywZVVzZr9fJZa0ViolyZ24e7ThHiI4YJ0fmzssORQJbU0SFDsCbHnyT8QWWOcp/qopN45KFgdwzejawiWYBa7k8poIwtmMt3xIfAI+YCLluvSsfU82iRU41eyj+fscB1pETAwHtmZ07gBdb3tUsqPttf5OfnZHd7kuV0inGNCwPjx4zKnoWyzNE51gnY0v2NClspIV9JNWuas9nQAAEVEUuOcno3YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tlk4RgwtmFiOsScTry8Mp+fvdvAGbCZJhCJeREyI02g=; b=jEIothCsRr5vs6lOD+vM97ZfEpegGBI4ADQWNiyKwphCRvZNQOm59IOdyiPSlPBPVbyoyfblugi5V4Xre/DvD11BpZUNfRAe3mS7ukSvG74oJYdFZbNd10FdCzpxgh2+kDf+iaF6b0mWxOIEPSnnW+SKCjm8VmfVBjIQSrTnJfLxZg91aDsDNp9ZIWmV8X+Hwvz77pvHuZmLr2cVSigl/eGGsZl9TbsuIZADJSNasEO7UeMFid3lXM5PpYUpj3n+tp/Fu7AXy0s/OiUpYxKkVtDcY1PZaz1me/Uqe3x9FRLv4ttMUPuk5h5AEbZlDp5rbEnzhFTKkjnA5znTh9GmHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tlk4RgwtmFiOsScTry8Mp+fvdvAGbCZJhCJeREyI02g=; b=GnQt/U90PdzCQHgynh3e/GuMiodMqN8hhVPMn1X1XXz+RCa8uUDrtkStkyGbWEW7EakxqQoxU31ZHubPN7+ZtLXcR47oAzMta1ZotH01KkH9G7K2lMlb7z+if2xqCMzC1wMInSCLJNLp158DLWGv0B4YnbuZosh8woK/1itG7Sk= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4420.namprd18.prod.outlook.com (2603:10b6:303:139::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct 2021 18:26:24 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 18:26:24 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "konstantin.ananyev@intel.com" , "vladimir.medvedkin@intel.com" , "bruce.richardson@intel.com" , "roy.fan.zhang@intel.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "declan.doherty@intel.com" , "abhijit.sinha@intel.com" , "daniel.m.buckley@intel.com" , Archana Muniganti , Tejasree Kondoj , "matan@nvidia.com" Thread-Topic: [EXT] [PATCH v7 0/8] new features for ipsec and security libraries Thread-Index: AQHXtqsx4fei1Q7H6kuFWx5dl+iGn6vJdf7Q Date: Fri, 8 Oct 2021 18:26:24 +0000 Message-ID: References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20211001095017.3342431-1-radu.nicolau@intel.com> In-Reply-To: <20211001095017.3342431-1-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 622bc1dd-b057-462b-acb6-08d98a892269 x-ms-traffictypediagnostic: CO6PR18MB4420: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:569; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ss+1fhNnDg4IV36cKZ2QeLuY0EDapPcDO3sO8jOP1nAVdiDKA4ip1CkVHwCxlUQDYraebtwe4QEZ+7v14PBOGwrznkrA9R8uE+K4mt4DyXbtPD6ze363DOTs8bNXfB3jp3oN/nIU6FMkHtneQAHtg/oxi3S19MgkuccqXTesSJRS+B2T2NmImG3bkKljxOo3Df453OlI6+ID/lSoGMMQQShi5e/IpqeuC58oue6XJ02HUHqGhxHHBaHoCAOLaAg5gs7aofrzrRX0U0x8ZNI/9LqWISR08kawNEBJz6/JENPdO1PD4SotVTYrzyxPY8ozzxT0vANq+xZY/bazk7L2mKosnH8fzcrXVebK455ZLFOV6votZktmfm/7+eu4RJJTo7dUau44rmLMlHtCIMFdUS1jm0Y1jkDA5Wh3nlJJYiTFOR7+Nq4AhXw7PUS+zZQVvDgHLXZUG2zdFefm7m0MUtQfa0UjcDOj9tH9k3r7y968A5M9e/OcwFaawuwAohjQ7mIw8Fa5FbYR1sj8S8VMt79PO8M3gQ/djp1ny4oXTEm9ynPvzQYiHlXCZn2U3hR9sTi7D4U7uTUo2I4IXIMOTEWtsobUtZDYINj6m2K5ZEJvg4Qr4jQ7W1hX0GNjGmcVftMhxBzu4vn0DIiYIqDmaSU588SifemZo61FYo1DWQ5Oyn7E0lmm4BQk8K7PXmQ/FRuVxPWCP8yIP+lUxaZvTw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(33656002)(4326008)(2906002)(83380400001)(5660300002)(26005)(8676002)(86362001)(38100700002)(55016002)(9686003)(7696005)(122000001)(316002)(71200400001)(15650500001)(8936002)(52536014)(54906003)(6506007)(38070700005)(55236004)(6916009)(7416002)(66446008)(64756008)(186003)(66946007)(66556008)(66476007)(508600001)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6c3tzKqeuAiwiwfix1jyNTlmCzT0SK0mDijOfgru4rQShvtQ/seSEcQxiWZ7?= =?us-ascii?Q?zndONel917iajqx9UPnlsTmhSh6g9DJ/h/SMYjuwFjNUoGKca//5okcBXj6W?= =?us-ascii?Q?OcJSG7MOafYEgM/KMfVIIsd93HZpQ1f4DgMmcvUpvUNhGkR8MAe7cYKwNqj0?= =?us-ascii?Q?J9fHn3B23SrCKF1kFl77Cm8fQ4aXREUJ+2nACiP4UYil4vCGJnnPVjmMQbw3?= =?us-ascii?Q?rQBDMtvkYojahOvICZvxEpLtGvqZwYGEnOVuFefb2zkqmz+qBspgl8brzlyD?= =?us-ascii?Q?OLs4imkPqSkeQQ1zccOsC1N5p8mBXYN66YROdtvAspP87BVdsiJWomKrNtXg?= =?us-ascii?Q?y4q4tXB+FhLX8gikzxXI9rkiylST/PQFeVXDl7SB63S8Q708URfeOp1G8wLL?= =?us-ascii?Q?4f4jXK0kShs7w1dohICds3hZZzIgk6bXq5pPG2+7pDSuWNB4LnxROIo+62oJ?= =?us-ascii?Q?185y/KZ1oS0kD64wxXHU0RvsACQRQirIaGsx1B2xXhO2V0uvLmNqM3e9L93s?= =?us-ascii?Q?wqblb898JByy1YZw8wdwx1WZqiyaizHN2OuEq5CV4vT/n1AhsTZlcwX9yDmI?= =?us-ascii?Q?xrWGDF0oLiAPi7CkSsGB40m+DfbCtdNoW4Y8Ubx2q0mpuY70VTUEUzYuhAAc?= =?us-ascii?Q?kLgwND3xphKjeBm+/57JdiEPSD53LwN7qHlsjmD7EUZLdou9I3fnWYvc/awU?= =?us-ascii?Q?yxtHfrL3EFLGDZLs5mvlcO0iCFtkgor6j+cFciaIx3+YI/QGrpaLoIKJOIe4?= =?us-ascii?Q?/Uj9PWrEmiMV/8Xg0+ESLPmtJdaaLjxhltLHTQEBINPxduhIfrJWqA4eRt9J?= =?us-ascii?Q?d0vEai1loFF2dIKbxvdti4R0VZwjkeXQQRyzlAOVk20hrFLMfxiU++2Vbdw5?= =?us-ascii?Q?xgCzK2zgiO4pB7nFZOYSY6yOUzKcddXlUqqfPjBcXrMRCwIivlpP5Cbri3op?= =?us-ascii?Q?rlR2fmBHyEacLr3ZJCb+Iw0AXcSWx8Tpi9P3RqqAiw+zjN5OuvXkk5VZOFvy?= =?us-ascii?Q?lo1CfUyXuBEHtiygw5GsKj8C8O+wruMoyU3rNeilCPvoqq5abpEl7zE0tYCc?= =?us-ascii?Q?Zurtljy8GB6Ehq9JDm6D+w492z4yfFVonucY/Jx69i8VSAivzV7AhDoMq9b8?= =?us-ascii?Q?+aaUkjS8bYqvvBcOrhdDBSEbtkOO2KeD2wsQbmIwuOHCZQbevmZKesLCB4fi?= =?us-ascii?Q?ApzWDdlkNTbZZ9Uf3NH8ikxYJgAgoFLAbuVq8ij0C90cfFu9mlFlgv9JqJBd?= =?us-ascii?Q?40DakzjKw3S/LPtQu3SABB2aBB9WTolA6p/3gy6SYRVXghaWT9QvhX0TtprC?= =?us-ascii?Q?4wOUFdTa2LDFdI8vBYF1Qi0W?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 622bc1dd-b057-462b-acb6-08d98a892269 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 18:26:24.0775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: COxDT71PG6y5Q42nerhAfpauwOggG/hjnsZh7vg0i9y5ijjGLodqDsIhhM1YLCfZSfsLRr5h0BA+7F6p+WE47Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4420 X-Proofpoint-GUID: XY77coAHqonpJoM7TJq2Q6vbUrjEtp7R X-Proofpoint-ORIG-GUID: XY77coAHqonpJoM7TJq2Q6vbUrjEtp7R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-08_05,2021-10-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value >=20 > Radu Nicolau (8): > security: add ESN field to ipsec_xform > ipsec: add support for AEAD algorithms > security: add UDP params for IPsec NAT-T > ipsec: add support for NAT-T > mbuf: add IPsec ESP tunnel type > ipsec: add transmit segmentation offload support > ipsec: add support for SA telemetry > ipsec: add support for initial SQN value >=20 > lib/ipsec/crypto.h | 137 +++++++++++++++++++++ > lib/ipsec/esp_inb.c | 84 +++++++++++-- > lib/ipsec/esp_outb.c | 210 ++++++++++++++++++++++++++++---- > lib/ipsec/ipsec_telemetry.c | 237 ++++++++++++++++++++++++++++++++++++ > lib/ipsec/meson.build | 6 +- > lib/ipsec/rte_ipsec.h | 23 ++++ > lib/ipsec/rte_ipsec_sa.h | 9 +- > lib/ipsec/sa.c | 117 +++++++++++++++--- > lib/ipsec/sa.h | 15 +++ > lib/ipsec/version.map | 9 ++ > lib/mbuf/rte_mbuf_core.h | 1 + > lib/security/rte_security.h | 15 +++ > 12 files changed, 811 insertions(+), 52 deletions(-) > create mode 100644 lib/ipsec/ipsec_telemetry.c >=20 > -- > v2: fixed lib/ipsec/version.map updates to show correct version > v3: fixed build error and corrected misspelled email address > v4: add doxygen comments for the IPsec telemetry APIs > update inline comments refering to the wrong RFC > v5: update commit messages after feedback > update the UDP encapsulation patch to actually use the configured por= ts > v6: fix initial SQN value > v7: reworked the patches after feedback >=20 Release notes missing. At least some of the features deserve update in rele= ase notes. For ipsec lib add a main bullet and then add sub-bullets for subsequent fea= tures.