From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51A9B43EF9; Wed, 24 Apr 2024 20:22:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCE30435BE; Wed, 24 Apr 2024 20:22:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 90E7640689 for ; Wed, 24 Apr 2024 20:22:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43O8VvPT011632; Wed, 24 Apr 2024 11:22:00 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3xpxn19xr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 11:22:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSaVGMKkbTjtCKjniisEvHW3woAMwGi24JDRJLrhQ/99a687CIFUgaezl1dHJNU1SMDYVjWCxu16c1goJpIdWYaanP5kIiBPSaq+YUxcrlXmm580D3lB6be/Vpc/5UQi0vljlA9vPRt0m/d7T6o/+mi04cFnqldVhjyr8IaQW2esv6PplOmqu5/sONrof83B5tMhHdOOj/e6Vs/6M6qZ0f1Yhk9kV3d4oEOtw7HJI/8uw74W9DTTDtLkygD5Kaawki6GxR+hC3iJ6hoRk3I3Bh7RjOsiEH6MQK6wdtyDFWecPsklbaMq87efMN5H8j/38v3SyOLUqUxj//t/LKaPOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1G2COhs6ssyL990lCvAXgfUyXUZgZ6zUjTdZWjOEtg=; b=BqjOXcyDFXbVoKNUZ2FqB2SRyjac/Xf9QFlQTnmIm41CEaU1n9XL9J/hdTKWCRnD+OZ+T0NaiC8WxeX6mtSHNMYXuiyXXfXCIfYrUzjMPXXkHHEoHSFvDvCdB33z28zYdHPATLkZqwC+nR3xo27crX1AgT6ienTK2bcjVb1i5ZNINMGoNQDOwhLwFrDWQ7rhbDVqj/4UVN1qfxn2iflsBDUVloZ95bwlE9MQAMJk0ZZLkOhrZXbNz+nmDGn1ct9Kz+oXZhmOrT8w9ZGmGMS+4vt1CqauBlJSZfNdWeYwhEgmOql9nFPl1QrQ9YQHiNr7ruCBDCutiWvAh0aK7J2/Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1G2COhs6ssyL990lCvAXgfUyXUZgZ6zUjTdZWjOEtg=; b=cryHXbtEFkPW70tu0ep6IHX1f8AI5wwiDlCm7jFpF1FmYsVImzZkk8OKtduoiPm+geo2zHAYTBLi0E6RyHaE6ChUatc7kwlh91pah+zEcnTApCtj8u8S1Dk7yle58YeK4HufJGTq7IBBLx1xXu5zIABZ8MuFM1L94Xg8r2h1yIU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB3826.namprd18.prod.outlook.com (2603:10b6:5:347::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Wed, 24 Apr 2024 18:21:56 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7472.044; Wed, 24 Apr 2024 18:21:54 +0000 From: Akhil Goyal To: Andrew Boyer , "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH 0/6] crypto/ionic: introduce AMD Pensando ionic crypto driver Thread-Topic: [EXTERNAL] [PATCH 0/6] crypto/ionic: introduce AMD Pensando ionic crypto driver Thread-Index: AQHakpNFwbAJFLC8ukelJiXkXYxtybF3vybw Date: Wed, 24 Apr 2024 18:21:54 +0000 Message-ID: References: <20240419195310.21432-1-andrew.boyer@amd.com> In-Reply-To: <20240419195310.21432-1-andrew.boyer@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|CO6PR18MB3826:EE_ x-ms-office365-filtering-correlation-id: dc474bf4-311f-4bf5-0f3e-08dc648b6b5d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?YcA2JDCZ6aKIQg2wM0dFIc2me0IvbYd7TUYdBPfzGSF0dDaqaBjJkLRC6xjX?= =?us-ascii?Q?nZrDAQj+NN0628IaeJxKKqoPJHhwp3DWY7KhMDNdPSy+c0oL9G7fDVRvhC5b?= =?us-ascii?Q?45pRrRFosiqyw1mELAQK4BRlmtoGy+6cKCR7cPJ5Pi2ZfwwvgsDp0eG6j8rm?= =?us-ascii?Q?/3E4DUPvlmgGvpEGrJm15b6UW4aeB1zHnsmLwEfq153QrKCoFDwZqMrhlwzV?= =?us-ascii?Q?vHoerb3r+vMmHHk60YIrAQFVf+a4G7i9bvuYFMcdDTKOXDuRDJJIXtC2NUKX?= =?us-ascii?Q?si04KAZmbNQM790XjVkcUOwJl1evPHA5f3GSVv0YjyOXDmoYe1zJpM3MC8QV?= =?us-ascii?Q?3Rw3wj/XoZSEmfBMYjrO7EI3HGs9Jz3aVIFZLHDwBxYmD2CvzHWgcNB03Puu?= =?us-ascii?Q?+XBCFifV9vs04Q7WE5k7tViDaeK2DOUpG5w5VsnrIgNPIEiRLy04vc+/1FtG?= =?us-ascii?Q?VE9XMuhLSZ/ENg8Tmr9QGlKEr7xdsuIUzb0yycx+avhu3520lxu8Q+uQJd0Z?= =?us-ascii?Q?nbtWGR5XslOAtS79jBROFTHu2UZZXg8W/Ee66jnwJoSBimksSUuInuZypha4?= =?us-ascii?Q?ZkxK0M2BymJxnU5xcJDoKrmLjE2xJ2muDA4G1pr6h96ZUITJ40pWRd/gbt37?= =?us-ascii?Q?pDPZ7UwoShT/C07EqkNXzwPW/swIVXYpZjBVjjni0Avj6olfMG81aZsnqrBP?= =?us-ascii?Q?aQI1jhkTtAZIAbOG8J9jE4d4RQkNCyg/9WvpnbfdnPvcBIhG+LY0iY+MFEqm?= =?us-ascii?Q?gQ19zZ/DgQi84ImyVZEEuO3AQZQkoyjLqvzrEQBbxcp81qrF3tdCjm2yAKT7?= =?us-ascii?Q?Cb5TnkhY22Udvi5XwYs+cDysy0BXQimLIowVdAxen4qSPTLblVwc7TlyNUEo?= =?us-ascii?Q?isWDChLwLKz8cG/sxRoE1aj23AWUVGZ/+vpZ1vm0C0jLIIyavwDtyUGp54t7?= =?us-ascii?Q?dgAGHh4KNKR07E9hOHa+Br7yQSM3daJfOcx82jr7f/ovG1nx+u0gFOpxoEMk?= =?us-ascii?Q?JmqbpTv3xZR7RbnRqtoHGsJvTWT0ftXC6YJv2qqwDkCnWly4cGzGiImiDFI9?= =?us-ascii?Q?AXPn9xLEctXLYdtbNId6l3m+xwcrK2lD/GWgnkK2VSKAtHCv2IvJ1ZOfn14F?= =?us-ascii?Q?iwc7p/r+wfxHxMg1G8zWjj6X/ufa5zu0XyXr5r09qvosTYtAzSdwlL3zlGN8?= =?us-ascii?Q?hXyjehIIBkH2veBqBvhPaSxZlGbm9YDnxzd6gn2Hcw1ZdY+m4jTLO6NAdxbh?= =?us-ascii?Q?6oIgRUR6NTF4TdJZVcJ1jR2D79jrcNQUl9if1bkix0dGPPR/nV4PuErNJRYt?= =?us-ascii?Q?hnSKuvYKpuWGrP6SdfZCTytn9RMYhLQPfYZL1piZqvCuqQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4NAvzBy0MkIwE8zMncaPYRV8Lu1tJVi2NVd9GTkCuEkVhTkNy7xiVcb5PhYQ?= =?us-ascii?Q?DWgOb2syLiMFzpE5DHbS3IlUXINcZBufWALdc2Vn+TaM6nUbRP7bXZttIRDv?= =?us-ascii?Q?PNfRV6yalK4U7Xo1qWXAJaJpH3lO3SmEAw7w3LECnenaU0rdVNnj0PA36u64?= =?us-ascii?Q?VfEqOgedgOIBF9px1qd40+17A+o3EyD+gFER9002g3xz1uQplCd2lxLWZwTQ?= =?us-ascii?Q?ZZm2GQLey7rMSv60kjDnbqOVtSczRcKbtGtRfnRuQy5VvyPr+fXxNG2vjq+d?= =?us-ascii?Q?63T9KpMP9pUHHUJVdU9gIIi6G0f9vzaGgYm7h54poYh69Po1ZQN/VTmaRuJQ?= =?us-ascii?Q?qSK5SCYN/53Zp9diZddVmXpQ/+++k/TUQeL9BXSiH+4qUX6mP87olDYLAbON?= =?us-ascii?Q?pEOp6brqcMY89Pr0j7FV7ognmijAyOSAFGhriEpXLJSL52COjSJxQwlZ8yrO?= =?us-ascii?Q?/VMb9txzrWgm/rsRAcOU2T7SvDZFAdf0wpXauQapp++U2XMNLWBsfTMI1RFq?= =?us-ascii?Q?7LB4Uw7XPN88pHnPl7BtdnDhKp3TW4XYZpo/bkuRohy8l8Gus5wvvLzuUhkB?= =?us-ascii?Q?LE2g4vCso0ckA163BfJatS7G3t1+XHqS0LmXB/t2INtt0QxBhdSRSpW5gpHO?= =?us-ascii?Q?qD5CDFB5AqeveKjuOQ4yjE7oeqrLvUJY9E3TtlouzkoC/cyaLesE21EPY5Qq?= =?us-ascii?Q?tp775cmCtYu214QJxmbVrUz9VxWIENHp4fXwnT3bwIjudh5X05sh3OaRTpMH?= =?us-ascii?Q?tVlVUDnGLbp35LowP4WtH9N9gc3EUKGC/E3Fi0Jy4Vn1DY57fOBlgie8kbag?= =?us-ascii?Q?G72or63dmEUIHCNmMu+hlia9iQWyGggoP3x6qxw++41qopeXbPAc0YCioNse?= =?us-ascii?Q?DxqHr3Q8ai/yb9vnYLMxw8pOVd8ROBiJ5U9B3vq+eEp/Yd2wmCVJ1/PdCcAM?= =?us-ascii?Q?3Ij2mRzM6Tm/JvoFZhBowjLu1R8SoKQRcyfq6zgH2Dy99Jvru9CVQpsxcl25?= =?us-ascii?Q?Xuw5w2C1VGWW9OtLkXD/6OqD26+jc276TeqoWuyZXBX/i7AgcKDZHbxXxOL6?= =?us-ascii?Q?ZDXlsEtIrB8fAGYIwycKZ/J1xb4XFdw1+a7x6eKcY2sfl2UyEM+h5CWtLyQ2?= =?us-ascii?Q?Cp3z/YrXRoN2WOCq6jCip5G5qhuRNIcaD9EiyOxpVXnygjklmMtN35zs8yVt?= =?us-ascii?Q?7JJ9/+zSd+SPViHK1vjGKgsk0jlI1qMcvuAjCwBYs96kfFDR9r6kDSSN6iTS?= =?us-ascii?Q?hcmmphYF2InzAXAhS8ObkuCYiCP+eqIX1TwuzfS/jEp5shxrTT1LqffSt2Df?= =?us-ascii?Q?hzqKzOjSrrHubZ9a3za/UkqE549Ja/tHa+PRUze0XulCXagFbChg7eTXPOq6?= =?us-ascii?Q?gyjz0mHNFMi18HRNQL/J92eAH0DdEDz5AqVPancZhcbZ4CdnWMBdWzQ4LnWn?= =?us-ascii?Q?M38l3O+oTYveX8+ATJwheNMK2HQGs3we6vp5vsFRSwsYXE/b5ZPQaDMJbkCy?= =?us-ascii?Q?L7W1Dr6T5p5yw51cNbT5cHBUB3Gp/kzhOqJjmwaJtLr4rdxFQXDLuybaFsGa?= =?us-ascii?Q?tHLMS4rhgFy4t1aYof8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc474bf4-311f-4bf5-0f3e-08dc648b6b5d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 18:21:54.3680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GIKEFaVVPgSfOD6BObBH5vxUmrhIU/EuG5luYqZvbPxUnk36/7FmoNmGMUwZAyZR5HQ0XgmyD9kWVRejtlvmSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3826 X-Proofpoint-GUID: ODooyTjHYwKuOQ5ka49jUdrsqMX8VJvU X-Proofpoint-ORIG-GUID: ODooyTjHYwKuOQ5ka49jUdrsqMX8VJvU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-24_15,2024-04-24_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Andrew, > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks. >=20 > Andrew Boyer (6): > crypto/ionic: introduce AMD Pensando ionic crypto driver > crypto/ionic: add device and admin command handlers > common/ionic: add crypto vdev support > crypto/ionic: add device object and vdev support > crypto/ionic: add datapath and capabilities support > crypto/ionic: add documentation and connect to build I did not review the patches completely yet, but the patches are not organized properly. Your 1st patch says introduce the new driver,=20 But it is just adding a hardware specific header file. Your 1st patch should add the base framework of the PMD Which is compiled in the DPDK build system. You can also add some part of documentation for introducing the new driver. MAINTAINERS file should also be updated for every new directory where it is= introduced. Once you have the base probe and remove added in your first patch, You can add each of the driver ops in subsequent patches. You can break queue pair related stuff in a single patch and session relate= d stuff in another one. Capabilities can be a separate patch. enqueue/dequeue can also be separate patches as well if they are big. Add documentation changes in each of the patches wherever needed. You may refer https://patches.dpdk.org/project/dpdk/list/?series=3D17483&st= ate=3D%2A&archive=3Dboth >=20 > MAINTAINERS | 7 + > doc/guides/cryptodevs/features/ionic.ini | 40 + > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/ionic.rst | 39 + > drivers/common/ionic/ionic_common.h | 2 + > drivers/common/ionic/ionic_common_uio.c | 48 +- > drivers/common/ionic/version.map | 1 + > drivers/crypto/ionic/ionic_crypto.h | 361 ++++++++ > drivers/crypto/ionic/ionic_crypto_caps.c | 55 ++ > drivers/crypto/ionic/ionic_crypto_cmds.c | 651 ++++++++++++++ > drivers/crypto/ionic/ionic_crypto_if.h | 1021 ++++++++++++++++++++++ > drivers/crypto/ionic/ionic_crypto_main.c | 993 +++++++++++++++++++++ > drivers/crypto/ionic/ionic_crypto_ops.c | 606 +++++++++++++ > drivers/crypto/ionic/ionic_crypto_vdev.c | 128 +++ > drivers/crypto/ionic/meson.build | 16 + > drivers/crypto/meson.build | 1 + > 16 files changed, 3969 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/cryptodevs/features/ionic.ini > create mode 100644 doc/guides/cryptodevs/ionic.rst > create mode 100644 drivers/crypto/ionic/ionic_crypto.h > create mode 100644 drivers/crypto/ionic/ionic_crypto_caps.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_cmds.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_if.h > create mode 100644 drivers/crypto/ionic/ionic_crypto_main.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_ops.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_vdev.c > create mode 100644 drivers/crypto/ionic/meson.build >=20 > -- > 2.17.1