From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEB20A0C43; Fri, 15 Oct 2021 20:47:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74C2440041; Fri, 15 Oct 2021 20:47:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id BE1634003C for ; Fri, 15 Oct 2021 20:47:16 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19F8qV6x021806; Fri, 15 Oct 2021 11:47:10 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by mx0b-0016f401.pphosted.com with ESMTP id 3bq6gta6sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Oct 2021 11:47:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/QHSUpPwEHeapqzoG3eq8xcrvhjfkbmPNsBeWX2LmnZ3zSw7kC2MfOXBcH9azLrR7+EiEN6FBSrY/am6u7ZnvxN45c9+VJfCA8iK7+G6BDiRaHpQ3jb3Fch8OELhObeqD4tDCb7ilQVpoeeumTNEamaRWdsueNNC1/Ix0JdawLkXj56dS9TwF8+yIaIMGdmuP1zCxtPeM2pM+X2UaJRSY1eIc1B4xoWqwpZAMqO1bKaeX231dRQd85vp92SpZ4mT5MO6ZYKgZwGceImhav80uG48GNC7CiaWHpdBXnK/xnpVeavcchnj62Z61aBvnXzryokcXnQI6DuPqlHc6oZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qsBs24GZx5f/zDEGEk25NFb6BStu0hq/siMs77ujCKc=; b=Z/NKXvBbsnLXkGBuoWZJ6bgzIMWC+ufzrq4+RMxhQrAplO37f82J8I0tLOhLxKNrjd+BkJSjeteCFvk9Zq3efPZ7bxxRf0qG0xleQELzuM91rrh5vBZJQS+dDuvn88lM27BZ7liXjmARp2mJ+rA9tW4jsPV99nqe1WAz+ygUo/+yAlbIvo/K/l41qAfD4kORkTIS2+wS5XzObC/zWxVcH5GRfgef9pzj/WHtlh54waQAeVjCIe4KEy8yuSXaZF6/DTgk7yiYx/fnK+wiDqKrYeVQm8NW4CK6eW/i8Lm6DVTKjGZh73BG7D1ZuXt9t244TuPcni2YGmdWW/v5HjX/yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qsBs24GZx5f/zDEGEk25NFb6BStu0hq/siMs77ujCKc=; b=sOXHgbmXgD2ZueBBT8asxQXL+XWIVGn8SjpTs2CxQTf9WP0pCvUydCU9Mc92ClHKvm1DSE0OnCNRPSXr9MMSaqSnqmQl1CuI/ATmP5WdEqh1uFMM2GYx7nS4qyHyVaIYavM6qso3iJsnQ5lRARfptVvCn+TRFIxYY3M5M2XJ/nQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4778.namprd18.prod.outlook.com (2603:10b6:303:ed::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct 2021 18:47:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 18:47:06 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGetv1shlNanEkaGEWDxUt04X6vSX5xQgABbf4CAABT+AIAACUMggAFZ5oCAACF/cIAAEBow Date: Fri, 15 Oct 2021 18:47:06 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9af9e6b4-3117-4d0e-5ff5-08d9900c2ff7 x-ms-traffictypediagnostic: CO1PR18MB4778: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CjG1JcC5vz+dyD+f7pEbRxxoGed84SlgHF6bTo2o3DiZBIfWGThVv6YohJiFmqfkEWYawYWRq1gYe5Om8nTrnbop8A/stisZ6yn0qoel9+dWthF+ackuKE9PHEhLTdN5kB3h1w4peioPE2Lm1spSdvsh9/bRvkYhUjwV7CNOF4OkE61yU9dhlRXxuAAKP7riGpvytTWeFpOV1gpcSgGtyaQ/xig+defP1jGnUTVmbrjbqxsZoAEDYy/1gZZuhEE0HzUQy/e04uS6vBUFOAguVZHILAdxjqOzP9hA7wXbdn6603mZI1E9yz7w5eWQ/SfpVcO5EgYRdxIVWw8WAx/cSdax4pt/HtDUQNN7lB2J2BS1LaA/zwYRmKfCdUtg7KKcWpWsyydT/g5dBcZrSz89yN2yee7MozDZBQjDDSVVusDlJ4wAxGZF6FgAFL9OOrfH8qqw7g5ANbwugPrBOoOuNajzrM5nBGh9z+uMw3eKb2SDMHQ98TzyKUtHXW4JS+iza7g+1tzrv0nZEAoWzEU/2Rc9t6SuWMfjxlbZNI4Ajh4aqG8akCJtg2N/dBQvK/BnF0dXD7OrWB/XbHHIvihnio+Dxlw+aa4uPNBB5O+le3yedjZFfy2TIhuqv6vmKkJhUFRs3qwbLaPPje4lt2/8bnTkxRU/gcxW9GVqoQivMcRTfkiObWC3w5oS3NG5N8dOnjG5jNs6jKIcZjmf1+QFcw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(66446008)(76116006)(66556008)(64756008)(26005)(33656002)(71200400001)(2940100002)(110136005)(54906003)(86362001)(66946007)(8676002)(66476007)(52536014)(7696005)(8936002)(38070700005)(122000001)(186003)(508600001)(55236004)(4326008)(5660300002)(2906002)(7416002)(9686003)(38100700002)(6506007)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pGDJQWe1WE3ywSyt7h9WahxxMs02qDR13o5RVY/I2CbCcLN4xgL3FT93DgDF?= =?us-ascii?Q?BtPHdo6rNHp6iNYM/pIlb6mMH1JyV9JRKx6Jz1EyU5IolTsy/Qt9R54f8ayY?= =?us-ascii?Q?7/Jx76I5dmFGyBbbMpFRUtxI92Y7D8S1h1crT1MvEATHyfLxXqiRFkAqDyk0?= =?us-ascii?Q?Y3KJJ15/tz/o9dWGYx4ucMiw2WwAgd1L1uFQFIFsMNiCtQkoXw/KYJ03+Yor?= =?us-ascii?Q?2XphpAgE2wn0lHalMncL1Dhgsv+ezcTclRzApWOGmlWNaqGHDPXb2zKWKkjK?= =?us-ascii?Q?Coa/majaNdUmSXcIoAwJ48r2E4z0HJ7WduJd76klG4pYP0VArGDs3/GLnq83?= =?us-ascii?Q?agdBcDGL7AcEm17T5sGayg08Yauu9hO289U9ASk+a8/xBiCiwdTsye4GiUOp?= =?us-ascii?Q?l3MwkIjP4cueVIWSQsGwxhKlS+SRzEFx5VeIUZnVsCheA7EK53M7o6mERh/r?= =?us-ascii?Q?Onlcl71lKXtg3TNnXxofYzlSaJgaFNnQPvMqIgll9VD44HEbJ4ZzQVp/yWO2?= =?us-ascii?Q?iLcUat68n/kNyU51BngZ6DK3NsVQnTZo1aRKVhMHu9Jj5MROQt4ophQiKM16?= =?us-ascii?Q?3UD9ufbu91Vdw0PD+Kuipb8OxfAUp3T4hDyNN7MTI8TpZk8YdoW3ablZcjXF?= =?us-ascii?Q?GZrz6e/I6izM1W8a4nNp4Pg8zBvg/dbyMddPQ7BYFU1nwrbsCdc5pXS86OKX?= =?us-ascii?Q?1vgbouYRwHIcVb4wla6HsUXH74PtSqmA+eFy/h3cZAY05x8MhBa9XinPw/UL?= =?us-ascii?Q?RxdZ8Sp4D3T0I3hXhTUf+Nlrhhj52txwboAdO/VyN2BLTOCsvmIAMDFHa9na?= =?us-ascii?Q?OJeRlEp5MIfph89JtmrDuPYIUb6IO9m6XRQQGPhsLUsrPB/alJIe2OBoFhWL?= =?us-ascii?Q?WR4YRtGuUAetUmQx/ymEbxtwCLlSvWcgRintxEbQJPTOpVjsPJkXpyWmvT8W?= =?us-ascii?Q?qLB11PW/90crliVWdd/b+99Wpg41poULNOmvTH9CtLNyfsvLdfM039VSMp2T?= =?us-ascii?Q?HQctG2Zzr0y9aZFAeUTQdTJYhQBQRV1cbfYo+ob8CTG5ooTY9voLjHDm7R19?= =?us-ascii?Q?qgLVcklgmtlyhcaURvtO14b8mncZvl0F4xQmzd35Sppxse41TK/+aAhg5dZm?= =?us-ascii?Q?eLnkz6LgRorRD0k9NBWGmLB9Qc1DuGJEK2WO4TzNozklzDWMgRCvsnchcigp?= =?us-ascii?Q?3Gwc/pSyVG0zW74uH40R5IV1q+oHleED5P/kLzrPuEMXSWNzN3k6jglECS2m?= =?us-ascii?Q?3AzC54iyrMxd592sAK3H+oM/2ePz3OJrI2+GfKm8ypJ14EsLT62N4ElI08FC?= =?us-ascii?Q?rQmLX+pVNsxm5HWPSOMkAN1B?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9af9e6b4-3117-4d0e-5ff5-08d9900c2ff7 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 18:47:06.6034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XDi8SRzUGC3iN4z/wEQe5KzamMwmvh+jQgG55c5Rtllxpyv9rmGlfYRQAVKiF0QpWV4suMV0me1iJDaxLJxF2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4778 X-Proofpoint-GUID: eYo1-Ae0hli4XM_VZzAhu4FxpCZCtLqM X-Proofpoint-ORIG-GUID: eYo1-Ae0hli4XM_VZzAhu4FxpCZCtLqM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-15_06,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Hi Akhil, > > > > I tried to fix the problems of seg faults. > > The seg-faults are gone now but all asym tests are failing too. > > The reason is the rte_cryptodev_queue_pair_setup() checks the session > > mempool same for sym and asym. > > Since we don't have a rte_cryptodev_asym_session_pool_create() the > > session mempool created by > > test_cryptodev_asym.c with rte_mempool_create() will fail the mempool > > check when setting up the queue pair. > > > > If you think my fix may be useful (although not resolving asym issue) I= can > > send it. > > > Is it a different fix than what I proposed below? If yes, you can send th= e diff. > I already made the below changes for all the PMDs. > I will try to fix the asym issue, but I suppose it can be dealt in the ap= p > Which can be fixed separately in RC2. >=20 > Also, found the root cause of multi process issue, working on making the > patches. > Will send v3 soon with all 3 issues(docsis/mp/sessless) fixed atleast. > For Asym, may send a separate patch. >=20 For Asym issue, it looks like the APIs are not written properly and has man= y Issues compared to sym. Looking at the API rte_cryptodev_queue_pair_setup(), it only support mp_session(or priv_sess_mp) for symmetric sessions even without my changes. Hence, a qp does not have mempool for sessionless Asym processing and looki= ng at current Drivers, only QAT support asym session less and it does not use mempool sto= red in qp. Hence IMO, it is safe to remove the check from rte_cryptodev_queue_pair_set= up() if (!qp_conf->mp_session) { CDEV_LOG_ERR("Invalid mempools\n"); return -EINVAL; } Or we can have give a CDEV_LOG_INFO (to indicate session mempool not presen= t, session less won't work) instead of CDEV_LOG_ERR and fall through. For sym case, it is checking again in next line if session_mp is there or n= ot. I hope, the asym cases will work once we remove the above check and pass Null in the asym app while setting up queue pairs. What say?