From: Akhil Goyal <gakhil@marvell.com>
To: "Ji, Kai" <kai.ji@intel.com>, Yong Liang <1269690261@qq.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Subject: RE: [PATCH] crypto/scheduler: fix incorrect variable usage
Date: Wed, 9 Oct 2024 08:59:49 +0000 [thread overview]
Message-ID: <CO6PR18MB448492A3B7AFAD4A65645E0ED87F2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <DS0PR11MB745859953B6C40115240D92F817D2@DS0PR11MB7458.namprd11.prod.outlook.com>
> I'm not see any issue with original code, can you give more details about crash so
> I can try to reproduce at my end.
> cc kirill.rybalchenko@intel.com for review
The details are there in Bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1537
>
> ________________________________
>
> From: Yong Liang <1269690261@qq.com>
> Sent: 18 September 2024 15:15
> To: dev@dpdk.org <dev@dpdk.org>
> Cc: roy.fan.zhang@intel.com <roy.fan.zhang@intel.com>
> Subject: [PATCH] crypto/scheduler: fix incorrect variable usage
>
> The variable `pending_deq_ops` was incorrectly used
> instead of `pending_enq_ops`.
> This causes the program to crash
> when the worker PMD accesses the session
>
> Bugzilla ID: 1537
> Fixes: 6812b9bf470e ("crypto/scheduler: use unified session")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Yong Liang <1269690261@qq.com>
> ---
> drivers/crypto/scheduler/scheduler_multicore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/scheduler/scheduler_multicore.c
> b/drivers/crypto/scheduler/scheduler_multicore.c
> index a21b522f9f..70f8a25b70 100644
> --- a/drivers/crypto/scheduler/scheduler_multicore.c
> +++ b/drivers/crypto/scheduler/scheduler_multicore.c
> @@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev)
> worker->qp_id,
> &enq_ops[pending_enq_ops_idx],
> pending_enq_ops);
> - if (processed_ops < pending_deq_ops)
> + if (processed_ops < pending_enq_ops)
> scheduler_retrieve_sessions(
> &enq_ops[pending_enq_ops_idx +
> processed_ops],
> - pending_deq_ops - processed_ops);
> + pending_enq_ops - processed_ops);
> pending_enq_ops -= processed_ops;
> pending_enq_ops_idx += processed_ops;
> inflight_ops += processed_ops;
> --
> 2.43.0
>
prev parent reply other threads:[~2024-10-09 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 14:15 Yong Liang
2024-10-07 10:35 ` Ji, Kai
2024-10-09 8:59 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448492A3B7AFAD4A65645E0ED87F2@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=1269690261@qq.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=kirill.rybalchenko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).