From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50BE7A034E; Tue, 22 Feb 2022 19:24:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31F1340DF6; Tue, 22 Feb 2022 19:24:03 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3DC9540DF4 for ; Tue, 22 Feb 2022 19:24:02 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21MGu0a5025483; Tue, 22 Feb 2022 10:24:01 -0800 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ecw9y2aqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Feb 2022 10:24:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0M6jbyejab08i9IrpyxMHYKD2c5I+7k8/jSSmzi2q3iy0zSrMTIAy4WFuZVLqoKp7FPE5H0GNcLFj7OJxWRVCEtmdJtmfha+GKtrwMTFfxs679A1k1x+ZxmZAsPhdc1201GgBSECB2QMSVTVWUyJ0bs7pQ96ND2UjzMuy4n0JTW2v/CKgW4a26i7hHxoqJ8y6ddA1uhp2SccpjHNw20LvNnSE/gUt7UmHvlVdWe4s+WsR2KV0cqzqPcCIT73JJ+O9+mx7Vr/qMyG8RWrhjZzyRRkkrkxvMXR+VfN7ya4icnWnYk0WBFKtWslfDjj4uBaAJLSiRvz3LzFpdEws2hOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dOJpL9eRfFG2oJD4VysONKaliMx3mOjjoHuw9SR47aI=; b=Yrpw5t2jX67Obw3sLaeM0q5uaYLhtgYy3/O2pW4VYZQBrZ1i1+Hliel7ndzTpzH2MTFPXe6zwBUEPJ5u9ekFRmWycMjrC0w6332FQe4amzO9jYxKPjTb+Oc4zj7MmCkaikVjtXdXQ95z1ft9SrObT2vpNPNm35rwrN9MqkRJyGKklcL6QOP4NzImJQBDz8IAM5lCauxbsCHoEK99cJHbdeuicJpnsziimX2vZ7tku0myZ5NpmsdpBjM3rdYWaEsZyr2cCVsjQAVZwHb9aCVf8TmTmNyHy7wmoG2IsFCfg5Zltp2QgLUdNzTmCDuGW606CkWr1tj4Cua3JGmdRNpVNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOJpL9eRfFG2oJD4VysONKaliMx3mOjjoHuw9SR47aI=; b=JgZ47I+GqnvppZRwBCqSR+YtMq+WY/QnW+AvQ0fxGMIxIWaZ97Gy93N5IrQSrh2eZDt0+qH43gfsmvLOz4oc+Z5IfsiyIThcCfX0ksdYWNVYdzd8oKvIPT6mJ54cJ0n3yxq62Ss10kW295TT1jkRYlfDVYsBcjQgUsosxbmenBo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN1PR18MB2352.namprd18.prod.outlook.com (2603:10b6:802:28::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb 2022 18:23:58 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79%9]) with mapi id 15.20.5017.022; Tue, 22 Feb 2022 18:23:58 +0000 From: Akhil Goyal To: Kai Ji , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [dpdk-dev v10 0/9] drivers/qat: QAT symmetric crypto datapatch rework Thread-Topic: [EXT] [dpdk-dev v10 0/9] drivers/qat: QAT symmetric crypto datapatch rework Thread-Index: AQHYKA4aIojAOQO9P0CtIHZ4aVQHeKyf4c2Q Date: Tue, 22 Feb 2022 18:23:58 +0000 Message-ID: References: <20220218171527.56719-1-kai.ji@intel.com> <20220222170226.90002-1-kai.ji@intel.com> In-Reply-To: <20220222170226.90002-1-kai.ji@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 496d1810-f235-4aa9-0c0c-08d9f6307e1b x-ms-traffictypediagnostic: SN1PR18MB2352:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h2Eqn1xU1AfzPKaKyoZbRb2fGEZs3MZhf5gtvwz900SRnhaZwFGN29hgc+g+BAYrFO9pAJVh6aszoxJD0Vysq+tmqwcsCy1tujG1/hrsq8jZq+E4fXZJcVzRK2PMqSpC8bo5CY1ACQnBn+X0QH9n3ay10BriNsy7evrnmQP6kSd3dnXz4wMEs23tCm2DS29xAgBH+NBJteMlCu6yR9FXjCIKczbQYB81MF1t2SbVzMJ3EOOv5T1vr/dcJO/8gtmxLPk8Ww+L96zRe1FQStOhSGRCrTavPHKbVGS6KwG08eBh1yO9QxotsJ/3GoVzR6ZnRQeVODB9myKdSDq+g4NhkNvSEcBeD2rTQl/xzYq6NWKQrvhh05EYN5TCxSQtyaphJ8sLgYI4FPJ5ifSAlOSRf2YHBMy12tLdUF075klLbFS9b1sE9oEAymNQ8Bhx9T9RUC44kpGQWZ+wMcOq3EN4PNu2zbBfceBuOZLqy+GGeBqU1BVEV+gat3a1Sligccd/HHzNvMBfUQd4/LoWqpvy91BTLIn9omeUqoDDoPP8V2e8Typx7Q8oHaw2SQQpXCtzXgayCrVwHAuXQVyTHfv5Z6lBZVV1zsAbpYGbmj8LyZTGF8/+OtSOS67mOvHsbRT2rcSg5LjwryHG8aKiRHQchRozZNeNJK3OFcxJUpftAQDZZwBYFqh5fxsCsOTmeRByo7U8EvM4SQF02PuSg9yVew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(110136005)(76116006)(66556008)(64756008)(55016003)(83380400001)(71200400001)(508600001)(4326008)(8676002)(55236004)(66476007)(66446008)(7696005)(33656002)(6506007)(122000001)(86362001)(26005)(38070700005)(186003)(8936002)(52536014)(316002)(9686003)(38100700002)(2906002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RZjYdEuBLcXxWV/rPxupJ5azOA3ATTzWM44F0Gs2ikn9kdFyM4eDcI71m50Q?= =?us-ascii?Q?3UFahwMf7iPoUE4qUxdVpZSGb3OwYT1Ob6VuzpZ0+gJTwyMHHfcASUbuLQLK?= =?us-ascii?Q?FsC9xPzwL1t0B5jzp7triUaCMjQE6XJKjHZ1Uu06IAcw/mXmJXDwaXZnb8/w?= =?us-ascii?Q?2QOljp4FccjtQ6LFANQqGekU/B8TluKNNs3KF9h/3qslgkupVlrvIW5dNP8L?= =?us-ascii?Q?MzpjxIA4p0moIX6PMPPFTnkk1gdCSv2+6XrDl2yB11Wnr1Im4JVLFkc9Xqm+?= =?us-ascii?Q?jtR0D7IMyBvsAVrx+h7oPgocNSTxBKRdAru1HdItFhcFdqyfrFAsIhrP2p3h?= =?us-ascii?Q?ZXTet75TjabmkR4i5vor1wmldeQYz9/B7W4ux9Ce5efbLxhJbWzX2nReqO2H?= =?us-ascii?Q?fpqt+35qWEp+8HsKnunHp0k0qef46CXcw84iHQslBVrhxXOki4hprwbVDQEm?= =?us-ascii?Q?EwS53XE0gNdeWidYVNQaPz//XYezFXekd91oPW/W88uNCW87ot0Jg2F8UYSZ?= =?us-ascii?Q?vZF3z8khIWJfpBp+6RhWLF5cL2si4WBVYa3fZy5O3QbI0hVlbEqgE3HOAoUs?= =?us-ascii?Q?dmhFWhyucYFwUUYOCwjGfgXFMfYoX2CS4/48CAp3ztXAWvi1BIDVu/8JuwhK?= =?us-ascii?Q?oEfX2fIQcffC2wsNPgtQ9DQpsVXvF9YAWC2IlXpc0Nev4+/gm1jAAu+OQ2mD?= =?us-ascii?Q?E2vrlyPSN6TxWK3nOz89oz5gesPBBclKGTh3QWXDzYL3pSjbn7aQp1o/5cex?= =?us-ascii?Q?UxlkWbh2PP8F9D8kdotEyyNG8No+47ewXFgLWMOF92qQ2DPrzjSI8hpTiWAR?= =?us-ascii?Q?+E6zZ7X50kjogVR6GiIcKXKbM2atHnkNY8P8bSKRLeZHsMuTM/745nhOKUzq?= =?us-ascii?Q?MLjbLqaDUlKTs6j+VLu/qy5a9gCnp73BYitxYSuTkyaD0+PrsrLml+ArWxGZ?= =?us-ascii?Q?TwB0A7ztzp0ZKYK4+mIA37s4D7Y2I5s+KJPP/Uy4jXkAhbIAC40pDJ7ivlBN?= =?us-ascii?Q?/2MayMmBlietnfu65NOvTsNeTv2Gd9WND2AwmOnRYpRZGNNAq5SJCFfwb2//?= =?us-ascii?Q?uCRxulRmdDYrdSAzLvp9qhVwySyWtAsp7IzyZTha2tSX/lEDDrIJTcJct8TA?= =?us-ascii?Q?4I6i6vLpQ9B0H0rG8yRdeHYADIi8wVP5ONixHm71ZnHXiN2Lj37kupItNjun?= =?us-ascii?Q?7SWb2SKJGe9trmxLunSL3myU1mdDKA0opfYujacsFQthEcdPMCJ8ILRLgCyE?= =?us-ascii?Q?8YjOsa34VWLHaTt2YuAjTqQIsT9bBeeBJqcGL6zYbRxwB9Q6Y7uuXlC6uX4O?= =?us-ascii?Q?QDhFV64ri6eT56CxsHpOe+gbpbhwTprhFTiyuM4yk/tT8l+6BkssbFiBAE4A?= =?us-ascii?Q?dCh9JmuWZyDUEkoT4NgPAtzD4nLe1Qq0jtfTb1dWHpnNBA0uaj5JV6nsBu44?= =?us-ascii?Q?tWw6OaAilGZowzHVGERK+bgu91em3xcGd/EL08zdfiGdLDRMs1WZb6i1alCu?= =?us-ascii?Q?2XpCymr0yTihJo6Ot7oSu7z8DHrxSze+QEUvh8dZpEXJ+hWBrrRPLwj7FC+t?= =?us-ascii?Q?p9LpmfUsBKhfDTfuCLSHTD0V7PNH+G23jFrGXvTgFuzmKL4ytAyEezA9wikL?= =?us-ascii?Q?GdiK19VJWaL2PEn06v1182o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 496d1810-f235-4aa9-0c0c-08d9f6307e1b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 18:23:58.3263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FYg3Ha5Rr4KZ2AJ2VFrQWjtp5KR4TrIZFNt6GHM30NJmc8C+HEQL4yFIAMgTJ0HejjM7PoWG7yHdGPfyVGInqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR18MB2352 X-Proofpoint-GUID: 9nDqXeRiWJTo3VPfwYmc03L2vtSv74eT X-Proofpoint-ORIG-GUID: 9nDqXeRiWJTo3VPfwYmc03L2vtSv74eT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-22_06,2022-02-21_02,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Kai, This is again not compiling. It has been v10 and most of the version are fi= xing one or the other compilation error. You should fix your build system before sending out the next version. /usr/bin/ld: drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym.c.o= :/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/= qat_sym.c:16: multiple definition of `qat_sym_driver_id'; drivers/a715181@@= tmp_rte_common_qat@sta/crypto_qat_qat_sym_pmd.c.o:/home/gakhil/up/dpdk-next= -crypto/build-clang-static/../drivers/crypto/qat/qat_sym_pmd.c:23: first de= fined here /usr/bin/ld: drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym.c.o= :/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/= qat_sym.c:18: multiple definition of `qat_sym_gen_dev_ops'; drivers/a715181= @@tmp_rte_common_qat@sta/crypto_qat_qat_sym_pmd.c.o:/home/gakhil/up/dpdk-ne= xt-crypto/build-clang-static/../drivers/crypto/qat/qat_sym_pmd.c:25: first = defined here clang: error: linker command failed with exit code 1 (use -v to see invocat= ion) > This patch reworks QAT symmetric crypto datapatch implementation where > each > generation request building separated and the crypto operation under the > raw datapath api implementation are unified. >=20 > In addtion this patchset also enables QAT OOP support in raw datapath api > implementation. >=20 > v10: > - rebase to the lastest for-main > - fix of build rerror when RTE_LOG_DEBUG enabled >=20 > v9: > - commit messages reword > - fix of unused function error >=20 > v8: > - rebase to 22.03-rc1 >=20 > v7: > - fix of pointer cast compile error in x86 >=20 > v6: > - fix of pointer cast error in x86 > - rebase to the lastest for-main >=20 > v5: > - rebase to the latest for-main > - patchset reconstruct >=20 > v4: > - patchset break down and reconstruct >=20 > v3: > - sperate a single patch 6 to two different patches >=20 > v2: > - review comments addressed >=20 > Kai Ji (9): > common/qat: define build request and dequeue ops > crypto/qat: support symmetric build op request > crypto/qat: rework session functions > crypto/qat: rework asymmetric op build operation > crypto/qat: unify symmetric functions > crypto/qat: unify asymmetric functions > crypto/qat: rework burst data path > crypto/qat: unify raw data path functions > crypto/qat: support out of place SG list >=20 > drivers/common/qat/meson.build | 6 +- > drivers/common/qat/qat_device.c | 4 +- > drivers/common/qat/qat_qp.c | 42 +- > drivers/common/qat/qat_qp.h | 54 +- > drivers/compress/qat/qat_comp_pmd.c | 14 +- > drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 9 +- > drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 93 +- > drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 490 ++++++++- > drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 257 ++++- > drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 913 ++++++++++++++++- > drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 942 +++++++++++++++++- > drivers/crypto/qat/qat_asym.c | 303 +++++- > drivers/crypto/qat/qat_asym.h | 79 +- > drivers/crypto/qat/qat_asym_pmd.c | 231 ----- > drivers/crypto/qat/qat_asym_pmd.h | 54 - > drivers/crypto/qat/qat_crypto.h | 16 +- > drivers/crypto/qat/qat_sym.c | 979 ++++++------------ > drivers/crypto/qat/qat_sym.h | 148 ++- > drivers/crypto/qat/qat_sym_hw_dp.c | 995 ------------------- > drivers/crypto/qat/qat_sym_pmd.c | 251 ----- > drivers/crypto/qat/qat_sym_pmd.h | 95 -- > drivers/crypto/qat/qat_sym_session.c | 115 +-- > drivers/crypto/qat/qat_sym_session.h | 15 +- > 23 files changed, 3582 insertions(+), 2523 deletions(-) > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h > delete mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.h >=20 > -- > 2.17.1