From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31A5CA0542; Tue, 31 May 2022 13:39:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6599400EF; Tue, 31 May 2022 13:39:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 71EE4400D6 for ; Tue, 31 May 2022 13:39:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24V3YPh8004646; Tue, 31 May 2022 04:39:42 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gbk8n912h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 04:39:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5CQ7qsXhc6bphWQ1bL3doxYXnQlOyRSMlRccmnniW9QxqPKWt6zhAk4JSHE9km2MVUW0o4+dL4hsIBiQg6zkSjCtxTdnznK2KNzRWkfwp4ifXAjvb3l5aIFbPHw1z5hDctQHxhp+SfVUeEx6eB4RcKbEh0N7eYidXG3OMOntnzogNUujrRgAT6rRm9TNvf8QtGK74zXLYwvIrESa8zwNAcc2z2Tpd2JjclPwvz+/8yevdWRXH3f8GjiEuOPpxmJ9b8FfBjYrJC3k697d4AlDv7g5dLMdySq6wwN0JdFN79zPImtrX4XoADUQQJgqRDIwJfsrBcJiKHIpnMx0QaP9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r9/5zFBzWxwYdyHulaGWkYWiBjlElO7I+80etYpF7nI=; b=GSzbmKkRPY/UUdHNSIJUuivTsjoDOiEnLDUxA6iS/HB4eHyhq5D82HziOc29eMoDxFpK3pAsFUxIVuIYWVwuHto82WCMriUuHTqNSc0al7Jgl2VSD7xrxOucADr+k2VveGYbd2G9JJcd9VaUqFeZqsj1n8qCQV82k2u/5p1ZUl1QBgP4it4G+YfoZ6cLO+/v4pERzycsQR7zD+DAb+OfdMaX66RsMxnh7ovWGj52ZN28G8QndC9tSeLcjxZlHMtiJOj++kbq1BzQtRZoyexKMWpIVY/bpGDcxvCmgLNIEYiDS6bdxOn+C4EU1n5jAmFiHy2gy/3j9mpcTA+zVO0rmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r9/5zFBzWxwYdyHulaGWkYWiBjlElO7I+80etYpF7nI=; b=PBUwhASKYytIqIaTCJ1NQwGB2U+1cT1nNZsJx8Y7tLpVDi6WVHsHP+upBjYn2LKFEYPWYz1TRUSyzVcq3NB4ny4yxcgotfbKELINjysuH7kGhU8Rnm2KGoohkKFMnCvGkiFVGcC5kOxE/z5AhznkqNJR3BymISAFJgpaWRJhNT8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BYAPR18MB2647.namprd18.prod.outlook.com (2603:10b6:a03:136::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 11:39:40 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.012; Tue, 31 May 2022 11:39:39 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags Thread-Topic: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags Thread-Index: AQHYdK0Va0iBNAHUN0CXBNjqcmLENq043INQ Date: Tue, 31 May 2022 11:39:39 +0000 Message-ID: References: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com> <20220531040439.15862-9-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220531040439.15862-9-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91837a54-c367-4ea9-9f18-08da42fa3f5a x-ms-traffictypediagnostic: BYAPR18MB2647:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZJ6LeXz3MAj4k0uxJyfT6nlmFO+WdSd5IMhMA6JfmAbpk5L2ykSu8u442cMc5uugJ296akeLVkjmwXSm+iLzhcMFtnUFjHsGg+0mibQe3/H4FgAlhPbXatP3kMJMlc9pZzPPf2mg3lqyrxJmMuVOWqjU7+etfihgoaC0/On48o963B3rUDOuZi/p5gnFNvhkwa46VkIknTA+YfmHPL6jZc67wW1bJmiIH07lpShC5yO2pKaamXRXuUQXYM8cUacLohQ6oUqeyNlaQZK20na1nh8TI1zYCnqN8BY3s7Gdd8kuCiGDwF2joAE/5LulZfcCWiht7TWCNBnShcuPSuLKXr9JZxM8DwmWvd6ZpsPFy0zs/ZSOtxJkCd/nFKCxHOQe49pg7GT++TXaQFbwMS4tISkbjpqt1Ob6ba+DAuzsliL3nRhHy59cdNGMpGSZwmksoFYwZTCD01utdVoDRBSjLY6GK3kK6FcyRZSybYGlGMbnmIFo+rovDxFydV4k2sFJ7U7g/requdlaVGV9LMTbeb1ukwdavyIs2B/4rhC2z/sV65eF1NnVfCb+BmprJZLgShPNNjXIsfqm4VpnrKk4htA8TptT8VZSllmOVqwJXtlSwkLZ7huptqu76ZPN42RVinhZ9KYrFqNddjGr+Sk/vHgb8sMFcHtddKcnoIycgcpuQ8ziIKdSRWN9XX9noSJjX2bZItRgYAfoBqVYfJA+oQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(38070700005)(52536014)(33656002)(55016003)(316002)(53546011)(55236004)(9686003)(4326008)(66556008)(38100700002)(110136005)(76116006)(66946007)(64756008)(8676002)(66446008)(66476007)(2906002)(26005)(71200400001)(186003)(86362001)(508600001)(83380400001)(122000001)(5660300002)(7696005)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H21PSLwziR96znytdxrvHUov+ZCgkVEJUdDeyiJwgMVnGCRvT9QfkfGwJqBr?= =?us-ascii?Q?SByoo+40VosJnBudKYVQ//0VfB3+mhDQ+81Z4qvvmBZ26ohHFbi8rYfXC9/1?= =?us-ascii?Q?DTl5k3OogXNl7nb21vaRdzc6NHIUSoADyu/coOyUv5AGX43uMLmnO9Pff3BX?= =?us-ascii?Q?S2X4E6m8ZVCHZLZbMms1hDJECwxSWoy3o9SbKsX0Vkvmoc9T5O4KIx0GZ4Po?= =?us-ascii?Q?Kse+SoedbhZyuJCkk653dw9DmSrgBrpCZUX2mAk2uxvMuYu079ULRIfF0rEe?= =?us-ascii?Q?ZJx4YhTWJSdgERzLjTfZktqCTMNyWI3mk0GuIdIMvAmMOinbYZkts2DiFGJ0?= =?us-ascii?Q?2nL9uB9o0dY1fpLp5aHOSZKEXI1OKdsDlffwF3VzeGN7KVt028E+YzgJZ5Je?= =?us-ascii?Q?BUKXJ7iEpeDCnYmnzsZQhA+/1TNPBnd/qW8nvOAjmd4RM8jtLrWubup9QKSO?= =?us-ascii?Q?0U08y0Fs9i04a9fSRP4bx6ucQ5n6d4k99VHxvNxE/YR4AyOtNP2ITOdMtCi8?= =?us-ascii?Q?y+J7ty4Kj8kP2eRH+k/PBRI3P6l+oDrCtUcX4bTfLEp8vnWl5IUARzAXa7W+?= =?us-ascii?Q?72MT5oqcPYte2bPLC+FZBpJAchNfFZXaNV/RF1La97zkpcE+gT/vBhYZKuSY?= =?us-ascii?Q?C/Xw/HGajGp2qfLhQYPvv0wnKF1hqjchz+nBFmsD52WVPXj1JaFi47YGR6Pa?= =?us-ascii?Q?kjkCQcKgPhseKrq4gwSald1gYNqjNEWn95BJJ2UblGpUBkfzPH8sDPkyMoIp?= =?us-ascii?Q?tckGpASUMSIU5Gk4cqd/kOcAtVqgm+fGGP+fPbRzvDQ0eaq5lAi9QEM4x8WI?= =?us-ascii?Q?FLTVwb7tAbVIrnGWScptXWbslkWbT7SRCe2RfsTZYlvmWBKQyErV1hBAH2Gt?= =?us-ascii?Q?m4HeszlPOzCVt1r+L+/miRDFnD4HhZKGbk/0/qmI5LdU/g9kEMenZ27Rj1E7?= =?us-ascii?Q?m310nZPJPlsIL2IChOTSL8ykHWTH3Oejl76QyXR4ZQDptoagKit8WVCTYxVL?= =?us-ascii?Q?M5qnW9z+81pBK/tZoxPhDXCnOI4tYMaIXnwfx+kpNG/Ma0UOIvSO60uRcOA9?= =?us-ascii?Q?dniMus2AivMgNfJAsLm7FGhiK2EhxT6iMp5x8MOAMmWth89NPefMbcMRVsLi?= =?us-ascii?Q?6jw3FGQ+5v8v9UnEnf62MGVdbMDOxxr3m9PmIYCahDIR6lqdJ0y+ZgmjasqF?= =?us-ascii?Q?86Ue0qy2xK0fDx9f0fQCWVgotX9V8FNEgVTg3IydZbESwTXWgV6Mubl9hr1g?= =?us-ascii?Q?JZGVvUSSZXBvVIUEAqZpTnQiJi4hIzQaHKtiVep4peR2SMLxDdMNwJz7aaXm?= =?us-ascii?Q?RdiOtkDkSSU2aHfWPH0TtXOT1PgLCHDYKBL0RolwFx9AA99m0G6pclCxVNDe?= =?us-ascii?Q?krJZFlVxyr/OQrjBZa51WO8NXUZVrtaiublMPq0ElUfKwsQnp/LLQHfVyxVy?= =?us-ascii?Q?nmeHdugdT4QJYv1E0UELEnhZAwKUDgzdPSSHYDWFCXnuqAS8qnhBF29hpvKD?= =?us-ascii?Q?jzJdtXGmDYHA2MJbKDBvMLBDafGfoR1WzXwEGKJfMxHPx90+bUniaU9cKdNR?= =?us-ascii?Q?vsvy6dIkjTtlywJXPqw55vSTEZJorLYeFWrJLWTVXCuTP1QHsWYe1/PTi8ri?= =?us-ascii?Q?5IN/l/e1akCSAMdP0FUEK9cJbl9WMpXUhsivKcj+ydNZS4vB31r3t6CojsKv?= =?us-ascii?Q?rd6J7KloPIIofI79B2YySqou1AAKrB10OfjO6DgEeJyFNqnqalLJqeAKmNum?= =?us-ascii?Q?uZyhkWsMlQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91837a54-c367-4ea9-9f18-08da42fa3f5a X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 11:39:39.8195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FVeou/CvCSAbv7jDNMcaijLexZLpF7XkhENTvLXgbmyS6LBsXCi3pTGHJQ56MNoBaUAW0XLL7Y/mgeTn2bvWDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2647 X-Proofpoint-ORIG-GUID: wdw26xwjPMYDi3oz_qSLWt7sU-PHDe60 X-Proofpoint-GUID: wdw26xwjPMYDi3oz_qSLWt7sU-PHDe60 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_04,2022-05-30_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Arek Kusztal > Sent: Tuesday, May 31, 2022 9:35 AM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zhang@intel.com; Arek Kuszt= al > > Subject: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags >=20 > External Email >=20 > ---------------------------------------------------------------------- > - Added flags to rte_crypto_asym_op struct. > It may be shared between different algorithms. > - Added Diffie-Hellman padding flags. > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most > glaring example is TLS1.2 - TLS1.3. > For ease of use, and to avoid additional copy > on certain occasions, driver should be able to return both. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index ae3ca31a89..a215f4499d 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -41,6 +41,19 @@ rte_crypto_asym_ke_strings[]; > extern const char * > rte_crypto_asym_op_strings[]; >=20 > +#define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_NO_PADDING > RTE_BIT32(0) > +/**< > + * Flag to denote public key will be returned without leading zero bytes > + * and if the flag is not set, public key will be padded to the left wit= h > + * zeros to the size of the underlying algorithm (default) > + */ > +#define RTE_CRYPTO_ASYM_FLAG_SHARED_KEY_NO_PADDING RTE_BIT32(1) > +/**< > + * Flag to denote shared secret will be returned without leading zero by= tes > + * and if the flag is not set, shared secret will be padded to the left = with > + * zeros to the size of the underlying algorithm (default) > + */ > + > /** > * List of elliptic curves. This enum aligns with > * TLS "Supported Groups" registry (previously known as > @@ -613,6 +626,8 @@ struct rte_crypto_asym_op { > struct rte_crypto_ecdsa_op_param ecdsa; > struct rte_crypto_ecpm_op_param ecpm; > }; > + uint16_t flags; > + /**< Asymmetric crypto operation flags */ Reference of flags missing. I think, it was highlighted in previous version= also. > }; >=20 > #ifdef __cplusplus > -- > 2.13.6