From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50721A0C47; Wed, 3 Nov 2021 19:49:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11DE240E0F; Wed, 3 Nov 2021 19:49:10 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 1879A40689 for ; Wed, 3 Nov 2021 19:49:09 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1A3DI4b5012160; Wed, 3 Nov 2021 11:49:08 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2177.outbound.protection.outlook.com [104.47.58.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3c3dd8d5gg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Nov 2021 11:49:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKDM6F7rVhjcECO6WKfBuFn2mXGHXzHZGfOooEp1StuxYn5TgegcPWgq6VjVjT5VvAY1ntrgC2vnTpz53cmCMOyGRLSsqklWoEIiC1lgWpmA1YhJbH12xacaaUBLbc43leftuzgkmntA/CjChW05ikcMrmctKJv5koYfkljfy2XlC09CkC0SpOwZckqbcwnn/ngHTctNd5U8X8sYz7W6KkBGt1ufl44k07F69K5KmPwuq77d0iXECpUVxZBQFD68M5vw261ur3plDiLwrwaidR229lENMD382vknv3QrP339HIYuhlIz0xln7LI/s9EXzKoyyA6C0M++QsqMqOHQsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xpq6txDHYxo5QCkayIKtdeYDTKPhIpIedOJnJgATwX8=; b=A/J1sZO8pU4COBnf9c0DXdLlW2JyFxv6mkDYwFaC3g/m18pFpRidDowSVClOGf3Z5mYTLB8vYl7EBEGka63JtANyL5Hcl/AfKYD7ojoB2AOuhAVYP9QMnPfSWQ/nuzrF73U/8NJqmFwFZEWLZEMxrZgSDfmfFWDihrgCM8IFNSFvJIzYhWK7thexye/6XOpNp1AD8wzyw5shuW2mopZcMJzeqd14G4h11T5WR4LzFjK/Qad5sg3K8MqEZjLb87PoJ1nccaVVTWxVEWzQAeqUpaNkWbuQKiyPTrJMXB5sLszOPXOOeyigpwEYZwvo5hBcVw9QthhKazeWchBFyexbhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xpq6txDHYxo5QCkayIKtdeYDTKPhIpIedOJnJgATwX8=; b=WSLHjnjngjE0Y3yYvioJ2HJct6jZUgeMVRlCIwRAVAaKpn0ABrZ3bvfl4m6TLcKqDwokAFQOCDLu/jSan/Ztb/baeMGHD7otVdraC0ZynaDRhGSIfr2jsWswfA7PmlgCQwN0AENf2WJzkgj0+JarWcXBYnMUd93jmCYeoAJPlfo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4697.namprd18.prod.outlook.com (2603:10b6:303:e4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 3 Nov 2021 18:49:05 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 18:49:05 +0000 From: Akhil Goyal To: Kai Ji , "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto datapatch rework Thread-Index: AQHXz/B61Y33YDeJJEmpdz3KDtgGRavyJmIQ Date: Wed, 3 Nov 2021 18:49:04 +0000 Message-ID: References: <20211101231257.7629-1-kai.ji@intel.com> <20211102134913.21148-1-kai.ji@intel.com> In-Reply-To: <20211102134913.21148-1-kai.ji@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 83438069-4906-4d62-313f-08d99efa9c57 x-ms-traffictypediagnostic: CO1PR18MB4697: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EKQ5Od83fs2onbuQcBXcT38TxUqYXvIue/XwsrTTXpvZSP3lzddKJNtn8P7cVnSVd5disLsQnrABBbqXjbPNw7ijSfp5L05hOheI8kbu17VQRuyNa/yZNRPm6VIx8oiE9xc7TLuxwJwUVm1T1Lm9M5/rZ8rEnkoc+x+7JPdYGchFHHPqzP75mwgVx2lM3+l+dRA05SErgdeaQQvl+7y1pahGXbK4IJLKCKt2B5G7Bl7zlp/1Et5MAmtGK3/O7h+RxscIGMhF0/4kBIZnLIe1sxvCsECa8nWR3ZOAxTXox/DLs1yH2pflvJqtRWMQFs/dIEH2GDWcwewhJ8FMHw9bEXji6EOYImePOtEPltjjfEeH04q0zIICCIF9393Zl91phxIMGQux1rCoJx6BU2+KOqX5A1RYm+If1GJmvrLroZme1EzSDu6fFrI7iiS2pI8FShEeOntn4KrJe5lCkNKC9Uf51heb8BceLIlhOZrSOxnj4BHys+St7cfU5qLcQLDP6qKTpedrfMZB1A13mjm+2lhG/fVJQZEdP9NmTCy+flhjUFuK7Epqp7rr5NhdfkBuyzH2lGnX1LULD4zibIBNOzTv8V/mjTNTPg8k867xJs5pRWet6UzGW274KDB257xeSL30WQRcMqj148K+SQbwtSBw8Z9CoMb/KsHqcJP/pzAzK/ekJszcbdZBAXIk/Zfdfo8huOCMbL9kaVvKn+A8oDnp82Bk6uRsnOzW0zhWTcOEvCbnuIpOQqvptkP5W7pHeC5vfl80whBQWtBi5F7VakfTx6SIYf+22NVIdYiafqM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(122000001)(26005)(83380400001)(38100700002)(33656002)(2906002)(55236004)(5660300002)(55016002)(6506007)(38070700005)(86362001)(110136005)(9686003)(7696005)(76116006)(52536014)(8676002)(66946007)(66476007)(508600001)(66556008)(64756008)(66446008)(966005)(71200400001)(8936002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2vwBHBLwWpIoWNiEPuD1sjkviwMcMbpbweT0paxBNyah3LEOLIrYKesEnxhD?= =?us-ascii?Q?UT4vu3ioKaXg3NqFUAzoKAGPJj0MYJ7foOjzjoCfK/0ZmP3Xl57i7QxqX1fN?= =?us-ascii?Q?XchBmKK+4TPVF1LVTy6ZSr3gRxNQFbbNR77pajzHdUv8rgVu2HcEkc9cvp15?= =?us-ascii?Q?aNXPry6FsDlKi/1F6TLwaPmgNhq/1Nb/SiYyQwkslK7795augn7a5J79kKVQ?= =?us-ascii?Q?YFgVIK/2o9x5W4x5CxJAbLkGEfUcSkqMqhZhPYhnE324cXSjoLi69l4KMh5/?= =?us-ascii?Q?nA/0Z6OUKtby9+W0njh0DGkEM2K67XrVQuWV76AawgM19zDQptPlmwRcrk0k?= =?us-ascii?Q?Rre3dHb2+wc4Uy3SxhMwGaeQt7xQeel83TLrAe7yOqVEj0+M/WHAHiRW1Y2Y?= =?us-ascii?Q?m5TPyq1MMrOLoZuvzADt1C7gfeBBT5NWyW+LFbea7xRU65V54xaMniEV747U?= =?us-ascii?Q?KnlN7Zfo/fblw4G161wnFqoqXhdlWOhwp08fYU9oqIvHA8hWZJilfggDmqgZ?= =?us-ascii?Q?8XAiAqLZju1RteDTnEE/i1ekz0Lzvgvugg5KYDbribz/Krg3OsGIR0Gnl1Fs?= =?us-ascii?Q?u42Oaxm7Pj7WlwDGJw0xpwYTvXBypOs4VLif5fhelC7vB20svhciX18w90aB?= =?us-ascii?Q?1pqUtvr/msFgoRtjU1xVLs7YboS0FVFedzFs+V8D+cfwgxiH7iGudq4te4Tq?= =?us-ascii?Q?ysFrw2pvXsebgGK92gA5xEmrJS1BplvSJoBCmUfj3yKNpBOLx92YFNRx69xu?= =?us-ascii?Q?DyTYDfqjFARFBP4yZGrIZ7xYxWsI6G+SwgfFHVJqBf8E3/YSnzrQbChhFWag?= =?us-ascii?Q?f11InSDnnbhaZMRE9jZODnpFgIwo6s8hBft9VwEsNLwQNzOVbCQDd/Y5acKE?= =?us-ascii?Q?nHPaKrnHj0UpfjPYCSSoKqlUIf8gr8M08o3t34xICC4p2M70cqA2S5orzkEB?= =?us-ascii?Q?dAxCYc5eUIEQcNYpCBslBFwKuR1hh5l28FuOAwojd/4+BMBep84Vg1QLzilz?= =?us-ascii?Q?YQhOE/FEqhX7M4LpQ6WI8Q6ln3x+ga9oDDMT/dTrV09+8SbUgUS6qPA2dt1S?= =?us-ascii?Q?0JCRb36nWZcPkVqmzJXXurxY0bpReveV2cDJwVy+eGStzP1QARP0pxE7JxFK?= =?us-ascii?Q?bDH/TR6lxRMHqPJeKzgGbFVyKS39Lxz5/O7ErYkzQzvvGuQBmeZ9kW11MGqn?= =?us-ascii?Q?eV9Edr1diEYG6SiGtCC6/3rzYjo10DYH7+hbw476IE6tesst+QZCZcICVxE8?= =?us-ascii?Q?A1VZYGuBhrrDTemlFsqJW788tKX6pG5TicXQ2mvJrYlaZ4CNjtqveXbx8/7a?= =?us-ascii?Q?8p4A5fsCg4AUm1nHLtHh4/JiSykxL+6Nf52tu3H3/AJ+eXZYH/VHtdKPYd/l?= =?us-ascii?Q?wxwst8J5mUbv53f7qMgxx60aC9LrUjw3hnnliTFzJvBZYck9wijjl0s9eUTK?= =?us-ascii?Q?AA4ioiaZ+UmFDOpw5x0louS8RJttN1zQZiwYKuJ/mGQN6Jlkd80ZcqHHofj4?= =?us-ascii?Q?DJqSskWxJJtbzwR9WRrrbysWi8X5CO5nef5FtGrZKYy0oPvJyVlqL+FHtZig?= =?us-ascii?Q?bzRjX2hlBBG+iEWF+Ev9pkCtEu5PVfzNgEBmhwGzUuaBVLpHibM1JdmR8w8X?= =?us-ascii?Q?KECB8xeCfLRFSibYm8hwa/0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83438069-4906-4d62-313f-08d99efa9c57 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 18:49:04.9826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TtLevEYxGshkiktsJ8AnSRYZbMrPtXXAMUXLaMbfMtJV+P/XdM6Z41/w/LOMiImYj3ek3s+WUZFGKF5MtYsjUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4697 X-Proofpoint-ORIG-GUID: ABLEe0BLXEyJarc9Y7NJMdKwg-GCwTUn X-Proofpoint-GUID: ABLEe0BLXEyJarc9Y7NJMdKwg-GCwTUn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-03_06,2021-11-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto datapatch rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This patch reworks QAT symmetric crypto datapatch implementation where > each > generation request building separated and the crypto operation under the > raw datapath api implementation are unified. >=20 > In addtion this patchset also enables QAT OOP support in raw datapath api > implementation. >=20 The patches do not apply cleanly. Please rebase into a single series. Rework patch titles as follows [v7,1/9] common/qat: define gen specific structs and functions [v7,2/9] common/qat: add gen specific device implementation [v7,3/9] common/qat: add gen specific queue pair function [v7,4/9] common/qat: add gen specific queue implementation [v7,5/9] compress/qat: define gen specific structs and functions [v7,6/9] compress/qat: add gen specific implementation [v7,7/9] crypto/qat: unify device private data structure [v7,8/9] crypto/qat: define gen specific structs and functions [v7,9/9] crypto/qat: add gen specific implementation [v3,1/8] crypto/qat: refactor driver skeleton [v3,2/8] crypto/qat: refactor symmetric ops [v3,3/8] crypto/qat: refactor asymmetric ops [v3,4/8] crypto/qat: rework session APIs [v3,5/8] crypto/qat: rework data path [v3,6/8] crypto/qat: support out of place SG list [v3,7/8] test/crypto: fix ---- The title and description do not show what is happening and what the patch = is fixing. [v3,8/8] crypto/qat: rework ---- Can you think of some better title for this one? Also, the description does= not specify On what basis rework is done. > http://patchwork.dpdk.org/project/dpdk/cover/20211027155055.32264-1-kai.j= i@intel.com/ >=20 > v3: > - sperate a single patch 6 to two different patches >=20 > v2: > - review comments addressed >=20 > Kai Ji (8): > crypro/qat: qat driver refactor skeleton > crypto/qat: qat driver sym op refactor > crypto/qat: qat driver asym op refactor > crypto/qat: qat driver session method rework > crypto/qat: qat driver datapath rework > crypto/qat: support sgl oop operation > app/test: cryptodev test fix > crypto/qat: qat driver rework clean up >=20 > app/test/test_cryptodev.c | 58 +- > drivers/common/qat/meson.build | 4 +- > drivers/common/qat/qat_device.c | 2 +- > drivers/common/qat/qat_qp.c | 40 +- > drivers/common/qat/qat_qp.h | 70 +- > drivers/compress/qat/qat_comp_pmd.c | 12 +- > drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 7 + > drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 90 ++ > drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 487 +++++++++ > drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 253 +++++ > drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 911 +++++++++++++++++ > drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 939 ++++++++++++++++++ > drivers/crypto/qat/qat_asym.c | 786 +++++++++------ > drivers/crypto/qat/qat_asym.h | 77 +- > drivers/crypto/qat/qat_asym_pmd.c | 231 ----- > drivers/crypto/qat/qat_asym_pmd.h | 54 - > drivers/crypto/qat/qat_crypto.c | 1 + > drivers/crypto/qat/qat_crypto.h | 14 +- > drivers/crypto/qat/qat_sym.c | 978 ++++++------------ > drivers/crypto/qat/qat_sym.h | 141 ++- > drivers/crypto/qat/qat_sym_hw_dp.c | 983 ------------------- > drivers/crypto/qat/qat_sym_pmd.c | 251 ----- > drivers/crypto/qat/qat_sym_pmd.h | 95 -- > drivers/crypto/qat/qat_sym_session.c | 114 +-- > drivers/crypto/qat/qat_sym_session.h | 8 +- > 25 files changed, 3861 insertions(+), 2745 deletions(-) > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h > delete mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.h >=20 > -- > 2.17.1