From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D44A8A054D; Tue, 31 May 2022 16:34:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B61C04067B; Tue, 31 May 2022 16:34:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 8985A40143 for ; Tue, 31 May 2022 16:34:51 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VAaCOs019829; Tue, 31 May 2022 07:34:50 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gbk8n9pdu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 07:34:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JlPYuaeEGXyaF5vzLWRNwlrRvHDa98J90MkKdmnMQWVl8tuBrqj82VzEMd1F7YYB3GwtQb14xqFIjjPL/QxC1sFIiT3E7xoAxem2O/TOjzxPpAdGu6mov4fmUxGhQmh9HbGmP+qRBI/T5YG2ImnYH3vjP11c+uHxCPSlHiV8I8VEdGEhGS9iGbeAup/attsgxMxeLMXN545XomF1Ym9vQO40hB+Z5nG+EHq0z7Yi5lnfXVW8WeFf5x8AV7X+iyrxV/lfj8JEzl94sPOGe1/JEP8i5PkJIvJBnJ6bV6Es96h/om5STfzAUrRXJT/pmB2ozC/hQJp9Uphk/raB3pIaJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7yZE3O+qtdWjKhv1+oJwRx3DFowrKnusIfoTJh95Pk=; b=EXerOgETDSZU6OyxhvAC+LEk1s9BFBkn2Ix4BdC28XRNlpzQhoq02/D0UBU/OqHwwtUXnw6ioaxNt2kl4EB8UtnxL37roJW50HyC0/un5W9wQkpJxoQw4vXwPzHDviuyW+9lxYLvpdJzLl1tbqEv7lOOyLqzJovFylWvq+XRsjPnPwn9ELEqTTDcIOm3XowB2Qlb6OIFOpxYGjDkO/opjgVeEGBdjn7E7lJ6wwVMQtlL46n2GJACYQxklszxN/OFDkeJ9JtXDBQKREk8M2PXnwnTwNoHtkXyEIBkXBKtHnhgTdlbF0rkhfBHpCQgke4xeVSb0jzEU/iBYGhvzXg1VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C7yZE3O+qtdWjKhv1+oJwRx3DFowrKnusIfoTJh95Pk=; b=EoloUrh8QwVuL/ogoZVWwm+9STAEwhKXo8icQdSwurSotUSZmIsgrniqsQj2Sy6BsxzLufG5Q86AEblGolswOt3OTRAuVXuNnoy2GAkemSNjTD1dkLRbWmezyCGIR2igDQRU0vPFRIOe7nJDf/SDbbLFdFHvfDSAtDt8nWwwd0k= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MN2PR18MB2671.namprd18.prod.outlook.com (2603:10b6:208:108::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 14:34:47 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.012; Tue, 31 May 2022 14:34:47 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Index: AQHYdK0O9KfTG1pWHka/BweqAhldwK043moQgAAi9ICAAAlZAA== Date: Tue, 31 May 2022 14:34:47 +0000 Message-ID: References: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com> <20220531040439.15862-3-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9fa3d037-7218-463e-bfe4-08da4312b633 x-ms-traffictypediagnostic: MN2PR18MB2671:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rL1jQyhB5FaXHnOARVfNz0zvx9nRnzdLKlB74zOovOwHwFW7PEkyf8f5gLIZDXLTUjVnhN2HwFApuwLjDzVmXNSwPZye2WOxu2SC4Q/L68WzZ/k43HOxHTWThu/zjyueI/wTSlgFZFcR0Ibg0tphw9V2lJYzXyNMKRJtVar9Bw3Qs8Kxyy/E3IWHnFk4eeSNY9L4Vwns3DfLZ/qxD5oOjL1AYLxW0L0KpMcIgNK331+WZlgKdV2Hs5AjyK1QOvwBjNS0hHZ84cXAoxXrozz4RJm/PsC54cSfkEidxm5LZ2EJK6s1y9+KU2nOPi75IOaKWnDTbSsxpdj/PLyNgm/7NkeMST8dZqAGfKt0tkrsthG8wrzJLTsazPf+UVH3vlffQ7wa6QwIzagSVNUgJDHN8MgRYx2/0ji0MQQVeSeMuTMSikfVj71BB35OTx/l72+6ezqT8m4anDt/MDzGnQqJtSCB8zS36lk/Z185EJnJP9o//XqjJTm8dgRyZbTeUlxuZjukwkUvYQP2ZyuAdXVRU3Xrex31UBRsmdl7pLJyNilXCYRjyLHRAOzdpZSJk20Imzi+bt6eGKNic2q2I6gmKvPVpE68Xf9PRYxHJURbbPwKQVheUAYUmT81Iw+jTb8g9wlX8j1Jl2+kNWlKPh7+r12L+zoYpobLw+9GLXFQIgq6I9+KumZMDcDCV/yyGy0cHeqkEuxjqhJy/tXJzH/nug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(66946007)(9686003)(8936002)(110136005)(76116006)(66556008)(4326008)(66446008)(55236004)(316002)(64756008)(7696005)(66476007)(8676002)(6506007)(26005)(122000001)(38070700005)(2906002)(33656002)(71200400001)(508600001)(52536014)(186003)(5660300002)(86362001)(55016003)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EBhYf1Xn023TosmTLhRZqi7x0Ov9/LkzSXTQAAHUsfLKrl1HMCa+H+oDDKjB?= =?us-ascii?Q?gLogBwi9JZCEVBXhTrJX+PuNYiJwaD5LhYPK5kfE31hE5/Ul3loRrGpwZjaG?= =?us-ascii?Q?83svt3so0mVgWEsCKl7kygOu2h+FG9wbBBxH+onifg8TqZETkLC1Uqmk6hE6?= =?us-ascii?Q?pEuBEDbkZbdhhH5DFkIS43OMYXh4FOjLkm2OPDNSm34CcRrQ6qF5mYN4esj/?= =?us-ascii?Q?C8LriPOxNBoYrGNfRkLkJFqSzxHJ1eaP+HSBzGvuh5f4ngzRDiEq2EXdCquJ?= =?us-ascii?Q?HSuZO573X8VrfSS8MVzPZPfPDl7ihPdan22OQN6YdnotOMaICQG4B19lK4f/?= =?us-ascii?Q?P3SamVEos6puPcHAKq93AXFXGv2LFgoSx0JF2U1oc2J1hZuqketyFo5y1k9J?= =?us-ascii?Q?zV1Wvy0BO6IHvf4/iH0V6prIzXn2ligu//IHaQ+r0qq0Vcp/0aB0PdvD7B56?= =?us-ascii?Q?dErCrYGOcSDoIdBQM/zaIuKHJpeRGNftqzDiBUlBL3D3BPc5LDK1c9Xyy+bK?= =?us-ascii?Q?agKp6CLb4ttLgbJrt2Y3go30BtUZqLlEFfGS3eZgGwk5VBDhzdSKDV/nTmYS?= =?us-ascii?Q?nK8Rwd176SIkqIz++yvNHD548G9pDi6pyGy39zvg0LuAn3jf0H3jioD9Ll4q?= =?us-ascii?Q?Q3VpTMMD4AxLB9HGB/NRmSfvT9d/mlZS1EcVS+u6Fk2FLJ6MkgMvP92UuWqG?= =?us-ascii?Q?vZROUcmi6LVi8QWBF5eqegVsxZ5oFOaDVpUDjU2sydibI22eh4P3hbXgHWAC?= =?us-ascii?Q?qu/Wp4D3shgs0Zd266jS7yi4q2HJ6xiYLXeFH1W1SMpZ1pVaGpp/y5nB5ndT?= =?us-ascii?Q?TSIB0LhF/I4sL9fMqN7UbJ1fsLdwOX0hMGqK+ZDURW4NQmJM75Ot4aet2y+i?= =?us-ascii?Q?b5tNqQRnCAmwkTXpbOyP6SCqcwr8RiQNlhbozrCZ7QUZHWwD9TPTDERJWpsC?= =?us-ascii?Q?oIz/BZ9HKgs51fT1kliXv+AhmjeSFqaAogLkeKVuIsmYsWOK3PPZ5Na4bAUJ?= =?us-ascii?Q?H2dI6bYDtc/OVVju93qtmZv5Vc+eK3JH9PODmjGwW+NJg1dh+lL9ZXMQQ+cn?= =?us-ascii?Q?WFBpm995pcPBUTFv6sSbAHVQQZw3EoNkvhXmEwI/w6SWNnv96ZBdZVnAS3Lt?= =?us-ascii?Q?ZKYc4UiXQJZbntgFV1vGBr/vnE+q/gNOrV0z8RMHvViSuKvGQ6EC0v9M5g8m?= =?us-ascii?Q?x8zYNB0+0d8gCYiuDFAwZeVg60uW18TLcauWKhT1UVCYUlhPMVASnErICWAx?= =?us-ascii?Q?FRyJkwnrkzBWfPpMnmkP+xcFNBIPgPONg8QRwzStEk41nkuYoQdHUK7mc1GO?= =?us-ascii?Q?6etwuVxatXSBifjrn89tHbbaWy2/46y2y0wp1+TG+ONxk/PQlPn3ZJmYsSsC?= =?us-ascii?Q?kMee066BLDl5dcnA3RvnJvMEaXhC4/SXvnxgeGXOWBKsTTOv+p+Hcooi7DNW?= =?us-ascii?Q?Zaov2AHLPs76AUO7IaqjtC1tfLZmARiS9bROi7ERosxvhzuMW3kGMnh9eJLo?= =?us-ascii?Q?5WRZM9GYDewqc7Us8Rltl+xSK+KRhGudkaieU732HjKB17io0ZF1JoRxdfJe?= =?us-ascii?Q?WsMbX8mbpLOK/Ysj1C4t8LKMrECf3tG5c2EqMdkcv75trADYxERBAKCMSTKS?= =?us-ascii?Q?7/qsd4WgRk5Wz64389YHlIo6gyjoAEPkmsDw/+8BkMb53TMN0hHpGz5cxlDg?= =?us-ascii?Q?d9OrROAOHyJKetSufTFUEmnbRfdLQCHO+wrp9doZMSmilMbQo/3JjQKJBFWX?= =?us-ascii?Q?yblFvZc5TQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa3d037-7218-463e-bfe4-08da4312b633 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 14:34:47.1351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M/bEPLbE0fhiSX8PqnuZM0/72v8L/YPf3nQ161VlXGwZdvK/tmlCkqi1Ni93J/JgA/B0xEdxuZxCxG2lmDU2sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2671 X-Proofpoint-ORIG-GUID: hrUMadSDsnBsKsiPDYULt9BXf18Aze5x X-Proofpoint-GUID: hrUMadSDsnBsKsiPDYULt9BXf18Aze5x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_06,2022-05-30_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > /** > > > diff --git a/lib/cryptodev/rte_cryptodev.h > > > b/lib/cryptodev/rte_cryptodev.h index 2c2c2edeb7..7d683fd728 100644 > > > --- a/lib/cryptodev/rte_cryptodev.h > > > +++ b/lib/cryptodev/rte_cryptodev.h > > > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability = { > > > /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ > > > > > > uint32_t op_types; > > > - /**< bitmask for supported rte_crypto_asym_op_type */ > > > + /**< bitmask for supported rte_crypto_asym_op_type or > > > + * rte_crypto_asym_ke_type > > > + */ > > > > How is this supposed to work? > > Ke_type and op_type are 2 separate enums which can have same value. > > How will the user identify which one to use? > [Arek] - by algorithm - xform_type. Ok got it. But please update the comments to clarify this confusion that th= is Based on xform type > > Shouldn't we split this too? > [Arek] - for me both options are ok. For some SM2 may be bit challenging = here, > but in such situations we should have different op types for KE and OP. T= his > would spare this API from having one op with majority of fields unused. > Though it may be split too, not big problem.