From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10871A0C46; Tue, 31 Aug 2021 09:04:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2E6B406A2; Tue, 31 Aug 2021 09:03:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AFFC040687 for ; Tue, 31 Aug 2021 09:03:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 17V6HucL005032; Tue, 31 Aug 2021 00:03:51 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by mx0b-0016f401.pphosted.com with ESMTP id 3asf15g5dk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Aug 2021 00:03:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgKaCiYca2E8F7wa2fkE/6YOv+j/AgwdxmX7MRojn2mu9lD9ShUicFziIl0sEAxPDPp+oDdzz99wjks/Ysd1EzxsFCffarz5jVxMnSzx7uVH2QnBft9gQ91atDSSdBzcIFU82nci8OCWmjZY1TeRzufmi5n0vfybZlORtg5xYlmvsOEkB/b0gkv3Bo6WeHFIyh+xZD8GaCZbt51Lkb/3IKV3yOcGqAHtCRmtBgjhUf8rhSDK6G2ePyShrueNeYvyynvN7tfO7AgkLxnUOurLxbpVsgfWAaSBY6soTN8GecGF/lY7Au9F0simrBQM0gWCN/Q4QbezrNripbllmoirnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4xn0CE+xrktpy1iLxDt1XtkvvFLcQYlWmsdp2cz89A=; b=KZFY+iss+bh6geGEHmygmyTyZ42urEYmyPo1q9aR9WDn81ci75Wmv0mI0L2lHZ+h1fbYjR8Xr/RpKHbN/PimU0Y8IyU5LnmWavyoITjg9SzwpkKRDnbBkBH+NRgWTXNFovR0qa452HNE1yRfO7mdXj97VPLYDGW+hcCS6LteqnU0T/2lFOqSt2iXzBwmniqew/deS/OsWFmnpwO1aMWmF6162PxwBfIXeXqTomz1sXNAADfsaB3E28DOf85flNf/k+BJPybQN1eu6BsedcWieLMoqVt1e6QsO66LJV9NduzzBc71Pb0U6Sec15N7R+QHX0kk9ausoQWg7wH5M2c9XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4xn0CE+xrktpy1iLxDt1XtkvvFLcQYlWmsdp2cz89A=; b=N1e9Tm+3/hwWXLohvB81oKlTX3iT9EaIWyEH1rloLPCV30beNyALBaD2giaoJKG8LcKau+B76CF86qHzF61/oE4OfMkyAqJMn5TSTY31Xm+jI/PWptzvWk5GQQfxzIm6NHJnO0b7VUn5ujzK58B3GAQ28X0whpq1JWjtogHHeYk= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4652.namprd18.prod.outlook.com (2603:10b6:303:e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Tue, 31 Aug 2021 07:03:50 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%5]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 07:03:49 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , Matan Azrad , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Ananyev, Konstantin" , NBU-Contact-Thomas Monjalon , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" Thread-Topic: [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs Thread-Index: AQHXjiEPBnxbhBM+ukePEjdPj9/KUatt3+AAgAAVOGCAHqmLgIAApHcw Date: Tue, 31 Aug 2021 07:03:49 +0000 Message-ID: References: <20210805200236.1180289-1-gakhil@marvell.com> <20210810195020.1423013-1-gakhil@marvell.com> <20210810195020.1423013-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5fd414b0-4bb5-44c6-df19-08d96c4d7c16 x-ms-traffictypediagnostic: CO1PR18MB4652: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XgfbD2m+kdckFjc8M7Fl3SxmaZn5ISea6Z1RHdCctNgOsGvEKd4zsQHmmD/juG3OlQY/tahmaXwHA3oXsBTq+eIy2SIB1E/oYH56gpCeIsfgUN9k8dvET2bWr8XYQTWV/EAxtW2/nJCD16GgeVheMwRB2Wcal0f1v/H9cNh/qkptThwin/D2MuqfQUMrDEFLoohkW8pEXIMma2OW7bJcg65CQ0JmRB+i3V+i6L24KDORzA5kmVd1ZF/dXR6dJgpvdrzwQttBBdYxm2+yHdvQzmTRvMmJLvuCcih2Y0Lg0YKtnjxYNAKLCqkW8rcVCEobAHeWcSwA2SQ/3CWb4tLAzG5VaV+h+S2wuTAyC2z5yQA6RDA/73nV+56FoZ27pdSbiyhlHSZJntTFwlMV3KJ19qm2NRJKli6HvZXuYbOhvJXjrWN6asMKoJo88pNQx6XvJt1iK1Iqj6swn62u3msF3rDbiNQOh5l0fqZnIqLsgjOwW4l/IANfLBr+Kwcb67Xm042GDN0W2gbvOEiHE1BWzgL/yJLGIUSv1vxhl3V0oUwO3E14NMuB/J2iUodRNUmeiCBYNR/H5X/l4SqmOmiMcBn6yWEsSfkRs3yB4LCZLAitK6GT83YOfhWl4w6ijtp7q6NKHnnJfk1gI9xxhJnOk+CdfZEOSiEr9IgfK4VtzD3HlZFcfMfDgLYU7tlCx0Q5HDE+7F6Hs0VEAmReR1FRXw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(8936002)(76116006)(33656002)(7696005)(8676002)(66556008)(66946007)(64756008)(66476007)(66446008)(2906002)(186003)(83380400001)(6506007)(38070700005)(478600001)(86362001)(7416002)(52536014)(71200400001)(110136005)(122000001)(5660300002)(54906003)(38100700002)(55016002)(316002)(4326008)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?McgbNXq0jurXDEBBCmIvceMFCJxKib+w0Z+7JhbdYpaxqPzqWv3CJw4xA1dh?= =?us-ascii?Q?HcUTB1a4uQXG3Dii/E8FQq8UX5w7bDlYcVVbappOvTgVFcp0+y11CzOMSfDy?= =?us-ascii?Q?QCahQJ/wZiDZ5YOr7HwrSYjvAj83aVSASnTs7Lzx+Rc2kBP5SeGFVUfHoXnv?= =?us-ascii?Q?QDhHri0yfAakTwAmsRpoRr3Hsf68VcLKQPGboPasYsYd+FHfg3xc4FflkKVS?= =?us-ascii?Q?jZYFnj7iFEB1nU5aSHYEfTQAsFnJmw/aUEpe5Y/1JlpVts0OpZ4QvgClicbn?= =?us-ascii?Q?zoHYE0+41DGvOK76KQEz2ua8O8HCEDkDLeO/Q+CBwKVEM65odbf1KlMI2vmW?= =?us-ascii?Q?gMlrlVh+3YiC0Y0/+d6SKGOblhRaUPCGP6nIZ8RGzrFhjSIcbLhsi+Lzfk1S?= =?us-ascii?Q?H1Kf/5mM5WdLIbCcVauKQhr4xyjYb1xbyvXgn7IGaJR5nR0QdbTwBBEehvNw?= =?us-ascii?Q?pzMjeHw0cGNO+uPrEv0S1vDpJdOEVATSHTxw8M1TT5dXLc4P6dvReDr+c8bc?= =?us-ascii?Q?5/IGrFy6EhfDBx9M7OiY3z91/FMPtS0DamVrNToMgC1wL+fzoxFdXHnE/RxY?= =?us-ascii?Q?qvqFKKzpJcu0VSmKgKjOKHXBkGKas7ndzYLe+ysIhmow1xj0koppaS7SqNbI?= =?us-ascii?Q?DtZbRWMa1h0+lroGBl7j4Tt9QYBDy2b1Ifo/cK1Op3GuVhKajasPkgFsipki?= =?us-ascii?Q?06V0llW2vMfGJVKYu41hA77N4pscA+2lZDRmOPo5CGK/Hwdm6ZZpi94PeYGe?= =?us-ascii?Q?BJ4X9/Tt4kgM9k4wMRrKJWmSNNybOOitP5ydysTfBgmXct0gBSmogo3fQmgu?= =?us-ascii?Q?aov6pE2kTCwqxdzZ2cV+W+Qwa27EODER/1h0QtaMFghebiuxeFxidd5DqJVi?= =?us-ascii?Q?PeiNZ56FFU+9oAzvaJ1bELDwU/Q8+gyJIlk/QA8WR84QH7PFgLo1eDM9WD81?= =?us-ascii?Q?NZhGwv0Th6AusgbWQXkkTtvbpB6BMhY3iHd/slYo7QnbZrsyKKZ5x8/zTScT?= =?us-ascii?Q?D5HtrlI1H3nlExpuwZ31nL9qKUaPDet7GhfbrTDUakNQaDVVmGsRuuot9xkH?= =?us-ascii?Q?2ei5QQ7hYbE1VhdVkZw3xGKGYirA5f5ubYlUcZ1DsDcMo+MULB0YStvdqsZy?= =?us-ascii?Q?Jgzn/BpmBxzkLW/fQ5l2FxDfst/hhjfAszDIkNLExlWPC2m5w/5Au9FepB96?= =?us-ascii?Q?AUWPG8ipVGKina5e2w6mt0qiJo2wdzt74g9YqPQk6/kot0H8HuHBRJLldYNd?= =?us-ascii?Q?UJbOWXegPf1ErbRBbamyDgy34BRJqfiumhcgoj7XX5lm5V69Gs+AOhbz35IH?= =?us-ascii?Q?i//ShRY8TONLfqFMuFxQZ5A/gOTBiA6/agA7nC6MZe9H56XU5J9nfvNjHx3H?= =?us-ascii?Q?NfXHhjYFpYcTlE6cyO7EEDhbtkrY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd414b0-4bb5-44c6-df19-08d96c4d7c16 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 07:03:49.8088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DCY1N1Qrte0QpQ6nXQs67xqThdwohkF9rniyxOqsJNpFOh6XG2c0Xp41qaK13V8X3OggggjhkBSqL4GxInvKKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4652 X-Proofpoint-ORIG-GUID: ysj258oIWSRJkkbnv4byXQZaoIMSkfgp X-Proofpoint-GUID: ysj258oIWSRJkkbnv4byXQZaoIMSkfgp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-08-31_03,2021-08-30_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, > > > > Some of the cryptodev APIs are not allowed to be used by applicatio= n > > > > directly. Hence removing the usage of 1. queue_pair_release: it is = not > > > > required, as configure > > > > of queue pair release the previous queue pairs and the > > > > dev is not directly exposed to application, hence cannot > > > > use its ops from app. > > > > 2. rte_cryptodev_stop: it can be used directly without > > > > checking if the device is started or not. > > > > 3. rte_cryptodev_pmd_destroy: application should use > > > > rte_cryptodev_close instead. > > > > > > > > Signed-off-by: Akhil Goyal > > > > > > Look's like it should be backported to stable releases with a Fixes > reference. > > > What do you think? > > > > > > Besides, > > > Acked-by: Matan Azrad > > > > > Yes, Agreed. > > I wanted to get opinion from the Maintainer of fips app first if the ch= anges > > are > > Correct or not. >=20 > Hi Akhil, >=20 > FIPS requirement is upon failure of running self-test the device memory > shall be destroyed completely and not visible by the application at all - > rte_cryptodev_close does not provide this functionality. >=20 > In this case we may need new API rte_cryptodev_destroy() to replace > rte_cryptodev_pmd_destroy(). >=20 _create and _destroy are called from device probe and remove. If the requirement is to use pmd_destroy, how is the driver created again? I do not see the use of rte_cryptodev_pmd_create() function. The use of pmd APIs is not allowed from the application and it looks someth= ing Is not correct here for the use of destroy API. Please check and fix as required. Regards, Akhil