From: Akhil Goyal <gakhil@marvell.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Declan Doherty <declan.doherty@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH 4/9] cryptodev: fix segment fault when parse input args
Date: Thu, 2 Mar 2023 08:11:15 +0000 [thread overview]
Message-ID: <CO6PR18MB4484ADD74BD52D6638E57C2BD8B29@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230302075012.32423-5-fengchengwen@huawei.com>
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
>
> This patch fixes segment fault when parse input args with 'only keys'
> (e.g. socket_id,max_nb_queue_pairs).
>
> Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
I would say, you can squash your 4/9 and 5/9 patch in a single commit.
As you are doing the same thing in both the patches.
next prev parent reply other threads:[~2023-03-02 8:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 7:50 [PATCH 0/9] fix kvargs callback prototype not clearly defined Chengwen Feng
2023-03-02 7:50 ` [PATCH 1/9] kvargs: detailed definition of callback prototype Chengwen Feng
2023-03-09 13:12 ` Olivier Matz
2023-03-02 7:50 ` [PATCH 2/9] compressdev: fix segment fault when parse input args Chengwen Feng
2023-03-02 7:50 ` [PATCH 3/9] compressdev: fix null name " Chengwen Feng
2023-03-02 7:50 ` [PATCH 4/9] cryptodev: fix segment fault " Chengwen Feng
2023-03-02 8:11 ` Akhil Goyal [this message]
2023-03-02 9:21 ` [EXT] " fengchengwen
2023-03-02 7:50 ` [PATCH 5/9] cryptodev: fix null name " Chengwen Feng
2023-03-02 7:50 ` [PATCH 6/9] net/hns3: fix segment fault when parse runtime config Chengwen Feng
2023-03-08 7:37 ` Dongdong Liu
2023-03-02 7:50 ` [PATCH 7/9] net/virtio: fix segment fault when parse devargs Chengwen Feng
2023-03-09 15:21 ` Maxime Coquelin
2023-03-02 7:50 ` [PATCH 8/9] dma/skeleton: " Chengwen Feng
2023-03-02 7:50 ` [PATCH 9/9] raw/skeleton: " Chengwen Feng
2023-03-02 9:17 ` [PATCH 0/9] fix kvargs callback prototype not clearly defined fengchengwen
2023-03-09 15:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB4484ADD74BD52D6638E57C2BD8B29@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).