* [PATCH] test/crypto: fix unnecessary stats retrieval
@ 2021-11-11 10:56 Ciara Power
2021-11-11 10:58 ` [EXT] " Anoob Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Ciara Power @ 2021-11-11 10:56 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, Ciara Power, declan.doherty, stable, Akhil Goyal
The device stats are retrieved in the testcase teardown function,
but are not being used afterwards. Remove this unnecessary call.
The stats retrieval for the device is being tested already by a
dedicated stats testcase.
Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Cc: declan.doherty@intel.com
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
app/test/test_cryptodev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 52457596e2..a2f5e71be0 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -1417,7 +1417,6 @@ ut_teardown(void)
{
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
- struct rte_cryptodev_stats stats;
/* free crypto session structure */
#ifdef RTE_LIB_SECURITY
@@ -1464,8 +1463,6 @@ ut_teardown(void)
RTE_LOG(DEBUG, USER1, "CRYPTO_MBUFPOOL count %u\n",
rte_mempool_avail_count(ts_params->mbuf_pool));
- rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats);
-
/* Stop the device */
rte_cryptodev_stop(ts_params->valid_devs[0]);
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] test/crypto: fix unnecessary stats retrieval
2021-11-11 10:56 [PATCH] test/crypto: fix unnecessary stats retrieval Ciara Power
@ 2021-11-11 10:58 ` Anoob Joseph
2021-11-11 12:00 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2021-11-11 10:58 UTC (permalink / raw)
To: Ciara Power, dev; +Cc: roy.fan.zhang, declan.doherty, stable, Akhil Goyal
> The device stats are retrieved in the testcase teardown function, but are not
> being used afterwards. Remove this unnecessary call.
> The stats retrieval for the device is being tested already by a dedicated stats
> testcase.
>
> Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
> Cc: declan.doherty@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] test/crypto: fix unnecessary stats retrieval
2021-11-11 10:58 ` [EXT] " Anoob Joseph
@ 2021-11-11 12:00 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2021-11-11 12:00 UTC (permalink / raw)
To: Anoob Joseph, Ciara Power, dev; +Cc: roy.fan.zhang, declan.doherty, stable
> > The device stats are retrieved in the testcase teardown function, but are
> not
> > being used afterwards. Remove this unnecessary call.
> > The stats retrieval for the device is being tested already by a dedicated stats
> > testcase.
> >
> > Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance
> tests")
> > Cc: declan.doherty@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-11 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 10:56 [PATCH] test/crypto: fix unnecessary stats retrieval Ciara Power
2021-11-11 10:58 ` [EXT] " Anoob Joseph
2021-11-11 12:00 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).