From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DBB7A0093; Thu, 13 Jan 2022 14:18:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B297C42731; Thu, 13 Jan 2022 14:18:32 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 13D0940150 for ; Thu, 13 Jan 2022 14:18:30 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20DABBGZ029805; Thu, 13 Jan 2022 05:18:29 -0800 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3djarna22q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jan 2022 05:18:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2HK4Ce+J4QAFfNeM0iopMPLkTqNepXXG8VMIAyQSe2jCN1yeOsvNAj0R4sk3aAyjHRhW36Dk5TbRgcwJzl4GnedutufGUMFIxTjet9Dh8UIJV+c1GEP3M5i8UVoDivlL06MRdBbi0gSNkYBx4kZsaEpmV8Qsw2f7pEfCrPOy4pU3M//APbyRK21prKUpkBDDzDlpqgyeVFYgsSVIeWOzXfI2NrJ5sBoV38gLmzqtjfbiig1K1wkeBAJ1+0hPvEDl+MXsE+futaFHSHz/+zZ0DlGIdqEnpdkVyiSPccllL27Wydq7r4fFioFVxtjctm/Bmh8yldoj902JVnQBQFj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MyjwvTT+2VmBF8hfYb/971D0gZx5UVVquR2gcAVWHhA=; b=gcsDOvAPiEGdUG1AlZGv36gPNwCZuXJhwuAA3HxM1GiTsTS951iegYcp3kz8yQDJreEVLg1Oovo2IYImsHIUXTWU22Kba9UXf4CY+dSbJcphn9ROdH92w0owizfmaNF6uomE8S6o/ly7aEs0o9F/oTeiiG6BrWGIS+r/N4jBS6NgY64O4aKK5XMQgYZQBfxFfa0wvjq6rF0yCoSUEKSNjqw0OmURmLHJF1ZfoyanPJRlahIYHpETKNkg6OggE10L2Rxw2kBrS9Wruj4RoV3GqSuTc2BcCXWJxaxQX/3GEY5wLAw86QowJ38HgSlEGR9UhYSdMghG9jIaZXyjcXVCcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MyjwvTT+2VmBF8hfYb/971D0gZx5UVVquR2gcAVWHhA=; b=DSy/q1GcBMooVfwEzcVMd9zICnUGWCF//5MlM1dUDTAys007EoNVC0znTVpQ+66B/vs/kDDG6JQCbSDbWruu+C0P3Idy3Yf1LGq3BemGhxH+hitGry773UhwpBvdsbHHVqprzBNzShJgNfgfGQIQGtUZmMZTpoVEwFLSkkDey3Y= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN6PR18MB1170.namprd18.prod.outlook.com (2603:10b6:404:e6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 13:18:26 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%7]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 13:18:26 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Topic: [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Index: AQHYALPPmu8JVnwqYk2KffUFopwd36xeGRCAgAAa47CAAsakkA== Date: Thu, 13 Jan 2022 13:18:26 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42d848b6-68cf-4fa9-fb53-08d9d6972efc x-ms-traffictypediagnostic: BN6PR18MB1170:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Uae9NFhB5Fl0BRFc4TXOCu5t2n+a6pour7d0nc8WRYTkAbshwRFfnJnWRxGYkcy61mtzMG2sp3gW0eVb3rejSijgL9APb6N546Xgjjiybn4qOwipCYk9cvoByhwWOE0oEOp95YRzMnMY/+cFDbr7tkG7sROlivO2tlL/yWY9NwclV+Vc75+m/A8HT5fOpDUIWEwdBD/eRiO8XAjfbK9p4cW/EWsFOQB399oy/RJNAjivsnsUPzVHWs3BSY6m7RjIfpa3XWFxZdq6RXzb+8EwL2wS/QOrdkZkrigs1CFCnn5bjNFaqDAhFk1zRrShGaZAG6wzhI/Tt7w155sew9apxSTxxHFt7XWUiE2IoXNHbi2CaEMRcr22Odaau7HRuJlRGSlrgmwzZPFklhcL31ALZKOGQTs+UGZNI4mph4uAZlAmqzWkbcOjzmguhYKrdKnHvxvl3ubWsRiNW7kJ6GdLq9haRIA+vG1Z27Qm3wtBqFFHaanZOyJ1UNAHWM6XGa08YkQDIoj5zfFb+qQvIevlbfLP8wlUqnMLshlkLXQBA/dIogc/gVzy5NDtFq9i2IgSLbwbpbaRPAmDWNj7UFzpn2f1wk2mgmAxP8Y8EOKtu0TG/1iFBUXloLxJoeIoZZpjmZR+25XFfzxYp2cqvfNxeOZgugqIng2Jeu1pWOenXVaYHhrzB3ikf8CFoLLgbPXGRLg+p4fo9gnHbc9UTDSNA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(110136005)(66476007)(55016003)(66946007)(66556008)(64756008)(6506007)(8676002)(2906002)(7696005)(66446008)(71200400001)(316002)(76116006)(38070700005)(186003)(8936002)(38100700002)(7416002)(33656002)(86362001)(52536014)(26005)(9686003)(55236004)(4744005)(5660300002)(4326008)(508600001)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1eNakNfiusxFuZ7i/365RkCWtlFCDux3nZ+DDXuaEG89cHBOcPVEwOmnuAzg?= =?us-ascii?Q?L4rof04mMYQOM1oB71yoGfIrrVOkkPLHo4no5Z8lwUU1/Kzz6TY7u43BoVPr?= =?us-ascii?Q?+3+aGQ9TqnpMu9bquRduCovXuMlVdJGhuyutJs7V5GjDmI3h8PMR+Jl3WqDe?= =?us-ascii?Q?Pdy1nFTpSBFlJHDENWJU39nxlzfDhihFHT0Q7bgp6kaIT8r8FWOBp4GcbPTu?= =?us-ascii?Q?BCwk/CjOJLaJ0aEVYBlseoGO+N8/GO3VO4/KMgZQ8vB8ACV7cHr90Quz+SJ7?= =?us-ascii?Q?lBut65McuyC9fGPhOf9it0LZDxRzUaSO/HCH/jqDT9zCTYrbD6UBRicF8rHf?= =?us-ascii?Q?E4WJlmeroCqAwIZn2jRHYnlA2r/84AfxjToypIcu0FTKuwFJfvV5LPiYZouV?= =?us-ascii?Q?kKocBvx2lpiCPdOhasdzuuBsiQ9QZs4XHMXpd4V+RS50uazo8VzQ5eTB82CQ?= =?us-ascii?Q?N4jlIMMyPKZxqSkfg138/mSyTy1Fy56Du7RBUo4V4Yag/E17c0AHraOHZu+i?= =?us-ascii?Q?DsQW/JujKXP7RB4yh/uD4Oj2dtnTrVzHyShC2lQ03suwGjpOiqOGvzBGdz5z?= =?us-ascii?Q?4gll+GJzjmtVxUvL+b78atMX5smaS4dffv5N/7RuqnpuAC4D/3Xc++A3N6Jw?= =?us-ascii?Q?6H/bLG5Io/vYoNP5d2cXrhSQ3qCCM3miNBmJen5bwtuZu/Lf+TB7CJx4fBhF?= =?us-ascii?Q?NLXHWIoabZg0zhT4stJpOfj8naBazwPvha38OmOdZ7SvFOSjZIfIutKLvcUO?= =?us-ascii?Q?XTclIHa8IUDZPlUDXyyNAxAQHhNpZa+b8Kyn4hl4b9Flo9/9ELbhWHE5z7+A?= =?us-ascii?Q?bVultwEGEpXAnBCSggCa5MceJdBuoJQ27QG577/aNdwYw3SK8VCaB9mrpcnM?= =?us-ascii?Q?Bbzcl1rxV3C9z7+ry9totuYODocnFNTVUENllH+3sUKbE4h2+XO2RtFgd/KI?= =?us-ascii?Q?L3gV5mn44zpHCTsFdqq5vksazyqUkc/ALAGZ/nIF5AjDmbeLj2+LAuB4oAZ2?= =?us-ascii?Q?mKSfFTZvL/2l+2aPUF3wqyd/BlQn9Fubp8qEl5/B1+QpXYWSE4Zailm4FLuX?= =?us-ascii?Q?ndtm5tWKCzJD7eMi77za+hDl4WHLyTt2Vf+KcZbgl6f68rJKHJhlwjBI+hjY?= =?us-ascii?Q?YwU4YxHoYIEbxAnx7vJBNAN7YOUsmJ7o9+PErT9eiKTiz4A7WiMEzTA21QSr?= =?us-ascii?Q?lPauBk+NVjpeouD5EHfIz2yMQdhjL53FC+vSCoLRv22HjYrMUZ2/rr1CVyfJ?= =?us-ascii?Q?uuy71RJfirTy+ku0WQB6qWtT4blOvsdTDEaUv16WZazicl/Cx6DNGnmTkTzp?= =?us-ascii?Q?gaY6d7jjWFXcLwD8S3UwaM9eQvsIC2pm8RuVL05M0DaGpVgc2s2eqhwyv8sk?= =?us-ascii?Q?iGA9AcuUbE9lj+JNy4N118bN9wEm6fAu/rsqkgHLp0oDAi7mQgE/kJEiYprT?= =?us-ascii?Q?Kjmi0kS4BdxR8ygRo48gJF2oAU2BPuxbAYUgEqbYgg0oqS75Ok68vqtMJUVu?= =?us-ascii?Q?BzElvpx/DEaiMaD2Lr2qGOSezbOYdL/bR4EYvKHwwOI54xpLuimhtK2W5Yqf?= =?us-ascii?Q?R8PfqLh79jsx84SALNRgJd6IBS8cPdCR02C+or8kpUEFxuHvxnILjH6LzbIe?= =?us-ascii?Q?Qw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42d848b6-68cf-4fa9-fb53-08d9d6972efc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 13:18:26.4966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W50SOPxhtQChUcnt4boAUxTxwZ53B3z3hLErbBlAAKwuS/SuqtE4OBv3JVgGchAum/EEYAB5/rab7fkT7mTjZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1170 X-Proofpoint-GUID: jnhuZphgsUH1bubp1eexrKYUSiXouXnA X-Proofpoint-ORIG-GUID: jnhuZphgsUH1bubp1eexrKYUSiXouXnA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-13_04,2022-01-13_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Konstantin, > > > Hardware IP reassembly may be incomplete for multiple reasons like > > > reassembly timeout reached, duplicate fragments, etc. > > > To save application cycles to process these packets again, a new > > > mbuf ol_flag (RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE) is added to > > > show that the mbuf received is not reassembled properly. > > > > If we use dynfiled for data, why not use dynflag for > > RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE? > > That way we can avoid introduced hardcoded (always defined) flags for t= hat > > case. >=20 > I have not looked into using dynflag. Will explore if it can be used. The intent of adding this feature is to reduce application cycles for IP re= assembly. But if we use dynflag, it will take a lot of cycles to check if dyn flag is= set or not. As I understand, it first need to be looked up in a linked list and then ch= ecked. And this will be checked for each packet even if there is no reassembly inv= olved.