[dpdk-dev] [PATCH] doc: announce SA config option struct changes

[dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Akhil Goyal]

From: Archana Muniganti <marchana@marvell.com>

Propose new fields to support offloads like
- IPsec inner checksum(L3/L4)
- IPsec tunnel header verification
- TSO
- etc
in the structure ``rte_security_ipsec_sa_options``.

Signed-off-by: Archana Muniganti <marchana@marvell.com>
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
Proposal for changes are floated as per below links.
https://mails.dpdk.org/archives/dev/2021-June/212977.html
https://mails.dpdk.org/archives/dev/2021-July/213484.html
https://mails.dpdk.org/archives/dev/2021-July/214521.html

Cc: Radu Nicolau <radu.nicolau@intel.com>

 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6a35c7649a..96192b4a41 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,7 @@ Deprecation Notices
 * security: The functions ``rte_security_set_pkt_metadata`` and
   ``rte_security_get_userdata`` will be made inline functions and additional
   flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* security: The IPsec SA config options ``struct rte_security_ipsec_sa_options``
+  will be updated with new fields to support new features like IPsec inner
+  checksum, tunnel header verification, TSO in case of protocol offload.
-- 
2.25.1

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Anoob Joseph]

Hi Akhil,

There are 2 more items that I would like to add.
- IV gen (in ``rte_security_ipsec_sa_options``)
- SA lifetime configuration (in ``rte_security_ipsec_xform``)

http://patches.dpdk.org/project/dpdk/patch/1626759974-334-2-git-send-email-anoobj@marvell.com/
http://patches.dpdk.org/project/dpdk/patch/1626759974-334-3-git-send-email-anoobj@marvell.com/

Do you recommend sending separate deprecation notice or can this patch be updated to cover those as well?

Thanks,
Anoob

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Saturday, July 31, 2021 11:14 PM
> To: dev@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>; radu.nicolau@intel.com;
> declan.doherty@intel.com; abhijits.sinha@intel.com;
> daniel.m.buckley@intel.com; Archana Muniganti <marchana@marvell.com>;
> Tejasree Kondoj <ktejasree@marvell.com>; hemant.agrawal@nxp.com;
> matan@nvidia.com; konstantin.ananyev@intel.com; Akhil Goyal
> <gakhil@marvell.com>
> Subject: [PATCH] doc: announce SA config option struct changes
> 
> From: Archana Muniganti <marchana@marvell.com>
> 
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
> 
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> Proposal for changes are floated as per below links.
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
> https://mails.dpdk.org/archives/dev/2021-July/213484.html
> https://mails.dpdk.org/archives/dev/2021-July/214521.html
> 
> Cc: Radu Nicolau <radu.nicolau@intel.com>
> 
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 6a35c7649a..96192b4a41 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,7 @@ Deprecation Notices
>  * security: The functions ``rte_security_set_pkt_metadata`` and
>    ``rte_security_get_userdata`` will be made inline functions and additional
>    flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* security: The IPsec SA config options ``struct
> rte_security_ipsec_sa_options``
> +  will be updated with new fields to support new features like IPsec inner
> +  checksum, tunnel header verification, TSO in case of protocol offload.
> --
> 2.25.1

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Akhil Goyal]

> Hi Akhil,
> 
> There are 2 more items that I would like to add.
> - IV gen (in ``rte_security_ipsec_sa_options``)
> - SA lifetime configuration (in ``rte_security_ipsec_xform``)
> 
> http://patches.dpdk.org/project/dpdk/patch/1626759974-334-2-git-send-
> email-anoobj@marvell.com/
> http://patches.dpdk.org/project/dpdk/patch/1626759974-334-3-git-send-
> email-anoobj@marvell.com/
> 
> Do you recommend sending separate deprecation notice or can this patch be
> updated to cover those as well?
> 
> Thanks,
> Anoob
> 
This patch is to cover changes in ``rte_security_ipsec_sa_options``, hence for iv_gen no need.
For ipsec_xform a new one would be good.

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Akhil Goyal]

> Subject: [PATCH] doc: announce SA config option struct changes
> 
> From: Archana Muniganti <marchana@marvell.com>
> 
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
> 
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---

Ping for Acks.

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Nicolau, Radu]

On 7/31/2021 6:44 PM, Akhil Goyal wrote:
> From: Archana Muniganti <marchana@marvell.com>
>
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> Proposal for changes are floated as per below links.
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
> https://mails.dpdk.org/archives/dev/2021-July/213484.html
> https://mails.dpdk.org/archives/dev/2021-July/214521.html
>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Jerin Jacob]

On Thu, Aug 5, 2021 at 3:44 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Thomas Monjalon]

> > Propose new fields to support offloads like
> > - IPsec inner checksum(L3/L4)
> > - IPsec tunnel header verification
> > - TSO
> > - etc
> > in the structure ``rte_security_ipsec_sa_options``.
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > Proposal for changes are floated as per below links.
> > https://mails.dpdk.org/archives/dev/2021-June/212977.html
> > https://mails.dpdk.org/archives/dev/2021-July/213484.html
> > https://mails.dpdk.org/archives/dev/2021-July/214521.html
> >
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Akhil Goyal]

> Proposing following two new fields for IPsec inner checksum
> configuration in the structure ``rte_security_ipsec_sa_options``.
> uint32_t ip_csum_enable : 1;
> uint32_t l4_csum_enable : 1;
> 
> With these config options, per SA, application can specify if
> the inner checksum(compute/verify) to be offloaded to the
> security device.
> 
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
> 
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> ---
Marking this patch as Not applicable,
As a new patch is submitted for consolidating all notices for same structure.
https://mails.dpdk.org/archives/dev/2021-July/215906.html

[dpdk-dev] [PATCH] doc: announce SA config option struct changes

[Archana Muniganti]

Proposing following two new fields for IPsec inner checksum
configuration in the structure ``rte_security_ipsec_sa_options``.
uint32_t ip_csum_enable : 1;
uint32_t l4_csum_enable : 1;

With these config options, per SA, application can specify if
the inner checksum(compute/verify) to be offloaded to the
security device.

https://mails.dpdk.org/archives/dev/2021-June/212977.html

Signed-off-by: Archana Muniganti <marchana@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6bfd7..da65ae68be 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -141,6 +141,10 @@ Deprecation Notices
   in "rte_sched.h". These changes are aligned to improvements suggested in the
   RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
 
+* security: The IPsec SA config options structure ``struct rte_security_ipsec_sa_options``
+  will be updated with two new fields to support IPsec inner checksum in case
+  of protocol offload.
+
 * metrics: The function ``rte_metrics_init`` will have a non-void return
   in order to notify errors instead of calling ``rte_exit``.
 
-- 
2.22.0