From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CECEA034C; Tue, 11 Jan 2022 19:54:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E92354274B; Tue, 11 Jan 2022 19:54:24 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 876BF410F1 for ; Tue, 11 Jan 2022 19:54:23 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20BB236H012288; Tue, 11 Jan 2022 10:54:22 -0800 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2043.outbound.protection.outlook.com [104.47.57.43]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dh8nm1pc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 10:54:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4bpYW0rnlsrJVe0X8JoiZoBzruEH4khz3h4Cc8M6DTM+9Vb9izNPCMLwsH2tGzbtx5JKFd/6sOOKrpNt+Pt6OnoS1fsfgjiSA0IkawSVFuR86rfVioj2XZWM3vqX4fTxp3v6zVw2AYUfrNKQfLL0L81Nk0xjacBvvOioUvIB8opENb3NG/AfQnxjxg7rJaaScMISXZJNlnac34x195T8E+/Ot0S4UOb+avCsZapPzBGx2EW53G16MRAiGr8oNPcyaCvPWrN9IjjkjHTCB0zRUi/yYGhyRDxX/Cs02TBBthuJjsfxwZDsYSZT3il26/d+c+lxKyXRp6nYZb002KtwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i9pLqAdu9/mspcXzDRSTt3mNlnK4FOLPHpiuk6vU8Pw=; b=AA5nH45Bg38yHsJRcAfT/R3HNJFLqr694nJ6t5tq+1R676En2h8TKvEGNRG2YgN45L6m6GsJd1KG/L9VRf/NkI6EkrCsXT7+JBDGsxgZlEdSik3H8oZOcQE27hJpkZ+h3VEehe3I+IIcRu+zPHCgmVOcxFmkRaJHSsPaVLuIVnS6UlH0LG248DmKpj6S9WuHVwVrWlLHXbNWzQWGizpC06HfftEaM7e8OlOc8MoaPxj0ryXTAUUY0Cq9M9I5oCDI7mFNndOk5WwrLNknb6hHaeWQRWQ4GVye+DpaaOcEhjWP3vFJUJu5TnP/X36v0pzi73GN5/4OuxDP+7j+Wmf5EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i9pLqAdu9/mspcXzDRSTt3mNlnK4FOLPHpiuk6vU8Pw=; b=uXN3ZBgrFWVyinL6+x+cfQDI9qZdfFRWHUbVvyNgffVP8V5bWpwlbDqkY4nvCOqVMGQBkC0nuh/IsnBN4LgBlT8XSUIUoe1pox6Mr3iRwdPVWJUay7mdj0Zs2NdJouVWhIJmTsG53gfV6wWgrF0f5/x8/I3FscmfQ8LgE7Jy9S0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4762.namprd18.prod.outlook.com (2603:10b6:303:e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Tue, 11 Jan 2022 18:54:20 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%7]) with mapi id 15.20.4888.009; Tue, 11 Jan 2022 18:54:20 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPOiP3b/bX9/ESNWXt27mVBoKxeCfCAgAArc8A= Date: Tue, 11 Jan 2022 18:54:20 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a96e3fcc-e3f7-48f2-d5eb-08d9d533c6eb x-ms-traffictypediagnostic: CO1PR18MB4762:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SgyeFrg1R55xmBqEKWjdRNISQ1QToEw5FNujA5EKldjtDMszy5rbobL+I9BWTnPRiUl9gtDsBouBb+MUPuMpQttGYMiC8o8RCSAuqpdZJ1yx9MLgoG1isZpHGcN7B4xIXZDTqTqSFIyT92xrJWttQ3TVJTfNocjjcKdHcHFQRSbOwPeAlXLXVOz3VvRkEf42eSk2CkWWuT4hiew+lJ78ddFAZAwbNyZuJ1/7ASJN2RqYIrigbJqyrr1mqFux+q8bVoiMpe888SZZnLiPnraKqZmx0XM2qQUZaPfqrsX+eqV5Z3baXv2IyZ3k+ADwX1RROaUuIAj8nJfSFd/r+2JAecaiWO6eGXKOlzSBYSK3KZHf3MjQXF4i/QNiMOz227p5XO69aZhJMnJA+280Audkvt0d+ajuFe0CwKLuPkw7gUpUhFu3BocrJR45JaJPxlSO0yKk+D1eVjiLFL94fu5/5YNJjumDEe3wGjW0OSliaUprwsHfwwydxcv/TfztF+ljCkGegGFMKeDvh2oEUQAlr0xe+WkjMRPf/2T6sSRls8feOdZ3ivF4M6Jt+nwxlvb4V9UI3cpaDEQOSnGI1dvI4aeiWAi7byTik1SH/e/Byq9fOW5WbSrEJP6v2jojFRiZQK6WoWFu5enuwTSHeAbsiEjawj1bhIqD9X7Aqn+3nBDnWLR7DGuMWQj5FrdhFboB4wn4uphAyNyEbds78CxpXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(71200400001)(54906003)(316002)(8676002)(7416002)(66946007)(86362001)(6506007)(38100700002)(7696005)(55236004)(26005)(4744005)(2906002)(186003)(33656002)(110136005)(76116006)(8936002)(66446008)(38070700005)(64756008)(9686003)(55016003)(4326008)(66476007)(122000001)(508600001)(5660300002)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JEGM63PBc9XrLT4o4Gag00yy6o7w9YBy6+IuT7bCbAcfbwqMU7/uuWAdtThk?= =?us-ascii?Q?pp0ZQv045Ld1opS2IjzuSD+DyOqC85Akzb1REmIWRSOOOolgL6QGjNpd+SGM?= =?us-ascii?Q?PACEnHKn7dosjogpO94ZoHuRURRBXRs5qOcYunYw7K3BVp+PsmUy9vVCMSj2?= =?us-ascii?Q?HFVXwCKQz5hyc+5vV747hPUodU0JGZlUsKS5GFQLcCJMndBRoDdINLOxAmVl?= =?us-ascii?Q?XeHZ+/GDk8gvpMTZxgwrv/MoauNfdk5ijWe4N0MAC8NFpjrXPQs+K18dqnUH?= =?us-ascii?Q?p/CFlfsmIrF/GnmO7lGNQoKhuxSP/Fi4lBUkdKUc9d4mKrV6XsQtjkZQo0Iw?= =?us-ascii?Q?QjhR9E35pXsrNwrEDXN72zaZLlOrSfBsmnhd+bq2DK4IxDoKol5Cp1DrYzvZ?= =?us-ascii?Q?lR38mWJlkPbRD0ZF+yRkezgDy34kQ0Vs4kH3+fBOeaEsZEftQY3D8wodSZKz?= =?us-ascii?Q?U8ypX1i/5xVXr6Y+PvSmQSyqFxlN3al50GCGqYXP4LPwTX5Ddo9VMx6Q3+hM?= =?us-ascii?Q?0yyDpXy8Tu3R/XOcdJ4m/uzQghGWhfZZCTrGc3JMObY6yFudg40tmYEn5Ntg?= =?us-ascii?Q?o+LRmOhXLjb3VSgQ+NGh0y80wUllbP6VfHNcvv3Xl2CTKtQAF6cMYjc86Wy0?= =?us-ascii?Q?s0ZN+pSyGTYf5vSqJsCsnNANuxjTPDrsEXOSSBbotKV4zyGuC8SufdQm7krR?= =?us-ascii?Q?pekyWlRNMEv1+EUBrE8tueSlKYfsVuZT19EgV0j72YViEN+YOM1t2qIJieb0?= =?us-ascii?Q?w0D6tzCAh4yVB2KTA0maMvsCEe621QMuVEZSITOgKm1AjRO5XKjFj1IiHwIU?= =?us-ascii?Q?YFk6NHlGW1OYQAmSFtf6JaKfWzFce1QuPEVe3Nt3qV0Rn6487H9198SgiRzr?= =?us-ascii?Q?20obd/CgB6/5LAOGnM3T+eCVKhcQvuv8geq0+968fZa6QqPxMwcx4ovD8FZ0?= =?us-ascii?Q?Q2gtry5AJY7BEJWGfAwv/YyWk+hxy8CEE8y4+qawxfocW/DUc38EO5fz8s8J?= =?us-ascii?Q?lKVJbnKVjIXBi+s33YzffYdMDIDLcxRk7gp8kUB4eqvruAeMH/VJywBziGtA?= =?us-ascii?Q?pCxMPnbov1PW6OSEnFIELNReJFsTF1FjZ6Czs9uNf+55X6vfD5+bT2ODm11x?= =?us-ascii?Q?kA0+2v70DKQEZhPiJSnAiDbVRDIXDfL1ZSZ97ZWXhRxs7+WJfShyg0ssshxn?= =?us-ascii?Q?c4d4pADURB02Zkz12HYyI94QGNBqDv8vCkFccWTVeHgU/ik0B3iHnwxBJWTP?= =?us-ascii?Q?oC8XRgts7H9FEQH/axAB6U2CWYdQBCdmwStB4udywYdPPC49iAfD0KKVPK+h?= =?us-ascii?Q?yrI5dYFsdpyH5emhmaMpot4lw/4TtCXYV/HHPkspuerb2/1RXGTPyZvawUkb?= =?us-ascii?Q?Ukapcx2jARnzKg2NXgcT/L5mQVzvpZFOlOolOUwdN5AZL2+M3UGoeoO1Sc0K?= =?us-ascii?Q?MF2RwML1BrIDGeEAT5Bq5pGzUjcGIeQiU6H4zezbI36TV9lPEhFI1XtRx9PR?= =?us-ascii?Q?FYpAoPKB6cTiPhbhF9vqACeHbKmz6jVq5JfveMmaHpE8/LHxiqOU1JN9DrB/?= =?us-ascii?Q?TyszcekgT4AIiUz2yvX/UFf6E+J+93Sx31VMxG7qf23maqotgDilthORvV1o?= =?us-ascii?Q?Qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a96e3fcc-e3f7-48f2-d5eb-08d9d533c6eb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2022 18:54:20.5778 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G3ZwdyXIBixW4HJgglELHXrqRdJNFw7hsBbEetBMBtikU2b2HHNH9oyRhW7FVxJGxmmGLrbGFeHSyEUId+DsiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4762 X-Proofpoint-GUID: sSmY0PimBsm79762wNDKyGoq7PBTWG2c X-Proofpoint-ORIG-GUID: sSmY0PimBsm79762wNDKyGoq7PBTWG2c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > > index d9a03f12f9..ecc6c1fe37 100644 > > --- a/lib/ethdev/rte_ethdev.c > > +++ b/lib/ethdev/rte_ethdev.c > > @@ -6473,6 +6473,36 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, > uint64_t *features) > > (*dev->dev_ops->rx_metadata_negotiate)(dev, features)); > > } > > > > +int > > +rte_eth_ip_reassembly_conf_set(uint16_t port_id, > > + struct rte_eth_ip_reass_params *conf) > > +{ > > + struct rte_eth_dev *dev; > > + > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > + dev =3D &rte_eth_devices[port_id]; >=20 > Should we check here that device is properly configured, but not started = yet? Ok will add checks for dev->data->dev_configured and dev->data->dev_started > Another question - if we have reassembly_conf_set() would it make sense t= o > have also reassembly_conf_get? > So user can retrieve current ip_reassembly config values? >=20 The set/supported values can be retrieved using rte_eth_dev_info :: reass_c= apa