From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8A82A0C55; Mon, 6 Sep 2021 20:24:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39268410EF; Mon, 6 Sep 2021 20:24:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id AC0FD410ED for ; Mon, 6 Sep 2021 20:24:32 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 186EVGZd023139; Mon, 6 Sep 2021 11:24:31 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by mx0a-0016f401.pphosted.com with ESMTP id 3aw9d2twe5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Sep 2021 11:24:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IVtB3kdp7GJwga0i3mGYkdyjhjicA6uyYolVyxUK3tJ4kOYmxPeoxKESj/Gxp/BSlIxl41hc7PYRYTD3GQh68keFsREO/F9U1fct661ngVeeBxo7i/pMeuUgFFboIAd47xdXuVgcSwz8XOSJM24s0vforcq/h2E1Djzdr5QkBW/JKu+fmjEMrkwhekFOzn5FcDAjh/jbflm791RcEY5fRhWYSmwLUN2ZOR7KTj6VIo/UxdDZg75Pv+/x8H4n2KRsP20EzWPWDLy6G9UfBnZwSbPHZBz6J+z57MdkE/fnqfG4Of2D9Yl3XfWRewOvqyWuZnTGuaSbQLVDnPTnrsHOVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vGv+j4uC848RkrYZwCzaaBfKLhSDMYyR218Ied7dpVU=; b=Pyu/L+agZ21tT6OsZdNAfGn12cRg9d3tfoUh8cZf/18MRBJoisO/wueLe6lg/4Y6bXNp6rXH9RgZzytV/vrceIMa/BFFS5xwiNOMul7IntrqmWPb4cvOJLtn7lYpsXd6M/B6ubSGImiYMbXs2rV+AYcrrbkwRV0/1bL6AJBL/enPNlLaZYTsHHZMvMKnT0QYJDg40kaNvYZnyoDRJSCrT2n6MVNl6WlOTsku0KeZyW3xGbJ6kLsGJJVdG4ahy0JTKmcEhS6yXVf1abdEYoBfxgrOr59hFmsX61rfIkYUIs7A7KIwNqbfUCGFDv3NRL9TfCWKdO7HPS0RIgNqPzjDlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGv+j4uC848RkrYZwCzaaBfKLhSDMYyR218Ied7dpVU=; b=bpaajOJxBeaxp/F6FHArcJr4nRTyt2yfLzKqfnlM2nDsRtWaUUlwCDu37z00zHSG1ZUfmp6VyUGHYD5Pj/GhZLZtyDLsIzzoqmwb+oH+ARQ9fT25cF25I+1VIjBdG7QZ1MJVYa169och0wzqgdnN60wz9NRTXlrtOaEDJRrgw1M= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4482.namprd18.prod.outlook.com (2603:10b6:5:355::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 18:24:28 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%3]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 18:24:28 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Thread-Topic: [EXT] [PATCH 0/4] drivers/qat: isolate implementations of qat generations Thread-Index: AQHXn0BOubU9r+9+eUmb9+YK3ZKkvauXWkJw Date: Mon, 6 Sep 2021 18:24:28 +0000 Message-ID: References: <20210901144729.26784-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20210901144729.26784-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac91aad8-4d64-4f73-498d-08d971639048 x-ms-traffictypediagnostic: CO6PR18MB4482: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3degUxi1yiu/Setx7j8E8Wg8f+DAMP9ugIOgvYgX87nvHhVeIaUAYM21khTwfH+YA+8Nhy4w3HUZCIKJ/rXuRQLPKqNd+tzoE6kdmO/8Pfylv1NYJYcZsPjRBjng6YlYTH0eLFNbwNg5iRsX1/Hwbo936EvmMaMsTPKdKkWGcTF3GF638FQoRrsuBSBwb7hM1uZ5Jj19Q8T8UFboIQRrLwh46CqKWKRVdxGDQjEzokE7snuF5aol8dth0zQDFaSOvEfBTHPZrbrgKUK77i3l0rSTK4Z1gpPiy6EeTmO6x75BsbMrxrBILhifbFb+2wkOwM2qQs5wasvL0UP1ATTZk0k+6QeQTc4qp1hLbZlwif1usdXDh+/4qM0asB500PQWAMGAo53QVAyLWMdVMktE6TtmmGvzaO82rGFlC+dLxRMPAVmp02tnB5/w99CskTobpFXjO9ASbu7Shx0EEXgbMa3mech8HTiB3xscZcpvfOLWIlH4VopYeGOuJ+PDM0XuN4JXuHbmPMCZRbW04YmVa6RXfleMV31mpc97qIE3FMS5ancLSTJjGavhGt8fsSP8Enzea9DlEVfLCS8lhff5BobFCQSGUdY4QlgDXOo5NNvFGcYTjFs+OtmlgVPvrZXw6jJBEO9aPVS+T7rii2IjxWqaavqEEpYKA0KtKDfgkQR+B0otOk2ohR68BZAqKU/Mcti8gXWCC6r/wsQPu8iH+g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(66446008)(66556008)(38070700005)(66946007)(64756008)(71200400001)(316002)(7696005)(33656002)(5660300002)(4326008)(66476007)(2906002)(110136005)(83380400001)(478600001)(55236004)(76116006)(6506007)(55016002)(86362001)(9686003)(38100700002)(8936002)(52536014)(122000001)(186003)(26005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o6U6PC5vxE7hhMzWNI5m8RibdPqH1NFmoDDu/AGBODWOdNufhUVVvaxg7Rdm?= =?us-ascii?Q?sFULul5N8QIUQIIkvZVpEHWnQG3+PUNZCyfT6t6T+Iq6zIKTZXvZP0I/AOt9?= =?us-ascii?Q?7ZlYqylH8nRaYMQ59PAHR2DbwyoVlo78AT7VNHMa33zy+aTp04lUmh3CCHfh?= =?us-ascii?Q?amPacEGpXBikxvqOLqf2EZ20+uL5i9LE7XndUj3OzSiXzgY9AcohirTX803R?= =?us-ascii?Q?SFD2WebmT1pO1aym6OpqGJA00pGLDSJITYaLZJI/3niQsRf6em77TIKyJEaJ?= =?us-ascii?Q?YJBrYoV2TYqJ87+4e8QJtsdyGJPsiDXSWx1aFZiGfcM/c8bJTALo5Id9Lrux?= =?us-ascii?Q?dKmgnwpY8GrE2j6bywWxVpYg7lHNZa6jWv9FRLD+eYnDUgUHw09slN6Yy8qi?= =?us-ascii?Q?SiCIravZbo8c5aJ4vNUFQdMCwyXY7sgar6R7mj7q26hgpJa2YwViU5dqdQO5?= =?us-ascii?Q?0seww3f3Rv8i65124T0NyRNqhB5lxctB6oSe9mnqtzml+HjlQW/isQ1fMfKM?= =?us-ascii?Q?bUHD2lPvJkxwTyn+eR/tbxAUBrb9Tj//rqmlBCjMxjV1pIpcr+DyXOf8aEuY?= =?us-ascii?Q?2dC5BH8d2RlypjkfeIiglKUMlsFRp1we1LMvLuUvHYP8Znvs4+4RB8qTneSY?= =?us-ascii?Q?QGQ7XOMi0qajYNIvqNVkwG7Tm5IiNQwPm6dCfUWom13tPeEeNT/tK4R7EWag?= =?us-ascii?Q?Wku0AlA0NsxU7igMg439tTQkMZ1xsaYHr/deb7h/N4pkOQYecVHCXW82+BEq?= =?us-ascii?Q?iamVA9Bh8prgB385ttMSX50LoNhWcS4bfwQZdp+4Lpr1m411ExnXqVbaX2M4?= =?us-ascii?Q?VLYMi6wnqWXHtCaXl556GPOv0f2pRYIWoDoSSKe/FjwMH8dh3IVc2qQ2Hm1q?= =?us-ascii?Q?4LfcVmBTETJfVI9wYK62H/EdX0N5d6Vq1e1zMltn58z2Zz4FvSV3AKp0gc2P?= =?us-ascii?Q?YUL5aYYAvH8pb04qmhK0FnxqNt8w30YkdS6N5sPUhAVkcpGOV4o17oMRMXvS?= =?us-ascii?Q?UCESoPnW0Qgc64kmghNH+5fLxJn4rBCb/xtiL8l2yylHTff5I1x5XUNKlD0q?= =?us-ascii?Q?2QTKWg/kCOObFnS+GjILzpdlqrrUGQfJUyfYNbIvxtYY7QTdX/V2PDFSyYTZ?= =?us-ascii?Q?IYdfZlaiKvMTfFfb3gQJTwlHsjUyPOFoVr3UOw09nGOn+vdX+V7Y+ug00Ds/?= =?us-ascii?Q?aEc1FQBvG3x1lJrwTG0mMQt9dZ0e5NODtExxWezhP7LcQ/9GOIsbGS5bozQV?= =?us-ascii?Q?yFSKCsLBx4Nf8Ug7fRcvYrPwm//kgKteGUfZIpxsQKzobQgwf/PfGeu48HgU?= =?us-ascii?Q?ciHoXMbXfsdDj1J9e/w2YCSr?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac91aad8-4d64-4f73-498d-08d971639048 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 18:24:28.4748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zrnRuvNHsV4hBc7vEOihfShwTDKltcRr9zxemRzuyGkn39DJWr4X0mfPAhiRA1RYQygyhNaHxHJaKZ2vTn/f2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4482 X-Proofpoint-GUID: BXclBSzqQIfe9QRq4ROttcAKN_M-tf0c X-Proofpoint-ORIG-GUID: BXclBSzqQIfe9QRq4ROttcAKN_M-tf0c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-06_08,2021-09-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH 0/4] drivers/qat: isolate implementations of qat generations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This patchset introduces new qat driver structure and updates > existing symmetric crypto qat PMD. >=20 > The purpose of the change is to isolate QAT generation specific > implementations from one to another. >=20 > It is expected the changes to the specific generation driver code does > minimum impact to > other generations' implementations. Also adding the support to new > features or new qat > generation hardware will have zero impact to existing functionalities. >=20 > Arek Kusztal (4): > common/qat: isolate implementations of qat generations > crypto/qat: isolate implementations of symmetric operations > crypto/qat: move capabilities initialization to spec files > common/qat: add extra data to qat pci dev >=20 > drivers/common/qat/dev/qat_dev_gen1.c | 252 +++++++++ > drivers/common/qat/dev/qat_dev_gen1.h | 55 ++ > drivers/common/qat/dev/qat_dev_gen2.c | 39 ++ > drivers/common/qat/dev/qat_dev_gen3.c | 77 +++ > drivers/common/qat/dev/qat_dev_gen4.c | 285 ++++++++++ > drivers/common/qat/dev/qat_dev_gen4.h | 18 + > drivers/common/qat/meson.build | 12 +- > drivers/common/qat/qat_common.h | 2 + > drivers/common/qat/qat_device.c | 183 +++--- > drivers/common/qat/qat_device.h | 28 +- > drivers/common/qat/qat_qp.c | 641 ++++++++-------------- > drivers/common/qat/qat_qp.h | 54 +- > drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 78 +++ > drivers/crypto/qat/dev/qat_sym_pmd_gen1.h | 15 + > drivers/crypto/qat/dev/qat_sym_pmd_gen2.c | 103 ++++ > drivers/crypto/qat/dev/qat_sym_pmd_gen3.c | 63 +++ > drivers/crypto/qat/dev/qat_sym_pmd_gen4.c | 107 ++++ > drivers/crypto/qat/qat_sym_pmd.c | 188 ++----- > drivers/crypto/qat/qat_sym_pmd.h | 40 ++ > 19 files changed, 1540 insertions(+), 700 deletions(-) > create mode 100644 drivers/common/qat/dev/qat_dev_gen1.c > create mode 100644 drivers/common/qat/dev/qat_dev_gen1.h > create mode 100644 drivers/common/qat/dev/qat_dev_gen2.c > create mode 100644 drivers/common/qat/dev/qat_dev_gen3.c > create mode 100644 drivers/common/qat/dev/qat_dev_gen4.c > create mode 100644 drivers/common/qat/dev/qat_dev_gen4.h > create mode 100644 drivers/crypto/qat/dev/qat_sym_pmd_gen1.c > create mode 100644 drivers/crypto/qat/dev/qat_sym_pmd_gen1.h > create mode 100644 drivers/crypto/qat/dev/qat_sym_pmd_gen2.c > create mode 100644 drivers/crypto/qat/dev/qat_sym_pmd_gen3.c > create mode 100644 drivers/crypto/qat/dev/qat_sym_pmd_gen4.c Please fix checkpatch issues.