From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FE43A00C3; Tue, 21 Jun 2022 12:22:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE09C427EE; Tue, 21 Jun 2022 12:22:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5B48A427E9 for ; Tue, 21 Jun 2022 12:22:40 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25L1KISG027729; Tue, 21 Jun 2022 03:22:39 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gu47pstfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 03:22:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWM35moql8lLWPD4oyBeaZwH+xgC4EknqoArBwZVDRt+C/YXZaYTOOmZSKEERwcdbZXGgRZZNxEXWRXrfrvGjal4iTItn7orkTLiP5m8xbwrZcN95bZwlzKfZnoN0mtga4m55NbRHC180Lzhi0gwqolebH0BtqC8V+EUyuTcOXckYYVcRmwV8SCBpkukqi9UCd6P07xsrYnFzyCX69JaTEwvAYHIVsFoA489dq/NfTvhxVvkP7OUhFTpQroJZFaePi09P/iWM07bp5woJO2bRgUaK81lPLAPjUuSJ0LGNGXQUmmTHmHVgUWAweKyMGjlDfHryMmR+hA0Dt+G6TSgOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UM+Cc1y7DLftJCiV7c2IJjgxSb3AQ0n4jZVg6VjLRNQ=; b=Go4cxz3axYhuuXH4f8cb3Z0H9uUGwEmbD+6i9/M/J3bK8Xf4f+nbfDhfIP5s3s9mes8EaJ+yGwb+DL3EbWyzgmORDxd6Y4jC8+i9tMhTV+XilEL1wyND0u5x4zz0j+QoOEKvEp6rAscN8HDTYbzI19Eaj5rhsC7Efos16VS72iXpv2E//ixOf56C1aPmXDyR0zYr/LIwAioE1tWzVngR6+woG6YhagUYzu/JkFFR0SavODHByxFc+HykD4UTdHI9yDilUub2a9ccJ2O4Nj7HdR6z+5kUAFjp6hLSDis38wUVTdU9bdo5HkC/MNm7YSzXXUj9BlUi5VhOdjEgfq9mkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UM+Cc1y7DLftJCiV7c2IJjgxSb3AQ0n4jZVg6VjLRNQ=; b=MNrKjCtw5BuIJw+3mi3SX+Bzt0YfiVmKT5mTAIEZYWBPNnfkLBp1d+5KbS+L5g2yQSSFHCUPU1j/0nJ1NR7ZDineQylxNMnWBQTizzWW+FrPaHS0haN6mAFem+dM5xIjTcnUP1BL6sKxeRQgOvZMpIwIjw0ckym+ls41SAb5eSg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4464.namprd18.prod.outlook.com (2603:10b6:a03:3bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 21 Jun 2022 10:22:35 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5%9]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 10:22:35 +0000 From: Akhil Goyal To: Gowrishankar Muthukrishnan , David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , Fan Zhang , Brian Dooley , Brandon Lo Subject: RE: [EXT] [PATCH] examples/fips_validation: fix link to libjansson Thread-Topic: [EXT] [PATCH] examples/fips_validation: fix link to libjansson Thread-Index: AQHYelWzXZclbHK+YUeE9rYgW6MAhK1D34iAgBXdQHA= Date: Tue, 21 Jun 2022 10:22:35 +0000 Message-ID: References: <20220607100203.1611166-1-david.marchand@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 121974bc-5804-4f6a-09d2-08da536ff5d3 x-ms-traffictypediagnostic: SJ0PR18MB4464:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U5EkvwOq8NJbSqSmz+i7qmxbyKXBnfVD2GY0sURXb4zqzpZHF7soo+EvhLk/pfVAdeN3DWu6iDllnTQQk4JhDiYCmGRl40h4VM6rmIvGTUWpsls8Q15QOObFpGZl4GD0pkzWWUXFkagDXIyWVc1oM6H/kV7NLdGxgq19MywKkuPkGU6fWYeTJj8W9KmkOaA4qOVhn0R4Ljss+mf/SCvvIPZT4Bzeqgb5pdfDD18dJkugHriCDqyLSXX2wB1TNGM5rIxVPyhHHO2kN4WDJg9KBch2nCN4qEB7eoVRGVmgKPfD5djmiCFAdh6sdOCUIqFI5vWsLGt3O8lOQWUySpmdpBOVDs6Pyrur0Ztsni3R85sToE92lc4ar5P5PFdAfi0XzfDuXN/OxfaOkIyjMV6gB9IhuVkYA1tPJXTfeDhizsOhian0T0oQKZ949o4DnraTun20X59RkFwDOoQB3le+172wUVGVVMM5LGBMt4Zx/ldixt3qERXfxAHBLMum2hLRXyOlfQdNcUzv6DMQFdKlGChM6GSm+f3QpKlFOI5hSKlVnGrePaHeD70VwxYMyUUTMPahi9nCxAu6lCkvf98hpSIPY94ZIJNl+SAg9BAwugOR48a3QW5ajGDGQiF6yGV+hV+K369I9oXEgDwHHgz5su5eHvYatmKJ18A8LaWIV7MBGRHs+WmQMbcy+td7SmoeoSFuEfzQ7jDPHCC20jDbqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(8936002)(8676002)(6506007)(7696005)(76116006)(52536014)(66556008)(64756008)(66446008)(66946007)(66476007)(4326008)(2906002)(5660300002)(71200400001)(33656002)(478600001)(26005)(9686003)(55236004)(86362001)(54906003)(316002)(110136005)(186003)(55016003)(38100700002)(41300700001)(122000001)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8YuMulwzXcz7m6h8EfG36L/3PU3/PzgXGOW47r6vo0lrt1AK+UwGAf5NC1l4?= =?us-ascii?Q?UW0kEHnWJI9r/FZf45XtkaFAYbVSDl2iEpoECPpksgJVcAJi01JpsS4JNbr6?= =?us-ascii?Q?LjME6fuvamnno/r44DQscvhtUxePSGVc5GYAODv4pAya4xrhXSt4iSm4wxi9?= =?us-ascii?Q?pgZ5ayzmMTwFOA3gYu1JVZoOnjLWLcjPTdLtB495dLLxL41Ta/RvdVi0U2jR?= =?us-ascii?Q?fw7gkYyOjn5bwmICPH38C2pvAoGQCFcxtwOYptc/G6Bc+s/Fqqb9HJ/N8SKR?= =?us-ascii?Q?//gj0/nezurSe/pRRo1HXGFjLfLwTp4fFVNJMaOV+fZP09xaeTS/AZbMURff?= =?us-ascii?Q?eYB6FAHoY7XkEJjMkVp8GLTX1276X3z4EwndHxlrL9uXAM1a8T5oL4EmOgZ5?= =?us-ascii?Q?ejcKuRTkEukG1YVlDE94AfTpjHsOA9qipFGn38Mebg2+n9eyJlsnu9CVjL/u?= =?us-ascii?Q?zA7upj8Py1dp4db6vsuMuzx623/aPNw6FfO0Jg6XkYSX27Hh8dRM2Nr4YdMD?= =?us-ascii?Q?ErNSr5fUJbAjs3LulY641PGEztQeaL6ZQI7zf6FPMFVBuAGrxCT1+/ek/ABr?= =?us-ascii?Q?UP/ONB30tP8m9WeYpDgEwhnNywwJGpUZ1O0jRcGay3qH36DlCCFB2/zNLxQC?= =?us-ascii?Q?ORvgpdWPfnr9JkbapsFrwn4LThkSmGtRD3lW/qpmSlxaRMWuNzJGW+uAWKJU?= =?us-ascii?Q?eVVc5lABbJ95izFbIdmE2xylMa9vN2RoiPVBx0Ty42PIxY8pcxTA77g4/xnb?= =?us-ascii?Q?+zDY1N4VWO/WDGcJEzAdbmqqTIEYs3UKxuxOyzUaEZOfEWAEiAo63awWj6lK?= =?us-ascii?Q?ebUB/sFE/jeK8Q2nFMdum+bqWxVroVBIWwTt0/YMBYJFbyyxeBNaT244fsoE?= =?us-ascii?Q?jwnhTG8XfIDGlMOuVeg9um2Tag3hSumUKtjVsDNwE6D7/Q1iMwSNWXF/RP8H?= =?us-ascii?Q?L8iIHrE7Ufc503EisGnf2+b08Z5LEMU9H8yG2YHiYDkJcSWyjleYYMFZuIGM?= =?us-ascii?Q?uP++GapAMwkBBY2iUoQB/TORaAdBx6i84UVRBmfFarzMYL9dlG2QzMrAr5Hk?= =?us-ascii?Q?G5vSzkJL4oV9FIruyUXF+T+tcd03MUU1NK9NEixFrNO01Y3iDtqR6C8xIjLZ?= =?us-ascii?Q?/LoP2Y8GiCQcpXAHboz70MhPO1mFDzWh/h0MPmyjTMOPpgsM8D+rG9jZmkFA?= =?us-ascii?Q?SGqvkdnklWye6AUnG1iG/MxIy6IvNLpGNcY662f4M5GjeIP8DXbd+93VGcNR?= =?us-ascii?Q?IFlZTIDBssH+mmLlIeQKANYqcULWjQTZilW8ajv9QhvY5iofaQ2lGzLawHRe?= =?us-ascii?Q?lNz8VvaMhyot7G/QVgKL03WJzEgDAAYfPJ6O4hOYpqr/uf2hj5HSub2/eayT?= =?us-ascii?Q?I+zzJzzexLLSN/pqZUwE+3RTHLF/WxO5aj+OPKHHKbcg+fV6Sh1XwFl67cw0?= =?us-ascii?Q?h6tPXZBJuAKwYFIGSEZZ0DGk2XeUVvGRCU+Vf8aRdVfyhZ3TrnFdo6xPo+r2?= =?us-ascii?Q?gn/JyF9QFBJMhxltMwERxDcylbFNskwUfRt0pMF0PEnlpVUkHzrx6+klASu/?= =?us-ascii?Q?DBYOTKFKXvVlrFzeD5iD2JBqVMIkmHPWPSxgs3i6xcGUvfpDVTbgW+l1xavy?= =?us-ascii?Q?Y0iSuQ3nK+0Ei2FBzHOSluZ7KSc8y8x+GiyaK32g4f4kmeC4ULeYNLWF8Jde?= =?us-ascii?Q?kzxrfHQJJSvNiYKPi+KkpUHL5XzNeXUMqBp6DuxUEgg8AdzzIAMnq9AgDA4v?= =?us-ascii?Q?db73Pa1oow=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 121974bc-5804-4f6a-09d2-08da536ff5d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 10:22:35.6757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t4wAGsTg3h0zu00/ymg1EGEXCAX4orLeJNvFMxdiB4NlMLjw3OVAyZXyJEdLs5PSgPyTUS8fZV1YAnHCWQ2KjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4464 X-Proofpoint-GUID: nP_kvXdPI6HzFAp8gLmKiHVizjUFSLqd X-Proofpoint-ORIG-GUID: nP_kvXdPI6HzFAp8gLmKiHVizjUFSLqd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-21_04,2022-06-21_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > When compiling this example out of DPDK, linking the executable fails > > with: > > > > ## Building fips_validation > > /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init': > > fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf' > > /usr/bin/ld: /tmp/ccQjeHBg.o: in function > > `fips_test_parse_one_json_vector_set': > > fips_validation.c:(.text+0xc2e): undefined reference to `json_object_= get' > > /usr/bin/ld: fips_validation.c:(.text+0xc36): undefined reference to > > `json_string_value' > > /usr/bin/ld: /tmp/ccQjeHBg.o: in function > > `fips_test_parse_one_json_group': > > fips_validation.c:(.text+0xd00): undefined reference to `json_object_= get' > > /usr/bin/ld: fips_validation.c:(.text+0xd14): undefined reference to > > `json_integer_value' > > ... > > > > Code in an example can't rely on RTE_HAS_JANSSON, because it only > > indicates that the jansson library was available at the time of dpdk > > compilation. > > > > Prefer a local build flag (like what is done in vm_power_manager). > > And add linking to libjansson, if available. > > > > Fixes: f556293fd58e ("examples/fips_validation: add JSON info to header= ") > > > > Signed-off-by: David Marchand >=20 > Acked-by: Gowrishankar Muthukrishnan Applied to dpdk-next-crypto Thanks.