From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11F95A0093; Sun, 1 May 2022 20:37:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F34F640E28; Sun, 1 May 2022 20:37:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DB8F140DDB for ; Sun, 1 May 2022 20:37:49 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 241H9Q8u008886; Sun, 1 May 2022 11:37:49 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fs4mkk47d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 01 May 2022 11:37:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YvCuHRJ7uH4VptxFC+4epEnjgKD3W0bIIpD/NB6krE0RfkPUNfQitv6INBUD++4m5LfrMr9fVioNPBCpuaGYbE6rtO3m4reELgrj+dQWaj1ILKvPaf7lAKrHSqNHM6S7a2NFr0EVqhxObtHqigdNp4GjvnFjPmbXjVl9b007gEeSpGU0bIUpgz6o92F+dhgEHSiPEPgRLWTGRaIRLbbGVUqxHL4zTLz6bPfUWgCkNqhsW8NUr/Clc8+Lh/AIj8GIttToosrXjmKSxVp8ovmfT+U41bKaVzBBeGJAxOl8xu2maV9hiaMw5P7hnFKLXaiH+piC5QtfOFJyZ2jTycetsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kt2a9n47oU8WZmhom/NoEODg5gQsFSVNIR7zK+Nz8yQ=; b=BEhe4I5p/PW26v7m4u73j1QsBWO9wjJb/bjG36VwGVTwEFk3OSuikC84cry1JDUmrjw/wQ7zNdNZkxQqpCr9OXpwWI8sLt86B0CI/QTlIwKEbLg/u0mPzpq+scR8wCLD49rTReZHt+Q4rQGOsmxmd5lZFYQscRk5z/55rLOvV2U8tKEM1esgEXMu8RHp6HIJQGUubLoAu3KKLMAYcWwP5Kv97RZMy7vr5raAD/kVu5tVLLWU61iDiOcsjUyKuxfmZFA0NRJXvRMSBOu8UzTBqlqBHNeUjiB6gVVqWgGLYMZwWs2HrprbZjdtEP0dlPyixbxY3TE1stgjQElx2YknSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kt2a9n47oU8WZmhom/NoEODg5gQsFSVNIR7zK+Nz8yQ=; b=FK15b1ia6ROnl45TgDWsg9KXcwEFWYC9b5UiS/fLWTg56x9JB+uzSnNUGjMqXxxfZhJ/r6VK6YpqHHi17sJYgh7Ws2MQS1UcIhurLQUF9n3B4q71Iwt4AXsI2ydEi5XfgDg5AWdSW1bw+vrfm0aIxSobXBfYKz17s5B5GwUSr68= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4891.namprd18.prod.outlook.com (2603:10b6:510:11a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sun, 1 May 2022 18:37:47 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%7]) with mapi id 15.20.5206.024; Sun, 1 May 2022 18:37:47 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Anoob Joseph , Jerin Jacob Kollanukkaran , "Jayatheerthan, Jay" , "Vangati, Narender" , Volodymyr Fialko Subject: RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata Thread-Topic: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata Thread-Index: AQHYVY1YXGz9MMsdFEiI9o4USo01Ya0FcVmAgAFnNACAAylHAIAAZ9BQ Date: Sun, 1 May 2022 18:37:47 +0000 Message-ID: References: <20220418193325.368313-1-gakhil@marvell.com> <20220421143720.1583062-1-gakhil@marvell.com> <20220421143720.1583062-2-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2338456-0f73-4fb4-6b35-08da2ba1b043 x-ms-traffictypediagnostic: PH0PR18MB4891:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n8QctJ2TxTqtH9+T619OZRtdi9aCAmzmmAAm2o5mBM4YlW4/FJuTIp0ZZudk1ecB4OwPKdpvAN8OXttPkY0BdE6FqvdPC87/J+0SrRDeOMaeRT4j+p0mjB/kANwvf0UuGE1InFYJSDbyd6P9JFt889dXCxR4eHet6zbsDkKwCfEgVWHKlaLRbC/Be2tdRJPrrPYyCvTNSih0zHw38C1Q8OJzTcvj2aBR2Vr20k+4483LDpV8l941KC3vF4DSiOPETgN4nbQx0YqHP0Zhkd1bErmqj19BXtOQvKonFJv0PJ7kuhT/FlVafANc/LcmLlo8od5UDnWajw/mvlD98uGc7kUL3ORT3lgD9/Y2Le6vtW7NL6vsFefO1msRig38nI7L2aOMTYi9Ws802K4S1YOoN3oRAqkGUY0lJ5Uhj6terGY8MNWrMgWXpKSmpNl9o8EAYixztOSQ57sYMQNtcldPvn0H22ij6CqR06aiBMJ2lpmUgKoeBT7LqOJzLu/LMKJE0FbGtRfiKnudew3ig0YSaypOXHajjVJ5qUpQ2YEvX9M0ALWIDCv4+1L35kaWQzCAxtH0ph4h+v04AF7D3RG8nHHjp7ScY27xewoASxw8C5uCM6xiwVDp05EfnYZS8jr+y86VxR+GMoE5Qp2ZbZxloKZOL5788ipg1RlS1ckXaV/a7mzM3oHQZkr8hET0dHynq883H35sIb/vTUnIClJtmw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(86362001)(38070700005)(38100700002)(5660300002)(4326008)(4744005)(2906002)(71200400001)(9686003)(7696005)(6506007)(122000001)(26005)(66446008)(64756008)(66476007)(66556008)(55016003)(76116006)(52536014)(8936002)(33656002)(186003)(66946007)(54906003)(55236004)(110136005)(316002)(508600001)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5p7uFAn+jazFdY88xjwkU+aXsc5fi8N6jcrXX/fwYe+jnn5LcB3gISN4HmBd?= =?us-ascii?Q?njRJUJ3NGkLEJcsX+iMsuI2DHjswodbvRB+a3QMGnAO49kXksf4B9ttXTr8l?= =?us-ascii?Q?V3CM2wOaCborZ4vY140/eeHico79tTC6DBup0CaIZWTY0mdleXT7d5v3tZ3O?= =?us-ascii?Q?GCiQbYHETX0GXm5BxfzmL181vM7uyNKZlxeGzlq2KIkO/BNjdYGIVejBWGFQ?= =?us-ascii?Q?T8rQlY7t1EiTB6mkhR7CgeI9BwK5/IhNae1ayFHWlGI/V91UfFqEAbiKRRl/?= =?us-ascii?Q?U721sUZebumdIGi9jeS9VdUGCUolAWT+ihUztcdQUOjmzXQqN6CnjrQDlmdk?= =?us-ascii?Q?A6BUlOpAKwP4FYXrlw5IL42+Im7N05QvXmd4VGsVsRb5o5kdiGSx3OZZZClt?= =?us-ascii?Q?YcsD+H2g1badbI/3b05A8xUluwE3u6X0r5gzBMlxVSDLKQPzia4mcKO34Oeb?= =?us-ascii?Q?+jrIKclKXz6pQscCnP/WFpm4tF3pZyDBMlNFrLqjuKIUQX3r5bLb/uDn7cU8?= =?us-ascii?Q?SBuf2RsFF35lMeBjhsoRouwtoOwcLZ+JbSgPITHNkJVwY6H7KITxGoiEEEs2?= =?us-ascii?Q?3vzeLbYRa0nRpR/P4bw+CMyx4LiOEWj19RPF/3TVdha084POa3R5Tpjgt7H+?= =?us-ascii?Q?/FA++/8lnkYblmzVV4X9/Ju06Km8u7vAeYSQEmpsBcBy5LVYkjxVD1Yt2cRn?= =?us-ascii?Q?1urE8+ZpBkR6VHJDvaaCHFenWoRrXLaSnXib3FvMjLyVDmuYH/HP9ouNLK6z?= =?us-ascii?Q?Kw7+WXkfuh4EQ2Q/5XB6R5xXG4e20+Lkx5xXeERmQUgjPNvFjq8q0k73wBVd?= =?us-ascii?Q?rvoZeFPLssVvKXC7y1LM2AfhcsmVgPiTt4J2jIvsd9YZYfwN1Pg97zZSeZpe?= =?us-ascii?Q?CHkhvkx8LcY5Eg7DVK1Ju0KEy91qEtECjiMn2WIA58vYy5ROE0u2JhKcqf3W?= =?us-ascii?Q?9azFJXQo7Zgi8qHzEnlCbV9DifyQVVEy97VdB5FcsQMiPA4YiYWsHZGVPAI8?= =?us-ascii?Q?wFx/dRGJnWpthw+1V+voT+C5lBq+hAXlAJf0yETdnFhqIW+/G8uTyXmPQ3wP?= =?us-ascii?Q?JMRRg7jbKh31DGD2ZE2c/z93gtIv1ofHZ61fyDYVs/l1dIjs6wfhnWZJ1/yd?= =?us-ascii?Q?wAZiVxEosBkGl0XsbXDVkGoWZ2EtMDY8sf4uv3IRR4qlISO0WAtTlzHyzPS6?= =?us-ascii?Q?6WuuvbYyVwZvsul2EF/2SnVO/b0nnFlKcWUXwuX+cXcRXTyFA9hCaFdPMRo8?= =?us-ascii?Q?I4sP1wUGPzfeFkNsnA/5o5WX6hb3oazP3pp6Pem4rpqKO/SzD+YBuck+UZ/3?= =?us-ascii?Q?RQFcQ2402X11TInsVozMGxUbPE0/i2s8m+QueYvwysCRXDLVDEZdlQIovWds?= =?us-ascii?Q?X80cBFm6qoS1tIggB3+oImjf6JOz3H48TfWve7KyqsycPHMTvAnyFmTtozTH?= =?us-ascii?Q?TJ9HRYjQJET7ACjeqQ/DvMBQIx78Ccdzf+gUP+bPUI85bp5TmpH98RFp+s1w?= =?us-ascii?Q?Pa4wdu98JpGR+mf/rNqbMT4eSI05lOyAP3ncLGs2pSR6PymrQk8fjgZYf7Gc?= =?us-ascii?Q?z90xFBLNS/88uTLkEclgWQRqCowuLXepJXKYGCdTNXPkm3BWdN1ycbqbvZTD?= =?us-ascii?Q?pUDM27N3m6L6zVwAPXrjbzrsNdYlQ8MgxaDX+bTik2hxzCBMTbMyE0mXKXVd?= =?us-ascii?Q?IdHx9x1BDDYOBV1tRFdhgTsU5a3XOO1sELt8HROlJQ6dJR4PDbJWzkkBjU2n?= =?us-ascii?Q?CU+llA2fFw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2338456-0f73-4fb4-6b35-08da2ba1b043 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 18:37:47.2815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zfyQy14zWHUpyuW5XABhuGayXNut1LhtrqhRK3ew072JM7K1yqlk0KWFwRCLPQnb4eIDR/+IumCFO+obzSntdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4891 X-Proofpoint-GUID: BnvGn0oBDyD5wBObHfvMGGdSttecJsan X-Proofpoint-ORIG-GUID: BnvGn0oBDyD5wBObHfvMGGdSttecJsan X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-01_07,2022-04-28_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > + > > > > +void * > > > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) { > > > Null check for op? > > > > Null check can be added, but this a datapath dpdk internal API. > > We do not normally add checks in datapath. > > If you insist, I can add, but before calling this API, PMD/lib would ha= ve already > > checked for null op. > It is ok for get API. It is better to add the check for set API as it exp= osed to user > application. > Currently, the set API is validating dev_id. It is better to add a null c= heck only for > set API. Ok. Will do that.