From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFA9AA0554; Fri, 26 Aug 2022 10:55:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9955540146; Fri, 26 Aug 2022 10:55:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B9ACD40143 for ; Fri, 26 Aug 2022 10:55:41 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27Q6TaU9000766; Fri, 26 Aug 2022 01:55:41 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3j5a67n1pm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 01:55:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i6Daif3h9TdagZ67otBb5AQCCsLtOGE/I+RdiKTL6Lzv0iWYHfdzybjnRhmzSjEt7vWfgRIu1Zo7emDiLzJ5nN/33WDqHEsttk94Htl6T3XNwiIT8c1/DFc5K7Sl60qZ5QWSzh69SnU/hgOuo8I3O0XbzxX18DD8Yd7Rj41pWGXRUw6qqgmM9jhIaXCsWvuPa/+87+Cna/LdIdnbihhaEwQgpZslu0kO43O37iiTLfQ+vrCOpDvJMy9rvmY/VfjDEE9ZRv9n6bX10qa/gretT/RZJZAMPOT7J0p5CpUHstz0LHQqGptDaQWOSAHSMWqQ7yV68LdVIY0lTrGfoxg2Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HliQ+HUmxvgbONrhaURY6PCHir0IggIhsoUTW0xyCK4=; b=QBL1KVsPSDC7uFSU/fVWmf+XufySAHnkw7H7LBJvCEy1x//j+OaAGpeOLPKiIQnW5N64boPDJmPwA6oq8wOzcDJuvaw74h6o+H28QAzea64DdBhUsP4BosSmA9U7NPjyAXq1O3Wwd066TS91MCdeSB16414Xb6FDjBQU5KobwGeh33ILBJY+qNquJohBT3lsm1v5FJgCpKOGz94eypCbEvVLIP4pK4uiY0269j1GhC9g86hdkhWUY4rCGFGYxybTf6ag0DBNtPciI8KIybPsfTr7IdX7dBTJR9r80oB2HQwPEFiij5M61YO/4pYQK69vmL7SalqhjUmGW3cNVJun9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HliQ+HUmxvgbONrhaURY6PCHir0IggIhsoUTW0xyCK4=; b=qN7Awx/GPrzdph5nBlw3rj1jOUFbm9ECMnu90ys94kV73NNiq36pnJHwdDG5o/zzLfKxwzCapyJd/mVEvB2tWnnKD8HiWYeHbbNVUCQZUytgmrYBVRMY+bHJ8t4UpohUslWX1gNszB8DTMePefyaS9E6Qbc87tD9hsnxqYDVPZs= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4890.namprd18.prod.outlook.com (2603:10b6:510:119::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 26 Aug 2022 08:55:38 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382%9]) with mapi id 15.20.5566.016; Fri, 26 Aug 2022 08:55:38 +0000 From: Akhil Goyal To: Kai Ji , "dev@dpdk.org" Subject: RE: [EXT] [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC Thread-Topic: [EXT] [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC Thread-Index: AQHYlUjRvKqjo4WAgUmd3pH/EHeWoa3BKCgA Date: Fri, 26 Aug 2022 08:55:38 +0000 Message-ID: References: <20220711170810.60624-1-kai.ji@intel.com> In-Reply-To: <20220711170810.60624-1-kai.ji@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 827fc349-c3ff-461f-e015-08da8740bf29 x-ms-traffictypediagnostic: PH0PR18MB4890:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: COWdDopofSf79JNjtW/wduUPpUJBcA9bgV7NK2mwMTVxwof8WLmS5ds5YeZw6Y+ebAe+4bgriAdH7iNWsy91Vlk++HOhh6S85uVGdB5L7Dkt+R6lCWrOq3pJDmg07wijrQGMrvUJE6xFJcrCY2N37ekNisRS2g3ygmSlhFBb+sV5/KaubHKfNMdtxcF/ShE2yqL1ve/4MpZ2owv+fdWktvjtMApyv5LAzuw1G1hAtxaZrsZAdl5NNX14tgDdMqpf7tEFzOGEGmpX1J76A5wTA9LJu9pbYvLm7uxebxvucXNfnwYqRvKmx9erScWNWaTntraULdlodRzC8YJW+cTpyyaFwDjqM3uNajh/5ctP/nsq1no9u0NFDJ+FB+IFoBcll5+dROaTQjUBvMKYnBxlLJkoETosfqRjFtUTI8nOTZ2pGbvptGKGDIJl10W6RVDCSChgMMnKAQSl4fWDeyML26vJoy39pPNq84NdAIT7/hL+OB/6Wfkpc14udVw+aRHO01WhJ72k4hRdXNtb2ajDdaeQRowo1w8Z+P8Xm4ReXWTdJmJSsDVfH9VOxKMfDiojRMPQ7TDjifz3jtKGpXLLE7hyfP/uqL7OA5pHxaCkkiNjLu70JohBLwZhJ/21Eg4Xhqse0vUvsNyK/mFdWLSmfKWVmKQbqzcn7+Wsbx4BuxI2grcJJre4t5AVshTlrqV456bVRW2Zz6EG/LO7LExEH5TCYAxW1KnqTXD7G59BJg1fCUQQMILtITSS3Cla751fpJO26TaMtS27w52Hoo8kBA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(39860400002)(396003)(346002)(376002)(366004)(83380400001)(186003)(66476007)(66446008)(38070700005)(66556008)(66946007)(64756008)(316002)(8676002)(110136005)(71200400001)(76116006)(9686003)(5660300002)(26005)(2906002)(41300700001)(8936002)(478600001)(52536014)(33656002)(6506007)(122000001)(7696005)(55236004)(55016003)(86362001)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zuikhdcVcebVNq7cOcSOQ+/k9phCuwVVg6LF5Gjsw5/1x30ZDuNBogQ4Q/ZH?= =?us-ascii?Q?ij/PV86e3ObDYbINmgPkany4lIO0bhaSkwNo7NDBPi3aLrHhbA75mcGqzmtX?= =?us-ascii?Q?nKPf4TexUSvF/S7fASnE/ZCIHPzsvhmKuDpLPTysYAclTgAhwB9znzgPc+Nx?= =?us-ascii?Q?a9jDaa/9m9GJTk3aEvtQdPrfPes9yYBRcyou0W4s7IFwQmmmzIpLbiVc92eN?= =?us-ascii?Q?Zf+Jkn4xuVgkum0AF/oovnLEZ39NvyigGeZOKxptcgLkGFp1wdd+wlG4Y+Lg?= =?us-ascii?Q?Hv6ipiV0cBqcOVkx8PFSSDYHUF173NnS4WaPRm8J6sOY1HDYX0kUiIK5AJoc?= =?us-ascii?Q?7ISp91qRDcAGEbQ5Di3DXXy19pVmRLEtCWGXa7bnqV7ePoUW4QyLrXbFwWdF?= =?us-ascii?Q?e6p2GnOc7WLRwi3WrzBGh1nefmkAcbA5SgwIwIUtzxwANXPNYiUdVdgPKfz/?= =?us-ascii?Q?JYlssr2jCsstVxc2grotVINcbNBNNnFV4PbCKcfMBHzdZjHvcDjCt5ROX0nS?= =?us-ascii?Q?aR566cecqQWXPbcefOIhj+hMdbwssQauo9lTS5j0LaLTwfpTWpsYl7bjHKq7?= =?us-ascii?Q?OEoGFCbxdiRXT2KKqRiMTcDvfG2nUIezkgasEUqfIge/JCD1+4v0uKlBOkJ8?= =?us-ascii?Q?gw/xlaDByZNqeQFXtiXS552WyU2x2YD/yOyB55EQqWz/itZesf+vuYVORIVW?= =?us-ascii?Q?hymGQVbY+YEcXpWwiOULEiahj/UY92EzPIXboElN7k8I0Jgp3Z7vRVJCAYNK?= =?us-ascii?Q?8ZbvnGR5LuwgZfsB+m5ZkXx/5updVfIDRzJyw8f7xNXq45SXOuhzfYcg9zcE?= =?us-ascii?Q?vvbcPHtq/GTBRxQS9G3jnuddWGQ++9qlKJZkQ5Pn4u4r0tisujOUR/rl1X9w?= =?us-ascii?Q?8L04V6AqWAL0ReSuAlVjS6BsjgccPqLKoWpfRwKwm2VKLpYxNJAJvdQfqbnJ?= =?us-ascii?Q?MAaTovY4rWsyCb3Bn/QStO7VecrHN8jBQM0G40Ry5Tm4ZlgU+1pSsLBdBiiK?= =?us-ascii?Q?xTgwHMgQUeL7wVPQHhRj2rNoA0emPZjqv3tK6BFjj5MALd4rrQoggsQ8Vt7I?= =?us-ascii?Q?y6aFGGM/qGL+71MmIbZGaccoXja0HyPUCShyoSUNu30IZLd86JiAYNoqvTMz?= =?us-ascii?Q?v8WVDen4sm/jSidyX5eVp2+KtzeKrCpPA/lLejJMOE85WIIJogggbS4o+0XU?= =?us-ascii?Q?OkT9nq5+dxfEhSjeDghcslx0MJrI0GW0A4JuPd9eVvWAI2zt+6bQJUl00Zqj?= =?us-ascii?Q?SurXuftCfESFuuU1rrlHEfOj6f5NqorSDYP1cD07y1ugDxRH/j+GfO0lgJUf?= =?us-ascii?Q?QW+v2fjmTD/qn/u9obru9LTPbLa0U/RfOlPQ164xfKxuCpcMlo2j8doXEPiG?= =?us-ascii?Q?mtFnrXp8LRrTm1DEaq+KO3tJUuO5OU3NBjjbjnfZof8ukVkAgnk8p4nRpQSI?= =?us-ascii?Q?JJv+DbJAJFD/+iS0Ln4jOMI0vtE724mkPtv6AHPGTFyZrAlHMAGfBnu/intz?= =?us-ascii?Q?VQCmfW9xvlyxwKsgYHQ4dLj3olYh47+fCOELj3GpGjzvIdHmnPZlRitCdBsm?= =?us-ascii?Q?qydACiSLgtKIbTP319WHK26xM32HXhHGjuHis/TU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 827fc349-c3ff-461f-e015-08da8740bf29 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 08:55:38.0883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MMyEwWfhAE8gQUYXJFaIu79O7Pn20JQGQwm+COoCvYr8ocf6QlLPDN+f8RE0J3uHbj8OX5COFTS/zGBfxhK01A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4890 X-Proofpoint-ORIG-GUID: wJ4spz8Uzjf4lyYdQlUhsXwSsUdn8QQ_ X-Proofpoint-GUID: wJ4spz8Uzjf4lyYdQlUhsXwSsUdn8QQ_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_04,2022-08-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [EXT] [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC >=20 Title can be reworded Crypto/openssl: fix HMAC output length > This fix of dstlen passed in OpenSSL 3.0 lib EVP MAC final routine. Please reword the description to explain what is not correct and what is do= ne to fix it. >=20 > Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP AP= I") >=20 > Signed-off-by: Kai Ji > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > b/drivers/crypto/openssl/rte_openssl_pmd.c > index e01dacc98d..5658b9db66 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -1395,7 +1395,7 @@ process_openssl_auth_hmac(struct rte_mbuf > *mbuf_src, uint8_t *dst, int offset, > } >=20 > process_auth_final: > - if (EVP_MAC_final(ctx, dst, &dstlen, sizeof(dst)) !=3D 1) > + if (EVP_MAC_final(ctx, dst, &dstlen, DIGEST_LENGTH_MAX) !=3D 1) > goto process_auth_err; >=20 > EVP_MAC_CTX_free(ctx); > -- > 2.17.1