From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 600F9A0508; Wed, 13 Apr 2022 09:13:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 094A540694; Wed, 13 Apr 2022 09:13:07 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DE9A54068B for ; Wed, 13 Apr 2022 09:13:05 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23CNGcwD018361; Wed, 13 Apr 2022 00:13:05 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fdjxysj0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Apr 2022 00:13:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Md3Hjt6KeW2vOc8LC2VJSGYmnAJrxGIkm8/jfnBHnGUe/RLBJVyLY6LherGttc9D0pP2poEE0L1BEF6WoEjItIoXz/CgcUUd3I1TvQ/oH5odjszXOTbV9yurVsG+5l7mmnJO4pL5Iwy1JnKC8CUiQtI46bE6tIRU5XiulzjQf0xX8teovbfdR/QRxVAm8VQRZG17bWEoT8l7GkSG+eEEdwM6a2VaPFYL/o2wmxP5EketmNPTh0uxfVp7Lm1pE9YuVTKMRNJum7+fGu0kbWUnBCMCo2E2hPBQtQbMQMJG8BC2DuOyT9FjnrpvOAnPrf/lNh0zWEcpIa90iLs1NxoMzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8MgXbX6oVzcwGeJWni7rqL71KiOI1VST4uVYPKUPjI=; b=Rv1iputslrMFBxkd03NiJnc/E5o6UpgT7+41Kanh8y3iPBtDpO4+4bh2sQlySAmyjpBMYOVQIC2rHZ1qqce8Kwei0L4g9Gb5BVKKd96kdV2lpavC3MFnazBKoCbcnzYmNqSE8dnDz1drPqdOzFCJPYU02QpeiV8VWeJY3xAe4/nwTycGXw5g2Jw3Y5mj8n8sSeZzmniQczk7FHFjKbEtHcVFw9Hj91WQEI9dT92SPXh2zV3J5Z01Cc9fJu3DIpr9Au2C0J/0x6v3/xllYLnPeF+aTrmH8v5a8mXOWhsKufP65JgHfQjJyBlu9Qi4gaQtN9E1y46d370DdvOdJOXhMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E8MgXbX6oVzcwGeJWni7rqL71KiOI1VST4uVYPKUPjI=; b=ZmMBENEpLnlwj8MxaKeB8iz87qvknFK52IWrw1cAFTqXe2syVE9kCyPtub5uyngUTnNfhGCrp02pGGOZ8B2fm9mCPeVLnVvUvXqf/ISVSGxmGKDNh522YD+gsoVPzqWdan5YIv9B3Gu4yFoXG+E7XXngpEwmDZT7enhgIWo3Bvw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4999.namprd18.prod.outlook.com (2603:10b6:a03:3ea::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 07:13:02 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%6]) with mapi id 15.20.5164.018; Wed, 13 Apr 2022 07:13:02 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , Volodymyr Fialko , "dev@dpdk.org" , "Jayatheerthan, Jay" , "Vangati, Narender" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Subject: RE: [PATCH 1/2] security: introduce per session event metadata Thread-Topic: [PATCH 1/2] security: introduce per session event metadata Thread-Index: AQHYQDnFfv+VO3bY0UKgR1ETLX3qmKzffiMAgAAR5wCAABDogIAN6Ftg Date: Wed, 13 Apr 2022 07:13:02 +0000 Message-ID: References: <20220325111615.1118946-1-vfialko@marvell.com> <20220325111615.1118946-2-vfialko@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79c3f536-a03a-467b-7011-08da1d1d0c6c x-ms-traffictypediagnostic: SJ0PR18MB4999:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xSlnphy+KcwcsIng59giaY8WSb0L2L9hPEopCW1yM2r1nG8ZexXoSxCIfDEzU7rsOstdQ+tJqzej04x8oQWq6bRB8Zofg7PpwoZr8ASb98RrCmOXtlqjqKGa6nu7cvsRi3Z7bSxysE4zaegfiOL6gBMNtbCnHkf1vY1JUIgC3y04UOf4KFydv7Pr0z5dR/MLsApzPG0nsZVaBVcjfeyTx9YI+1IwGU8AUjqa++UCnBlBEBVw2qIBMdlS7sApq1zePocyt87ZUIyyeWCmiM+/IuyYt1Py4pgxcBk5noDTjyvCv9oF/1tT4eBhaM3SazOU/PsO5XzFMeX9Z72haPOyw2caP5DWQH80IUpWX32M4UEikhzK4T9BX98YoWLpsDTD/oZabyNPmHViFZQ07RCPxcMvjzOL030EVSI/Kx7Mgpu/Y2uLcDunv5u6uBJ02OPcVMhgeKoBUoiP0cRNviFFZzV+iV9+0cSS4yLavCAF84d9gep4u7tSBQJt2FRpGd2xDJ6n2DVwX+1qfi9MEv+eKpq09wjoR35CH3dIMCofNiOlQyh285SbtNomu172/YwVszu2y9hyM0mqN5bx6Z3YQIpmoRShKiYtKK9QEjW30SIpAI5VB3fMHlzyYCRT3Z8H4bf2S04IdyF4Urb+uzPtcwAOEWwQbiH8k2zmn38O5YYi91KSGunpO4BpoBuI1m7ePMC4J1sbxeXyyPQn47wJ1g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(84040400005)(15650500001)(33656002)(2906002)(186003)(508600001)(64756008)(66476007)(66556008)(54906003)(4326008)(76116006)(66946007)(66446008)(38100700002)(316002)(122000001)(110136005)(5660300002)(71200400001)(55016003)(38070700005)(8676002)(83380400001)(86362001)(52536014)(26005)(107886003)(9686003)(7696005)(55236004)(6506007)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hGoZxzLl8+NIdNUsrYp9C+Mlu7cpnvL9DnBxnqJ5u9FRQQYrNRmX/fMfwlDt?= =?us-ascii?Q?WDrKaE/rWDGtnRpUsHmKn7Dbih9cNqy+JiZCnuNbBQ3IU7zr+7PaPXUx/bl3?= =?us-ascii?Q?lXn9iNccHkguJyi53wpOnFyHld3LhCzTTQLSnbDr3gt8PzcD8WbHXMMRzkP3?= =?us-ascii?Q?oyNp0VP1/9873DrAoYgF9G9Qwulqb+PrCJhRoHT8nYiGEsxf1SRUkfhUKQAI?= =?us-ascii?Q?vseIafmAvEUKi+t8ti/SMv2Rzp1t76VY/8l+e9evHdNPfE4QQvQKB8BbmJG/?= =?us-ascii?Q?ttDRNmRKsKp6A3Qj9r8Yj0zecf8U+iJu/ebw/+bmw+Zw4X1nMHj06Xgq3fj1?= =?us-ascii?Q?3MF9gq5tjflRgblqvkl5VcWewfbDTkDHlwk2KjxLZ1S+Jk8UV4v8/pDuD48t?= =?us-ascii?Q?cJSklC4exqTD7akbkcknv3T3Lb8mGwgXtNMoI65RdaM2UID6YtN/5bBUwqEI?= =?us-ascii?Q?YJOXrSGAVUfhMyi1D8lVSBAM0pJrlmotg2loIUClr6Y8wxR4+nRInwy7JKkw?= =?us-ascii?Q?mVyeDyV6Rerd8qsmeo24deiO3bskGecEv5Gfbm4eytxxfTZg18JR44yjzWXY?= =?us-ascii?Q?emXmerjSQ7qWOc+l9dmrwhEyM6/OLbBh6UVHW8X1ER44hKz6KL8UHU3/yqDq?= =?us-ascii?Q?XUO7xwqE2OwfWRBB5L5+rpTFJj3xhZquu98L5Ls+TDKZ4gmTgZLPxfxK2Nw0?= =?us-ascii?Q?p++SZnGbf0MzON+nAlxtUg2IYBLQxgQ4dQh2AnsRhP+0SdC9gcrMBvc5kV4+?= =?us-ascii?Q?7QEFCj7IKiYzdcBCVoGA+wjNVStcQ36jxbBm18+k63r15PEYGApbcXHv5TXW?= =?us-ascii?Q?GNaUKUOrjBveD1JJWwVD80BClQVZg4gv36+AHeQ+Xi9XAWa+uYUKyJ0la1zI?= =?us-ascii?Q?6lpcCpTZ2VxQ3h+imaR3DzJWHWigxefr2j4ZyIQ6CzwdKynYTxtPwx13pJmw?= =?us-ascii?Q?S6hhX4qQi8qL3HnpjeonyaNsIVTEufWhon+KWgHaMVn4FmTljI0Ii/Lw1AXw?= =?us-ascii?Q?HyIopOCFRxz22qvhq131999W6WHtqMfYOsa8imbYdICBoolifxF3M288YjhS?= =?us-ascii?Q?QNM6h39+CAuuT8YF+MHxJJOAf4Ke11gTXdMWNCtLjhTusERHXspsq2bXBRYF?= =?us-ascii?Q?E0SnSh2rph6pMV8S7BjIpW4TSJE7i3jKqoqdn0RjJqflLKv3Mru5T/CRnUKG?= =?us-ascii?Q?PGR54FQ/KuQF8adIXpimccNmuZUKUihW3GsHGeTVkXJt5TmQFAfHtwpXXaPR?= =?us-ascii?Q?llJflqNh0B8owclOnf1Oo2nRc3Uft34l2Cll5HKzuptEiSaM+dwTAvotWlS3?= =?us-ascii?Q?/lAMhZV/on/VOdUDj8d7DM8Mi5Lu8bw5lh4Zl3qKTt9T7AxsWP7cJPR4BQZq?= =?us-ascii?Q?m3ZnzZcM9WS7FA2gHErWRVGOducExQwqvKJYr5klIa9zFLvavsCAHJA6eOJA?= =?us-ascii?Q?BIbSob9FbpXw3KLFT5DFh+46mq+yJY2rIOtiaylZ3GAqEoTDqVLZur+u930f?= =?us-ascii?Q?8PApXbnwgf3zSBJjG1PY1EEUqHLcYyOKNJUJNDH4NT4/bNE0SbZrjSlHllMI?= =?us-ascii?Q?mdvTzUclN4ZC3/JCLgTKSDtGKfxPQrRCmIxfSzIpGI6sae0QAwvnGjlNb0dJ?= =?us-ascii?Q?esYDz9QNENBEQpGXX5QpQzbUkG5l4+X7niMGNPExVgHsibJUERbuoQUgVsjf?= =?us-ascii?Q?oqxenmoo9r/kbEfF5bEOesGRxVqx7WLYJnRQ1Q/syb9oCnwyyn05FsSlVeH2?= =?us-ascii?Q?10g/8a5GbQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79c3f536-a03a-467b-7011-08da1d1d0c6c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 07:13:02.5099 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KvsJmjfsh50elE0yOZnMRjVlolK4gze25o0Ov+OeV+ZVV+LBr2OEW//eU3jdD8bY1NeQ/hpQ06bNRLtIYnsfBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4999 X-Proofpoint-GUID: 6OMznCXTZigL3kBziWpN1IfJsWtI8wHr X-Proofpoint-ORIG-GUID: 6OMznCXTZigL3kBziWpN1IfJsWtI8wHr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-12_08,2022-04-12_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhinandan and others, > + @Jayatheerthan, Jay & @Vangati, Narender >=20 > > This change would be an ABI breakage. So to avoid that, we are planning= to > > Propose a better solution compared to this patch. > > We plan to add a new cryptodev op to set the event metadata. A single A= PI > > which can be used in all cases - sym/asym/security sessions. > > > > As currently in case of sym crypto, userdata is being used for storing = the event > > Metadata and it is then dereferenced in the PMD which is wrong. > > User data is meant only for user to use and PMD should not dereference = it. > > > > Hence a new cryptodev op can be used to set session event metadata expl= icitly > > if event mode is enabled. > > > > I will be sending the proposal soon. Would need your help in testing th= e Intel > > usecases. > > We may need to stick to the approach introduced in this patch only. As if we propose, a new single API for all type of sessions, the driver wou= ld need to Get the event metadata from the session private data. This is not possible = with Your use case which gets it inside the eventdev library for sw adapter case= as it cannot Get the session private data without knowing the cdev_id. Hence, we will take this patch as is in next release for security sessions(= as it is an ABI break) And would also introduce a similar change for crypto sessions in next relea= se. This way we can get rid of using userdata which is wrong implementation. Regards, Akhil