From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 127A1A034D; Wed, 12 Jan 2022 12:06:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80B6B426F0; Wed, 12 Jan 2022 12:06:13 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 34B1940040 for <dev@dpdk.org>; Wed, 12 Jan 2022 12:06:12 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20C9FUeF022569; Wed, 12 Jan 2022 03:06:10 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dhmnwt15a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 03:06:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+fCpS9C4neVXxtg9cw+gDH4udHjkH+Pq1ebevLG+RJPsjGyzZH7m91xc6q6z2Bgfhtt763eY8NWrzo2syWHeTA1p3cyRH9fbmczYBqUqSMTuGrNEvsX7Rgu+NwgiUBa8EZdOrRCxgihcHdH/u4CY6mkUDEbUy7lj+eE2JAxqv7tBQ2O8TrMK4mWWs+rRNQ8DsWH092e8mEe4iGzEnePnf/8+ykPHU4CqydofFSMUZchZgDUAQauEpPqDpb5TAQ+QyTGzEiStwMN5YM1eUpGnydzV7uh9oMRGyPckVeJks+EKfeL2J2qmBd5riSu/qz6F4CxnkBLNYro/oux1tUYPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dcTB08iQxNIx6AijB2GXHtvGwhASPaLg+UGNl/2Wvc=; b=c3q7kJrO34t2cHO0n26bKNhbqOdHhc+3Cf/5oc01QjXsuWVgw6+l4c8A7N9/Ny9jtI+uEF7w7VC18c6mLwwiYnxJeNLSPGPJSHK/WXnUaWEOyKRElcJ7OKlTYxihNbEd7R3u1PJjUwy325PTO9TJRT+0i8dIU8Ft4Zt4LcIG0oU1g9GsUF758fxMu+oAuonDQXkYR9HiOV9b99C3xroE+8gOx05ENg9wwVq8u/BoQCIm7CuDXHtkEXBRy5PDyh3WOrLwlACoUuWD7sVTFsVDUM8uiS5Cd4ffTodeRPWd83h9EOmtTwbaP7fBeyp+NSO/NltSgexhOCab7tTIxCjMOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dcTB08iQxNIx6AijB2GXHtvGwhASPaLg+UGNl/2Wvc=; b=PQefgL4YZrfY6LPegfZeYv6sjEFgTh51S6U9mCUXOFWNY08phGO64vCSyHw0Cx9gHcTcO9a4qxTF4LQjzs6QBmyYEVXTHp/aFyfMmsCZBSI9pvsKsIy95ELlPcwBT+5v1+fjkA3JSJqRytX9QxBSfHDAHHe1dk8zpMxa5BPUTQE= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1546.namprd18.prod.outlook.com (2603:10b6:3:142::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Wed, 12 Jan 2022 11:06:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%7]) with mapi id 15.20.4888.011; Wed, 12 Jan 2022 11:06:06 +0000 From: Akhil Goyal <gakhil@marvell.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: Anoob Joseph <anoobj@marvell.com>, "Nicolau, Radu" <radu.nicolau@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "matan@nvidia.com" <matan@nvidia.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Xu, Rosen" <rosen.xu@intel.com> Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPOiP3b/bX9/ESNWXt27mVBoKxeCfCAgAArc8CAAQXIgIAAAJWAgAAGqQCAAACF0A== Date: Wed, 12 Jan 2022 11:06:06 +0000 Message-ID: <CO6PR18MB4484BF745C71144E0A2D4C42D8529@CO6PR18MB4484.namprd18.prod.outlook.com> References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> <DM6PR11MB4491A35D01C2FF217A8A065D9A519@DM6PR11MB4491.namprd11.prod.outlook.com> <CO6PR18MB4484B881A98AD80B9F3D9673D8519@CO6PR18MB4484.namprd18.prod.outlook.com> <DM6PR11MB44913F3C43355F8309A764F79A529@DM6PR11MB4491.namprd11.prod.outlook.com> <CO6PR18MB448425B06A61D76908028FF6D8529@CO6PR18MB4484.namprd18.prod.outlook.com> <DM6PR11MB449180CB74AFB659EA7D2A969A529@DM6PR11MB4491.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB449180CB74AFB659EA7D2A969A529@DM6PR11MB4491.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1e42a3d-3583-4011-4f29-08d9d5bb8818 x-ms-traffictypediagnostic: DM5PR18MB1546:EE_ x-microsoft-antispam-prvs: <DM5PR18MB154634FAF6FD2CFE2D839D3CD8529@DM5PR18MB1546.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n91MpfBYxZI6/IubEDxWrI379BlM227QONEoWcBzH8U6/KC5QTyZvWA34u8biVu2ZbhnoG4qxbYo8nSytox+ParVno4ROgBscPf81kH8qZKJZwcJquVRzGCPKz0eykC57SI1layFkbGpEQjGLNlANxD97xrDFjwifKGaScjVSVcnr/fEH+a254IBYxSzFPAZoDL/BLYujBR5IszQ4FrcfrEUxbDW6k6vqnxoD4dsSGdcFvUTN70WAy8pFMQiAIdIFRNU6U8D1qzxk4AVosz8LPo2BlIvA54nh22q3kb5BY6ZaSs0uJXzPhlwcNRnkH4u2JhpTc+D+efbBnZIcCiBgfXveZMIQl7JxZ33L/Y4THyBgCLML3R/RRfvqOdwyWlpN0n4/C2B4/WIJq50P4t7EQX2Vld6O1aL/S9CX2F3G6P3qc88EoZ+1xN0LG6MjqM2xgSgSJs8GOTQ8km+SlSwQBQu0FnLi5e2eXhartVETJWVwRuPUKTahneoUObGkxn6GmDmkXtwNulUOJHNd3geCa3fjoyVBS/1JFCC1LDHLOfBlxxG/q87Ben7WDrx4BUEnF6YUueGVRGVRJLDhwJbUlufwbXDqXqGYa7THrAEmuuqtK4LHy2maV36ux6YeFsSzB1owlwrhxYiou8ehusO8sWVSzxsh1dMrkiUnCph227JUqMuHvThM596tAXAPoM8Mmme6UJ7mwmyz4OqLlEf2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(508600001)(316002)(52536014)(9686003)(4326008)(122000001)(54906003)(110136005)(7416002)(2906002)(8936002)(7696005)(55016003)(38070700005)(26005)(186003)(76116006)(66476007)(6506007)(66446008)(5660300002)(71200400001)(33656002)(66556008)(64756008)(86362001)(8676002)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BEqu68SDqOTHU6xIGwjcIEaE3aQjBMSkfeYn2LFTbp4rQh/nbg1WpGnj51Vb?= =?us-ascii?Q?pP1qJIRoerfOwoRjxyJN8FieHmMJIg+0m+Jr/wwPQ4VUN/P1jvNFZ/ir0rQc?= =?us-ascii?Q?1vYW+duFzX+azO8jAy+yuUztb5cbBvLUQiouqVC3EwMSIWBMZxSKcxRzGDhC?= =?us-ascii?Q?O+f4WE89TGMmW+TZu3o8iBByl6cHKOHKmPi5a5PrUjK8gbVKi8uhQWBmK26R?= =?us-ascii?Q?r7aTDlvJCmUSF1mtgcC/MgqarZ3V9dmhGos0JQnVJpj9YbEZSTKfkC8xHURG?= =?us-ascii?Q?zdme+Ih2DyRHNKiD8r/XqFZaMRhI6rDXRRWS+UghpZq07mrk8zZImm1Ty4MT?= =?us-ascii?Q?cRQz5bnfahKziiWgiyxLmHlxvWV4U5SsfS70n9rN0ofa6gmDT6ATkDiU1EDO?= =?us-ascii?Q?GrUwnFm0Ey/3aAcPrDsx8DFjzJau71v0qVEknMIrqR2kSYP6CilXKxSSc5fu?= =?us-ascii?Q?hvLWj2rSX3RlWiiqxpWAmPkW01CEvsIPINNxHV6kqcBS8wPdSxL49PEs5KVn?= =?us-ascii?Q?fGHqFV6ilLngP8/hu9DUxC4TmjWVTjspX5uiW44vv/Unh5JFh9zA+PX9r6VP?= =?us-ascii?Q?UmDKP3CF55eb7MzBwXGMQQFrNTF0NwYd08EUJU5jGsKwAY5C570Rh1htetbJ?= =?us-ascii?Q?WYipcS03T0xvplk6LA20txGgFZ7v6wos+V+jozptxjTG5XywXW1JRJgn2zR4?= =?us-ascii?Q?Zetraloq1jSBWWlIu1ck3QT6RcyJq+pInMMFGQipmWfJuWTFaAmp89D0M2wp?= =?us-ascii?Q?BdQwr1XwdnuDOykhJOUQvOt+h2ZLns+0hK1lh2bCBVrHz8q/0Ug2Yw5b4R9s?= =?us-ascii?Q?ePATjzZrhrk1tLVE3edcCvqXJFUxXJvfFNe0zFI9X7u+t6FU2jDswa0+TOzP?= =?us-ascii?Q?VC9w70bcJZfQQLwENxWiWx9dNRUTqDhbSlz9qk2YJp9PYv1AGQYDBf/w9R2X?= =?us-ascii?Q?UPRZLd5c4wJPpaEngZSPTX+BD3Y1UcgbbTxi8kBy2z6TEvHkTwMvi9DWVhag?= =?us-ascii?Q?deyKTR+LBsbiA0xVXxBzjkzyGDaq6z5MS4wfA2CTmkDHq3JrIARx56EOl7jo?= =?us-ascii?Q?i7uFob+ngtVBX8R0zpm7T1cWPcv5ZI3V7kUObaOcOxGn0eoLhh03hnyH6dyn?= =?us-ascii?Q?ndV3RPu2BYTWK8x1g5zWjtesW16kTDSADsEHD9IQ0XIR/QIAazdmzqyp5VZq?= =?us-ascii?Q?A+l2wEYymz0lKxxSguaZnqA1R3ovL+YH/rHVS49+njh7eDt9ibjxPFi/J8du?= =?us-ascii?Q?z6PWr/JmXMsd2+GWLrBeRxWGOsmJkoh55d/5lyzmub0wG0G5vHOgOnb/XeiD?= =?us-ascii?Q?Wl/05FhjXNJw3LQtIchDtSJM/9bpu4pDXprGBTWkIncj1IyKuU52yL1XHzy2?= =?us-ascii?Q?+FoUqRqUE1vn9CKwVZVFbV6RW8zhzaUrERSFmc57vfsQa5i1X4sl6pvIaXfY?= =?us-ascii?Q?KSefM9wQgiZeXDCxudN6x6GRgD08QXZroaYly/WRSJ2nYWSJx1h7BTOadA17?= =?us-ascii?Q?PBYFbhgtBXrDDVGpdbtLby3GcwTqsc774IsDVnGl33ceUcCNVPItLStP4d1D?= =?us-ascii?Q?j1jhVIGan4P/SEpK0M2j3XYo5pvVD5bYRGwVyBHMaSeQyLgIp6YqI07mgmk3?= =?us-ascii?Q?HHMVQ577uEn17Iuy8EDBdE8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1e42a3d-3583-4011-4f29-08d9d5bb8818 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 11:06:06.6500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YtQpXtNhnodFRqTKGEM8kalPxO+k7U2iIEBUf6R3V+P3dDaoJUSmzkpHxNbpnwrRb9eALDAO5uHyOEAaM4gJXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1546 X-Proofpoint-GUID: FGC2YlqgVD4Td87k5JXySpw6JvIFFhAg X-Proofpoint-ORIG-GUID: FGC2YlqgVD4Td87k5JXySpw6JvIFFhAg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-12_04,2022-01-11_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > > > > > Another question - if we have reassembly_conf_set() would it make= sense > to > > > > > have also reassembly_conf_get? > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > The set/supported values can be retrieved using rte_eth_dev_info :: > > > reass_capa > > > > > > Hmm, I thought rte_eth_dev_info :: reass_capa reports > > > max supported values, not currently set values. > > > Did I misunderstand something? > > > > > Reassembly configuration is expected to be a one-time setting and is no= t > expected > > to change multiple times in the application. > > You are correct that rte_eth_dev_info :: reass_capa reports max support= ed > values > > by the PMD. > > But if somebody uses the _set API, dev_info values will be overwritten. > > However, a get API can be added, if we have some use case. > > IMO, we can add it later if it will be required. >=20 > Basically you forbid user to reconfigure this feature > during application life-time? > That sounds like a really strange approach to me and > Probably will affect its usability in a negative way. > Wonder why it has to be that restrictive? > Also with the model you suggest, what would happen after user will do: > dev_stop(); dev_configure();? > Would rte_eth_dev_info :: reass_capa be reset to initial values, > or user values will be preserved, or ...? >=20 I am not restricting the user to not reconfigure the feature. When dev_configure() is called again after dev_stop(), it will reset the pr= eviously set values to max ones. However, if you insist the get API can be added. No strong opinion on that.