From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E31DA0C47; Thu, 2 Sep 2021 12:14:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F263140686; Thu, 2 Sep 2021 12:14:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 79B1C4003C; Thu, 2 Sep 2021 12:14:51 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18280SfC010729; Thu, 2 Sep 2021 03:14:50 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by mx0b-0016f401.pphosted.com with ESMTP id 3attqmgey5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Sep 2021 03:14:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D05dVsqYU40X06G94nfXn4E/7wUAl8eMj3GVbwH/LY79I2j+L3ytBN9ikDpSn8ZUqAcPmaV7e8XCE2pxKCqjgqqwNKftEYxJmUPOErq5DPJEedC6DcAtIkbF/t4RKvyzrBLMkBjxUelwPXZ0hDUSmIDnplenAKqVkxZr6suvD80ajkLVzGjovhmJ+eKLW1VKExlhMFH0vfCzHS6kNMzv8qrPCZa3PoSm0u5kozjd79JQL19Rc+cotrJXvAN+qirEP46mH0FISgZkS/vzG2nm6AYxOnVDP40GAyhs2EoGOfgtaR6OXgk3uhiNjJ4wvevB9QWMMlXTDMLNqUWfJ/cyNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bLHlz+FXvFElnMhPD5+yY6uvu+lP0a9YIJKARuMr9PM=; b=GXb2n0q8exbp/KENh1xWjXfBBBj4pD3JedlaFJ+wlxgxbVd0SsLHm/4ji35KF22DoSWcv4188NA5OTrmQgbE79t/z6tICNogGUSKHRXoazYn12ZVzQtgjIE1/39bMxxyb3x78/XIjakAcjFUtf8q6yi/xF4EcE8gJAgKT80QtZkFFv2F50VWCvjSdNYWhkQWNjxy74Teurfi4IY2iBBd08vXlsFvywJNzxPLfhu7oACvyOoHZE6AOesao76ILCHsGuuAwoiEAdqz2nzaS+ssjrmiWdJ6/HxIB/Wwha8O2tu9aaAp+IygH2eV0Gkoo/u2AQswbdpYsnFF+iRuQYjRpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLHlz+FXvFElnMhPD5+yY6uvu+lP0a9YIJKARuMr9PM=; b=f+LZSJ4E41p6/hD9bRC9OVZaed+tXcNXGRwChEQZE+cvvi/WvYBT/lUP4WZCaY5XlNN26NR7yzohXJtmpLd2ZeGRd7qi8B/Xi9boIcScPKc2MBUWTjYUEsi1Z8yk3aRwBF3pjYV5k3gLWPLk573TcY/kVT1KIt3DYKXgnL//7ec= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4713.namprd18.prod.outlook.com (2603:10b6:303:e8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 10:14:49 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%4]) with mapi id 15.20.4478.022; Thu, 2 Sep 2021 10:14:49 +0000 From: Akhil Goyal To: Matan Azrad , Michael Baum , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] compress/mlx5: fix QP setup error flow Thread-Index: AQHXnwWsBJYvBVz5Z0Oc+DIzKdFbDKuQiJNw Date: Thu, 2 Sep 2021 10:14:49 +0000 Message-ID: References: <20210831203941.3411351-1-michaelba@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68c2f937-ed7a-4b78-5e0c-08d96dfa7f69 x-ms-traffictypediagnostic: CO1PR18MB4713: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1013; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YEqIpNoDRRYqSyEm7EyiedNm/zIac9/z7bufm84CLzDWupnz1Lympc2mMYd162275cRpF7dvJVKEBFInu3I4NBd0u3zHT2fxz1hU+xTSjIHgoZhjMp2WY/mvbF+xGegu+QKfXS9hiWvOdddRFZsAW0/2AE/qEKQEANdt0bbbB1PnnYpWO4+TBxQbHEX36lLByqHJiwXAYEXIDPQkblStsfoe2f0oPEtMjQVjx7KRcebEONMgkfUPpGtOxDd9qa4WhXk8Ig5BA64D2TqTW64wLXpESQkye6uNJ2ymsI565rsOdQD2W2KfxDg71Q5BadcFlWokygnIDTPL0JS3DLeP5fninzxPshKn+CmbF/4cGxHMzIuom5wLlT2BYizW4cmsk22IW8FUWy/0rpvfAByG8FLRpUo+pB6P++jBMhycdoEWLKTs0naBDl6KXvKN7Cf08fnWxrfsYjiiMbMH4/b4yTLjTT1U7Wkpa1U+Ann6t7GNXdLNB3UdgGGoGxbq4mMr6KEso2BnijNYepeNqzO5x3kMQXJsu4tHnWEAU8YsZm0EWpd4yHBxN6ASmKm3ukI6SLutq6d+vY2uK8G4h2bH+/p7B3WTMcSNHIW+5cVE1nfnqsfY37y+5TEADOl+xnf28tIon5wOEmhweSD+jbgAhS2RqKLymTdJ+ZeJ33t+pa0yRUKRQEq0V5RS1yJjrfLJDVHkfDLyhrjxvOwkkouikQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(52536014)(4326008)(66476007)(66556008)(64756008)(66446008)(5660300002)(478600001)(7696005)(26005)(110136005)(316002)(38100700002)(38070700005)(66946007)(122000001)(76116006)(86362001)(2906002)(4744005)(8936002)(6506007)(55236004)(186003)(8676002)(33656002)(55016002)(71200400001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?myqhyFTjGhn6BhCb1Wf2RZlrWMI+ZWBQ5Xk+n5TRwG3Tnsres5CklCvHfhPo?= =?us-ascii?Q?BVcH3cz+0xNQuSwUSBEmanNzHkvS2iJV7uuskOKBsEVk4Q6g1gXIMylx028B?= =?us-ascii?Q?Y7cXAr5eYUOyQlH1nbR2Vt7f8QVDBnGF+G0D8cfi/RHZmxrJLxWU8BVUgIHS?= =?us-ascii?Q?OnY8Gy4xMWjdjjGhe+dJSuBqwBw2se8cfXeowqjGWOtqEdj/k0oI5ZTiMjRI?= =?us-ascii?Q?JZMLEszswxn7014HP/L0G+fK//3z2AgpVlxu3fWGhdnDR3rjY41BiYkTBPEm?= =?us-ascii?Q?+dpL4bHsKwiuZPbBFbE0ukNpzKH6l6oveIy9itU5Kc7GHK5dBpst1zNx2gNs?= =?us-ascii?Q?8LWyn0dcENnClqyebT5711JLViE3ncarkqlAF68CJZdHw0lF1RdCzwbQNRwa?= =?us-ascii?Q?6WDg3X+g69/50IWM7v5U4FggZleOrp1J9F1rkanff6nn4fxy3ThGHK1/LcIy?= =?us-ascii?Q?zyXkkokneIBSnwzd12JxfCahuzFAprdp0d2wn+E+DZRanWu37/6TLMZ7jUGC?= =?us-ascii?Q?fKxKakJyB6AS9jcGgc+huOvRSOz30ks6L/GtjpNsPjz0XsHknOYEafRXfJHy?= =?us-ascii?Q?du8VEi8OmICMNvcJ6EshzTtrCtBF1fcstAtlQ3jm21P5nET2CuJBxe2TzAtJ?= =?us-ascii?Q?8I3QVmAINjc8xTSI/Gt+omsGp208FUHKORGvo8UjfyRIa1P0eXpIPlNvO6ya?= =?us-ascii?Q?vyaNbCWhpVhqdYvPdePlq58UO4nQO5oKj1Ln+vJ7E9/T2VNlkYMY+QKgevrG?= =?us-ascii?Q?IIFciHsDns4zyNegSlfpNZIMefuGP7xaRDcjXKnP8hx31y1SxZs8dbTHifvF?= =?us-ascii?Q?RPKQjufbb/V0SW5t4a7dRcxqHbH7MtJ5pG2hXQkhl+5QAk5ldZN+J35QFlDj?= =?us-ascii?Q?UbcSD5dNRF5Ty1IhHkBDHnPcLMMz1KrWeTRLcfqTaxiXkUo8tSu8oba6S95b?= =?us-ascii?Q?UL581anc01fVFgnVptzZg622WjiIjZ34F4w/QUHEdbi/Q9DHRhCKWMKkqtWJ?= =?us-ascii?Q?NghxMJb6j1GcgM9WRB56zkubFbxZlGgr1IL5BGJzpdC+GH/Q/+pZHMvun9rU?= =?us-ascii?Q?MTYsgIgQADZIgC1l6IPNgSf0ELN4b+K3rH/Hgye/9IyncrQAKxj8XhiV1QzQ?= =?us-ascii?Q?HynqQ/kaCk7bkB4lJ08R24DN5aNDPrnqh/PPMiqtrSnlZi680PyuQyfONbUw?= =?us-ascii?Q?kefPrN0PVm3MUzDHZdYaRRittRSunIQMufTVmiR1z2BdKssFM1nS1LUr9VB3?= =?us-ascii?Q?l7NEiv2OP1fPvVwA7LHJRhQHaeK6EmoNIBG3ZbhT6K4S0RySjyxWTAhDWbUB?= =?us-ascii?Q?1aTb7RwH5oEnjGobusS77Mn9?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68c2f937-ed7a-4b78-5e0c-08d96dfa7f69 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 10:14:49.5085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VnxDgxsOsG5CRj8VYN3EJ7x7ulHN7Ncw9UK+iaYDH77vxmDgSfc9gB8oLw9aKFg0D/9vjhXRp+N84KaIZcKNlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4713 X-Proofpoint-GUID: J-ZFreAh8riB8z4ZD15AzENZcbr993e- X-Proofpoint-ORIG-GUID: J-ZFreAh8riB8z4ZD15AzENZcbr993e- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-02_03,2021-09-01_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The QP setup function allocates buffer for its opaque MR and register i= t > into > > MR structure. > > > > After buffer alloction and before MR registration, it tries allocate MR= Btree. > > When the MR Btree allocation fails, the buffer was not freed what cause= d a > > memory leak. > > > > Allocate the MR Btree before buffer alloction. > > > > Fixes: 0165bccdb45f ("compress/mlx5: add memory region management") > > Cc: stable@dpdk.org > > > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad Applied to dpdk-next-crypto Thanks,