From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B99ECA0C40; Fri, 30 Jul 2021 21:23:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76D2A40040; Fri, 30 Jul 2021 21:23:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E2A014003F; Fri, 30 Jul 2021 21:23:32 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16UJLVri002454; Fri, 30 Jul 2021 12:23:32 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0b-0016f401.pphosted.com with ESMTP id 3a456tuhdd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jul 2021 12:23:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Php88tObPpfvTWFn1WhGhHlfN8Ver77sGI+nd30oaZnyEcVKTO+cNcHbhVdPuPvPVnci0xx2xo/lc+IoLx5/Mu82O1sxgNmX0NvVqe+nOLs8hxV/D4zJ1EFdLj/3s024dGd4+yJ0tXP2RwnJXmRgtQdkw+G+EzFPEA8GQeshwfETkzCoBBhfSiH30doaNTSSuf9AcqdsSKup/EOvU51stDoyME2eP+RbMDW8qHgm9hKwWSTB3F/4T+TFSsg/tyyF3qOBhNzEGyO29IL5nfIBSqWjSMxp89UYS71tpN5HkmveIUbU5nP5dJo1V4Vv120TEy7JzckaPCWmSz6750+e/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Mk9XyrKVK+BkDEsAlHTr3QW9JqKUQ7/RTVKDn19xeY=; b=gYyZSzw4qe9Y0nPoZ2kM4OUlFutanUlToKoNUBhD9EEhhtM2Y82MtvEc5DymIILPglHKCCSoBR0GMiJyj6+3tf1i07yuxJfuTQT40xkSiJsw2F5lSQ9RsZe4sM++0GKucSuoOJao82LncI48UtNkPpWGXeQXVK1qiQK0fAfTtnBCNCCu0awezTzELppFDK50UmagqRjd63OMxSwk7ArizloPMI1FnV6jS4G81iDiGdwDcO3XaaL8LkO2jjLiTUN5Fp3SWNbakETbpG8sHJaQi1OD9tf12rhqUChL6FVB/sqs4z4gI/p0OalHO+DdM66HjNVdgDtF62zq17mKXnGF+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Mk9XyrKVK+BkDEsAlHTr3QW9JqKUQ7/RTVKDn19xeY=; b=E1ZGFliPQYj9DZK3nCQ7X34ZVhfQ02f92kBFi421dyx0BtoNIteWX8d9y/kkagueSwZpASlj4f8kNs/XNEF+7Cf107ek3vyEBW0HJ7MHkmujkiO8fYy2b3JURsPHDX1cApgeGhXwF8KaGtSSV2okrRMbEvAia8ETdDD8IxPjzR0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4570.namprd18.prod.outlook.com (2603:10b6:303:fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Fri, 30 Jul 2021 19:23:28 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%7]) with mapi id 15.20.4373.025; Fri, 30 Jul 2021 19:23:28 +0000 From: Akhil Goyal To: Michael Baum , "dev@dpdk.org" , Thomas Monjalon CC: Matan Azrad , "stable@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH] crypto/mlx5: fix driver probing error flow Thread-Index: AQHXhEYRhlbSaz30m0WkWCrh7XXbt6tb533g Date: Fri, 30 Jul 2021 19:23:28 +0000 Message-ID: References: <20210729065000.172793-1-michaelba@nvidia.com> In-Reply-To: <20210729065000.172793-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-Mentions: thomas@monjalon.net X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2c053a3-1c86-48c8-085a-08d9538f82cf x-ms-traffictypediagnostic: CO1PR18MB4570: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /UCxTsHNZkqDfTlC9Fo51jxfltVBy4oCw834SuxvK/l7KNzSDYK4TKJtftGELKouZY90nXyaHFwH43sYDTN3U75JgvOwbgVZWBZoX0tzMIz/VPSwMCiLtfp6cCYg7H0Ec6mxCQUDzNWURborRi42USrjLgftf8Ey69in4WOfWhT8qxKRa+moeNcDqS+hB8p5qioS72pa8EMVUTwugOycwIwPKscSPOLI5vWTCqXEDTWToXJeuDV9XZMx37ZnYa8Lj8hhTv2oJ6MBgxFPmuSacFWAlg9km71MYJ0jSaOGy8twx17PMwf+qikdZUAoZT8yX0RajxyQ3bO1nufiC5vE96PO+t+tXECqfi5EgnFeIJkvGI4Clqwq/7vLYotUU283hsl9hYrmIwxUxT03gJA/1kOM1Au4B8qzSAN0ceEpJ4XMVT/NRZWn3NEXO4yL79D/UIXgSd7Ce67pkspGnFSOVMo1Cx3h4sbVfFI7hxddeoc2/E4CUchVWubBZKpg24dRt87Us3MqMzB5DxVoDxKAGF/D9uNSrtHPioPREpoxcJkDo1Z0vd3R5SO4NQFlaq2DY+tqhW6wF/+crV4XlwZIsRtkRxV5vKm6qCLzpL9OFJ3Iir3I4FXzHmskvWE6K0qLEywL50uYNuIyFlIgbG1OYaqgNJvWVHw4Pukd2q2MnAB7F2cAbQVSOcngS3wwzLDFmRKQr1yFuweHt4kpkSpf5g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(86362001)(66476007)(76116006)(83380400001)(38100700002)(5660300002)(26005)(55016002)(66446008)(64756008)(66946007)(6506007)(186003)(122000001)(33656002)(66556008)(9686003)(52536014)(478600001)(55236004)(38070700005)(4744005)(71200400001)(4326008)(54906003)(7696005)(110136005)(8676002)(316002)(8936002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ncFhMS8YnP150a8lutbiU0HCYQQuT/biwPA+VEPLZTWvWAlkaoc/6UhPprIY?= =?us-ascii?Q?BZ6qQbCCe3BkpTAPZgVRAcLzO79mnWDQ6X2SQefhouiAHFqNepbB4Iw84C6F?= =?us-ascii?Q?7L95LekZhLKFiIn48oqprYJ9PGwmMWiD/+FH95QGmLvU2r+ttT1lIMUUk95B?= =?us-ascii?Q?f0Aj6kQI+1ul4b8dfAPM+fxFa3HVHjvaLXhV+nMMMVT6JShI90anAyxsv+dV?= =?us-ascii?Q?YFVjEc92cEbZYV4O4mbdmIij5GAXMpAhtJGs+b4NabVCiT9QyMTOpJCLhqrA?= =?us-ascii?Q?Zbc8Fc8hibxQjG+Kvd5WH2CEmoDfbAkE+rz5pdHxc7nAIWTOmFb8MdW4F8db?= =?us-ascii?Q?gut5U8wXUt1M4Vli2Y0tYIPidU+8mtG+n9Jkc7t6nmkl0+Sqmp14YeiM9tQr?= =?us-ascii?Q?SoPBiQwGOy9h/6lh0sK+AlGRgh0n6HRzadZEdNa5Vk630RLAZMLy2zXSNNzV?= =?us-ascii?Q?KO5cgIDIc9qQGs9cTIoER/ZyVL754n2T4/8DvOmn0ot4aqo09DmM0sZEkU9g?= =?us-ascii?Q?BzsUWSu1gb7c2g4aPU7+fJr6Hnvx7O+zLhIRqtDD6X0ZJNNwjE/vG5LU+awJ?= =?us-ascii?Q?k98AtEEGBmaqmqWOKd0rPzVg+n6yEM5iswmllwI+m5aiuRo2dajCE01xeY7v?= =?us-ascii?Q?r0ikgDmzTELWljjNSDQyw+GqjIKWgrFSaI+VPs0/SWcbtpDoVwAjnVnLifek?= =?us-ascii?Q?ndJxsCW4jdmAmlazJk7818Jv6G68+3+zRd+jggRk8WPgfgB+ZEzBqmh4CzT3?= =?us-ascii?Q?BMxrLTp/sYNVhCUydZZSgmfuk5rwEQUIBSKwXdxPbNkDJbm/vYJtTmYxvp3B?= =?us-ascii?Q?MltLs9e7vza6pdkkAzL0J+3V8Ul73668pmtflBcGwmBNwsKJrtltN1XCkVMW?= =?us-ascii?Q?CiJML7fN/or3R4ZYw/P0+28LZHvGKSwPd0ziGoYMC+b5dvEBZzZ9CN3LpMAc?= =?us-ascii?Q?RsOl+oplgU65Q4y0SikG79Pg/TCfk2z8SJYiRci/L80cQ7+KwdkMN41yVNyW?= =?us-ascii?Q?3z/mcds1/ICRVrHoN5HEl8MAWpszC0lEgLPH3frtR817Klhpa1f3X+Ywo5c0?= =?us-ascii?Q?w+Vs2wGqnA/iZuHe3Y3wtySdFJGaclmHwuzlSK4uK33SgoQZVvVDFbF+f5/9?= =?us-ascii?Q?YxephvwMC0dl06I4SXSR3kPqcKaXOWIB/2VZEWdwFRAwDA/VYojyB1E8GaGf?= =?us-ascii?Q?SWHvbsxLWutnMC+FLGIy0HLe1xmHLz3oT5OYzDVg3QApIUBLSOOnluM8d+gi?= =?us-ascii?Q?oGAPTx7fpRp62oEqGFMl843oADRvs+K+zN7b335LfP8oXr6JVXm3HggzI9HO?= =?us-ascii?Q?VOqnr5xmxARF2lx89Yn6ywjE?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2c053a3-1c86-48c8-085a-08d9538f82cf X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2021 19:23:28.8207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +8ZqfW/e2drZAIC5vlOc0k4P4el5DfaU5il1u1GXyV+68mmjL7pBTEyUN7990bgWbMyD/oYfATt2sdPlJ8k9SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4570 X-Proofpoint-GUID: 3lvLWGWXBpYwqGV2htbHdGcu-Xkf7xMv X-Proofpoint-ORIG-GUID: 3lvLWGWXBpYwqGV2htbHdGcu-Xkf7xMv X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-30_11:2021-07-30, 2021-07-30 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix driver probing error flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > In crypto driver probing, there are two validations after context > allocation. >=20 > When one of them fails, the context structure was not freed what caused > a memory leak. >=20 > Free it. >=20 > Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX") > Fixes: e8db4413cba5 ("crypto/mlx5: add keytag configuration") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- Applied to dpdk-next-crypto @Thomas Monjalon: I do not think title and patch description are inline. You may fix it while pulling on main branch.