From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F1BEA00BE; Mon, 16 May 2022 20:57:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC46240A7A; Mon, 16 May 2022 20:57:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 86E044068B for ; Mon, 16 May 2022 20:57:34 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GEsZlP004341; Mon, 16 May 2022 11:57:33 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g3rsqryn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 May 2022 11:57:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YjuQH9xu26mOsbLwWLIAXy3eyUnht78JvOpEyW2kAcZjwJn1NQ3RUjwDdLARdbFUpEThRJqIVcYs/sPwazsVMezeEJjvJIk/GDkZ9r1zJXCnssxFEUCl5EPTu0jncqK4zbwdA50SzaPOvs2TILmmjfixrvuO/D26GLrc3hPgLRw22lIR+q00cuTbvHQBR1W9/sBt/H5OmyRoHEG1Mo2ct2RCCiyqpj9IVS9OuuNLIIHXiA1AlHhPSugYazKoW4047l9dsagaWW7Syxh+/zRM6YteuV6aaWt2Y2BT1o9G4kvLjqwKJnBzp0u/pHtZjonQaU84LVu6JmlkQUSSOgAiHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRW2DYcnTgmf1LaP+3DE5RwR3g0FUC2azox7CyJmXms=; b=lCSWLxYDti4bPPEXds2KEi01+YRVaGPqrSOvdWWqSGqqH7B2eRWqt4LkMZOJUnDZKxo0/lM1CBNvCcGO1VJI1p99p392KnfY0xqxUOvAQqIB5xaKvSg/VLbkFZhKnz7mJAC/0fp9NY476tJ95AN4Qecg8WlwoLhgHbfj7aAajkGhr9/JPyUzELyMO8f6kk7xsZYkYb7Nfj+FxY9T7JqOs/eiXc8luPmIJHGD+wawlrQqi6IIhnNeVZYFi58cBrXZKHNUNxoBGX3UDJJgiTUlIRsToiBseec6fXmSGUJS6NxpRlU6D7dskZw+9VzxHTcxXL6fMMgeqfO24O9kCdwEWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vRW2DYcnTgmf1LaP+3DE5RwR3g0FUC2azox7CyJmXms=; b=L0k8TKS6LrfoclZ7W31Mft/HAc7Wv/xHkVQ7wcE+jTudHmg/zSRPBoZ3/q01i7pBHxbuxNbzmBrjeTHaXm1vpsw1EQaDSFlWmfIgjwfSXqWWHstl6BO2KAvl2Kh5CJrCzVZmW5bvux+muwRyshUkVRALb2mfyoPYYPC/wQegMVY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB2310.namprd18.prod.outlook.com (2603:10b6:4:b6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 18:57:32 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 18:57:32 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Topic: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Index: AQHYSoV+ZpOTq10DiUqrDGiFwFKjZK0iGBCQ Date: Mon, 16 May 2022 18:57:32 +0000 Message-ID: References: <20220407134334.20226-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220407134334.20226-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c08fc5e-9318-4e06-2b45-08da376deea0 x-ms-traffictypediagnostic: DM5PR18MB2310:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tpqnszKDqNf1b5lySUKXUZgRkd/To/n+21P9IZCbATl8GTb6cFoKT8WwVeVt95OWXqvXlKmb6LX/eyL7v7aMHU4UmPv9eJtVqH105/Wike5DIUCH9WunfOwwh/X7NmR1a13MVtER886slbLF8v6HFpSjJwlI3xL1jpCZhqTKVtOcbYPMl9SePMa4LN9r7/zXNfbXgbOS+rIbW+SWu5MDF2WzjhE4LnpBX/EjOHO/NxX3nt0Ytzsw4l0SilJ+WkTlE2BPRJx4w8T0Y2S2imgsHpptZCGVOknrEc8+RrKjQjphPp0rSB5h+3VAOu5uSgV2+P3D/fGKYbVYlaYjTUE/L5wbUqDTSKoIbZ8GpXNrfhJRqLJi4HGrRhI77JONVcQ50uJ0ryLwkyYF7+/gqbCr8WYDfeC8bA7WsGfBKyJ1aBJC8P2g+uwpzC9ex/TJkAB7E9GGaTCWxpV2+j1LRB98/2prm9kI3zhOwVR+PIwm+orzvuvDl8JHA1F5eIUAWfv+5udRTW6/KVqoXDWFoFnS63xiqbu05kNZ3df0fL4S4qiXSOnXm/WqjtrIPGi3eMTlxvy26ofw3uC/ENymu/0F0zWOR99B7crgrWqu12HKMedYrK/aB4cpWzuEBg6XNFi+lI06pIGNgQFJSE5QizHlzljyF/0ml99yTC7HcbMPjQYX4C90jV1VlobGVeALb+iuPTeqcFgQ3iAaqtxrtipegw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(55236004)(7696005)(186003)(110136005)(2906002)(316002)(4326008)(76116006)(8676002)(66556008)(66476007)(66446008)(64756008)(66946007)(38070700005)(38100700002)(83380400001)(71200400001)(33656002)(55016003)(508600001)(52536014)(8936002)(26005)(86362001)(9686003)(5660300002)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vYMg1n7zCUuGKt4UUslwJ/jlNrzsu6CTjyFzFtpgFZNa2B+XNblFxU6Xayju?= =?us-ascii?Q?NG7rL9XD17r625Rp2bdx3RRGJ5uEIzRWuet2Dm6509r7NWU6zL+Ym2IpGkQu?= =?us-ascii?Q?ebTBhPVqlQA3UR5mpZwFU3xmRlvgvkRm9tbQ46ZnwoW7qus0Ch0Wzob2LXLk?= =?us-ascii?Q?ZSdyQzarFYcHkNWDMZrtsoYP8HkcMI1Tr4EgUjOpbYFm7FQ7hpq3hkiU0EeS?= =?us-ascii?Q?ZsbexhPkREaVE5Jm1ke+WqxN2lr5CMgYceR2fQHPyTX7PkkL/zreRR9Vq2zJ?= =?us-ascii?Q?gWddc/84pxJm+0C7kY6WOhLQTgGsiFkOJphT37AuuK3O3fNh+IRUe2cbu+B/?= =?us-ascii?Q?gPougQfi6gUx2I1BYp8Kht5oXUzI7kYXdumyUk9+FrPM2RgPbCdP4TF1iMVD?= =?us-ascii?Q?u+1gS2D5vFVFQrw141Xvr7kK63ukRBL6WVJbq6/wKEYCApVGhz8M0x7yyPLR?= =?us-ascii?Q?mxh9m+PcQlxx7k8yxmppdu1B6ZTclyf0jtGT2ZBSNLmLIE+n09SB9ijoSIgh?= =?us-ascii?Q?/aMr/MTJyWYvWkJpi2hznut0ZF4oSe1ljNUEX4gCHoGpgqoJOJf6KbaBGumS?= =?us-ascii?Q?Ev7s2jDZbwHpLX5tqxPRJq4BwbWbC6WMHtaRSLLBbhCNFayKssjQPrCG9pzs?= =?us-ascii?Q?Zqke0yddltEolOgWLIDHLWdNvOtmLD2QetKxgZGARVxYbrbon5dArAHLjU3C?= =?us-ascii?Q?n5xUoFZ7qPY7aqHwz6CYsq17zndZ3RGoBRuoio+Zri1RmjoQvgPK5f08b4yV?= =?us-ascii?Q?H7oea8+ElsC/6502UaCaStuNTTkWFItnECHyTUydVVH9sQtJMrxiXTYB/Lq9?= =?us-ascii?Q?4aTiptqBi72YXLAI2Q+PXFZB3E7w5QPUMF9013L2BD9uKLSecxpBT7Dm67Bd?= =?us-ascii?Q?dlkpV1zNBhV6B88cjpXFbl1uGlktkn+YihdtfvEm/ZM+NVp6jV0b6vHZdvcL?= =?us-ascii?Q?KXqlztcP64SJdQfIOjbNwVVfQPa2UE1vSDLLMnxnlzPTpkDyJnCJRxCvomws?= =?us-ascii?Q?Qf2kvtaN+rpIXKG+3FEljwD0YzHIRlTQq+OA8UyO3nA+vsy9pdoTHDh6v8bg?= =?us-ascii?Q?smCEl2oOnP9l8eqq09PWxrt/yKmw1H6/nbbL0l8kwnIVZm9WU6KJwvTycJcO?= =?us-ascii?Q?xAC2quO3qBpcYTW/RlIqI7+3QsfYS1PGQVbKB0Y7uQ5dI6PXKbkZjWA3GKIR?= =?us-ascii?Q?WoPPxt1ZzrDZnTb2hdP5Vt4Isl627tYAkSTEH6p/qZZV42N2G7vnEDd4hlma?= =?us-ascii?Q?oCzvrd/CcJKJlssvE2Xbs+stP/2zbWPAJcHkFZKOVMZd5Q/dODhQFjk6bsIQ?= =?us-ascii?Q?Hk3+zRd2xyoGph7Ump+qn1t5Vh3Obhk/YPU9ZVPh5AkGoAD+QW3dQkWKq29i?= =?us-ascii?Q?oZPwJTmdnRhoz9BOCTVzhKKJkpVoZLUAQHvsd6lt1beWPrL7+tV/+bT2EB+Z?= =?us-ascii?Q?Hl1OhTc0UJZeS5LyklFnpdIvDZ7sNkpEvwCwR0LtM2RsUAo+YNwinCWJ1b0t?= =?us-ascii?Q?lyEVFKXuI48No6phxr6zP7RN3xOfefRp/0KsBZN5fQlBNjtLN4zgPlrSBNrG?= =?us-ascii?Q?orP1WGn9tFnWTcV4v3QIUzLf9ACmRSkaczb05msEuVXHXZMEz9AxjfIgav+1?= =?us-ascii?Q?GtoHSJbZWHl93tLwWqa/waS0IRmAXK0hA4bjWXGhPWQ7q/Pv8xoKd+wsSG8N?= =?us-ascii?Q?DCBGdvtzYJG0jNTPs6Y0OVSXkF9eiWW+k6yCUI+8Da39Z0JzP5aI5xYkn548?= =?us-ascii?Q?dB7rtJC9Iw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c08fc5e-9318-4e06-2b45-08da376deea0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 18:57:32.0315 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lzp/nF1RrmzwImv6iPporNxS85Cb7CzqegXoMn7B6vHBv8bF9m4pUOGJCiHCIf8/ibsplDr83jAg+oHx/wogig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB2310 X-Proofpoint-ORIG-GUID: XwnNMiXlw2m0bl8CgkjqBDwlHkXbBSRe X-Proofpoint-GUID: XwnNMiXlw2m0bl8CgkjqBDwlHkXbBSRe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-16_15,2022-05-16_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This commit adds support for following elliptic curves: > 1) Curve25519 > 2) Curve448 >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index cd24d4b07b..775b2f6277 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -48,6 +48,8 @@ enum rte_crypto_ec_group { > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > + RTE_CRYPTO_EC_GROUP_CURVE25519 =3D 29, > + RTE_CRYPTO_EC_GROUP_CURVE448 =3D 30, > }; >=20 > /** > @@ -180,9 +182,17 @@ typedef rte_crypto_param rte_crypto_uint; > */ > struct rte_crypto_ec_point { > rte_crypto_param x; > - /**< X coordinate */ > + /**< > + * X coordinate > + * For curve25519 and curve448 - little-endian integer > + * otherwise, big-endian integer > + */ > rte_crypto_param y; > - /**< Y coordinate */ > + /**< > + * Y coordinate > + * For curve25519 and curve448 - little-endian integer > + * otherwise, big-endian integer > + */ Can you give reference of the document which specify this endianness? And if it is implicit as per the protocol, do we need to add explicit comme= nts here?