RE: [EXTERNAL] [PATCH v2 1/3] compressdev: support for dictionaries and PDCP checksum

[Akhil Goyal <gakhil@marvell.com>]

> Adds definitions for PDCP checksums and apis to pass in
> dictionaries
> 
> Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
> ---
> v2:
> * Moved dictionary params to deflate params
> * Added infalte params to union
> 
>  lib/compressdev/rte_comp.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
> index 96d9b276dd..25835d589d 100644
> --- a/lib/compressdev/rte_comp.h
> +++ b/lib/compressdev/rte_comp.h
> @@ -101,6 +101,10 @@ enum rte_comp_op_status {
>  	 * is not an error case. Output data up to op.produced can be used and
>  	 * next op in the stream should continue on from op.consumed+1.
>  	 */
> +	RTE_COMP_OP_STATUS_CHECK_SUM_VALIDATION_FAILED,

Please make this as RTE_COMP_OP_STATUS_CHECKSUM_VALIDATION_FAILED,

> +	/**< Checksum validation failed. Either calculated does checksum not
> match
> +	 * the one provided or there was an error calculating the checksum
> +	 */
>  };
> 
>  /** Compression Algorithms */
> @@ -166,6 +170,10 @@ enum rte_comp_checksum_type {
>  	/**< Generates a xxHash-32 checksum, as used by LZ4.
>  	 * https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Cyan4973_xxHash_blob_dev_doc_xxhash-
> 5Fspec.md&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TW
> ey3eu68gBzn7DkPwuqhd6WNyo&m=ZqKTNhO2Un7IWZUom86z94D9In-
> NAGK6Ebs6rkJwgqJHD_iXsdHhI7ZJOP_mpcDM&s=L3Y03TXGjmKXToUXMM9ZY4Jt
> uNqASR9hmi6fGtOip_c&e=
>  	 */
> +	RTE_COMP_CHECKSUM_3GPP_PDCP_UDC,
> +	/**< Generates checksum as defined under Uplink Data Compression
> +	 * checksum as defined in the 3GPP PDCP specification
> +	 */
>  };
> 
>  /** Compression Huffman Type - used by DEFLATE algorithm */
> @@ -201,6 +209,10 @@ enum rte_comp_flush_flag {
>  	 */
>  };
> 
> +#define	DEFLATE_MAX_WINDOW_SIZE	(1ULL << 15)
> +
> +#define	DEFLATE_MIN_WINDOW_SIZE		(1ULL << 8)

I think you missed to address this comment.
These macros are defined in external header files without comments and explanation
About where and how these will be used.

> +
>  /** Compression transform types */
>  enum rte_comp_xform_type {
>  	RTE_COMP_COMPRESS,
> @@ -228,6 +240,18 @@ enum rte_comp_op_type {
>  struct rte_comp_deflate_params {
>  	enum rte_comp_huffman huffman;
>  	/**< Compression huffman encoding type */
> +	uint8_t *dictionary;
> +	/**< Pointer to memory containing dictionary to be used for deflate
> operations */
> +	uint16_t dictionary_len;
> +	/**< Length of dictionary to be used */
> +};
> +
> +/** Parameters specific to the inflate algorithm */
> +struct rte_comp_inflate_params {
> +	uint8_t *dictionary;
> +	/**< Pointer to memory containing dictionary to be used for inflate
> operations */
> +	uint16_t dictionary_len;
> +	/**< Length of dictionary to be used */
>  };
> 
>  /**
> @@ -321,6 +345,8 @@ struct rte_comp_decompress_xform {
>  	 * setup of stream or private_xform should fail.
>  	 */
>  	union {
> +		struct rte_comp_inflate_params inflate;
> +		/**< Parameters specific to the deflate algorithm */
>  		struct rte_comp_lz4_params lz4;
>  		/**< Parameters specific to the LZ4 algorithm */
>  	}; /**< Algorithm specific parameters */
> --
> 2.31.1