From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B0CA42B39; Thu, 18 May 2023 10:46:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCF442D16; Thu, 18 May 2023 10:46:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A189A42D16 for ; Thu, 18 May 2023 10:46:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34HMFcXF013246; Thu, 18 May 2023 01:46:26 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qn7jb9w9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 01:46:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZcwtL+6WPLvsj2hi8I6JuDGNZc5BKv0sOtuQmnBXCYaUZbgKBn71fm7qsXNcDsbSe2T/ejPDo5BxKa/AEunObP0DSDtgq/25mixZm3/t/CQ7qaSAXJhsIlFZZUxamxCowL7zU/EmrZV9vcD+RvNthTU84KTdxTM0LThkxfI/wEoTrUB5P2P/iqCmrx1KkmTdlKMgpK+L0V0ceVegH6lirUhY/RsxSmRrC76YdhT4qoZ6FaLpABrHGuBs4xAgnutkCkvvEr1yQDesjMrkFl12TnEXJrLtQ/2NrcAfeMBQyhrO8LcCnMqF98uvJK3T1bRdcUG2weRInDh+XTUNtLwtBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0TlUtScY3i0uDdYKX8w1/dGZ02KuWXCOGgVhKl4ayTM=; b=bxVl2YeeMUpV6KtcUJn8G46qSAUGaSXA9nANqKtSiTX5JGoGbIosEA+1P/G5UbS/yc+W4H/xLfxX12qgC2FuwUgI78FcFq7OfZO52QkhlfMycoJEjGWdyIOMpfpld97mcI8nlnpypgB6rYdIzvEoK4GpMV+88sCHmyl2GQIaOrfBJ01UxXQzE5WmllWPKMNRB5ii+hlDjU1HkWnXah+i/WuqTFUiIAiVoA9mf/PVp734FIPy+1ong36Wq+PFv8A0UmPiaurzPEVBlxmAezrlLa80conAc1qOu9J3MaRqREEwCXm7LVHrXGXK78s/agI9rOOxRI+Xh+p83owQHMeJmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0TlUtScY3i0uDdYKX8w1/dGZ02KuWXCOGgVhKl4ayTM=; b=KqPTpVnsU2aNtdXrqpVSibGW0wxaQQm6cyNERzTdsnlgtbkOWBoZUuRLoGGSW2RlidTOubCmHVDRl07aFEU7AJ8Diwe1LsUmkCNPIKDtWxd+PEUu2bS0ABZoIWjxA5Hc15Ts9nvvg5t5k/ae2SCjmhyaR34ZgwnrsvkfALBUiHQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1642.namprd18.prod.outlook.com (2603:10b6:3:14c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 08:46:22 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489%6]) with mapi id 15.20.6411.019; Thu, 18 May 2023 08:46:22 +0000 From: Akhil Goyal To: Anoob Joseph , Thomas Monjalon , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Bernard Iremonger CC: Hemant Agrawal , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Kiran Kumar Kokkilagadda , Volodymyr Fialko , "dev@dpdk.org" , Olivier Matz Subject: RE: [PATCH v2 02/22] lib: add pdcp protocol Thread-Topic: [PATCH v2 02/22] lib: add pdcp protocol Thread-Index: AQHZbvjvvmj4ZOLr0kOu2Nfgh9ofla9dI8uQgAKpFgCAAAHboIAAGeEAgAACunA= Date: Thu, 18 May 2023 08:46:22 +0000 Message-ID: References: <20221222092522.1628-1-anoobj@marvell.com> <20230414174512.642-1-anoobj@marvell.com> <20230414174512.642-3-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ2FraGlsXG?= =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?= =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctNzM2MGM1MmUtZjU1OC0xMWVkLWEwOTMtOT?= =?iso-8859-1?Q?RlNmY3NjYxOTA3XGFtZS10ZXN0XDczNjBjNTJmLWY1NTgtMTFlZC1hMDkz?= =?iso-8859-1?Q?LTk0ZTZmNzY2MTkwN2JvZHkudHh0IiBzej0iMjkyNCIgdD0iMTMzMjg4Nz?= =?iso-8859-1?Q?MxNzk0Nzg1MzY4IiBoPSJZR0w0bGsvZXdnaCtBb2puSGJjSEZ5d3NtWWs9?= =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?= =?iso-8859-1?Q?dVQUFNZ01BQUJZeERBM1pZblpBV3RDVnVBU2tOTk9hMEpXNEJLUTAwNFVB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCWURBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUVCQUFBQTQrVXREQUNBQVFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?= =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?= =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?= =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?= =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?= =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?= =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?= =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZk?= =?iso-8859-1?Q?FIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lB?= =?iso-8859-1?Q?YVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFH?= =?iso-8859-1?Q?RUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFB?= =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISU?= =?iso-8859-1?Q?Fid0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFC?= =?iso-8859-1?Q?eUFHa0FZd0IwQUdVQVpBQmZBR0VBYkFCdkFHNEFaUUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQU?= =?iso-8859-1?Q?FJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0Fa?= =?iso-8859-1?Q?UUJqQUhRQVh3QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCak?= =?iso-8859-1?Q?FIUUFaUUJrQUY4QWFBQmxBSGdBWXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?= =?iso-8859-1?Q?QW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QmhBSElBYlFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQW?= =?iso-8859-1?Q?JRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0Jq?= =?iso-8859-1?Q?QUc4QVpBQmxBSE1BQUFBQUFBQUFB?= x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQU?= =?iso-8859-1?Q?FBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFjQUJ5QUc4?= =?iso-8859-1?Q?QWFnQmxBR01BZEFCZkFHTUFid0JrQUdVQWN3QmZBR1FBYVFCakFIUUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFB?= =?iso-8859-1?Q?QUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQV?= =?iso-8859-1?Q?l3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFHa0FZd0Iw?= =?iso-8859-1?Q?QUdVQVpBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQU?= =?iso-8859-1?Q?FBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3?= =?iso-8859-1?Q?QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQU?= =?iso-8859-1?Q?Y4QWJRQmhBSElBZGdCbEFHd0FiQUJmQUc4QWNnQmZBR0VBY2dCdEFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VB?= =?iso-8859-1?Q?Y2dCMkFHVUFiQUJzQUY4QWRBQmxBSElBYlFCcEFHNEFkUUJ6QUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWl?= =?iso-8859-1?Q?FCc0FHd0FYd0IzQUc4QWNnQmtBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: QUFBQUFBQUFRQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFBPSIvPjwvbWV0YT4= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DM5PR18MB1642:EE_ x-ms-office365-filtering-correlation-id: 7b596f0d-0be2-49de-9ede-08db577c5b42 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: koBkrTa7smrHCp1qjaIpwb8bwj4WFa4JmEutedOmgd68RdaOH+DR9dDrhtTmV8AbB9bjKWnQWf/W+D5bxWEeqGwayOyeS2SeiIAKp3B+p+RUceLKnFYdbQJ3Dr36e2qmUFQV5zPwR6KorknSj8RVBYlGjirJrr1FewWoFH2HxQ1GHmJwCQRIhjvD3GS/E7emWCKfbQnIkDohjPRj1kLTBQ4G8fZm+TXKGukqRsdNp21CKmOZ1MyIIxwYWYe1z4TJ4U5jIdnzhIcJTCaVwV+iUfQbsEpkLptXQ/KN/908Oyia3jpBAzuPc5piw9rcuBE4R7J7Ch/HQi9kSU4a3XdLDqD7T+LiC5gXUbUBjCz6yD/NDs5hToLWVDM3RJbV3YzxShHYo5fTzmJcQcTLaUzjxpb7qkPYxxGxocS48jpyPJkPWQAUgOrqnWbaGHqI0uj6fNRFocQCLILD1r7bOizu7KyTFL3vWd1C3/XY1hg4kEbWxDPKYOTNRcivgdtS9Zaxb3Ra4clC+qoyvlE2dpdITt9wZWfXQaBmZWTL3mMXJQFGip150PEG2sXFW0PDMK341kGEN6mWsH2CKhx72X1YEHkKwQtAlKWt1vjB3Z6T4TvM7Q8aKPe0uV0XaJ34lr+d x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(451199021)(83380400001)(186003)(478600001)(7696005)(26005)(71200400001)(54906003)(110136005)(55236004)(6506007)(9686003)(2906002)(52536014)(8936002)(5660300002)(4326008)(8676002)(38100700002)(122000001)(41300700001)(33656002)(66476007)(76116006)(64756008)(66556008)(66946007)(66446008)(316002)(86362001)(38070700005)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kIWQgO148XKTtciFSjzZfvkNohNu8oEF/4r1vfmZWFZ301Ln4om9yHJxT9?= =?iso-8859-1?Q?6Cs+Q/+Qwxvpn0rZqZ29+9K23p62bUBAFW6Dy5o7FR07XhhbEXy/q7Gtua?= =?iso-8859-1?Q?UrPwM+pId+Ph326kgUphzWQSvMpbAcplrKVDNepoYI1hb00cIXP3nIl3d2?= =?iso-8859-1?Q?5n3kN+rR6usamf6O6w5ddgRvQQ03W/N6Z56Q9xQ18sK4cSM19mgbGwZ+jA?= =?iso-8859-1?Q?pCilcDSBGHPivlBIt5VbjnStXfogxHt2uHW1IgmacBoBIkRiZ0ByQKs71Q?= =?iso-8859-1?Q?iuRNtUhKkxzeM98eML/I2h7/S0jM5Rab8maWG5mx5nn6bTi1/Wfwy0Tnhc?= =?iso-8859-1?Q?8T/5xnaTjBGKjBV7HdQBb2gQeYzVVvSNgxZ7Jr3SS3+yxpW54AKy69p8M0?= =?iso-8859-1?Q?ZOuW8c1iybv0m2V29a80G9mQbkdB5hgYGrzEnAjBjhKl+vZlOOR1hjIByw?= =?iso-8859-1?Q?GNQf19P0y8LToiCZKl/T+/ofJaLlxSXhYkH3TbPRGQD+fSJerkWwSaZNQO?= =?iso-8859-1?Q?6nj40vMq3dzW6WhcfZM0XoiUjAMMhOAZH/rSaQru+g4qm3My//XY7/tAm5?= =?iso-8859-1?Q?4RLcL7bWA2dP6jMFCBerjDMPwee5aC+55jDtlLqzD3XEDS/XLyk2yhMgt9?= =?iso-8859-1?Q?3UGJkgyvJ03RQ1YW1V+x8ZqDS0hMN1UxYPmLKG04l4eAuZX/4cZ7eHbPWO?= =?iso-8859-1?Q?hfxfx8LKAAYFIEra0YPEZhn6Hng2Xbl4qAzH5JNqKrleoZ0KXJbKKtWgLp?= =?iso-8859-1?Q?P+/WwEKlj8FlZSe9RgNTUAy14TnrorO+gfTQ9VhpDA8ScEA72blZixk6gx?= =?iso-8859-1?Q?ZdUzBlZDoHeraEQoyEFDjkzEy1cfQZ8va8DOAX/+wuYMxEzG458IFRP78+?= =?iso-8859-1?Q?dZdBifk8NtOHopdaYn3YPicKinR/kMogW8zw/vLBVkUvLVRQN9E2oPesEY?= =?iso-8859-1?Q?aJVxhkwSDikeyHFiuCS2W5BjDp8OJkaJxaHf9UjcbRU4ZHi5tWq/OEUKPK?= =?iso-8859-1?Q?u/Sf8XOjh419B9GfcuKG6A8aOfnVkj4RcwPoKe9573b9LiYvLsG85Tbfas?= =?iso-8859-1?Q?0+Ku+aR7ii0rEXchav25aNsm4jLkDlB+4EyUPd9qu92K4S0oNRwjKd95WQ?= =?iso-8859-1?Q?ciIOxXXJh94qU4UXMxqu5b0enSxJ/tsmMXN/C2jXd5Mub0+t7v+g9k7koH?= =?iso-8859-1?Q?hc/oV/3ao1sQRW81F1bN775JSXQIH6+rNxmHhGNDTK1+9BboQYJb38Dlay?= =?iso-8859-1?Q?VP7+WetVpwIcP2/V5HJnXuKNLQF7zpjjk/DBZY5fPbElL8NGUhNDsSmO5U?= =?iso-8859-1?Q?uqETc1X+bj2z8cZptZVMMgsvhzBB8G9wV7hkrfoD0jbRVpzayxvVC6mrPA?= =?iso-8859-1?Q?zi77La6XXVyf9xCsCldOSeXH9CLj49185oBNUDnD+92pUzxjpVDjfm5DZJ?= =?iso-8859-1?Q?6LDzMxPoN4xiUZCFX5exiI9scZxFxpRtQqhHOXSz471jfwNJ/a6v0cve3x?= =?iso-8859-1?Q?eYyZSLhjCb/ZGNvm8v2FBS8+37CC8Y+oas15gGuxAvJgI+y2hsQjGEbNaK?= =?iso-8859-1?Q?7DAtrjG9WNGmklZF4O83EHbAvR0IATtM5sPJa5ZYpbQ3MCgaYoAEA8It7E?= =?iso-8859-1?Q?PpSSgh5TSAu2QVXvRUuRJes9fd9LtlCdbz?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b596f0d-0be2-49de-9ede-08db577c5b42 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 08:46:22.1180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: otSYREqiSDPuD7RNVV4yWO3GX1PdwZZYwGpBCQlorto7crEDa7BP0xsbK83qwj2y6pPdP91PwUvhAhTYMzgghg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1642 X-Proofpoint-GUID: hYZnFJevvJkXheHXMdQ5vY01LhKHBAGe X-Proofpoint-ORIG-GUID: hYZnFJevvJkXheHXMdQ5vY01LhKHBAGe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_06,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > diff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c new file > > > > > mode > > > > > 100644 index 0000000000..8914548dbd > > > > > --- /dev/null > > > > > +++ b/lib/pdcp/rte_pdcp.c > > > > > @@ -0,0 +1,138 @@ > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > + * Copyright(C) 2023 Marvell. > > > > > + */ > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#include "pdcp_crypto.h" > > > > > +#include "pdcp_entity.h" > > > > > +#include "pdcp_process.h" > > > > > + > > > > > +static int > > > > > +pdcp_entity_size_get(const struct rte_pdcp_entity_conf *conf) { > > > > > + int size; > > > > > + > > > > > + size =3D sizeof(struct rte_pdcp_entity) + sizeof(struct > > > > > +entity_priv); > > > > > + > > > > > + if (conf->pdcp_xfrm.pkt_dir =3D=3D > RTE_SECURITY_PDCP_DOWNLINK) > > > > > + size +=3D sizeof(struct entity_priv_dl_part); > > > > > + else if (conf->pdcp_xfrm.pkt_dir =3D=3D > RTE_SECURITY_PDCP_UPLINK) > > > > > + size +=3D sizeof(struct entity_priv_ul_part); > > > > > + else > > > > > + return -EINVAL; > > > > > + > > > > > + return RTE_ALIGN_CEIL(size, RTE_CACHE_LINE_SIZE); } > > > > > + > > > > > +struct rte_pdcp_entity * > > > > > +rte_pdcp_entity_establish(const struct rte_pdcp_entity_conf *con= f) { > > > > > + struct rte_pdcp_entity *entity =3D NULL; > > > > > + struct entity_priv *en_priv; > > > > > + int ret, entity_size; > > > > > + > > > > > + if (conf =3D=3D NULL || conf->cop_pool =3D=3D NULL) { > > > > > + rte_errno =3D -EINVAL; > > > > > + return NULL; > > > > > + } > > > > > > > > errnos are normally set as positive values. > > > > > > [Anoob] I do not think so. I checked rte_ethdev.h, rte_flow.h etc and > > > all APIs are returning negative values in case of errors. > > > > Check again lib/ethdev/rte_ethdev.c > > rte_errno are set as positive values only and APIs return error numbers= as > > negative values. >=20 > [Anoob] Okay. There are many APIs were this is not done correctly (check > rte_flow.h) . For lib PDCP additions, I'll have this handled. Some of the= se > conventions should be documented to avoid confusion. I am not sure what you are referring to.=20 I cannot find any discrepancy in rte_flow.c as well. Can you give an example where it is wrong. We can ask specific people to fi= x that. Regarding documentation. It is mentioned in rte_errno.h /** * Error number value, stored per-thread, which can be queried after * calls to certain functions to determine why those functions failed. * * Uses standard values from errno.h wherever possible, with a small number * of additional possible values for RTE-specific conditions. */ #define rte_errno RTE_PER_LCORE(_rte_errno) And errno.h has all positive values defined.