RE: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver

[Akhil Goyal <gakhil@marvell.com>]

> 
> Hi, Akhil
> 
> Thanks for your guidance.
> 
> On Tue, 25 Oct 2022 at 23:02, Akhil Goyal <gakhil@marvell.com> wrote:
> >
> >
> > > Introduce a new crypto PMD for hardware accelerators based on UADK [1].
> > >
> > > UADK is a framework for user applications to access hardware accelerators.
> > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
> > > the same page table between IOMMU and MMU.
> > > Thereby user application can directly use virtual address for device dma,
> > > which enhances the performance as well as easy usability.
> > >
> > > [1]  https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=Dn
> L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=tyhRlU0KYYHgoC9wyL
> _TYFJMfkt98378qTt70kHNizUdEEmLt_dSBdzMJS4IOREt&s=ZdQO3qCVbcJePPFh
> OGL2IsFh0AoEdndgscdqMT_QzhY&e=
> > >
> > > Test:
> > > sudo dpdk-test --vdev=crypto_uadk (--log-level=6)
> > > RTE>>cryptodev_uadk_autotest
> > > RTE>>quit
> > >
> > > resend:
> > > fix uadk lib, still use <uadk/wd_cipher.h>
> >
> > There is nothing called as resend in DPDK ML.
> > Please simply increment version number each time you send the set.
> >
> >
> > Also add release notes update in the patch
> > where the driver implementation is complete.
> >
> > Compilation issues are all done now.
> > Have sent some other comments on the patches. Please send the v6 ASAP.
> > We need to close RC2 in a couple of days.
> >
> 
> Got it, have addressed the comments and updated to v6
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_dpdk_commits_next-2D9.11-
> 2Dv6&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3e
> u68gBzn7DkPwuqhd6WNyo&m=tyhRlU0KYYHgoC9wyL_TYFJMfkt98378qTt70kH
> NizUdEEmLt_dSBdzMJS4IOREt&s=8D-
> LSc3u5Dbhbp5kiEynMpS46QYwVLM0AuwAMY5HdYU&e=
> Will send tonight.
> 
> Some uncertainty
> 1. The updated uadk.rst
>  https://github.com/Linaro/dpdk/blob/next-9.11-v6/doc/guides/cryptodevs/uadk.rst 
This seems fine.

> 
> 2. About the release notes change,
> Do I add a new patch in the last: 07
>  https://github.com/Linaro/dpdk/commit/f2294300662def012e00d5a3c5466bbf8436904b#diff-b994e803545bf8101a466b464d2171d96f01226aee3401862f0c0a3c1897ffb5R199 

No need for a separate release notes patch
You can squash it in your last patch.

> 
> Or merge it to the first patch 01.
> 
> 3. I update uadk.rst and test in the same patch, is that OK.

Yes

> 
> Thanks