From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61232A0352; Mon, 7 Feb 2022 18:29:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C78441101; Mon, 7 Feb 2022 18:29:23 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 3F0AC410F6 for ; Mon, 7 Feb 2022 18:29:21 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EQPQo006292; Mon, 7 Feb 2022 09:29:16 -0800 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2173.outbound.protection.outlook.com [104.47.73.173]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e30b0a4mv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 09:29:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OMhakHMPg/t7jtHOObA7qTr5rK4F0lZPYAuMT3cCScRH1Spl6m5FVPsOzBI4iytczwoTEpinY9Z2QUGovANcbTPCLcSOUQXvnKhn3mq1klbhN+NVK15FHra9H0o0dUxc3tr9CifvVkmHYUGe2u9lDcbO70Jfl1C/UY7a5yUGrUF+F4ZjbyuRTAMWzc/7zfkAVouMWoXWPwYDmQt/h7GR+0BYfoM9ZzW8C9B2VZbcf14JMYpTda5WHpulaYb6WVxSp/5kfKrOdVvYW9XQGsvMElLwXRvlCwuSIjBe+HE6ilso4Ey+2DZAZWDhtmZaWBwBWB0VVFyTzGkD22STXNy39w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JXLhj2kR+2gDAP0vpLq0OLEUrStcagGGjf6VKP7tOhI=; b=KmKOuRARKjIj9HQ27WmuVuXogHg14a60Im0I0ZI43oKIpnBNGbL4rOLAQQIxA5zHwZ8RfAGIVkOes6uDp6HNkXcOcQxUC36Qf4aXl5xA0ISaSNTgVGDvO8Fpzn7quibnvGmMsCpy9gCoovUleLsc+Wtr/AKS2Vm48Ai9bx7vCbb+mI5cfmNTka4ZfQwcrZqqN33jUWlqXYcSvR5Jgq5gqWisEMgwtMSQUvUo3hsMs2oWIngSmFRQv0+oVjjQl/tsZmb7ocOWkcppB6i/lax9KUKD8OQSRqVoVP+fitCXqnMiSbnD8yL63OEAu8YZCGtsD9w/IvqFJwAGS/SNvZoSiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXLhj2kR+2gDAP0vpLq0OLEUrStcagGGjf6VKP7tOhI=; b=m4sO1UJHfKqmj//GXtKi02R+wEBGIfuqNUoBLGJfCXWF/4WZu8JMjn3jdUGYKGEMOW+A98cRwGPFvqkfVluXFBCFAkVnDpUQ3Wx3VaPwkvi860HnZEntPpu1MRasyS66WOnKAElm8xd7eVlFnV/vXQq1CJlIakHPml6IKDiPKYg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MWHPR18MB1136.namprd18.prod.outlook.com (2603:10b6:300:9d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Mon, 7 Feb 2022 17:29:14 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc%5]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 17:29:14 +0000 From: Akhil Goyal To: Stephen Hemminger CC: "dev@dpdk.org" , Anoob Joseph , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "rosen.xu@intel.com" , "olivier.matz@6wind.com" , "david.marchand@redhat.com" , "radu.nicolau@intel.com" , Jerin Jacob Kollanukkaran , "mdr@ashroe.eu" Subject: RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Topic: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Index: AQHYGhSD5snN0ffJdEyr+e/sHU+c5KyIWrAAgAAAibA= Date: Mon, 7 Feb 2022 17:29:14 +0000 Message-ID: References: <20220130175935.1947730-1-gakhil@marvell.com> <20220204221334.3551574-1-gakhil@marvell.com> <20220204221334.3551574-3-gakhil@marvell.com> <20220207092330.49a0ba8a@hermes.local> In-Reply-To: <20220207092330.49a0ba8a@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f2533b2-9a1c-49e5-1fdf-08d9ea5f5c68 x-ms-traffictypediagnostic: MWHPR18MB1136:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rYiFsAiS+LVSv+0Ob1VSq5vAkMvHg8BrYcD619ur/+ZG8pT665wpD/r/Zal1UnifLeO1ySYNP6gbi7RjwiusT66Y7blPXos4zO8yapMReah4JvOwXSaEuBDDbEk42M30trlNcB4dMhXruVqdSEkYI3DFxwtCuJSJKnwVPKwgZo6CYxh4+9e131JY+ODfx3FoK8NKMIZrXk23YRVUl4JUzaxnffJgxTGoyPDr6wquUF01mxoXHO396XSViV1kpxEbv8/3Mhhp6WlxOJdTQfiqTYlGsd+tqSHX4pMCxMEibtH+eJF9bXMVkj851UD2YtQcZ9DQ4rCaX2k6xo/87hcBKRJDglJYyG4FsfcCJ0WG8ntHNLycJXQXXNIweRb4MXCHe2hI8fW+ha3ERucd5c95+0TOZq/OP6gcT8vusfySdlCSNGxb1mgUvP+Xomwx3cO5R+klMx8Vdp3+zedxLm+M0jo/mjBV9CXuYEifDA9cho36uiR1pAAEf2sRDe/l+zri52Xtwcnh0+pGQW+hPp7BSGjvleWHowR8ejxioYKh3fWtSILcX0ak5a6KYObda3nJlYmk04aMGWVFpYHz7rJP+9g6YqzfTIwn+EAyq1mTNA/gFNdMId5fziPwTaIsOUXmel+j4g2R7HEbnY7iISmH0XVhxxV06qgbr32qiYVxciqtUp0CXZ8GH8z2TclPvWiVsmXybSPcjmwYBjd2Wj+aWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(6506007)(9686003)(7696005)(33656002)(316002)(2906002)(55236004)(4744005)(6916009)(8676002)(7416002)(66446008)(52536014)(4326008)(8936002)(66556008)(66476007)(64756008)(38070700005)(76116006)(66946007)(5660300002)(54906003)(38100700002)(86362001)(122000001)(55016003)(26005)(186003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9/kd9liPxunsGdImAzTqQYM++3Ivmgab2/26HcLQq6oociFIlYJz2bPA990p?= =?us-ascii?Q?WX8fF4qISmD2RbcckuZIMJaKPeOzhjNy7aBBLTxZu0Hq1yhYPgMMWoTPL4yG?= =?us-ascii?Q?zel44HO70Z5tNwZ13r+aYYvexQH+Dw2rwWnSetkBwMawPgmR/jSK+YqdWXN8?= =?us-ascii?Q?rGB6LZrWXpf05TTIs/YMtNpdFhkGeDA9u2ir9nrMso0tI3mGkQJr+UBxWjIz?= =?us-ascii?Q?6OEkNZTarlH1F9PbF29SoY8b+O/S7sjK0se28puTveSMO4I+5eFPy+54/S+r?= =?us-ascii?Q?g1EpIlbBPcqY49HgVxNyBOkfuW9KIFuGQksLeMq8n16LcbLFcBlJhSinlZpO?= =?us-ascii?Q?Lhb0qd+o9dRRw5jeHLnT8tmAiuAVlSkOntJZ33HYWrvy87xmdpgj8yySLflg?= =?us-ascii?Q?RbfNEG4zN6cHM8DOApe2B122IxvU7KFkm54/0TsfyU8yuxfqEWUMDp1j2C7V?= =?us-ascii?Q?yyqfMEcDOk1PD0F9xjQvEqwG4TdyzBaFZYZ78qsrwYavqdHm1R+WtxKDKnJV?= =?us-ascii?Q?D2lhVsISNvdQbflH2d3zIRVQ4KWtH8jSCAEoZnI6FCD5P7bc53NvA1pD82wG?= =?us-ascii?Q?WnI8ukLgllk1M2x2PtfxVPFAyC0bu1mbHhtL2TYPO+ltmmXJW9+Dy5xsu5w7?= =?us-ascii?Q?ZH/2vxibrZEwM/pTuZYkXWF+PutZ96EwFArXkYfVF47Gp61ULQryPa0kBst5?= =?us-ascii?Q?Wv/OXwmZOaYm9jVMt4ZUjBaooO+0gl6uGwRvHBV67CngKNmGQ3WXa+Pm7p9g?= =?us-ascii?Q?Vv/oQd5fDDqkpHKtHg3C4Rj50hXdu7YmapmJQDUq3xeExDW8s/darK9Uf8He?= =?us-ascii?Q?dsEoVwOH0c11yoFYqJskOzSmtoXsF9U7YPAIEUAuB4sdjXTmF86pD3y0umTD?= =?us-ascii?Q?LkpcVPari4JayonqQoHLN5vQt5rCikLiXt3Tufg01e4YtnuOdOxFQmN6/aeO?= =?us-ascii?Q?Ho18jJ6Xlb4HhktrzD9NlL4nEr8wQkWrtTQ9fsXaaxHsi/km1W20jg1xGpy2?= =?us-ascii?Q?DYA/XDbOWUejSrpTwzeWTjKh+uGd70F94W+TnKf2Oe4aMEqN0OinMqn3d6ae?= =?us-ascii?Q?IZhZKYTBsGFJbwtVgw+VPYHrs3BwHBQnkdSGfUWkFfE0pRewIlSswOL20Mj1?= =?us-ascii?Q?ZGRJM+d3cL0xdw13QrvWVejv3+3AQqCPYdxhzL5eqlHfOW/TjYyRC2fEiXr0?= =?us-ascii?Q?pRb+sNFsA5ELxBXqKzFRz5AHTEmQusxMwxZ8ph+Av2s06Yv92AB3PSX7uFmJ?= =?us-ascii?Q?c4wp++1drwURfY861K/lZRONFBfHsH5y/qAiq5PJeCQjqRrrm0+PQJqu08ba?= =?us-ascii?Q?RR0kV1iL7IkeRfbrN6ER9LUiprCkde/LUK0ewDkmTB1jYaclIK0BbUUvkkA0?= =?us-ascii?Q?SOB9NfVBMEcT7AKAyL6eYJ8E51geSza4c5gdq5kEETmNRWScBUcU9ED/vtB+?= =?us-ascii?Q?j3yIQfxEKjZsHf4kZDU7sDQo6CbM916G7UTGYeu9NRgq0LRe598dOb+lFuPu?= =?us-ascii?Q?tT/kYaCH0T2P0V8oS58xwAuHcnWT5x/i8Urm+D6O+YGHcUipIi87Jhz9lT6S?= =?us-ascii?Q?uj1Pf5PLNYJUW0njZdWO+YGqLb5IAWi7e+8aanDr2Qa7JKPIy4O/yjhdp7vE?= =?us-ascii?Q?xRlQS9tTeyhTI0/00XNu32E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2533b2-9a1c-49e5-1fdf-08d9ea5f5c68 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 17:29:14.1662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NFnL72o7HmqaRq1rh3a1fXMZmrr+UZ2XtRhzi7A2YbZ0VyUDQvCo3Q4F+Ww6AFydQielbaQfpam9zsbs3ivfmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1136 X-Proofpoint-GUID: 02L8QzF8rdbT7jmDcv2hvN_FEH2RI1c4 X-Proofpoint-ORIG-GUID: 02L8QzF8rdbT7jmDcv2hvN_FEH2RI1c4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Sat, 5 Feb 2022 03:43:33 +0530 > Akhil Goyal wrote: >=20 > > +/** > > + * @internal > > + * Register mbuf dynamic field and flag for IP reassembly incomplete c= ase. > > + */ > > +__rte_internal > > +int > > +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); >=20 > Maybe use RTE_INIT() constructor for this? The same application can be used for non-reassembly case as well. RTE_INIT would mean, dynfield would be registered always even if it is enabled or not. The current implementation would register it only when the=20 Reassembly option is enabled.