From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82049A0C4E; Wed, 7 Jul 2021 16:07:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C460413B6; Wed, 7 Jul 2021 16:07:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9D67F413A8 for ; Wed, 7 Jul 2021 16:07:42 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 167E0mT1032398; Wed, 7 Jul 2021 07:07:41 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0b-0016f401.pphosted.com with ESMTP id 39msw2cdwt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Jul 2021 07:07:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QtnOTBMzI0aEdS+Qk11S/YGo+MH7BXSwgXbPLmvliXGx5BlJfYV0wCLv12fBm3kD4UkkL+G/R+/c/UpZVd44Hnr9IzyMNuJGZVosKjhT7YaoIBBMVb0rk7OR4NFuHdV266+qpIWZFS4E9SbjM4xoICB28+DphIFEEWBGvHiesRMS/F7JC6Eq47hkzreQNFMtGhnVVdt8wDV+DwRPmasxf7ernV+J3m7eNNjm/LuANWl1SrPqleb94YqIyU8D86g9M7WmgyoAKcTiUt1QDIr8mjNm6X1YU/PhWEnnVgOWpWmi9if80XlWVv/q7QY8ZCHGiYVepu6SUDyr16aPwiucpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dGl3gLu5H7EAZOLwrmdDDvgANjjDcwkA59MdW0Qh/tw=; b=g5BAK/aE3bhJn2OYq7d2F4JAYTUyT07K1E5hf4gIuAsQ47p4q8LNeG9jlpbcHtfepsA0VFq/jsbiQnk0H6n8ICq8ywzlVooa+zT0IriX9ba5uV4Eu/MGLST6ZmhNJm9i718560pInbdZ6RhWD4NGKBM6/bG8XhTRz8AKteZWvK3oS3tGCQecDhEoYHQZL5v1IWYMcm7rDhKmL8AFmGTyKNM+lnG75m31Lv0YYDAJ+TRskdvigo1bkM/dkaKk4vVdb00wAYootVfBTfAcpAf8F4/ZB0gRh8k8bDnZDX9GaIT1XST0aleslqgwtLt0MEn+MYzNkqPruCRKeaDifJ1Wzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dGl3gLu5H7EAZOLwrmdDDvgANjjDcwkA59MdW0Qh/tw=; b=K4quHOs7WaMnJ2JtkEB3dashyipAV9n0s1tkKmXv4iShJ8NU6c+0MieWkfH1vc4yCSksi8u5b0bILGXHSqmQ0CrvgCu1whZupWJWROdzdAyHfKexl/fnJHpm1D4/qqS/VshYoyY+IxVkL9OvRSPgrI8VN16+nzLdgT/i2UXLlDk= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4602.namprd18.prod.outlook.com (2603:10b6:303:e1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.24; Wed, 7 Jul 2021 14:07:39 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%7]) with mapi id 15.20.4308.020; Wed, 7 Jul 2021 14:07:39 +0000 From: Akhil Goyal To: Abhinandan Gujjar , "dev@dpdk.org" , Jerin Jacob Kollanukkaran CC: "ciara.power@intel.com" Thread-Topic: [EXT] [PATCH] test: fix crypto_op length for sessionless case Thread-Index: AQHXba4gpBGYGYGTHkSKS3XIMoCFn6s3liwQ Date: Wed, 7 Jul 2021 14:07:39 +0000 Message-ID: References: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> In-Reply-To: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41f62a88-e486-4ffc-18b9-08d9415094ab x-ms-traffictypediagnostic: CO1PR18MB4602: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SThNKz0UZ3iGuLixSSoj7+NujMksSCNuvHHlI4VDaYloghyeDcbfgUIiD0YjZPfSrMocvEXKjtoszuTi1ZlZyK7vHNsC6bXZpromd0F3raN0eqU4K4g1ySsGNjLWGspXEiJweiTdCL7esA5j3oZf989cqrovsaK8lmbEjtEs8nqXO8u9SpHoqPsSTKOhJQuQ+9CEyhmuUVkwdnAVJktJDuTtMddq2HkuNM2ospD+A9RmgzOyYLM5qcFhQSE8Nz9/VOUhtLRl6Rb3byUFRVhk6782tTqABi867DrV0k92+ynbFco6xK3yjDFc47gdp9f6ktbXZV6QUCer90Bvbpyn+upiP8yN+vEKz2l89ER7HAlUorWm79rG6jVzmnB6204RbCbhGd/kMXVLBcorxXH6roANjvnFxNrEwK4A3qL8p4fEG7qzr/rrqyoY0slNKgsjDlZFht/A/ODkaSMd/SzH4Vvhiudj4q2JM2pXRFtfvvX6skJeRlEIC8t6QY2y9b8LIS1aIfecAI0zkqS96Qc007jYkW3L8zNEabYGX4YJNxMGZTZ5T+Nf12vBbzaXg4ihBtx1FG0cCD7VsVqUvrX8TAO8EY5HS+XMtk1BCyRNuquav9FWKktN0HMhPI29mvXf2bJqUWm1gAHgatkB7txdLQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(376002)(39850400004)(366004)(26005)(2906002)(8676002)(316002)(64756008)(186003)(66556008)(66476007)(83380400001)(9686003)(71200400001)(33656002)(66446008)(478600001)(38100700002)(8936002)(5660300002)(6506007)(55016002)(52536014)(7696005)(4326008)(76116006)(6636002)(66946007)(86362001)(110136005)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JsaXDPU3LdfNygWMIdoipYAENVFhV7OmQXhEjgLxBnOx0PrXdX/6yguBNl91?= =?us-ascii?Q?qgaD1csewM04BbItmOqhSFJlJ2bR22ct8SqgtsBOVMsYJqqacca25lFh5MTb?= =?us-ascii?Q?RupougWnrulVtg5z8/bIW2IwcaPSY8gXOTuScjmjcZoEDZ1KkeAtcmvdPap2?= =?us-ascii?Q?52UzFKFxGfELcSkVA9V5LKqa0VufxA7v1PsC6nuYooMhksjSSMHpOPKwn+lZ?= =?us-ascii?Q?c01lAzPWkfBDei/7nvguMsyPDEuI2b7jRUEdaprpyxd0tksZQGDlJ9fLbEq3?= =?us-ascii?Q?rz1hJbDI795Mfu82nUwGcPgEVzo170Q/JCFiLi4Lnwrl/hhcPP8x4n8ablms?= =?us-ascii?Q?+bHyk7N6vpXDtkQRY8k/TXXFrC9HCJH9zS9j4Gy9TKOb3JBZbWV6r0Gh+IfZ?= =?us-ascii?Q?WHr68rNDA2bjRnw7yTI5m3wpr2xtoDsUsr0Vi4yRaK2RpyYc3ApqdRioHZCZ?= =?us-ascii?Q?4mvZLXqLjoNdqM5D+cLM8iXHRx+DZzzmBVqw8WAgxE3E8L/XDaUg2TopPJuy?= =?us-ascii?Q?LE/uresNOydNx+SmhyawlKqzmQAhru3dGcCPVGzJUhZjeQDv/e6qv4WnvAh4?= =?us-ascii?Q?idEWW8d0XG4vCiOI2N03AqQIrLylktIOsOITSlVSSE+QG07ND9I4sdE6nx2H?= =?us-ascii?Q?3SuI2wE/bjWyrLBKvxhE33CHdul1UVwy+G/jKF6ISo/s1YwC2zzvmY2Ejn3h?= =?us-ascii?Q?QKTc3FiQljrnxTPN3NQx+eL+RVQRujIC11izwM4JVNGUyIjBihhsWpXlK+iX?= =?us-ascii?Q?RA5I5e4Fz/eOl3CNbhFxkD3+0XhH9nrnBGpaF19HypIOeIX/HLaeii7xa+5U?= =?us-ascii?Q?fr5P6ut+qU4Y1rkSx6WsgpX7iHtSA25DL/3NJAFvcTJDTofzEPHxZ3kfu8zi?= =?us-ascii?Q?rAaefAV2BwAf8tpX8QzXErBuUveeoPrKt3Js3PmbcPBPt+ouKyN4ewNa5L0g?= =?us-ascii?Q?Hmq9WY56glz8KisdtI9iL+xOKZM/Lr+HbTEF/xg0JdEqhuGhIa33yif6nd2m?= =?us-ascii?Q?k49tLplFbUewNmY1wcD03hn/dD59w2oTqMuDC2DA97cpha7GllnhtapVnLl5?= =?us-ascii?Q?EoWD36W/pt27ujUkJ3+Cx53HMrBBPhQYxtliyO19nVn7iAM1Hx7SNeu7R0Fq?= =?us-ascii?Q?8ek9nV+6ZLFN2dNo8Jb28sgUVBCqfa/k621EGxS2dWU1uwVEiPLMuT0bugUs?= =?us-ascii?Q?VcYeA1c1TITi0GJ3CNpgkuJ7ZFl6wJxLgCuih6uoSS40Q0el+jK30/EMl1rj?= =?us-ascii?Q?RTHIU1PlwjMblNJImEZNSZBBkiJs0vuBU9YRcvi5uQ48VpZePSSNWiYKJesG?= =?us-ascii?Q?F0R/TOLRYF8k8kD1xiA8YyYz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41f62a88-e486-4ffc-18b9-08d9415094ab X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2021 14:07:39.5721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5UkQSYGs/MlYN7/yBBexrIF8auK8777qtIHXWPm0h0S4PGw/v3bt3iP1NNehhhLRBcfgbizG3KliDMuphYY5Kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4602 X-Proofpoint-GUID: yqL7s-0hqZP3R4AGhXCPRX-3_uz3tAdc X-Proofpoint-ORIG-GUID: yqL7s-0hqZP3R4AGhXCPRX-3_uz3tAdc X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-07_08:2021-07-06, 2021-07-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] test: fix crypto_op length for sessionless case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, > Currently, private_data_offset for the sessionless is computed > wrongly which includes extra bytes added because of using > sizeof(struct rte_crypto_sym_xform) * 2) instead of > (sizeof(union rte_event_crypto_metadata)). Due to this buffer > overflow, the corruption was leading to test application > crash while freeing the ops mempool. >=20 > Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") > Reported-by: ciara.power@intel.com >=20 > Signed-off-by: Abhinandan Gujjar > --- > app/test/test_event_crypto_adapter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index f689bc1f2..688ac0b2f 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less) > first_xform =3D &cipher_xform; > sym_op->xform =3D first_xform; > uint32_t len =3D IV_OFFSET + MAXIMUM_IV_LENGTH + > - (sizeof(struct rte_crypto_sym_xform) * 2); > + (sizeof(union rte_event_crypto_metadata)); > op->private_data_offset =3D len; I do not understand the need for this patch. Event metadata is copied after private data offset, and this patch is changing the offset value. You changed the value of len =3D iv_off + max_iv_len + metadata_size, but metadata is copied after this 'len'. See this rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); I do not agree with this patch, am I missing something? > /* Fill in private data information */ > rte_memcpy(&m_data.response_info, &response_info, > @@ -424,7 +424,7 @@ test_op_new_mode(uint8_t session_less) > first_xform =3D &cipher_xform; > sym_op->xform =3D first_xform; > uint32_t len =3D IV_OFFSET + MAXIMUM_IV_LENGTH + > - (sizeof(struct rte_crypto_sym_xform) * 2); > + (sizeof(union rte_event_crypto_metadata)); > op->private_data_offset =3D len; > /* Fill in private data information */ > rte_memcpy(&m_data.response_info, &response_info, > -- > 2.25.1