From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 648BDA00C5; Thu, 15 Sep 2022 09:26:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C0E44021D; Thu, 15 Sep 2022 09:26:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id D402140156 for ; Thu, 15 Sep 2022 09:26:33 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28ENmMLk023140; Thu, 15 Sep 2022 00:26:29 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jjy02752c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 00:26:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kz73YDbk9uKVNQJqy+wWptlnfU0OceewhxLsCEuvRwI5b3P65s3AqZRYNmhlcO05uEPGkFSd6ZQr4iuIHpF3p2dWdJNCJGVVFhTn1CJp4mQ3+FPjCUUOtTQurnaYraw8A99WqTBwnpXMf9XlMJe0t9pfppvwhtYsmZRCLsnShCsE7tlrGXeu72pGJJhS06iANKu8tadSSBS2+jMAWn3TrrPS1OUykVs5Arpe2SQnrrlzdvSSBMex6QEBFHSe5BBiN/CbAkdZIK2o+DfrOG/uqy5mTtc6fYo7eYlhYTs6uSyPWHPssO96ZL3+1Fx3OWXLUVJCKfC6dOI6xYFdQwjqeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=irVliEcyzOJnYysKpuWYJaWlZw17Ue0Z9zyoeEymdUs=; b=RLXDgnBkfFGLE30+rGAfr91zDzI/JfxjW8VulaHjCe1VkXH39KFTCA3SMn65QhCogYIMe6bz4QpshRxLlF7y1ymfk+8eXKYrxhzCtjYNCZPY4gMDkGnhzaqXGiNpu8mLtJ+c2DisDvaTIwgDLPP/hlAz9N87Icnf/FYbD+kzrp01T9LLruyzQQb1Mu++HySh7nsFgmfwo2nUnQ2/EwYYDoxKHR40pX5qX06kPU+E/THLb0nAOzSBT2Z0uunuDZSPPwSMSGn3sLsOpMfuXuv+wYjdzTEh04zXxUCIeV9CBkp7weVx1Xt83P40aaFAQ0Pz+oTG4IJthEBYt60BhiMobw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=irVliEcyzOJnYysKpuWYJaWlZw17Ue0Z9zyoeEymdUs=; b=rAQaMFYXptByhdq8zBPExcR7Fntr2VcNs6yn3VLPYIhjnwhWtTPvb9S8ZLhPzH8NR7yZZWOLBbShCuMkUDTHp8Xz/9G5D2XsSHiPoRGkA4gnuunsBJ64JjnYu/cblm0wIYAqHOyZl0Mst9HhgreabjXEhgr42loJpNwgqQY6XtU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW5PR18MB5094.namprd18.prod.outlook.com (2603:10b6:303:1aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 07:26:24 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319%9]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:26:24 +0000 From: Akhil Goyal To: Fan Zhang , "dev@dpdk.org" , "konstantin.v.ananyev@yandex.ru" CC: "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" Subject: RE: [EXT] [PATCH 1/3] cryptodev: rework session framework Thread-Topic: [EXT] [PATCH 1/3] cryptodev: rework session framework Thread-Index: AQHYu8M208HTf52gBUSVhtTZwPxv6a3gK9EQgAAE1cA= Date: Thu, 15 Sep 2022 07:26:24 +0000 Message-ID: References: <20220829160645.378406-1-roy.fan.zhang@intel.com> <20220829160645.378406-2-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|MW5PR18MB5094:EE_ x-ms-office365-filtering-correlation-id: adbd0fca-c0be-46b0-c6ec-08da96eb984b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lX3/aZXQY6Fe5sYhVeJEqZY9n54Sht0Qt2jxuu9FMlyWAbwIuvLbqNCo8m3Oj7+dboHBPqGkwJqjVwiFUoSrNiT05gUFej5kc+Q5BCK3cClbHlm15+Zm1vY+a1+cTj5uI28XlvqfFL1Lac2Ujk/zM+pzEAte2e/FDo+sBc+xbYbbF4ZH93c8yEXeDk2IMxyImUVYljjNnfvu5+2T7Zmit42cRdBSeOBflmUjGsJ4UiKKk7kU714oXKXrbnQ9sn7ntvzLeK2WI6EBvF7dDDw2fDX7bl5kHO7bUbxAmKv/C38/u1tZFcwzp4pNc4zHVrfB9tX9RX5OuvLb++nHSbXpfmXOY9OLtShuK2COHog3mwElyyYOXTfl69F+rmhpAbeCD0uC4ZGduB67KwCN31NFM7D7b4LGIf+pLZQ7mxAUOOB/1Fhrl4O0NrRsOxz+wP5pdWHE8ZIlIlfrzFmHxkJaKJqkQYRPY8lBiTFyPtrv6fkLVQeojgba8QxCSALOuaMfBe0H+5tPtLB0WZBnBNFEnv9yyff1HqFLZmsOecF3vIIeEqPyzkCDTVE31YooBxWHYxUkTj6m1xhFSBYJaCwG7OvJIQxIUJezMBhZNV7b9XrmUaE/axBInL6bjVk7vdppz0RVza8iXhlKiTfFrwq/Pzbs368ZjlaEhSQ30eF37sdrfK9EuzDdxFoovvucPEpQTZBOI0L1+VPhEN7gLbas4GO0N2LmCTjtAumUSpiiXkrco2F0nfqZQcXH9urFuVk3YDnratNmVXZpJ3uhlZmHrQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199015)(9686003)(71200400001)(110136005)(2940100002)(8936002)(83380400001)(38100700002)(8676002)(55236004)(26005)(38070700005)(55016003)(478600001)(7696005)(66946007)(6506007)(86362001)(4326008)(7416002)(66476007)(66446008)(186003)(64756008)(66556008)(76116006)(5660300002)(54906003)(53546011)(122000001)(52536014)(33656002)(2906002)(316002)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FeOeCHn/0UwOnV4GGD2/jQQ0YSJpDLa4c0b+hI4JkafAKYUykZSlJXGx4+L3?= =?us-ascii?Q?MsWyoJGlPvlCX3LHQqecrJwQTnJ1Ki+OSrT4/6lV7xpkfp+Pnu5Nq98Fzain?= =?us-ascii?Q?PODotjgXHjmR0UcONCgT7OsKmHLVqzBM5XzYhokBCBMaE7A6UJA8r+AMUGG8?= =?us-ascii?Q?E6ChSGHH5fIxu10FJHQEK4LGgGBUsXWe0t01krV+rwgpKLK/JEKpYp4HOPlE?= =?us-ascii?Q?cizLKdfBVXlbDmquGVnMvsLI6YLOWXukq6kUquUnmsGhbd2jN1GTpFE5et2x?= =?us-ascii?Q?R5x85bxWN9HrqxnSJtlfIMtiMgnNqvDY9JKttIk/N5vjOwylnDLzAyu17a8r?= =?us-ascii?Q?uk7WRV37a/2MLQMxcWsIT9a+AenBd6tF4LeYLqI6+YkqRQzpoKFQBkPkpeYp?= =?us-ascii?Q?P3YDZO8PA3OhITrX1lm1Y4olz6TuvF1Hcefy93ocEpqiYoU/aqgenGMheEnZ?= =?us-ascii?Q?GA1ICI0RgxBTesRLXnmjIWc9eDc+sMvLBV2eo+jrU364OhgcRe+1hhF+9XWn?= =?us-ascii?Q?PnfKfxe5Buu9OnH/XGxbR/ZURGLRWrRQlZEisgNLsRDU63DgxseMG/W1D+6/?= =?us-ascii?Q?IvNyeEUAJEf6h32BoIHUwzwrOjtRlRBRK70asFwuuroRJ3l6Ll8EXX3HCiIu?= =?us-ascii?Q?rCOiRuOJULXrkNUl9WKPEaBD/5g5vJ29U5S4B0BNLj2fcJxj4TyaObOymzfx?= =?us-ascii?Q?FM3JVwabD5AKLuLJgPxI102YY6WFq4myCfrQVesLviV0SPDNaqMXCs+DzvM0?= =?us-ascii?Q?1Ni1Q0WSGrtFFJj+fyGLN6P9vRqUExi0dx8HESG1+HiCcx3/Pa8FZfAq4jIU?= =?us-ascii?Q?pE3x2P7g7mLZrPeAg0a+wqP98lELH84suz0VMdH3ZctY2rNNF2SPpo9H8ZXi?= =?us-ascii?Q?SFhOfS0Qdi4DlGVmfdngjsCZZ/MLW2gLrzjvHk+tBpESfXZ2GOJyjTrWzyUo?= =?us-ascii?Q?19xapFQjkr3r8mQXjRKXT0elJzxKR91MfzGA5kPZ0KBXUQrRTi9rHS8IwMCg?= =?us-ascii?Q?A3p/rSK5HK1jiKk8WtD1K+OIt1W1YZtXRlAnXQH+n3VTVVykqKKadAuSp0K3?= =?us-ascii?Q?RKnRBFrwQemNKRMQys6dbmpcdrRGFSFq35w0kg/2ZEjIk8infPh5WBWvSjce?= =?us-ascii?Q?TLT+lUvvBLzNHC+JyJGMJ+cF1MFFLY2oN4n5W6owhcok8xJhTsk3JowEOX1+?= =?us-ascii?Q?aHFwMI8VYi70El9QI7dMqpUJWH0bwYbToPXR+N5vfuGSq+oRFY50csZY4QM9?= =?us-ascii?Q?UXX635HLLOO6oFERxL6RE++6hsMWWvFLxdMcS1b3/O8EKcD7qJgL+VM2dh+p?= =?us-ascii?Q?BxuXEsKGCO7HnJqSjrm0Z2RmJci8emlVxH14l3LmsGMxvvuOKLnv2SEcNeCS?= =?us-ascii?Q?pq8bEuqzaBhgbFoRcMVhoCywzYQxTgADovadwzuZ6YuFU3yP0UlxvY86+/Ii?= =?us-ascii?Q?eLln5gDIl/n7PG1EcZmX6QcenJvTo6y3p1/Qo1vlYheFpOYBs2YkOAEPIK5q?= =?us-ascii?Q?jy/M9SLE+XfAL8ijOvbFa1aS8tbIUfES0W2wOXgKt9LkyL1K2wJ+wRb1IUTL?= =?us-ascii?Q?9QSAUObY3qTGFtbyNJkbj96W+uwhZfkr27UP396P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: adbd0fca-c0be-46b0-c6ec-08da96eb984b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 07:26:24.2305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yEVWQk38I5gFsjYRA8Ipp7Rerx7dYQ1S4qb6wBP66rn3/Uo/yYZDY3gCxzGv9Y1Q+/PZRz1kXjtSJbMXQmZvDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5094 X-Proofpoint-GUID: wiygZvYyVAUgYc8BldLLy8OlYkvX6VGB X-Proofpoint-ORIG-GUID: wiygZvYyVAUgYc8BldLLy8OlYkvX6VGB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_04,2022-09-14_04,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ++Konstantin Requesting everyone in cc to review this patchset from last year. This patch was not merged in 21.11 due to lack of review. Please help getting this merged in RC1 for 22.11. Regards, Akhil > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, September 15, 2022 12:38 PM > To: Fan Zhang ; dev@dpdk.org > Cc: maxime.coquelin@redhat.com; chandu@amd.com; > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; Anoob Joseph > ; pablo.de.lara.guarch@intel.com; matan@nvidia.com; > g.singh@nxp.com; jianjay.zhou@huawei.com > Subject: RE: [EXT] [PATCH 1/3] cryptodev: rework session framework >=20 > > As per current design, rte_cryptodev_sym_session_create() and > > rte_cryptodev_sym_session_init() use separate mempool objects > > for a single session. > > And structure rte_cryptodev_sym_session is not directly used > > by the application, it may cause ABI breakage if the structure > > is modified in future. > > > > To address these two issues, the rte_cryptodev_sym_session_create > > will take one mempool object that the session and session private > > data are virtually/physically contiguous, and initializes both > > fields. The API rte_cryptodev_sym_session_init is removed. > > > > rte_cryptodev_sym_session_create will now return an opaque session > > pointer which will be used by the app and other APIs. > > > > In data path, opaque session pointer is attached to rte_crypto_op > > and the PMD can call an internal library API to get the session > > private data pointer based on the driver id. > > > > Note: currently single session may be used by different device > > drivers, given it is initialized by them. After the change the > > session created by one device driver cannot be used or > > reinitialized by another driver. > > > > Signed-off-by: Fan Zhang > > Signed-off-by: Akhil Goyal >=20 > Please fix compilation for unused function ipsec_mb_fill_error_code