From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76359A0503; Fri, 20 May 2022 09:24:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6239D427F3; Fri, 20 May 2022 09:24:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8D666427ED for ; Fri, 20 May 2022 09:24:16 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24JNtk2c018974; Fri, 20 May 2022 00:24:15 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g6008sf74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 May 2022 00:24:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTs16UjSjMedNeHbg8edUJiVPgYWz1UZHiCA4go0fTmXW3wZzq+4W1TYqsUyy/9050NB6aULgffMA+zfbRICHIpHqr/w3PTnnh7DHpv27jqTnIK905iuKD2UD2jlG43zcw4WpWlV+WMVofwjRZ5yp5pH8+Y5XhqZklO8pykOPYmEB6Q5m9Y8sSCPvjyCmdA1W6xbUg9LuIF09QxshaP76ec1MLsMYZkH1wUoXUV5+QgNyQs5f52oRC6u0qkn/Pbl+5o49JAI3j8NcssP3p86dn48MjYjrOvmarkfspG5diieeL96jKEA90D9ScYWi8bfqGHjp5leqgw/YxHGJZkYqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yAJh3U39Xl/vckJvO3s9WaRFLFp6X9Tx6BAzigO+now=; b=cHo7TmQoQKDEFHAZt8QWf/BQI9HRNrm2Kyo9f/WJxKYAW38VirEN6lpBfGR0UgQkxqgWJA5wG4HJrqFOocFANmNpP+2C/3/ytle4llSpmvhevz3Xpwy5pROaJBPr45a67R0BEoqcwckbSlKwjnchl8aZuFgw1wcNJlzIzrGacOLS1BiJbgxIFNLfZEEBAvc36WTVGesFA9e8+Op8oOu98bp/Ax3QsTmQ2mU/W8/X4TvNqXZAES7IJcM+9e4iLiMAwSG4+M2HOzR8vI5bR1OWJrkZk7JStKQNKcEaXuT2FhVsMFCD77KXMmGrBE7ylUh6kNb0Fapz5gCKwgKMQ+Cxpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAJh3U39Xl/vckJvO3s9WaRFLFp6X9Tx6BAzigO+now=; b=ARVrmpIsu9CAl1K7tb7BpNjBcLb35IdX7oxuQYNDVUkFG/azSUlsUubzloOJHJdkXCo8qQIeL8mg0AgaSUUScYCtQQh59Gg0T1Xbd8omPpHltEEb6x3yv+qch2eLAPB6ru+W777aoN0/PG5ng2t/Z6tBSQcqAdtY5hcYig8EWNI= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4849.namprd18.prod.outlook.com (2603:10b6:a03:401::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 07:24:13 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 07:24:13 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform Thread-Index: AQHYbBepkiLSwUUd6EW0It27m6mYO60nXOQw Date: Fri, 20 May 2022 07:24:12 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-14-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-14-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b81e399-a385-4e5e-84eb-08da3a31bd45 x-ms-traffictypediagnostic: SJ0PR18MB4849:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5yuPjVUtDi/Gi5k+1Hm1GMaJBeW1naktNlf1+9ZPE5cD41SW0REBg45gasJRFxqh3QKeIBJn+5D//JoE8lOiYktsW5vZC30BVk5rBky5Po0kC9zd4qRRQFyGPAcDmJzapH/nhwAsKeZ4ZzRSX0U4cBYOwTS0BCnFDxz+YH2hnwv4sLT/UZ/QHFy5TraMV2tdsh5qhC4Q/mZuYSMHREGATOx8+W1DvqircDKz346XwPcBEk02HYOTN/w1Yjdy/PWfGhXlGQq8/HidWTpEZAavTjjefGdGuOIDhrKknu6hXocZyEHC3/Wj//vCKe3zZyYJ9yHU9Bllwx3NJDkUbjLJr+9Pcn/HLXra0qtN/PahFor9WV2x+z7l0u7xYL+bxdcww1ytT+zzTXugU9lMPyfOw4Zr51mEG0UWvFsYPA9lz9atAR3JgdYrUZc/WDAhGf4p4XTD346Uj5gWa4XzGEaS/pnl61lUPpHu1+yY46/UUijPnzDhXtl3C9UwxJfPiLc4+4/AXk4SlyJH57GCuLz/YvrW8ZyDUapzxZmk4ROiXSWvKIA1Lg4/KMTo1HPzhdhq77dU3/1VPn+CaDn5DgQ5c5UWJGPbcV5xg86pInR+0+6qu3uraPgze+wT3ySNQtrAg/i/8jBbv2NNWpMfF7Btz0k2oB+ymuibevPHc2dBI0Tle1uij25Hb2msSllEC314eIH4FZKoIVY8X5jyMy/0dg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(64756008)(38070700005)(33656002)(26005)(66446008)(54906003)(52536014)(8936002)(71200400001)(55236004)(508600001)(66476007)(66946007)(5660300002)(8676002)(66556008)(76116006)(4326008)(86362001)(38100700002)(2906002)(186003)(7696005)(110136005)(316002)(6506007)(122000001)(55016003)(83380400001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OkHIpoBVmFCfauQCR54IQJjKBhUmECpUIAMqbXaQw0hFN9E9cXv9FMdShD7s?= =?us-ascii?Q?m7FneVNQwdSKG1msZPghh6Ozhcrq1uqcAYqj9sTs4b4pI3/wJblJux1gbhD8?= =?us-ascii?Q?F7sqszZvT5wCZ3TDKpglBin4alBvKZMAXtFIWtU9Usl0gDfznFvUSNUobb0R?= =?us-ascii?Q?P7jQa0i+GFw9g5Uq2x4ww8c+QAm5jw9GesfxEAX6FgGslxJ5iAojXag73iVX?= =?us-ascii?Q?nj2bwRk8kMfjpbttKXN+y2QuqrdwblSx9C6msy+ZqJ+uOydhHnxPb0xkWfYO?= =?us-ascii?Q?e2PhWCVF/vfUbYgVtrLbOvVJBdFuPfBwKAhmU9T8r7+5g+E+c/qERXgiOenO?= =?us-ascii?Q?yqwi4hNAqS7Ik3kBX6ntNrRH9VSQ/6+s1gE1sB89QDk6k1xYGbau4iqZ+5+J?= =?us-ascii?Q?CFyeRQXasflwQ7GysHRdAIIr4akmA4pcsXfPrIFEwyVrsdqkHOCuhswPhVJw?= =?us-ascii?Q?7blOnVb459HrL7cbirwSQgs6tYMHMCUEa7oBW5v5JCxv1GRNwAcb91Q+CcBL?= =?us-ascii?Q?JFyNkh7Axk9wG+5whqGrR9Whf0h0+xZ+FYVBqo0gkmf5pcFkl999Gjs/OeYw?= =?us-ascii?Q?ef7Rw4+lILDfsTQkGcHq9Gj8UaSLXsE4NLhEYL9mloETfMhfPpzqf+YWcV1U?= =?us-ascii?Q?KH4LdmpHO4p6MtEtIx5BySxwS8KgNyyc93IdP8ohaW5kQTltUqHMw2EuzLmG?= =?us-ascii?Q?yxisSENMAoLTiAwbIcY3W1nwd4zkXXG+Z91suGwnICa3Xn3ggdmpY9nLPnT+?= =?us-ascii?Q?QzLg3dsgkFL9FNSHiLr8RrK+4U5AgKm4j8SNYrTCofa3d0ucnjgGj6SVDjtH?= =?us-ascii?Q?XpTFlFJ41o/lTeu0qZPQXRIj53TvrC26AtydBifdJvLnHLA6wMvnnWksQBrP?= =?us-ascii?Q?19qbs9RcRguDh5FTwpdj2uvt2i/qDdFENxr0T6hh1sXmN/eb7HRidabQnObG?= =?us-ascii?Q?vh0gvjydLIHj/elMmq9QFwkoSlxdUBGEGPwS+oNJv5fMZab8PHvdLLoOf1Ev?= =?us-ascii?Q?5GlfqWgtxXWSCemKjGabk9eDfta47QucutkmV2t7v008sapy64ALlWzjhBXk?= =?us-ascii?Q?rW9nwaMXdD6QoxpndA+9jplUWA3DHDU8EHPMYpCoQ/t24+7sa/X5QpBULYFU?= =?us-ascii?Q?aRJ6Eu75o751PSoz6y0aKzW5O8vHa6dsxY3HDqGGE6GhHfkJ0EreWtSjrWxD?= =?us-ascii?Q?AGTZgwekRkrzct8g/SX4koBpIFepDx41ONeQZdEj5fxq8ulNJYE3XCnQRhlF?= =?us-ascii?Q?KK/298nJWfkb9iWBnO6DVKBU3EbGCWjoyFyOZOQ8Vuzs2o7vegS9o9CRbOKd?= =?us-ascii?Q?MVD2gHblvM+U7uB02bXYHQpfWNd9yyMhVhEFNAzziHrkb0Eo+pQ+5oRxIG6f?= =?us-ascii?Q?R8ZPOxAi8Mb+om8I2mjMzfMlzAr6rV5Ea9cX/9VTcqTsCVjDiiZRF9bcHbNP?= =?us-ascii?Q?SyYpQ4WxOHZJLbqP6nh+NWe/mfgh61qdBaiKrkKjFSlXwZH+/CcYNKqKPR+Y?= =?us-ascii?Q?3MQPTjzWZ7vDctt1klF6RzVmyKomGSel66ROxpLNyL9vMONwaxlrpsUAgly7?= =?us-ascii?Q?OUeRzjQfvxSuWlYbZs+w8MPP8ZFvtjxjFRvxbMbsMySvMpebGbAczeXq8B2V?= =?us-ascii?Q?kk9MeJri9/Ll6q000CIOzRzJNIIvu0vEWAEY4VK2n6PpRvYv2NyErIQjIu0M?= =?us-ascii?Q?AOYu+oC9cjYYjxnLxwrHM3t/i1b0tMcdGpA9/W6E6eEkKRwP6q/x8RIarB3e?= =?us-ascii?Q?FTSXEwoJwQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b81e399-a385-4e5e-84eb-08da3a31bd45 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:24:12.8979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iQxTuHU2d17ND/b9YUOivCMljuzeACqXYsgv2hvDSOySFfhCCrzcNZ7WJIEpei+GHWWY7gnfV7tXK4P3WOvuUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4849 X-Proofpoint-GUID: C4tjsqBiDCtO0fyGzNPEfksuW8rkVKrL X-Proofpoint-ORIG-GUID: C4tjsqBiDCtO0fyGzNPEfksuW8rkVKrL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-20_02,2022-05-19_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - removed asymnetric crypto xform next field. > This commit reflects changes to the asymmetric crypto API. >=20 > Signed-off-by: Arek Kusztal > --- > app/test/test_cryptodev_asym.c | 100 -----------------------= ------ > app/test/test_cryptodev_dh_test_vectors.h | 1 - > app/test/test_cryptodev_dsa_test_vectors.h | 1 - > app/test/test_cryptodev_mod_test_vectors.h | 2 - > app/test/test_cryptodev_rsa_test_vectors.h | 2 - > app/test/test_event_crypto_adapter.c | 4 -- > 6 files changed, 110 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index 0098b6bf65..9e5d5e4f27 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -318,7 +318,6 @@ test_cryptodev_asym_op(struct > crypto_testsuite_params_asym *ts_params, >=20 > int ret, status =3D TEST_SUCCESS; >=20 > - xform_tc.next =3D NULL; > xform_tc.xform_type =3D data_tc->modex.xform_type; >=20 > cap_idx.type =3D xform_tc.xform_type; > @@ -1063,7 +1062,6 @@ test_dh_gen_shared_sec(struct > rte_crypto_asym_xform *xfrm) >=20 > /* Setup a xform and op to generate private key only */ > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE; > - xform.next =3D NULL; > asym_op->dh.priv_key.data =3D dh_test_params.priv_key.data; > asym_op->dh.priv_key.length =3D dh_test_params.priv_key.length; > asym_op->dh.pub_key.data =3D (uint8_t *)peer; > @@ -1145,7 +1143,6 @@ test_dh_gen_priv_key(struct rte_crypto_asym_xform > *xfrm) >=20 > /* Setup a xform and op to generate private key only */ > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > - xform.next =3D NULL; > asym_op->dh.priv_key.data =3D output; > asym_op->dh.priv_key.length =3D sizeof(output); >=20 > @@ -1228,7 +1225,6 @@ test_dh_gen_pub_key(struct rte_crypto_asym_xform > *xfrm) > * > */ > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > - xform.next =3D NULL; >=20 > asym_op->dh.pub_key.data =3D output; > asym_op->dh.pub_key.length =3D sizeof(output); > @@ -1288,94 +1284,6 @@ test_dh_gen_pub_key(struct > rte_crypto_asym_xform *xfrm) > } >=20 > static int > -test_dh_gen_kp(struct rte_crypto_asym_xform *xfrm) Why is this function removed? > -{ > - struct crypto_testsuite_params_asym *ts_params =3D &testsuite_params; > - struct rte_mempool *op_mpool =3D ts_params->op_mpool; > - struct rte_mempool *sess_mpool =3D ts_params->session_mpool; > - uint8_t dev_id =3D ts_params->valid_devs[0]; > - struct rte_crypto_asym_op *asym_op =3D NULL; > - struct rte_crypto_op *op =3D NULL, *result_op =3D NULL; > - void *sess =3D NULL; > - int ret, status =3D TEST_SUCCESS; > - uint8_t out_pub_key[TEST_DH_MOD_LEN]; > - uint8_t out_prv_key[TEST_DH_MOD_LEN]; > - struct rte_crypto_asym_xform pub_key_xform; > - struct rte_crypto_asym_xform xform =3D *xfrm; > - > - /* set up crypto op data structure */ > - op =3D rte_crypto_op_alloc(op_mpool, > RTE_CRYPTO_OP_TYPE_ASYMMETRIC); > - if (!op) { > - RTE_LOG(ERR, USER1, > - "line %u FAILED: %s", > - __LINE__, "Failed to allocate asymmetric crypto " > - "operation struct"); > - status =3D TEST_FAILED; > - goto error_exit; > - } > - asym_op =3D op->asym; > - /* Setup a xform chain to generate > - * private key first followed by > - * public key > - */ > - xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > - pub_key_xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_DH; > - pub_key_xform.dh.type =3D > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > - xform.next =3D &pub_key_xform; > - > - asym_op->dh.pub_key.data =3D out_pub_key; > - asym_op->dh.pub_key.length =3D sizeof(out_pub_key); > - asym_op->dh.priv_key.data =3D out_prv_key; > - asym_op->dh.priv_key.length =3D sizeof(out_prv_key); > - > - ret =3D rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, > &sess); > - if (ret < 0) { > - RTE_LOG(ERR, USER1, > - "line %u FAILED: %s", __LINE__, > - "Session creation failed"); > - status =3D (ret =3D=3D -ENOTSUP) ? TEST_SKIPPED : TEST_FAILED; > - goto error_exit; > - } > - > - /* attach asymmetric crypto session to crypto operations */ > - rte_crypto_op_attach_asym_session(op, sess); > - > - RTE_LOG(DEBUG, USER1, "Process ASYM operation"); > - > - /* Process crypto operation */ > - if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) !=3D 1) { > - RTE_LOG(ERR, USER1, > - "line %u FAILED: %s", > - __LINE__, "Error sending packet for operation"); > - status =3D TEST_FAILED; > - goto error_exit; > - } > - > - while (rte_cryptodev_dequeue_burst(dev_id, 0, &result_op, 1) =3D=3D 0) > - rte_pause(); > - > - if (result_op =3D=3D NULL) { > - RTE_LOG(ERR, USER1, > - "line %u FAILED: %s", > - __LINE__, "Failed to process asym crypto op"); > - status =3D TEST_FAILED; > - goto error_exit; > - } > - debug_hexdump(stdout, "priv key:", > - out_prv_key, asym_op->dh.priv_key.length); > - debug_hexdump(stdout, "pub key:", > - out_pub_key, asym_op->dh.pub_key.length); > - > -error_exit: > - if (sess !=3D NULL) > - rte_cryptodev_asym_session_free(dev_id, sess); > - if (op !=3D NULL) > - rte_crypto_op_free(op); > - > - return status; > -} > - > -static int > test_mod_inv(void) > { > struct crypto_testsuite_params_asym *ts_params =3D &testsuite_params; > @@ -1611,12 +1519,6 @@ test_dh_keygenration(void) > dh_test_params.priv_key.length); >=20 > RTE_LOG(INFO, USER1, > - "Test Public and Private key pair generation\n"); > - > - status =3D test_dh_gen_kp(&dh_xform); > - TEST_ASSERT_EQUAL(status, 0, "Test failed"); > - > - RTE_LOG(INFO, USER1, > "Test Public Key Generation using pre-defined priv key\n"); >=20 > status =3D test_dh_gen_pub_key(&dh_xform); > @@ -1828,7 +1730,6 @@ test_ecdsa_sign_verify(enum curve curve_id) > asym_op =3D op->asym; >=20 > /* Setup asym xform */ > - xform.next =3D NULL; > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_ECDSA; > xform.ec.curve_id =3D input_params.curve; >=20 > @@ -2030,7 +1931,6 @@ test_ecpm(enum curve curve_id) > asym_op =3D op->asym; >=20 > /* Setup asym xform */ > - xform.next =3D NULL; > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_ECPM; > xform.ec.curve_id =3D input_params.curve; >=20 > diff --git a/app/test/test_cryptodev_dh_test_vectors.h > b/app/test/test_cryptodev_dh_test_vectors.h > index fe7510dcd3..078719072d 100644 > --- a/app/test/test_cryptodev_dh_test_vectors.h > +++ b/app/test/test_cryptodev_dh_test_vectors.h > @@ -63,7 +63,6 @@ struct dh_test_param dh_test_params =3D { > }; >=20 > struct rte_crypto_asym_xform dh_xform =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_DH, > .dh =3D { > .p =3D { > diff --git a/app/test/test_cryptodev_dsa_test_vectors.h > b/app/test/test_cryptodev_dsa_test_vectors.h > index bbcb0d7297..cc60f50b5c 100644 > --- a/app/test/test_cryptodev_dsa_test_vectors.h > +++ b/app/test/test_cryptodev_dsa_test_vectors.h > @@ -91,7 +91,6 @@ struct dsa_test_param dsa_test_params =3D { > }; >=20 > struct rte_crypto_asym_xform dsa_xform =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_DSA, > .dsa =3D { > .p =3D { > diff --git a/app/test/test_cryptodev_mod_test_vectors.h > b/app/test/test_cryptodev_mod_test_vectors.h > index 807ca7a47e..bcd4d5248b 100644 > --- a/app/test/test_cryptodev_mod_test_vectors.h > +++ b/app/test/test_cryptodev_mod_test_vectors.h > @@ -1045,7 +1045,6 @@ uint8_t mod_inv[] =3D { >=20 > /* MODEX vector. 8< */ > struct rte_crypto_asym_xform modex_xform =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX, > .modex =3D { > .modulus =3D { > @@ -1061,7 +1060,6 @@ struct rte_crypto_asym_xform modex_xform =3D { > /* >8 End of MODEX vector. */ >=20 > struct rte_crypto_asym_xform modinv_xform =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODINV, > .modinv =3D { > .modulus =3D { > diff --git a/app/test/test_cryptodev_rsa_test_vectors.h > b/app/test/test_cryptodev_rsa_test_vectors.h > index 04539a1ecf..e769dec1f4 100644 > --- a/app/test/test_cryptodev_rsa_test_vectors.h > +++ b/app/test/test_cryptodev_rsa_test_vectors.h > @@ -346,7 +346,6 @@ uint8_t rsa_qInv[] =3D { >=20 > /** rsa xform using exponent key */ > struct rte_crypto_asym_xform rsa_xform =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA, > .rsa =3D { > .n =3D { > @@ -367,7 +366,6 @@ struct rte_crypto_asym_xform rsa_xform =3D { >=20 > /** rsa xform using quintuple key */ > struct rte_crypto_asym_xform rsa_xform_crt =3D { > - .next =3D NULL, > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA, > .rsa =3D { > .n =3D { > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 2ecc7e2cea..feb1d86c00 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -295,7 +295,6 @@ test_op_forward_mode(uint8_t session_less) > #endif > /* Setup Cipher Parameters */ > cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > - cipher_xform.next =3D NULL; > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; >=20 > @@ -474,7 +473,6 @@ test_asym_op_forward_mode(uint8_t session_less) > return TEST_SKIPPED; > } > /* Setup Cipher Parameters */ > - xform_tc.next =3D NULL; > xform_tc.xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX; > cap_idx.type =3D xform_tc.xform_type; > capability =3D rte_cryptodev_asym_capability_get(TEST_CDEV_ID, > &cap_idx); > @@ -672,7 +670,6 @@ test_op_new_mode(uint8_t session_less) > #endif > /* Setup Cipher Parameters */ > cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > - cipher_xform.next =3D NULL; > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; >=20 > @@ -807,7 +804,6 @@ test_asym_op_new_mode(uint8_t session_less) > return TEST_SKIPPED; > } > /* Setup Cipher Parameters */ > - xform_tc.next =3D NULL; > xform_tc.xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX; > cap_idx.type =3D xform_tc.xform_type; > capability =3D rte_cryptodev_asym_capability_get(TEST_CDEV_ID, > &cap_idx); > -- > 2.13.6