DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] examples/fips_validation: prehash input for RSA
@ 2024-10-29  6:01 Gowrishankar Muthukrishnan
  2024-10-30 11:29 ` Dooley, Brian
  0 siblings, 1 reply; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-10-29  6:01 UTC (permalink / raw)
  To: dev, Brian Dooley, Gowrishankar Muthukrishnan; +Cc: Anoob Joseph, Akhil Goyal

Plain text needs to be prehashed for RSA as well in asymmetric
crypto validation.

Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 examples/fips_validation/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index b34015ad9f..f21826e9d7 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1940,7 +1940,8 @@ fips_run_test(void)
 		return fips_run_asym_test();
 	}
 
-	if (info.algo == FIPS_TEST_ALGO_ECDSA) {
+	if (info.algo == FIPS_TEST_ALGO_ECDSA ||
+	    info.algo == FIPS_TEST_ALGO_RSA) {
 		vec.cipher_auth.digest.len =
 			parse_test_sha_hash_size(info.interim_info.ecdsa_data.auth);
 		test_ops.prepare_sym_xform = prepare_sha_xform;
-- 
2.37.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] examples/fips_validation: prehash input for RSA
  2024-10-29  6:01 [PATCH v1] examples/fips_validation: prehash input for RSA Gowrishankar Muthukrishnan
@ 2024-10-30 11:29 ` Dooley, Brian
  2024-11-19  9:10   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Dooley, Brian @ 2024-10-30 11:29 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev; +Cc: Anoob Joseph, Akhil Goyal

> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Tuesday 29 October 2024 06:01
> To: dev@dpdk.org; Dooley, Brian <brian.dooley@intel.com>; Gowrishankar
> Muthukrishnan <gmuthukrishn@marvell.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>
> Subject: [PATCH v1] examples/fips_validation: prehash input for RSA
> 
> Plain text needs to be prehashed for RSA as well in asymmetric crypto
> validation.
> 
> Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
>  examples/fips_validation/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/fips_validation/main.c
> b/examples/fips_validation/main.c index b34015ad9f..f21826e9d7 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1940,7 +1940,8 @@ fips_run_test(void)
>  		return fips_run_asym_test();
>  	}
> 
> -	if (info.algo == FIPS_TEST_ALGO_ECDSA) {
> +	if (info.algo == FIPS_TEST_ALGO_ECDSA ||
> +	    info.algo == FIPS_TEST_ALGO_RSA) {
>  		vec.cipher_auth.digest.len =
> 
> 	parse_test_sha_hash_size(info.interim_info.ecdsa_data.auth);
>  		test_ops.prepare_sym_xform = prepare_sha_xform;
> --
> 2.37.1

Acked-by: Brian Dooley <brian.dooley@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] examples/fips_validation: prehash input for RSA
  2024-10-30 11:29 ` Dooley, Brian
@ 2024-11-19  9:10   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2024-11-19  9:10 UTC (permalink / raw)
  To: Dooley, Brian, Gowrishankar Muthukrishnan, dev; +Cc: Anoob Joseph

> > Subject: [PATCH v1] examples/fips_validation: prehash input for RSA
> >
> > Plain text needs to be prehashed for RSA as well in asymmetric crypto
> > validation.
> >
> > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Acked-by: Brian Dooley <brian.dooley@intel.com>
Applied to dpdk-next-crypto
Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-19  9:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29  6:01 [PATCH v1] examples/fips_validation: prehash input for RSA Gowrishankar Muthukrishnan
2024-10-30 11:29 ` Dooley, Brian
2024-11-19  9:10   ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).