From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C39AA0C47; Fri, 8 Oct 2021 22:33:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1718D40DDB; Fri, 8 Oct 2021 22:33:30 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 11A6840DDA for ; Fri, 8 Oct 2021 22:33:28 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 198G9Ih4015267; Fri, 8 Oct 2021 13:33:25 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by mx0a-0016f401.pphosted.com with ESMTP id 3bjs8nrtwa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Oct 2021 13:33:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TsXOic13cDS4wY0d33fqL6iIKCBRMoNIl1flAYE8PoUj/WHnMKmiVVPlFJwD1kxBYEj7qqyqJ6uM5OGY2viG4Q6nKtmtLd+AVq0wujfkAhMzcvsHTtUJdQFGKppYcPp65BsR/VJI3ZZ3lgsy5zSa5oKJldu+4yhybLyuYD8W/tTOz9wcu83RQRTreUm/SLlFaBlD5NZ1BroxnDNYgm1MGMgM83JrHl0PJta7yWhXYkiVgPlDzldLGyArgDBKJtLQEk4Ce4ebP3HeR8jLRCjC4KhUyeyoJ/0IPt+/yhkPfNCp5rs7Ciiu5d97I3d7XgrOvaXtf6YQALIOPJBKprj7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gKvlAWVvcayKUFWdUFWnqf50EGiw++SjbARSdZ75Ikg=; b=FcUQJ6gE9sV9FcV9lC1baQQAWKTjhiALqmziAZSvi9AZvNAxru5MdqPNQd4kYL+zU3NKL5Jck2KDVSx6DNGE6z5voHpf9+s5RavATe2aLfiA74vLh0/a4ngpwZRx5kxYY+TssLJJPFD3a/9ZVb99WNc8Mlc2R498alt1D1XCq7pgWX0H2/bT6s9E8qI6D01x8gfMLwdJpCi3l2sP5DwFdg7wbbDopjL0MFdxVbSMn/d4VJj3uV/1FDmJbK2WjTdbv0ZbT+iT9HYsmzk+R0/TwKIFcVE5kCK6qchQygj6r+Ee8C/G92L7bjmxPpZ9to10JDjlbSLr7xJPuDtgZAnL4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gKvlAWVvcayKUFWdUFWnqf50EGiw++SjbARSdZ75Ikg=; b=N2SUnuDlR1vRyzZXHkYjjPRiPhzzfmjq31qqrbA4U9Y3OD6ZzNc6eeWl7P4y6FWABTDkJ5qRuBdGT615pzFzbs69pcV4WBzAK0spfMsKCA5kkCIUlyKSBLD7UbJDWNs1TaDij1Cx6rRWAJbrfdPm5jUTewrPn34EjUZDzolpUo0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4586.namprd18.prod.outlook.com (2603:10b6:303:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct 2021 20:33:24 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 20:33:23 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "konstantin.ananyev@intel.com" , "vladimir.medvedkin@intel.com" , "bruce.richardson@intel.com" , "roy.fan.zhang@intel.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "declan.doherty@intel.com" , "abhijit.sinha@intel.com" , "daniel.m.buckley@intel.com" , Archana Muniganti , Tejasree Kondoj , "matan@nvidia.com" Thread-Topic: [EXT] [PATCH v7 0/8] new features for ipsec and security libraries Thread-Index: AQHXtqsx4fei1Q7H6kuFWx5dl+iGn6vJdf7QgAAjz4A= Date: Fri, 8 Oct 2021 20:33:23 +0000 Message-ID: References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20211001095017.3342431-1-radu.nicolau@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8decfe4a-f788-4c19-96f3-08d98a9ae026 x-ms-traffictypediagnostic: CO1PR18MB4586: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:792; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LohkGGpOEUtqZH3QDPmeDVRKzcPmsmbM9djiHtvn901MZmBdVZKkceq5Tq2w880m23KSiDMvqlA4BynQ9AfSrp6JnuHytpYSb94hCKUv2QSXGnvyND3zzH3txZHNwiYbftSUuCb4yypjq6xaRWIC4ymhcsuqmPn1q1Goak8uFdkUU9XNyVx9YZQDJ23h2nbcBdmhYbE76KZlOPHDJU+a6xLL1Q0VrjhRZi7yf+GKPwMaukUiTzfMba1LQNJtY8MPpLLGppK6c9p27cpaKRR3xrcng6h1DQSZ+isuaUGiP3jZzDaTzoIli2IeW0EaHggelyBPsUJvAdj+C0lTOcJZbiJ/XNOr+BKbSYDTmtc9AH0yWpi4WTWi+L1LZ0gzA6vRgO3xFdQbewfMF0lUkuJVMVdnr/4l7089aiO775hj//EV96fIz5J3OfyDxkY2HmRhzjLdBVqwYkPfrLOEnv6HokhL2Wi2hLVDeemr7ZHFZKLbKPPyFgrlqji1TyM5bP7T1vUcUVtSVZs7ohsmYaqljqoI+IE4IGDJMS8NiDiBGojqVbl1L2BLUtdypR729TZkDTT9eO5cKoEMCstQ3ktWaIQibeeEPwynMZx6ti32ncnXYYJ7AfQpaePKOCgQ4h50Z/xUQChDptpVn68vyBCvE/bWebAp0iXpvfCWoJ6DLbFCA8zfiXR6LyV0fkeclP5FzNBqFEWRKXMQdOAakPj5Ng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(55236004)(33656002)(83380400001)(38100700002)(6916009)(15650500001)(2906002)(7696005)(7416002)(508600001)(26005)(122000001)(71200400001)(316002)(2940100002)(52536014)(5660300002)(66476007)(64756008)(66446008)(8936002)(66946007)(66556008)(8676002)(38070700005)(86362001)(54906003)(4326008)(55016002)(76116006)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zEfwFxidQPe12ov2/E6TMkSJte6zqTVw4p1/M5Slx+P5w+wlC3UL9Bl/A6Jy?= =?us-ascii?Q?r/fuBsdIKMtOxkPbItxsBhTO8eygpnaq+5bWZAMAc4qcUC3qCPy3moBJDTSK?= =?us-ascii?Q?qdM9vyRU0wnr1oqp85rcn2sfeSDwsEmo3k6r/b4je56sKJc605PRTFrWfTG2?= =?us-ascii?Q?3M184dAfiroGyClC4KFRuBPLgaan3IBeyyix2YKVc+U5NYxxte7W3aItUMnT?= =?us-ascii?Q?hxo2B6jb/fVk9mVFYXaC8xzHrllE3IxmYNUotVvRZ41Ko8I1rolLwT3u4FzN?= =?us-ascii?Q?PC3FZFkbM8kARB7hlJSqGRTH6ynX5CC/byoeQdjWRyEL/5nddYGOdjHuI/ze?= =?us-ascii?Q?bQPqxe3jY4AU/qok5yx3hkq5mgKt2xJ0TBBeQvmsG9Ek5+xEwfLIs1Z0GD0l?= =?us-ascii?Q?/Ybd2vf9VRA3gAPQGS/VngH04jCemf7wYVnpNQX2taeN9oWvjPKEQXQmFZO1?= =?us-ascii?Q?36Kq5lhAT1R2qhCc8Lo5wpiq8+rqlNK9EcPZ878q2gWTq8q6giEfC/wDKZ26?= =?us-ascii?Q?nvJ6QHRhsADmRHxdwPrhbCL2VKHvd08/rEmTMN2Xyl1DwU4NZI8N1o2P+sZa?= =?us-ascii?Q?nfQ05rZ8gbQLckHaV29p2ZeRB6TlX9SJJxSGM+7oAKqp7vtkm/0u21X8FwnS?= =?us-ascii?Q?pmbyV6rCAouhLk6JiHH/SmmqfMvz+egBwEa90FHzn+pItvg0mejg7/Dg5QUX?= =?us-ascii?Q?53VDAwXs9/pVzcRbgd1C2oBu76Jt+YnXJNRdHokNPXq+rnXhaOzLQIDBz649?= =?us-ascii?Q?91eXvnbtLL+N8SIyK8MQIy0Mw31QlkX63HEB5EAumMN+/riC6SWp92swGAbC?= =?us-ascii?Q?htoeVrRKSuc6OtNT68HyuGIGkifrqRWRsXD+VsGl+Al2GNJMHt+2Wutq0t04?= =?us-ascii?Q?VunrOwfeXvbsQqED8uKNkCyoEM0kuU2Pr5qYVQSC9V40ebKtr97cy3QPSIZ2?= =?us-ascii?Q?YPho+6HNJX/NWgrW8VKURuUSqTVol/GoY96WH9Wa0gOgtYcm52pKR/yT82Pe?= =?us-ascii?Q?hKwb5VVwjONjFGQUvU/byaEb+6YQ0K4fmOeS0YT4Q+BvMgmgYVY0Fzh3yqex?= =?us-ascii?Q?nN3QPpgu4X4UaYVsHfaruCtg6iT6yBnFo+2xTtyqAxYvsDdr8ywRg/4vYE6G?= =?us-ascii?Q?uuTBGx+Gp1R9lcU377PpwIglEB58U4qdBStriY2Jpb/k0m7liKHmWm9QGIZk?= =?us-ascii?Q?lcTF/MxYd5flDCUAHOuZU9IY0myNxIzEbqfq4utWP03FlTqf8ha1Vj0USbMQ?= =?us-ascii?Q?T6L9yEVNVl925gBj0GRBiD/A9tWRDvSseldYL40yOXrMef8U79upFxvuO5zx?= =?us-ascii?Q?uwwIyRjxSKmxfn8B6fdZoiRj?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8decfe4a-f788-4c19-96f3-08d98a9ae026 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 20:33:23.8324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P2zYgjel377IkEjW1cqGCXesR3Bp5JKN0rJ2dHmuveIAIskLqQ6+VXSqvqDy2t3Jt1p+lTy6HneWSGQ2wgydOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4586 X-Proofpoint-GUID: NAx8WC2ElrERw2Km3m20NxeJZlZoW0hR X-Proofpoint-ORIG-GUID: NAx8WC2ElrERw2Km3m20NxeJZlZoW0hR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-08_06,2021-10-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: RE: [EXT] [PATCH v7 0/8] new features for ipsec and security lib= raries >=20 > > Add support for: > > TSO, NAT-T/UDP encapsulation, ESN > > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > > SA telemetry > > mbuf offload flags > > Initial SQN value > > > > Radu Nicolau (8): > > security: add ESN field to ipsec_xform > > ipsec: add support for AEAD algorithms > > security: add UDP params for IPsec NAT-T > > ipsec: add support for NAT-T > > mbuf: add IPsec ESP tunnel type > > ipsec: add transmit segmentation offload support > > ipsec: add support for SA telemetry > > ipsec: add support for initial SQN value > > > > lib/ipsec/crypto.h | 137 +++++++++++++++++++++ > > lib/ipsec/esp_inb.c | 84 +++++++++++-- > > lib/ipsec/esp_outb.c | 210 ++++++++++++++++++++++++++++---- > > lib/ipsec/ipsec_telemetry.c | 237 > ++++++++++++++++++++++++++++++++++++ > > lib/ipsec/meson.build | 6 +- > > lib/ipsec/rte_ipsec.h | 23 ++++ > > lib/ipsec/rte_ipsec_sa.h | 9 +- > > lib/ipsec/sa.c | 117 +++++++++++++++--- > > lib/ipsec/sa.h | 15 +++ > > lib/ipsec/version.map | 9 ++ > > lib/mbuf/rte_mbuf_core.h | 1 + > > lib/security/rte_security.h | 15 +++ > > 12 files changed, 811 insertions(+), 52 deletions(-) > > create mode 100644 lib/ipsec/ipsec_telemetry.c > > > > -- > > v2: fixed lib/ipsec/version.map updates to show correct version > > v3: fixed build error and corrected misspelled email address > > v4: add doxygen comments for the IPsec telemetry APIs > > update inline comments refering to the wrong RFC > > v5: update commit messages after feedback > > update the UDP encapsulation patch to actually use the configured p= orts > > v6: fix initial SQN value > > v7: reworked the patches after feedback > > > Release notes missing. At least some of the features deserve update in > release notes. > For ipsec lib add a main bullet and then add sub-bullets for subsequent > features. Also remove deprecation notices in the patch which added support for that.