From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BA1EA0C41; Wed, 15 Sep 2021 20:28:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1B8B4003F; Wed, 15 Sep 2021 20:28:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 3C72B4003C for ; Wed, 15 Sep 2021 20:28:49 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18FHdmln007332; Wed, 15 Sep 2021 11:28:48 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2174.outbound.protection.outlook.com [104.47.73.174]) by mx0a-0016f401.pphosted.com with ESMTP id 3b3ed024hg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Sep 2021 11:28:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RP5WM9rkn1UTSoFolETzeJ1y2wMz/OWBlOIiIEfZhxvNXeP8uRMDfy8jovCjXbPJ22xZ0+6n070jgxiIaBvfHHLizpMGXTqFtByc1tjfpIcoGEUSCpJ3XwxeEIr8M5Lkn5E9BMZ7J43gmGBCKcKuAum7Ob/K3pbiuTS2tGwl3fzK0SQ7mMclo0queVGGJNLIGWYNW2DNRZDrQKk3S8oGPBOhap0UPcJ8mntcV8hnDiBH6TKOkPSajfgpTD1bUMdUCGB8KMPbMO/GPeVPWR+b9Ah7jEnxMv33Bn/zny1zw3k4WZQJMmOqmquUU6hIUQ+nZ5Dsj766WQwucQYMMjFYzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WuiJAszzHRSREk+zYuz6qU8iP5FKpIy8OPmNdfxZMU8=; b=Rt+O6NCQtU/RLMCcC3D+itGxsa8ExCCxLJnhy2Ky4qj1ShlW+xG6z5XOQ6Pw95DCsFS+U8crFEDI7ChHZK9TDwJVkk8g6UveWAGAGdfpDOX3L7BuAXv0CssRh2dZUiMyPkdt7/YWeMLQJ1IDyYyz1p5yuVzf86/MgCdqI8w4XAyGuXaBwwALLbpGbofQXOtsTjcib6qvFZJEMGGyPLshSY++p0orS9n6sk/k3F9NbxWW3mzHoDan0mOZ4lcGfYb4lFoAig8aNAC3VbbsputjPauRixgxGnfhgvKZKzzySh1euWLyk4E37e784ifTQvsnhyPDxlOqOvrD4nfjK2pwAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WuiJAszzHRSREk+zYuz6qU8iP5FKpIy8OPmNdfxZMU8=; b=ZNf2gSuZ8iJZHvYtIiNkdbVuv1A/MoHQgjqGghPp7INVo0KihbblHYa0vCXGBDZYdyMh4SUmsqjzOoCaJVCr54+dGzvtu/2kur9zDi8/AP8TOtoOIsl+6sunltMziqVAb6ofnadD8R+WyW8ThthQYYHaJZjJyymgloC//vvSW6A= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4587.namprd18.prod.outlook.com (2603:10b6:303:e2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 18:28:46 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f068:d9c5:99fe:31cf]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f068:d9c5:99fe:31cf%9]) with mapi id 15.20.4523.014; Wed, 15 Sep 2021 18:28:46 +0000 From: Akhil Goyal To: Tal Shnaiderman , "dev@dpdk.org" CC: "thomas@monjalon.net" , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "declan.doherty@intel.com" Thread-Topic: [EXT] [PATCH 1/2] security: use the net library for IP structs Thread-Index: AQHXqk6G3fi7sLUmj0a2/ziIAvj+Q6ulaiWg Date: Wed, 15 Sep 2021 18:28:46 +0000 Message-ID: References: <20210915162603.16652-1-talshn@nvidia.com> In-Reply-To: <20210915162603.16652-1-talshn@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63a79d51-1ea7-4c9b-1547-08d97876a77e x-ms-traffictypediagnostic: CO1PR18MB4587: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mQtNpiVQ4KouDw/GEp2brik0tbq7wSkBlBPckmWjp44BeFNeRJQn1vCjvI6Wv1VyNd9N6OFLbFr6pIWCJkXWXCkzR43TJd9vJZ8UntuznCL6jhO/+JNqtClzK+gCtqgwx5/2xD+Gi1jqkLS2iqhdWrARnaVfD1dP67yK1JUwygyIPeAvYhBoODEbwWao/U4Sh0jUmyiEMZMEf+vsl6Xq4DTxW1GPFpzNwMEXcagqq+rzYIAYK8hAXG5/7igHCXmtzdE50Ag+L3777xZdz763xWUstq4q0yStlyT5ksCcrRhJv5IiK3S5k96zwp0CXVfYFZuXvtK3x8XFhsMhpC67QPSZ68wK+VzV0FkNZZoZAawL9k2Jn8ZZ3WqNmFTJA7a0gQOfm6y6diUauWLlI7DvY5TMOZgxhfeV+Oxd8r2WUQASWdfrGbEthjbVLfpyEtZOU+nKIaSeA1lojTFzY4K/9MfNm7oE5oFRQC1jwU3BxD7cj5zMNh8E24XapWNvPOxjnOt598pdvMeTQCphQHJuHWDkeWQcHtES3ed0ODKZ+8g5JIQAEm/VLn7xNoBMvecHJfoTT4Xuy+sv9IeCLSBHUbVG2oI5GiZrr/AlW1Rxgm/vyk1OumFJncAeMFJgffWXGxcOMl9uQA+4gcG/n6kaaJlclgzdAD/mBunnrqj/lCKuTDawCi6J9RkdZJYIvEKsWc1McNrzxXqbfmcWyPCOBA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(38070700005)(66946007)(64756008)(66476007)(66446008)(66556008)(4326008)(83380400001)(2906002)(26005)(186003)(55236004)(8936002)(55016002)(7696005)(8676002)(71200400001)(9686003)(6506007)(316002)(110136005)(15650500001)(33656002)(86362001)(54906003)(5660300002)(508600001)(122000001)(52536014)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IrKsI/7cAiSNE5Fy6td5vKvwM9zhImEQQaQla1U5kfpXuLaeQVweziWA3WuK?= =?us-ascii?Q?w1C4nfrDOGRjOxrmwSZ3bnFXpcLkZnl1xqV605qhh3NJaHaPqa78ies5EJSR?= =?us-ascii?Q?NOD8rCF55KdrVF192O9VA8HApjZWeeZdN6qSqfIuloDL/mIbf8y3yHpqiJul?= =?us-ascii?Q?sr/g1Ryu2E8gBeK1TOFhKPISjKgTOpKGnrR9wz04FXaB+weN40KWK7n8xWGv?= =?us-ascii?Q?8M5hrXRW6LZoxVbcjJwd632CuMHr4O52ZhY9mxZH3E2rLdKTMc84VJDuueaT?= =?us-ascii?Q?3Ufbi+KsquB4P2gFMxkVbhgpjLSRej1fFIrBfUJJylDWsbs8LjLgmyfroeKx?= =?us-ascii?Q?gCEsKn36E+y+OObQZ91gY++AAvzXxN3OuH8L7+a/ocPduwWf6tLwZr5d6r0Q?= =?us-ascii?Q?+wRPBII2dirKLftWmJ61siO8ufnnVlMP+JmUB+26/5yGC2H+zPUlGW4nf5No?= =?us-ascii?Q?eMTmtl7q7/bTB7CIr22hnmBD51GpPNUJMN/zLXUXtSdmQ9jplW1i3ZN/AxAN?= =?us-ascii?Q?nPUXbpe6adJOetaf11Of0bZPtdQ0JvrAK3nntFT6tj7vwyEIIU42tYDYx/uw?= =?us-ascii?Q?jvP7lg9NsZv4Lfmad2bLx9AqiIjllBRnW0N5pG/htSeLMJ7D9n2rEKYD15fZ?= =?us-ascii?Q?fqgdl9f8m7RTQe/IIbA74o0E3yOSSNyVP9mIi2dgTmTPtU4VO3wALKVsQtzn?= =?us-ascii?Q?LRhyB6LipChkF+yM4zC+cI8/C2FbXoyVctv+Fxoi4ayGzxdFWC7oGf4AusTa?= =?us-ascii?Q?5k5UuOIcAbxYSrk3KIRnyon6Q2zfUscAh9sHZkD0rgK+L5vu51ZN6/H7oXKy?= =?us-ascii?Q?H4uPxiUk+Mr/b0jdtnzmMRjxHsAnEenR5Yy0qk3Jw2KgOpwapGhhiCN75v8h?= =?us-ascii?Q?s6TPs+Bulmxv9fA1zACyq8ddxww618hUbmtje2o2NTKQbqf3oHg7jP9NcRJU?= =?us-ascii?Q?Yq9H9lxi668RZQydjhYpwC7qls49IklZUob0pjXOz60w9IL4knuhpWPEjjNQ?= =?us-ascii?Q?QYxboTZjGaxQs6CfRROLHJpiAgTYKQbpUlYwIL9YHbRInwuZnKdyIq681AWN?= =?us-ascii?Q?FqhFP99mMrI9IEZF6WvZRu/ptgzCGSrO1uPaBFDBDWV1aXM2Ty2aYMBfU8sB?= =?us-ascii?Q?qjVlrSCVUUqN8BZ50ldKxPObd6dnazZUnRQOiKlquXM7J5c35C/3knCoyqFl?= =?us-ascii?Q?qA0neTA9U6M0Ax92MN14PedwE+cNL85iyMYxakJG6QAm3Ip2WmGCudOdJBGd?= =?us-ascii?Q?2C3oWL1xxABUYkHzZV7VE15yJnfRlSnbiT03NBJi+88WNOV2iSrmabtkzOd8?= =?us-ascii?Q?sX+6V+i3aGihnaB/ycXWTmSq?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63a79d51-1ea7-4c9b-1547-08d97876a77e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 18:28:46.0222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hebUMLYr9vD91eFebsdvKggaKcwLvIYuOM5r26PrXAsfQiJpjsAyUXNQHRvwYHlFTysE6UjXhwZyqW0TZZowng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4587 X-Proofpoint-GUID: UfHaibJsByqWh79czsSuUGk4Hz1WQZB8 X-Proofpoint-ORIG-GUID: UfHaibJsByqWh79czsSuUGk4Hz1WQZB8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-15_05,2021-09-15_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/2] security: use the net library for IP structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Remove the netinet includes and replaces them > with rte_ip.h to support the in_addr/in6_addr structs > on all operating systems. >=20 > Signed-off-by: Tal Shnaiderman > --- > lib/net/rte_ip.h | 1 + > lib/security/meson.build | 2 +- > lib/security/rte_security.h | 5 +---- > 3 files changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 05948b69b7..bbd8650962 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #endif >=20 > #include > diff --git a/lib/security/meson.build b/lib/security/meson.build > index 5679c8b5c2..1034a7a299 100644 > --- a/lib/security/meson.build > +++ b/lib/security/meson.build > @@ -3,4 +3,4 @@ >=20 > sources =3D files('rte_security.c') > headers =3D files('rte_security.h', 'rte_security_driver.h') > -deps +=3D ['mempool', 'cryptodev'] > +deps +=3D ['mempool', 'cryptodev', 'net'] It is just a header file inclusion, will it really need to add dependency o= n 'net'? > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 2e136d7929..0c1adcee21 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -19,13 +19,10 @@ extern "C" { >=20 > #include >=20 > -#include > -#include > -#include > - > #include > #include > #include > +#include > #include > #include > #include > -- > 2.16.1.windows.4