From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43B36A054D; Thu, 26 May 2022 13:09:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E136840151; Thu, 26 May 2022 13:09:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 9609A40150 for ; Thu, 26 May 2022 13:09:40 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q2Affm003176; Thu, 26 May 2022 04:09:39 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g9jap5bct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:09:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4ZaY9nnRXBFuozLV2z10VqhGf5DBWfmmcIsy93/UARGAKD4ldb19hNrJ7TvHtOA6P+HXwnXe3Hz6j0ZTjCfbARk5ZSTsmEXVhi/wOHjyazQQQnCAN/ADq6a5ilLcLTqAGWbroRw1XlIoonAAxyRdJD1yE8JH42bvs/07wvWcoSzw25xxIvFZwe/fIF3MVE1vnS/4CIXHinrjjG6WJGv2R/9EUNgbQqPsxEGB3mvOe3M8w0tcRSwZ30GtOA0xYyhIBiruY+EbKbjENkDrs+enVl8Ew1etGo/vb++4aJi3A6h4tEg8zm93LNRS1MRJMl99j/k3cmOWkkw4dBVUab6YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BZsW70YQwd8pZfgIfsRfOrt5fmbquTKMm6L6tffh4GY=; b=LZdCJPAGmv56HFWZoOEdQN7FvcffL0MEG5nmvpliygQnQq1Rv68s0BD9fCMX5cWAu4W6ZNVhkMf4CyPW94pTnIZ77H3GsYxj9p7BBLxlik7N4hwS5gXScRIRlKgaeptCLREFA6B7aLSN8fm6OZn64U3OqEcHbn5ZUQN13uGX+QZ/BPaPszAOfiUjY4V+qvl9y10TZTccjM1ojP+RvmqAZQtXd19+7YBFBS3zpZVltOpaRMYzAr+Y0Tbp8qcXpAkzkenTwSEjqPf7HiCzG+e4Bp+LJDLZ+ShpbV9PFow0SkumfQpfkWDxVzy4QE2gn3CeF+a6XVHhnzbyMSr/9qZJ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZsW70YQwd8pZfgIfsRfOrt5fmbquTKMm6L6tffh4GY=; b=DJSxsnIIKTiEcpRJtrHwG2vn2Ou4DaNV4hFZeN/6vWYhlfKJpfVBq2eqV/Upvym7Wzk2Ce+yZCCK938hyMJP3z3J+u6Y2nLRRmLOMxJw0RsZpx0uHztpKGEEnNmibgmOuHFYSVUws+3//gbXUqJdqrrkhnQd164u09a+So/svgk= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM4PR18MB5027.namprd18.prod.outlook.com (2603:10b6:8:52::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:09:37 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:09:37 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum Thread-Index: AQHYcFlz6J7eEXLswUuvC9Xin+IA5q0w7LaAgAAT3QCAAABKYA== Date: Thu, 26 May 2022 11:09:37 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-4-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60d2a289-2d9f-457d-ec30-08da3f08391d x-ms-traffictypediagnostic: DM4PR18MB5027:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IrlllGuTJT5EmXilk2xFix4v2dMoMAlsJuUcIYhanCF9Jq+Rxok50Em2r7tuVHMKFXf36h3ZwR5zI2La5JLh5c8p4uX9ip3UzChqhlVNy9OsjkF78F83pK2T5prv7f72pBq9PtlwQq5Qn891FGbdV3/u7HzUCxWe149sKMm30VfWqwRzSqE1ubGZ7apbjSwGG1tbyUld2pp+Rk33JIydihY4rhoVsiIl55/0oEPpmqe+Hw/MRHzp+2CJQllV8pANJbtg5WceIkb9yacZLZLleh4OpAEHoC+xr4vg5vYtUUu+/r5m04Qxz11fitMo9RX4NTtwwB2lnIDyWI5Vzi+sT3339GDcuuqMkV7FUZtVtUsjy7TWi/Hf0DqYq05nCAoYAXYYrM1bozyKKBErAu5ApmBiS3tPbKRIOBAZlcxCtRgqOAmV5wxz8ViKkKv/JWcfFSedWgnyOPB77d0hGEQj3f0mR+5hlyKreO2SMKBhi/gDggySVz0khwAtkhR72vqlmf7ujlElBsJZ5DaX6o20rqxLSK6MFRJqzw0D+Nu0PLgxMacZTKjKHQh/U3h64AAjZcZ+CdNy5WilPOubQVIc/Oiy5LqguwhmYwnITo5lqA94pye+9+4I9a14lepEXpwNHMqrHZYGWuz2JEdODX1OwLh8tjCj1GU4qAD/GAjLJ28w9FfbXOk+r/eMcb91Z2HwHg1qA+Pn0sKASO6P3XyCkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(66946007)(64756008)(66476007)(66446008)(8676002)(76116006)(55016003)(5660300002)(4326008)(8936002)(66556008)(52536014)(122000001)(508600001)(33656002)(6506007)(71200400001)(316002)(7696005)(55236004)(38100700002)(110136005)(186003)(86362001)(2906002)(26005)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AjGzc/qniaRq2FS8Bf1Hr/qniedZVOYJ4pEnLJsPRrnskiLoXkU5wPTsEZZl?= =?us-ascii?Q?dEB5QtC6k3f2ccyIUiKWJkd2/OB6h0JPUn/K3libxqS1ATaW9/Lv9zxEHSzc?= =?us-ascii?Q?q5Bdw0c/PBHWlNQGHmbtf/ftcF2ANI2jK7cn3XL2fy7HMxfBRXkuXRWLJ7FQ?= =?us-ascii?Q?hy2vzJJ6nMKNKmWJAXvrwpJN4pzfkXfrcp0MoQAbQ9qPG+FiG+JlIE4i7TZH?= =?us-ascii?Q?ADYiKbS2wJ1/MJT1Dcd58tiuTg08HOBE/ufgp7eA6C4kmtSGAsGjJZNv3sQO?= =?us-ascii?Q?YatHSxmrUputZ9ULkpkZLtNlJFBdGyQTB/5eRGuAXesGxgyjoL2sW7/fBz0u?= =?us-ascii?Q?SboWTPLy9s84jMqVzxJ8rnqkUbkKpgoeBCYQG9u1Qhnp5LcJNPKsCv8QWsI+?= =?us-ascii?Q?6SW9lgYuR626agXFRKx3a1Ibp4qs4y+yzYeDXMgCeAwW+xDqR+kqA3mCVSCe?= =?us-ascii?Q?cuWQF/m3q+avXGm4PQURPkMQtAe571ek6JnyUWuCOUPOpYEfWPjdH+el/IBw?= =?us-ascii?Q?ngWhVL0Fz0eaM6J/aH5C0RQ/nYbjvnkAeZ7VsEddwlbVH1UQqaP6o/5CLBga?= =?us-ascii?Q?mRrhuVexDcNMmGWBDTlouXxBCuPUDtR3/BpRClIOOQlNwV5+nCA60jrIS4nz?= =?us-ascii?Q?XBy/wNUycMd0OYLwctERox0AVUBz75mKhyCKJCy+G+XzdlAOZjeJDZSZnMOf?= =?us-ascii?Q?O/+waM2hCwhYWurP85+ihgXb/1zs7ssbqK65DDaQ/kRNjds4tVthAbRhuoDt?= =?us-ascii?Q?XIqyql6MFPJ4iviIdm8QmUBqSGqo0FFrjZJJ7oowcpcSGzIq5j8BruiQOtCF?= =?us-ascii?Q?Gq/4AmvhJYlluddR18oIJxHCIwyNKWHEJMqSMUzQCskfHBFUXsEQlU3h9Wb8?= =?us-ascii?Q?6A/rNh7sOGVmIFXDbbWPdCa49dapxxB0MOfYwRfcXtZBABqtVIls8NZ+943G?= =?us-ascii?Q?pGihZRsHTksXYF705rS3AXSNDgXpB4pIslR1bK8nqrraRAXXH4sm4ARIGAQ/?= =?us-ascii?Q?PN0GyQJj+lmkZrcN4NoN/8+6+PsyDaV4GAQTfWfJZ3e98N0uIaaPsAkksqyE?= =?us-ascii?Q?PPZFdw3MMVjcae/Gh3EQfIjhw0rnQRQtWQENhm9sWm7N5Tyh5w8JRqJ1XzIq?= =?us-ascii?Q?B0wLUSAxazig+EiO7l4QNcd41r8lu/i2ssmpWxfZNCFafFF/AHWPOdPKqMbO?= =?us-ascii?Q?DcgKP8h2su+1x4WyHM21P2t9HsmBY/4PRm8kFXpQHehKqJMXcgD6uFAYR5UB?= =?us-ascii?Q?sWBvenlJaYu2wcJLB/qjjB3pgdpzVPpHE+I9DXM6poF4CG/S79hchdTjQtji?= =?us-ascii?Q?nfyYwiqBOwakZjm8i7shS37pTTXRXHCuqgM5kmeGEyHP/b1qxv0Pw+ruZjEj?= =?us-ascii?Q?qAlcQpKJvvOXlkXwL0sUPZADx8RR5j0zXpYzF4qbGUR3dXjlIlmt6L51Hnyy?= =?us-ascii?Q?VITeEpwE/1rpYahfZinYok6oasfHczu1fjPgzx4QGxGOjuzrvycvHnY88IZ0?= =?us-ascii?Q?IsvQ3RgDkX2/uKXJWbQVrbNTsR8ybpq8l7cHHXPSDi3g7jVx/A/9jz5gpPkA?= =?us-ascii?Q?v3JMkyBX1uIdTmrFrmcld9VuqJ0DI3NXL9/oFKeWrse+voQCjudpSyPBry+2?= =?us-ascii?Q?wJP65z7JwQydUpHWTvbOUWM+EpUius+x8fOes2U66D5aYRNkAyr+6XRy2Dv8?= =?us-ascii?Q?FLyUfsEWIrmh6HOk7uWXpFu4uDSgHnWSRp1Y48ZU6PfMAPyykkkp5DG2xoCW?= =?us-ascii?Q?1JTwshy0mQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60d2a289-2d9f-457d-ec30-08da3f08391d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:09:37.6272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jlFV9FYm2gYNC1WcQ8TscrgBSmiDOpnwMxr1xh5YC+2+meblWYCrH5WMCGyqG9SDdsu8naQr7yvO8Rc1RnoKBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5027 X-Proofpoint-GUID: YgdwCpM5JZ4yb3HPwSZXwzg0KCgrb-a3 X-Proofpoint-ORIG-GUID: YgdwCpM5JZ4yb3HPwSZXwzg0KCgrb-a3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_03,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > /** > > > + * Asymmetric crypto key exchange operation type */ enum > > > +rte_crypto_asym_ke_type { > > > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, > > > > Is it better to shorten it to > > RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE > > RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > +1, Actually I am not big fan of having asym everywhere too. > RTE_CRYPTO_KE_PRIV_KEY_GENERATE would be equally good. It is better to keep ASYM, or else people might relate with IKE > > > > > + /**< Private Key generation operation */ > > > + RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > > > + /**< Public Key generation operation */ > > > + RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > + /**< Shared Secret compute operation */ }; > > > + > > > +/** > > > * Padding types for RSA signature. > > > */ > > > enum rte_crypto_rsa_padding_type { > > > @@ -238,7 +248,7 @@ struct rte_crypto_modinv_xform { > > > * > > > */ > > > struct rte_crypto_dh_xform { > > > - enum rte_crypto_asym_op_type type; > > > + enum rte_crypto_asym_ke_type type; > > > /**< Setup xform for key generate or shared secret compute */ > > > rte_crypto_uint p; > > > /**< Prime modulus data */ > > > @@ -375,26 +385,27 @@ struct rte_crypto_rsa_op_param { struct > > > rte_crypto_dh_op_param { > > > rte_crypto_uint pub_key; > > > /**< > > > - * Output generated public key when xform type is > > > - * DH PUB_KEY_GENERATION. > > > - * Input peer public key when xform type is DH > > > - * SHARED_SECRET_COMPUTATION > > > + * Output - generated public key, when xform type is > > > > It is not xform type, Right? > > It should be key exchange type. > Yes, I meant xform op_type. Will change, leter it will be overwritten by = move dh > op patch too. OK > > Check at other places also. > > > > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE. > > > * > > > + * Input - peer's public key, when xform type is > > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > > */ > > > > > > rte_crypto_uint priv_key; > > > /**< > > > - * Output generated private key if xform type is > > > - * DH PRIVATE_KEY_GENERATION > > > - * Input when xform type is DH SHARED_SECRET_COMPUTATION. > > > + * Output - generated private key, when xform type is > > > + * RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE. > > > * > > > + * Input - private key, when xform type is one of: > > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > > */ > > > > > > rte_crypto_uint shared_secret; > > > /**< > > > - * Output with calculated shared secret > > > - * when dh xform set up with op type =3D > > > SHARED_SECRET_COMPUTATION. > > > - * > > > + * Output - calculated shared secret when xform type is > > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > > */ > > > }; > > >