From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B327A054A; Thu, 20 Oct 2022 11:58:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32A2942D0D; Thu, 20 Oct 2022 11:58:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id EF62A42CEA; Thu, 20 Oct 2022 11:58:16 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29K6PwVm008877; Thu, 20 Oct 2022 02:58:16 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2043.outbound.protection.outlook.com [104.47.74.43]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kb1258nw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 02:58:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D/uoIbK9NN6PPVuAA7EjK5+vYnhRHEa9+v2y/ZYsYhkyxEX/XGSmZ8LBW44PZ6eIbeYtSOIi4xxz7jJs7dLFHjOsXmP2wLZaU1FhpwwkzLAv9SYMTD/682AzYM21Dvr/wxHwyCWBj8EYo1o+2PAEUfauSIMusd+PsiGNRQ86NQdtXxMMS3MPFKssK+11jQ6jbVg6nR2C3OiKP37+FTqotZHLTaxCcNsTAQdeR9uMmZBM3Z1opojJ0esXYf1zAB7uLFYP+05ry0C+1IawMYk8woY9YFpIBS6yIR7MZ1bh/SYFKAkXm1uMOjGGm0QTYTicyL2Oif+k6xj+oGOLvx/e8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/YUPo7GHPxZa8hdwCjZ8qqFOkPRSecJGHCpn+UfWHmg=; b=krYfmet1/NxqKOHA7lZQdx7XI1Gf5CAeH7Y6aIPCDJhyn3Xhvz0tIhLJYSreyAZnYRCgxq2cv2M/u6S5ClsAfh/CbjfLWdu5xqtKI8Q5U1A4tW9Y+2wdvBsW4zyXIqgt9xhL8lJ+0r1IWoT/YUNJMP1suZGbJDOIctyE79epvnXQ+dILmkAKf6LOkiVtq4VchV+BEQqPqjKIfX3aozcilDl1EDhOUGBTc4NPiVVChKvk7YzO5Vdatxst4r18hRVY+J+WTUru2D7c7WKSfsroWeYR1zzX/gs+rOIFQP4X8B47ijmyLOiPImgiQrgEoTejyZ0z6KQu5XO7Hg1WnF2wNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YUPo7GHPxZa8hdwCjZ8qqFOkPRSecJGHCpn+UfWHmg=; b=kV/aBGfiU8o9YuSu5R1YiU+tSM3Eagqu9QN4Eyp1ggMWAxqAUzPGsTMRfT+4AnPQTYhovhW2Dab7+jJdgr/wNJiExnplKwSl4p1fcIk4J8VoMlXWTHx9EO5OdiOPbOHDEVPgBvWIU2Or1OPYDwsKwVnj8K3Aty0Gc6ses9WiUK8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BL1PR18MB4374.namprd18.prod.outlook.com (2603:10b6:208:31d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct 2022 09:58:14 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d%3]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 09:58:14 +0000 From: Akhil Goyal To: Hernan Vargas , "dev@dpdk.org" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "nicolas.chautru@intel.com" , "qi.z.zhang@intel.com" , "stable@dpdk.org" Subject: RE: [EXT] [PATCH v4 04/30] baseband/acc100: add LDPC encoder padding function Thread-Topic: [EXT] [PATCH v4 04/30] baseband/acc100: add LDPC encoder padding function Thread-Index: AQHY4xCrm+sU7swNakyKfIghITjeu64XDakA Date: Thu, 20 Oct 2022 09:58:13 +0000 Message-ID: References: <20221019003918.257506-1-hernan.vargas@intel.com> <20221019003918.257506-5-hernan.vargas@intel.com> In-Reply-To: <20221019003918.257506-5-hernan.vargas@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|BL1PR18MB4374:EE_ x-ms-office365-filtering-correlation-id: 77e8532d-4a10-46e3-c553-08dab2819a8c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IWeby5+RS4sC7kbNfO5+9bngKWjsBUgo1uPMXe/HUGjhO/nEuHaadH+qCh2tzjGPHfUWWLXrVqWi4JsqQiVqK8VQFLtyDkpIaNBZprUgcJyYRFqyAtTiFZVf1eIZ4ZCtHYzFUho4JDha1an6pdpRxXjBvWbNL5pFYxQVm5uesvhsRDmh7CLHZMl1/TWw4VGJXQuRKRqq9mRqTmvDIBsBR9tdjy6Xq7Em0GEV6FQfcNvQ13h2GVs7AiaQd3vYlMb3/5gDnPhG461mZ6hGPf1FffaD//zWjERnPK50+srjDpw7t9uyshHOkhDPNMW1i4nn+VBNVHCy30GcFoB8FNPAAULpwW9TIs7xixwrEAZVyO0uwUpu4E/mLKix7jmzA7ketm8q/jUQpr9N/hxXiTZooRicc/EQ1XFTYhrupIxa2zqVCW1YvLiso5A3aDI9NjOcxRAoDGPWsERuXaXavJb6ixhHOlt9OJTxCFkqsgmfNHmEiQ4RJ3BnNyi5OZ/lxtjqUWSuwyjSgDHDWq7a0aJqcNC6FHH8gzu6W+h0CPuCH7ZQnkME+sJ3nL3pV550bxERtcKF+4R2OzJQbQHpTkAA8JbMfcQrEemuclE3bTSLFzrc6NBPF0nDvnKQZcB6d2TtCoN40g15jzeM2TUD2lh/vgAqU11kTDNqU/1XdY995mkNY6dQoznXwahfQ8cuq29GsAjvmf5VtSCPlNJoJSxU79Rubw2BarJkB+sBUjA59sNut3CNHKb57SKT3P3lyv8TZtzWK4TEK0eApWn32ULsiw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(451199015)(478600001)(71200400001)(54906003)(316002)(110136005)(76116006)(66556008)(64756008)(66446008)(66946007)(66476007)(4326008)(8676002)(7696005)(55236004)(86362001)(41300700001)(9686003)(26005)(5660300002)(2906002)(186003)(52536014)(8936002)(6506007)(83380400001)(55016003)(122000001)(38100700002)(33656002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EMHZW1RZbEs3n3T8msYxmY68u+rFLRHIjH4bGS7rKpaXp866emxSjmakzuyV?= =?us-ascii?Q?EVLU4fnSVklaw1SlOPQdcn6YBctXhCqE9FyjuJIudj0Jw0iFArDGqdgUKlki?= =?us-ascii?Q?HK8VFaaTTGcPf2ikSBTAc95YcxV4cn9dqwU8QSb6UDMaLrA/HM0/inyhf/9f?= =?us-ascii?Q?BW6ERJWu2r3Wapysp/q/PEEUuEhTBtIcs1HNyKNdp6gELJBOjUzO9CwJEa8D?= =?us-ascii?Q?vzrMkjYiiE2Yu274vy8EGpBlx/61354+StOwVONak7jCSc6o44EWmzut/njA?= =?us-ascii?Q?Q6ofrm9ROIWK+GSZmta/WNiYB9revLZpqI3RGkwRLznVfg4BQSeEVXC7rk8K?= =?us-ascii?Q?d28iCcHtifSHMIAfe4dflza/GHK4cb8L1cnAqVoQRurouLb8SBOSI76AigAb?= =?us-ascii?Q?2e90hVgjbliWHXpK3XOf86m5AeJC+Z+WXUois1u9OZ1nR+HOU64ZvISYf7hJ?= =?us-ascii?Q?HB979rIyRxLlxIswYCxqoTAOBKuPZ6B0IhMCg52gYADthMIXBBh/mwTkrALd?= =?us-ascii?Q?+uqlKBt1eO1dkeMTU4x+iK0jWFLD9tBjZDrKBKkuy1A5fsztSHiqz/M0D2DB?= =?us-ascii?Q?xSTxKkpZHTaJkRdh0ZvDnAPnSJGitKuntgOOLsx9/5SJKqF343v4ls9GKABj?= =?us-ascii?Q?lyav9JMtyjZOhJh+kTlfdhEYtDJ8C4lIrGCu26sc8vBlw6+fqoiEW7wc8HXw?= =?us-ascii?Q?Otix7eEpw7KcU6nuQy+kniw0IarWD0cyQkpLrJkny9JEHlIfZlYFci9sVUjh?= =?us-ascii?Q?NVMt9qsh1JR3ewbeXimjbKaR3WeMZYi01IJ/nvSHbifv0rUvgh8njsnwfrux?= =?us-ascii?Q?xJE8QOslM7wWk02s0uwCNx2KyCs+Esw8a8qhYiu+GIDT+8ci8xAJAHTYqV+r?= =?us-ascii?Q?UASxGz0IcDjwuKw7vJV7DV3FfMSmrKOvf4MUJ5r9xnCFH5N+7i0fThxDqEir?= =?us-ascii?Q?MilDwNNN6DwO/W2Uhd69j1VlZbGKPv2FZcFGwPrjODzknNeOwlENBipZl1Sp?= =?us-ascii?Q?wrT1CMmz4u4QhvtH5+Ki8KoaOyQ3WEgljSobJ65fReYshsUg8T1SqqbPb2p9?= =?us-ascii?Q?rHy9HQ3jfzHtmFV0v028/bjq/5aQs1frtTBc+CQGTvdjpiKHDjxaLimn8hkS?= =?us-ascii?Q?0ctn45bL2SPFjr1ooCy+CThcrPHBWQiVpqj4dN13MZmcC+3SfgF4DpO0AUdg?= =?us-ascii?Q?HjSKsbqjg+UdCxyz10nT/lfmkWjwqjglIK4DO0BJoO+4QCSq+LmgwNSoDQjS?= =?us-ascii?Q?29aL6K9yvgonWkpQp/Qw8WSLHpOd9QqoHV5UL2g4oC8qiWi8hG9o9WfuxXXW?= =?us-ascii?Q?b+tJSAIw0rDxSRJhaw880DukddQ9cE7mmQDbiOEXPJaXanJ5i/gvW0FRhbi6?= =?us-ascii?Q?v/DDCm328PaoifqJiVwKXuSBbIZJRocREU3lf4ipsKdMp1m+FwU+7/FNVnry?= =?us-ascii?Q?feHfLItVT5Y6gV9uXvm4lQRIKBka1yM63DAnHd1a6k+dvtUqga70mBDnP96y?= =?us-ascii?Q?jK0CMFhkoYt/KsMQRfQcmh5I7pTehMcJCB2377cu14clFGOcjs3niE1Nvblp?= =?us-ascii?Q?RA5lmWPZ2uTBGEuBAJ8iZ8EfYTxAnRa63279UFAS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77e8532d-4a10-46e3-c553-08dab2819a8c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 09:58:13.9320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kxiVnpoGoiRtdKDiFHfqOPp+lj4BSPHQ4S5IvUQmIAclh6vzVFhWqTUBwUPM+Iyt69nSJWTj3QZuWLgl6IZaMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4374 X-Proofpoint-GUID: op-37TmyFwkrBlbo6akbCOJu7QmPJb5G X-Proofpoint-ORIG-GUID: op-37TmyFwkrBlbo6akbCOJu7QmPJb5G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-20_03,2022-10-19_04,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > LDPC Encoder input may need to be padded to avoid small beat for ACC100. > Padding 5GDL input buffer length (BLEN) to avoid case (BLEN % 64) <=3D 8. > Adding protection for corner case to avoid for 5GDL occurrence of last > beat within the ACC100 fabric with <=3D 8B which might trigger a fabric > corner case hang issue. >=20 > Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Hernan Vargas > Reviewed-by: Maxime Coquelin Please fix compilation. It has been repeatedly asked to fix individual patc= h Compilation for ACC patches. Please take care. ninja: Entering directory `./build-clang-static' [1/26] Compiling C object 'drivers/a715181@@tmp_rte_baseband_acc@sta/baseba= nd_acc_rte_acc100_pmd.c.o'. FAILED: drivers/a715181@@tmp_rte_baseband_acc@sta/baseband_acc_rte_acc100_p= md.c.o ccache clang -Idrivers/a715181@@tmp_rte_baseband_acc@sta -Idrivers -I../dri= vers -Idrivers/baseband/acc -I../drivers/baseband/acc -Ilib/bbdev -I../lib/= bbdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include= -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -= I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I..= /lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/t= elemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../lib/= mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Idrivers/bus/= pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci = -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-= pch -Wextra -Werror -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -= Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmiss= ing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsi= gn-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-pack= ed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnati= ve -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE= =3Dpmd.bb.acc -MD -MQ 'drivers/a715181@@tmp_rte_baseband_acc@sta/baseband_a= cc_rte_acc100_pmd.c.o' -MF 'drivers/a715181@@tmp_rte_baseband_acc@sta/baseb= and_acc_rte_acc100_pmd.c.o.d' -o 'drivers/a715181@@tmp_rte_baseband_acc@sta= /baseband_acc_rte_acc100_pmd.c.o' -c ../drivers/baseband/acc/rte_acc100_pmd= .c ../drivers/baseband/acc/rte_acc100_pmd.c:1028:1: error: unused function 'va= lidate_op_required' [-Werror,-Wunused-function] validate_op_required(struct acc_queue *q) ^ 1 error generated. ninja: build stopped: subcommand failed.